dpaa2-mac: Fix potential null pointer dereference
Subsystems (3)
PATCH 1/1 dpaa2-mac: Fix potential null pointer dereference
There is a null-check for _pcs_, but it is being dereferenced prior to this null-check. So, if _pcs_ can actually be null, then there is a potential null pointer dereference that should be fixed by null-checking _pcs_ before being dereferenced.
Addresses-Coverity-ID: 1497159 ("Dereference before null check")
--- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +1 -1
@@ -291,9 +291,9 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,static void dpaa2_pcs_destroy (struct dpaa2_mac *mac) {struct lynx_pcs *pcs = mac->pcs; -struct device *dev = &pcs->mdio->dev;if (pcs) { +struct device *dev = &pcs->mdio->dev;lynx_pcs_destroy (pcs);put_device (dev); mac->pcs =NULL ;
Signature · 1 line
2.27.0
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 25 Sep 2020 12:03:23 -0500
Quoted 8 lines
There is a null-check for _pcs_, but it is being dereferenced prior to this null-check. So, if _pcs_ can actually be null, then there is a potential null pointer dereference that should be fixed by null-checking _pcs_ before being dereferenced.
Addresses-Coverity-ID: 1497159 ("Dereference before null check")
Fixes 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thanks.
Quoted 8 lines · David Miller
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 25 Sep 2020 12:03:23 -0500Quoted 5 lines
There is a null-check for _pcs_, but it is being dereferenced prior to this null-check. So, if _pcs_ can actually be null, then there is a potential null pointer dereference that should be fixed by null-checking _pcs_ before being dereferenced.
Quoted 5 lines
Quoted 3 lines
Addresses-Coverity-ID: 1497159 ("Dereference before null check")
Fixes 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")Signed-off-by Gustavo A. R. Silva <[email protected]>Applied, thanks.
Thanks, Dave.
--
Gustavo