Skip to contentSkip to conversation

drm/amdgpu: fix a warning in amdgpu_ras.c (v2)

PATCH In review Alex Deucher 3 participants 3 messages Sep 25, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: fix a warning in amdgpu_ras.c (v2)

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result]

 1284 |  sysfs_create_group(&adev->dev->kobj, &group);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

v2: just print an error for sysfs group creation failure

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +4 -1
index 49d10330bf64..8bf6a7c056bc 100644
@@ -1266,6 +1266,7 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
 		NULL,
 		NULL,
 	};
+	int r;
 
 	/* add features entry */
 	con->features_attr = dev_attr_features;
@@ -1281,7 +1282,9 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
 		sysfs_bin_attr_init(bin_attrs[0]);
 	}
 
-	sysfs_create_group(&adev->dev->kobj, &group);
+	r = sysfs_create_group(&adev->dev->kobj, &group);
+	if (r)
+		dev_err(adev->dev, "Failed to create RAS sysfs group!");
 
 	return 0;
 }
Signature · 6 lines
2.25.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

That's what I had in mind. No error--let the system survive as much as it can.

Regards,
Luben

Quoted 26 lines · Alex Deucher

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result]

 1284 |  sysfs_create_group(&adev->dev->kobj, &group);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

v2: just print an error for sysfs group creation failure

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +1 -0
index 49d10330bf64..8bf6a7c056bc 100644
@@ -1266,6 +1266,7 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
 		NULL,
 		NULL,
 	};
+	int r;
 
 	/* add features entry */
 	con->features_attr = dev_attr_features;

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c static int amdgpu_ras_fs_init(struct amdgpu_device *adev) · line 1290

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +3 -1
@@ -1281,7 +1282,9 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
 		sysfs_bin_attr_init(bin_attrs[0]);
 	}
 
-	sysfs_create_group(&adev->dev->kobj, &group);
+	r = sysfs_create_group(&adev->dev->kobj, &group);
+	if (r)
+		dev_err(adev->dev, "Failed to create RAS sysfs group!");
 
 	return 0;
 }

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Acked-by Nirmoy Das on v1 1/1
#2 lore raw
In reply to Alex Deucher
Quoted 25 lines · Alex Deucher

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result]

  1284 |  sysfs_create_group(&adev->dev->kobj, &group);
       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

v2: just print an error for sysfs group creation failure

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +1 -0
index 49d10330bf64..8bf6a7c056bc 100644
@@ -1266,6 +1266,7 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
  		NULL,
  		NULL,
  	};
+	int r;
 
  	/* add features entry */
  	con->features_attr = dev_attr_features;

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c static int amdgpu_ras_fs_init(struct amdgpu_device *adev) · line 1290

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +3 -1
@@ -1281,7 +1282,9 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
  		sysfs_bin_attr_init(bin_attrs[0]);
  	}
 
-	sysfs_create_group(&adev->dev->kobj, &group);
+	r = sysfs_create_group(&adev->dev->kobj, &group);
+	if (r)
+		dev_err(adev->dev, "Failed to create RAS sysfs group!");
 
  	return 0;
  }

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx