leds: tlc591xx: fix leak of device node iterator
PATCH 1/1 leds: tlc591xx: fix leak of device node iterator
In one of the error paths of the for_each_child_of_node loop in tlc591xx_probe, add missing call to of_node_put.
Fixes 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the
managed led API")
Signed-off-by Tobias Jordan <[email protected]>
--- drivers/leds/leds-tlc591xx.c | 1 + 1 file changed, 1 insertion(+)
drivers/leds/leds-tlc591xx.c +1 -0
@@ -214,6 +214,7 @@ tlc591xx_probe(struct i2c_client *client, err =devm_led_classdev_register_ext (dev, &led->ldev, &init_data);if (err <0 ) { +of_node_put (child);if (err != -EPROBE_DEFER )dev_err (dev,"couldn't register LED %s\n" , led->ldev.name);
Signature · 1 line
2.20.1
Quoted 16 lines · On Sat, 26 Sep 2020 01:10:11 +0200 Tobias Jordan <[email protected]> wrote:
In one of the error paths of the
for_each_child_of_nodeloop intlc591xx_probe, add missing call toof_node_put.Fixes 1ab4531ad132 ("leds: tlc591xx: simplify driver by using themanaged led API")
Signed-off-by Tobias Jordan <[email protected]>--- drivers/leds/leds-tlc591xx.c | 1 + 1 file changed, 1 insertion(+)drivers/leds/leds-tlc591xx.c +0
-0
drivers/leds/leds-tlc591xx.c tlc591xx_probe(struct i2c_client *client, · line 220
Quoted 7 lines
drivers/leds/leds-tlc591xx.c +1
-0@@ -214,6 +214,7 @@ tlc591xx_probe(struct i2c_client *client, err =devm_led_classdev_register_ext (dev, &led->ldev, &init_data);if (err <0 ) { +of_node_put (child);if (err != -EPROBE_DEFER )dev_err (dev,"couldn't register LED %s\n" , led->ldev.name);
This won't apply on pavel's for-next tree, there is no check for EPROBE_DEFER, see
https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/tree/drivers/leds/leds-tlc591xx.c?h=for-next