Skip to contentSkip to conversation

drivers/leds/leds-tca6507.c:730 tca6507_led_dt_init() warn: passing zero to 'ERR_PTR'

PATCH New Dan Carpenter 1 participant 1 message Sep 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 10377/11173 drivers/leds/leds-tca6507.c:730 tca6507_led_dt_init() warn: passing zero to 'ERR_PTR'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master
head:   20dc779fdefc40bf7dd9736cea01704f29228fae
commit: d78b10f5713d92d494d2b1c10ef74fdc5ce8946e [10377/11173] leds: tca6507: use fwnode API instead of OF
config: i386-randconfig-m021-20200925 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/leds/leds-tca6507.c:730 tca6507_led_dt_init() warn: passing zero to 'ERR_PTR'

vim +/ERR_PTR +730 drivers/leds/leds-tca6507.c

0c596a7ebb51b51 Marek Belisko 2012-11-30  694  static struct tca6507_platform_data *
0c596a7ebb51b51 Marek Belisko 2012-11-30  695  tca6507_led_dt_init(struct i2c_client *client)
0c596a7ebb51b51 Marek Belisko 2012-11-30  696  {
0c596a7ebb51b51 Marek Belisko 2012-11-30  697  	struct tca6507_platform_data *pdata;
d78b10f5713d92d Marek Behún   2020-09-20  698  	struct fwnode_handle *child;
0c596a7ebb51b51 Marek Belisko 2012-11-30  699  	struct led_info *tca_leds;
ef754e88e35f86d Axel Lin      2013-01-27  700  	int count;
0c596a7ebb51b51 Marek Belisko 2012-11-30  701  
d78b10f5713d92d Marek Behún   2020-09-20  702  	count = device_get_child_node_count(&client->dev);
ef754e88e35f86d Axel Lin      2013-01-27  703  	if (!count || count > NUM_LEDS)
0c596a7ebb51b51 Marek Belisko 2012-11-30  704  		return ERR_PTR(-ENODEV);
0c596a7ebb51b51 Marek Belisko 2012-11-30  705  
d78b10f5713d92d Marek Behún   2020-09-20  706  	tca_leds = devm_kcalloc(&client->dev, NUM_LEDS, sizeof(struct led_info),
d78b10f5713d92d Marek Behún   2020-09-20  707  				GFP_KERNEL);
0c596a7ebb51b51 Marek Belisko 2012-11-30  708  	if (!tca_leds)
0c596a7ebb51b51 Marek Belisko 2012-11-30  709  		return ERR_PTR(-ENOMEM);
0c596a7ebb51b51 Marek Belisko 2012-11-30  710  
d78b10f5713d92d Marek Behún   2020-09-20  711  	device_for_each_child_node(&client->dev, child) {
0c596a7ebb51b51 Marek Belisko 2012-11-30  712  		struct led_info led;
0c596a7ebb51b51 Marek Belisko 2012-11-30  713  		u32 reg;
0c596a7ebb51b51 Marek Belisko 2012-11-30  714  		int ret;
0c596a7ebb51b51 Marek Belisko 2012-11-30  715  
d78b10f5713d92d Marek Behún   2020-09-20  716  		if (fwnode_property_read_string(child, "label", &led.name))
d78b10f5713d92d Marek Behún   2020-09-20  717  			led.name = fwnode_get_name(child);
d78b10f5713d92d Marek Behún   2020-09-20  718  
d78b10f5713d92d Marek Behún   2020-09-20  719  		fwnode_property_read_string(child, "linux,default-trigger",
d78b10f5713d92d Marek Behún   2020-09-20  720  					    &led.default_trigger);
d78b10f5713d92d Marek Behún   2020-09-20  721  
9334129e8e956ed NeilBrown     2013-10-31  722  		led.flags = 0;
d78b10f5713d92d Marek Behún   2020-09-20  723  		if (fwnode_property_match_string(child, "compatible",
d78b10f5713d92d Marek Behún   2020-09-20  724  						 "gpio") >= 0)
10ead6e59934be7 NeilBrown     2013-10-31  725  			led.flags |= TCA6507_MAKE_GPIO;
d78b10f5713d92d Marek Behún   2020-09-20  726  
d78b10f5713d92d Marek Behún   2020-09-20  727  		ret = fwnode_property_read_u32(child, "reg", &reg);
d78b10f5713d92d Marek Behún   2020-09-20  728  		if (ret || reg >= NUM_LEDS) {
                                                                   ^^^^^^^^^^^^^^^

"ret" is zero and reg is too large.

d78b10f5713d92d Marek Behún   2020-09-20  729  			fwnode_handle_put(child);
d78b10f5713d92d Marek Behún   2020-09-20 @730  			return ERR_PTR(ret);

Returns NULL instead of ERR_PTR(-EINVAL).

d78b10f5713d92d Marek Behún 2020-09-20 731 }

0c596a7ebb51b51 Marek Belisko 2012-11-30  732  
0c596a7ebb51b51 Marek Belisko 2012-11-30  733  		tca_leds[reg] = led;
0c596a7ebb51b51 Marek Belisko 2012-11-30  734  	}
d78b10f5713d92d Marek Behún   2020-09-20  735  
d78b10f5713d92d Marek Behún   2020-09-20  736  	pdata = devm_kzalloc(&client->dev, sizeof(struct tca6507_platform_data),
d78b10f5713d92d Marek Behún   2020-09-20  737  			     GFP_KERNEL);
0c596a7ebb51b51 Marek Belisko 2012-11-30  738  	if (!pdata)
0c596a7ebb51b51 Marek Belisko 2012-11-30  739  		return ERR_PTR(-ENOMEM);
0c596a7ebb51b51 Marek Belisko 2012-11-30  740  
0c596a7ebb51b51 Marek Belisko 2012-11-30  741  	pdata->leds.leds = tca_leds;
9334129e8e956ed NeilBrown     2013-10-31  742  	pdata->leds.num_leds = NUM_LEDS;
33ca15325ff371b Chen Gang     2013-12-08  743  #ifdef CONFIG_GPIOLIB
10ead6e59934be7 NeilBrown     2013-10-31  744  	pdata->gpio_base = -1;
33ca15325ff371b Chen Gang     2013-12-08  745  #endif
d78b10f5713d92d Marek Behún   2020-09-20  746  
0c596a7ebb51b51 Marek Belisko 2012-11-30  747  	return pdata;
0c596a7ebb51b51 Marek Belisko 2012-11-30  748  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org