drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops
Subsystems (4)
Thomas Zimmermann
maintainerPATCH 1/1 drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops
Include <drm/drm_gem_cma_helper.h> to get drm_gem_cma_vm_ops. Fallout from the recent conversion to GEM object functions.
--- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/rockchip/rockchip_drm_gem.c +1 -0
@@ -10,6 +10,7 @@#include <drm/drm.h> #include <drm/drm_gem.h> +#include <drm/drm_gem_cma_helper.h> #include <drm/drm_prime.h> #include <drm/drm_vma_manager.h>
Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Thomas.
Quoted 6 lines · Thomas Zimmermann
Include <
drm/drm_gem_cma_helper.h> to getdrm_gem_cma_vm_ops. Fallout from the recent conversion to GEM object functions.Signed-off-by Thomas Zimmermann <[email protected]>Reported-by kernel test robot <[email protected]>Fixes 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
As this has only hit drm-misc-next and not pushed anywhere else there is really no need for the Fixes: tag. At least thats my understanding.
Otherwise the patch is equal to what I posted in the weekend so:
Quoted 31 lines
Cc Thomas Zimmermann <[email protected]>Cc Daniel Vetter <[email protected]>Cc Christian König <[email protected]>Cc Sandy Huang <[email protected]>Cc "Heiko Stübner" <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rockchip/rockchip_drm_gem.c +1
-0@@ -10,6 +10,7 @@#include <drm/drm.h> #include <drm/drm_gem.h> +#include <drm/drm_gem_cma_helper.h> #include <drm/drm_prime.h> #include <drm/drm_vma_manager.h> Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thomas Zimmermann
maintainerHi
Am 28.09.20 um 10:40 schrieb Sam Ravnborg:
Quoted 11 lines
Hi Thomas.
Quoted 6 lines · Thomas Zimmermann
Include <
drm/drm_gem_cma_helper.h> to getdrm_gem_cma_vm_ops. Fallout from the recent conversion to GEM object functions.Signed-off-by Thomas Zimmermann <[email protected]>Reported-by kernel test robot <[email protected]>Fixes 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")As this has only hit drm-misc-next and not pushed anywhere else there is really no need for the Fixes: tag. At least thats my understanding.
I'm not sure what the upstream requirements are. As part of my dayjob, I maintain drivers for Suse distributions. If we pick the original patch, we also want the fixes. We have scripts that look for these Fixes tags to find the fixes. So it's helpful.
Quoted 3 lines
Otherwise the patch is equal to what I posted in the weekend so:
Reviewed-by Sam Ravnborg <[email protected]>
Thanks
Best regards
Thomas
Quoted 32 lines
Quoted 32 lines
Cc Thomas Zimmermann <[email protected]>Cc Daniel Vetter <[email protected]>Cc Christian König <[email protected]>Cc Sandy Huang <[email protected]>Cc "Heiko Stübner" <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rockchip/rockchip_drm_gem.c +1
-0@@ -10,6 +10,7 @@#include <drm/drm.h> #include <drm/drm_gem.h> +#include <drm/drm_gem_cma_helper.h> #include <drm/drm_prime.h> #include <drm/drm_vma_manager.h> Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 12 lines · Thomas Zimmermann
Hi
Am 28.09.20 um 10:40 schrieb Sam Ravnborg:
Quoted 9 lines
Hi Thomas.
Quoted 6 lines · Thomas Zimmermann
Include <
drm/drm_gem_cma_helper.h> to getdrm_gem_cma_vm_ops. Fallout from the recent conversion to GEM object functions.Signed-off-by Thomas Zimmermann <[email protected]>Reported-by kernel test robot <[email protected]>Fixes 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
Quoted 7 lines
Quoted 2 lines
As this has only hit drm-misc-next and not pushed anywhere else there is really no need for the Fixes: tag. At least thats my understanding.
I'm not sure what the upstream requirements are. As part of my dayjob, I maintain drivers for Suse distributions. If we pick the original patch, we also want the fixes. We have scripts that look for these Fixes tags to find the fixes. So it's helpful.
That makes sense, I will keep Fixes tags in the future also for "internal" fixes then.
Sam
Quoted 35 lines
Quoted 4 lines
Otherwise the patch is equal to what I posted in the weekend so:
Reviewed-by Sam Ravnborg <[email protected]>Thanks
Best regards
ThomasQuoted 25 lines
Quoted 25 lines
Cc Thomas Zimmermann <[email protected]>Cc Daniel Vetter <[email protected]>Cc Christian König <[email protected]>Cc Sandy Huang <[email protected]>Cc "Heiko Stübner" <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rockchip/rockchip_drm_gem.c +1
-0@@ -10,6 +10,7 @@#include <drm/drm.h> #include <drm/drm_gem.h> +#include <drm/drm_gem_cma_helper.h> #include <drm/drm_prime.h> #include <drm/drm_vma_manager.h>
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel