perf/x86/intel/uncore: Fix the scale of the IMC free-running events
Subsystems (2)
PATCH 1/1 perf/x86/intel/uncore: Fix the scale of the IMC free-running events
From: Kan Liang <[email protected]>
The "MiB" result of the IMC free-running bandwidth events, uncore_imc_free_running/read/ and uncore_imc_free_running/write/ are 16 times too small.
The "MiB" value equals the raw IMC free-running bandwidth counter value times a "scale" which is inaccurate.
The IMC free-running bandwidth events should be incremented per 64B cache line, not DWs (4 bytes). The "scale" should be 6.103515625e-5. Fix the "scale" for both Snow Ridge and Ice Lake.
--- arch/x86/events/intel/uncore_snbep.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/x86/events/intel/uncore_snbep.c +6 -6
@@ -4804,10 +4804,10 @@ static struct uncore_event_desc snr_uncore_imc_freerunning_events[] = {INTEL_UNCORE_EVENT_DESC (dclk,"event=0xff,umask=0x10" ),INTEL_UNCORE_EVENT_DESC (read,"event=0xff,umask=0x20" ), -INTEL_UNCORE_EVENT_DESC (read.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (read.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (read.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (write,"event=0xff,umask=0x21" ), -INTEL_UNCORE_EVENT_DESC (write.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (write.scale,"6.103515625e-5" ), INTEL_UNCORE_EVENT_DESC(write.unit, "MiB"), { /* end: all zeroes */ }, };
@@ -5265,17 +5265,17 @@ static struct uncore_event_desc icx_uncore_imc_freerunning_events[] = {INTEL_UNCORE_EVENT_DESC (dclk,"event=0xff,umask=0x10" ),INTEL_UNCORE_EVENT_DESC (read,"event=0xff,umask=0x20" ), -INTEL_UNCORE_EVENT_DESC (read.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (read.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (read.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (write,"event=0xff,umask=0x21" ), -INTEL_UNCORE_EVENT_DESC (write.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (write.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (write.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (ddrt_read,"event=0xff,umask=0x30" ), -INTEL_UNCORE_EVENT_DESC (ddrt_read.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (ddrt_read.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (ddrt_read.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (ddrt_write,"event=0xff,umask=0x31" ), -INTEL_UNCORE_EVENT_DESC (ddrt_write.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (ddrt_write.scale,"6.103515625e-5" ), INTEL_UNCORE_EVENT_DESC(ddrt_write.unit, "MiB"), { /* end: all zeroes */ }, };
Signature · 1 line
2.17.1
The following commit has been merged into the perf/core branch of tip:
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 8191016a026b8dfbb14dea64efc8e723ee99fe65 Gitweb: https://git.kernel.org/tip/8191016a026b8dfbb14dea64efc8e723ee99fe65 Author: Kan Liang <[email protected]> AuthorDate: Mon, 28 Sep 2020 06:32:40 -07:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Tue, 29 Sep 2020 09:57:02 +02:00
perf/x86/intel/uncore: Fix the scale of the IMC free-running events
The "MiB" result of the IMC free-running bandwidth events, uncore_imc_free_running/read/ and uncore_imc_free_running/write/ are 16 times too small.
The "MiB" value equals the raw IMC free-running bandwidth counter value times a "scale" which is inaccurate.
The IMC free-running bandwidth events should be incremented per 64B cache line, not DWs (4 bytes). The "scale" should be 6.103515625e-5. Fix the "scale" for both Snow Ridge and Ice Lake.
--- arch/x86/events/intel/uncore_snbep.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/x86/events/intel/uncore_snbep.c +6 -6
@@ -4807,10 +4807,10 @@ static struct uncore_event_desc snr_uncore_imc_freerunning_events[] = {INTEL_UNCORE_EVENT_DESC (dclk,"event=0xff,umask=0x10" ),INTEL_UNCORE_EVENT_DESC (read,"event=0xff,umask=0x20" ), -INTEL_UNCORE_EVENT_DESC (read.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (read.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (read.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (write,"event=0xff,umask=0x21" ), -INTEL_UNCORE_EVENT_DESC (write.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (write.scale,"6.103515625e-5" ), INTEL_UNCORE_EVENT_DESC(write.unit, "MiB"), { /* end: all zeroes */ }, };
@@ -5268,17 +5268,17 @@ static struct uncore_event_desc icx_uncore_imc_freerunning_events[] = {INTEL_UNCORE_EVENT_DESC (dclk,"event=0xff,umask=0x10" ),INTEL_UNCORE_EVENT_DESC (read,"event=0xff,umask=0x20" ), -INTEL_UNCORE_EVENT_DESC (read.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (read.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (read.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (write,"event=0xff,umask=0x21" ), -INTEL_UNCORE_EVENT_DESC (write.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (write.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (write.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (ddrt_read,"event=0xff,umask=0x30" ), -INTEL_UNCORE_EVENT_DESC (ddrt_read.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (ddrt_read.scale,"6.103515625e-5" ),INTEL_UNCORE_EVENT_DESC (ddrt_read.unit,"MiB" ),INTEL_UNCORE_EVENT_DESC (ddrt_write,"event=0xff,umask=0x31" ), -INTEL_UNCORE_EVENT_DESC (ddrt_write.scale,"3.814697266e-6" ), +INTEL_UNCORE_EVENT_DESC (ddrt_write.scale,"6.103515625e-5" ), INTEL_UNCORE_EVENT_DESC(ddrt_write.unit, "MiB"), { /* end: all zeroes */ }, };