drm/qxl: fix usage of ttm_bo_init
Subsystems (3)
PATCH 1/1 drm/qxl: fix usage of ttm_bo_init
We need to use ttm_bo_init_reserved here to make sure that the BO is pinned before it becomes visible on the LRU.
Signed-off-by Christian König <[email protected]>
--- drivers/gpu/drm/qxl/qxl_object.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/qxl/qxl_object.c +5 -3
@@ -106,6 +106,7 @@ int qxl_bo_create(struct qxl_device *qdev,struct qxl_surface *surf, struct qxl_bo **bo_ptr) { + struct ttm_operation_ctx ctx = { !kernel, false };struct qxl_bo *bo;enum ttm_bo_type type;int r;
@@ -134,9 +135,9 @@ int qxl_bo_create(struct qxl_device *qdev,qxl_ttm_placement_from_domain (bo, domain); - r =ttm_bo_init (&qdev->mman.bdev, &bo->tbo, size, type, - &bo->placement,0 , !kernel, size, -NULL ,NULL , &qxl_ttm_bo_destroy); + r =ttm_bo_init_reserved (&qdev->mman.bdev, &bo->tbo, size, type, + &bo->placement,0 , &ctx, size, +NULL ,NULL , &qxl_ttm_bo_destroy);if (unlikely (r !=0 )) {if (r != -ERESTARTSYS ) dev_err(qdev->ddev.dev,
@@ -146,6 +147,7 @@ int qxl_bo_create(struct qxl_device *qdev, }if (pinned)ttm_bo_pin (&bo->tbo); +ttm_bo_unreserve (&bo->tbo); *bo_ptr = bo;return 0 ; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Christian König
We need to use
ttm_bo_init_reservedhere to make sure that the BO is pinned before it becomes visible on the LRU.Signed-off-by Christian König <[email protected]>
Reviewed-by Daniel Vetter <[email protected]>
But maybe let Gerd test this first before pushing :-) -Daniel
Quoted 40 lines
--- drivers/gpu/drm/qxl/qxl_object.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/gpu/drm/qxl/qxl_object.c +5
-3@@ -106,6 +106,7 @@ int qxl_bo_create(struct qxl_device *qdev,struct qxl_surface *surf, struct qxl_bo **bo_ptr) { + struct ttm_operation_ctx ctx = { !kernel, false };struct qxl_bo *bo;enum ttm_bo_type type;int r;@@ -134,9 +135,9 @@ int qxl_bo_create(struct qxl_device *qdev,qxl_ttm_placement_from_domain (bo, domain); - r =ttm_bo_init (&qdev->mman.bdev, &bo->tbo, size, type, - &bo->placement,0 , !kernel, size, -NULL ,NULL , &qxl_ttm_bo_destroy); + r =ttm_bo_init_reserved (&qdev->mman.bdev, &bo->tbo, size, type, + &bo->placement,0 , &ctx, size, +NULL ,NULL , &qxl_ttm_bo_destroy);if (unlikely (r !=0 )) {if (r != -ERESTARTSYS ) dev_err(qdev->ddev.dev,@@ -146,6 +147,7 @@ int qxl_bo_create(struct qxl_device *qdev, }if (pinned)ttm_bo_pin (&bo->tbo); +ttm_bo_unreserve (&bo->tbo); *bo_ptr = bo;return 0 ; }Signature · 1 line
2.17.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Christian König
We need to use
ttm_bo_init_reservedhere to make sure that the BO is pinned before it becomes visible on the LRU.Signed-off-by Christian König <[email protected]>
Reviewed-by Gerd Hoffmann <[email protected]>#
Tested-by Gerd Hoffmann <[email protected]>#
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel