Enable USB host for AST2600
Subsystems (5)
Ryan Chen
reviewercover Enable USB host for AST2600
The patches enable UHCI driver in AST2600 and also enable USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ arch/arm/configs/aspeed_g5_defconfig | 1 + drivers/usb/host/uhci-platform.c | 3 ++- 3 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
Ryan Chen
reviewerPATCH 1/3 configs: aspeed: enable UHCI driver in defconfig
Enable UHCI driver in aspeed_g5_defconfig.
--- arch/arm/configs/aspeed_g5_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/configs/aspeed_g5_defconfig +1 -0
@@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y CONFIG_USB_EHCI_HCD_PLATFORM=y +CONFIG_USB_UHCI_HCD=y CONFIG_USB_GADGET=y CONFIG_USB_ASPEED_VHUB=y CONFIG_USB_CONFIGFS=y
Signature · 1 line
2.17.1
Ryan Chen
reviewerPATCH 2/3 usb: host: add uhci compatible support for ast2600-uhci
In reply to Ryan ChenAdd support for AST2600 SOC UHCI driver.
--- drivers/usb/host/uhci-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -1
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) num_ports); }if (of_device_is_compatible (np,"aspeed,ast2400-uhci" ) || -of_device_is_compatible (np,"aspeed,ast2500-uhci" )) { +of_device_is_compatible (np,"aspeed,ast2500-uhci" ) || +of_device_is_compatible (np,"aspeed,ast2600-uhci" )) { uhci->is_aspeed =1 ;dev_info (&pdev->dev,"Enabled Aspeed implementation workarounds\n" );
Signature · 1 line
2.17.1
Ryan Chen
reviewerPATCH 3/3 ARM: dts: add ehci uhci enable in evb dts
In reply to Ryan ChenAdd EHCI UHCI enable build in aspeed-ast2600-evb.dts
--- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-ast2600-evb.dts +8 -0
@@ -237,3 +237,11 @@ &fsim0 { status = "okay"; }; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +};
Signature · 1 line
2.17.1
Re: [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig
In reply to Ryan ChenQuoted 3 lines · Ryan Chen
Enable UHCI driver in
aspeed_g5_defconfig.Signed-off-by Ryan Chen <[email protected]>
Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci
In reply to Ryan ChenQuoted 3 lines · Ryan Chen
Add support for AST2600 SOC UHCI driver.
Signed-off-by Ryan Chen <[email protected]>
Re: [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts
In reply to Ryan ChenQuoted 3 lines · Ryan Chen
Add EHCI UHCI enable build in
aspeed-ast2600-evb.dtsSigned-off-by Ryan Chen <[email protected]>
Ryan Chen
reviewerHello Joel,
Have you take time review this patches ?
Ryan Chen
Tel : 886-3-5751185 ext:8857
Quoted 25 lines
-----Original Message-----
From: Ryan Chen <[email protected]>
Sent: Wednesday, September 30, 2020 12:08 PM
To: Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>
Cc: Ryan Chen <[email protected]>
Subject: [PATCH 0/3] Enable USB host for AST2600The patches enable UHCI driver in AST2600 and also enable USB host in
aspeed-ast2600-evb.dts.Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dtsarch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ arch/arm/configs/aspeed_g5_defconfig | 1 + drivers/usb/host/uhci-platform.c | 3 ++- 3 files changed, 11 insertions(+), 1 deletion(-)--
2.17.1
Re: [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig
In reply to Ryan ChenQuoted 4 lines · Ryan Chen
Enable UHCI driver in
aspeed_g5_defconfig.Signed-off-by Ryan Chen <[email protected]>
Quoted 19 lines
--- arch/arm/configs/aspeed_g5_defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/configs/aspeed_g5_defconfig +1
-1@@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y CONFIG_USB_EHCI_HCD_PLATFORM=y +CONFIG_USB_UHCI_HCD=y CONFIG_USB_GADGET=y CONFIG_USB_ASPEED_VHUB=y CONFIG_USB_CONFIGFS=y --2.17.1
Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci
In reply to Ryan ChenQuoted 4 lines · Ryan Chen
Add support for AST2600 SOC UHCI driver.
Signed-off-by Ryan Chen <[email protected]>
USB maintainers, can you please take this patch (2/3)? I will take the others in this series through the aspeed tree.
Cheers,
Joel
Quoted 21 lines
--- drivers/usb/host/uhci-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/usb/host/uhci-platform.c +2
-2@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) num_ports); }if (of_device_is_compatible (np,"aspeed,ast2400-uhci" ) || -of_device_is_compatible (np,"aspeed,ast2500-uhci" )) { +of_device_is_compatible (np,"aspeed,ast2500-uhci" ) || +of_device_is_compatible (np,"aspeed,ast2600-uhci" )) { uhci->is_aspeed =1 ;dev_info (&pdev->dev,"Enabled Aspeed implementation workarounds\n" ); --2.17.1
Re: [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts
In reply to Ryan ChenQuoted 4 lines · Ryan Chen
Add EHCI UHCI enable build in
aspeed-ast2600-evb.dtsSigned-off-by Ryan Chen <[email protected]>
Quoted 23 lines
--- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/boot/dts/aspeed-ast2600-evb.dts +8
-1@@ -237,3 +237,11 @@ &fsim0 { status = "okay"; }; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; --2.17.1
Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci
In reply to Joel StanleyQuoted 29 lines · Joel Stanley
Quoted 4 lines · Ryan Chen
Add support for AST2600 SOC UHCI driver.
Signed-off-by Ryan Chen <[email protected]>Reviewed-by Joel Stanley <[email protected]>USB maintainers, can you please take this patch (2/3)? I will take the others in this series through the aspeed tree.
Cheers,
Joel
Quoted 13 lines
--- drivers/usb/host/uhci-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/usb/host/uhci-platform.c +0
-1@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) num_ports); } if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || -of_device_is_compatible (np,"aspeed,ast2500-uhci" )) {
Quoted 8 lines
Quoted 8 lines
drivers/usb/host/uhci-platform.c +2
-1+ of_device_is_compatible(np, "aspeed,ast2500-uhci") || + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { uhci->is_aspeed =1 ;dev_info (&pdev->dev,"Enabled Aspeed implementation workarounds\n" ); --2.17.1
The indentation of the continuation lines isn't good, because the continued parts are aligned with the lines in the conditional block. They should be visually distinct. Either align with the "of_device..." at the start or indent by two extra tab stops.
Once this is fixed, you can add:
Alan Stern
Ryan Chen
reviewerv2 cover Enable USB host for AST2600
In reply to Ryan Chenv2:
-[1/3]: Add SCSI,BLK_DEV_SD,USB_STORAGE in defconfig. -[2/3]: Fix continuation lines.
v1:
-The patches enable UHCI driver in AST2600 and also
enable USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ arch/arm/configs/aspeed_g5_defconfig | 4 ++++ drivers/usb/host/uhci-platform.c | 3 ++- 3 files changed, 14 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
Ryan Chen
reviewerPATCH v2 1/3 configs: aspeed: enable UHCI driver in defconfig
v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.
--- arch/arm/configs/aspeed_g5_defconfig | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/configs/aspeed_g5_defconfig +4 -0
@@ -90,6 +90,8 @@ CONFIG_BLK_DEV_NBD=y CONFIG_MCTP_LPC=y CONFIG_EEPROM_AT24=y CONFIG_EEPROM_AT25=y +CONFIG_SCSI=y +CONFIG_BLK_DEV_SD=y CONFIG_MD=y CONFIG_BLK_DEV_DM=y CONFIG_DM_VERITY=y
@@ -212,6 +214,8 @@ CONFIG_USB_DYNAMIC_MINORS=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y CONFIG_USB_EHCI_HCD_PLATFORM=y +CONFIG_USB_UHCI_HCD=y +CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_ASPEED_VHUB=y CONFIG_USB_CONFIGFS=y
Signature · 1 line
2.17.1
Ryan Chen
reviewerPATCH v2 2/3 usb: host: add uhci compatible support for ast2600-uhci
In reply to Ryan Chenv2:
- Fix continuation lines, align with "of_device"
v1:
- Add support for AST2600 SOC UHCI driver.
--- drivers/usb/host/uhci-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -1
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) num_ports); }if (of_device_is_compatible (np,"aspeed,ast2400-uhci" ) || -of_device_is_compatible (np,"aspeed,ast2500-uhci" )) { +of_device_is_compatible (np,"aspeed,ast2500-uhci" ) || +of_device_is_compatible (np,"aspeed,ast2600-uhci" )) { uhci->is_aspeed =1 ;dev_info (&pdev->dev,"Enabled Aspeed implementation workarounds\n" );
Signature · 1 line
2.17.1
Ryan Chen
reviewerPATCH v2 3/3 ARM: dts: add ehci uhci enable in evb dts
In reply to Ryan ChenAdd EHCI UHCI enable build in aspeed-ast2600-evb.dts
--- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-ast2600-evb.dts +8 -0
@@ -237,3 +237,11 @@ &fsim0 { status = "okay"; }; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +};
Signature · 1 line
2.17.1
Re: [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci
In reply to Ryan ChenQuoted 4 lines · Ryan Chen
v2:
- Fix continuation lines, align with "of_device"
v1:
- Add support for AST2600 SOC UHCI driver.
These all go below the --- line, as the kernel documentation asks for.
Quoted 1 line
Signed-off-by Ryan Chen <[email protected]>
You have no changelog text here at all, and I can't take that, sorry. Please fix this up and resend with a proper changelog text.
thanks,
greg k-h
Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
In reply to Ryan ChenQuoted 6 lines · Ryan Chen
v2:
-Changed : Add SCSI,BLK_DEV_SD,USB_STORAGEsupport.
v1:
-Enable UHCI driver inaspeed_g5_defconfig.Signed-off-by Ryan Chen <[email protected]>
Why do you need this in a defconfig?
Joel Stanley
maintainerRe: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
Quoted 10 lines · Greg KH
Quoted 6 lines · Ryan Chen
v2:
-Changed : Add SCSI,BLK_DEV_SD,USB_STORAGEsupport.
v1:
-Enable UHCI driver inaspeed_g5_defconfig.Signed-off-by Ryan Chen <[email protected]>Why do you need this in a defconfig?
I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.
Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it.
Cheers,
Joel
Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
Quoted 8 lines · Joel Stanley
Quoted 7 lines · Greg KH
Quoted 5 lines · Ryan Chen
v2:
-Changed : Add SCSI,BLK_DEV_SD,USB_STORAGEsupport.
v1:
-Enable UHCI driver inaspeed_g5_defconfig.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Ryan Chen <[email protected]>Why do you need this in a defconfig?
I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.
Then it needs to be described in the changelog, otherwise we have no idea why this is happening :)
thanks,
greg k-h
Ryan Chen
reviewerRE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
Quoted 22 lines
-----Original Message-----
From: Greg KH <[email protected]>
Sent: Friday, October 9, 2020 1:47 PM
To: Joel Stanley <[email protected]>
Cc: Ryan Chen <[email protected]>; Andrew Jeffery <[email protected]>; Linux ARM <[email protected]>; linux-aspeed <[email protected]>; Linux Kernel Mailing List <[email protected]>; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfigQuoted 10 lines · Joel Stanley
Quoted 9 lines · Greg KH
Quoted 6 lines · Ryan Chen
v2:
-Changed : Add SCSI,BLK_DEV_SD,USB_STORAGEsupport.
v1:
-Enable UHCI driver inaspeed_g5_defconfig.Signed-off-by Ryan Chen <[email protected]>
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Why do you need this in a defconfig?
I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.
Then it needs to be described in the changelog, otherwise we have no idea why this is happening :)
Ok, will send new version describe it.
Ryan Chen
reviewerRE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
In reply to Joel StanleyQuoted 21 lines
-----Original Message-----
From: Joel Stanley <[email protected]>
Sent: Friday, October 9, 2020 12:55 PM
To: Greg KH <[email protected]>
Cc: Ryan Chen <[email protected]>; Andrew Jeffery <[email protected]>; Linux ARM <[email protected]>; linux-aspeed <[email protected]>; Linux Kernel Mailing List <[email protected]>; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfigQuoted 9 lines · Greg KH
Quoted 6 lines · Ryan Chen
v2:
-Changed : Add SCSI,BLK_DEV_SD,USB_STORAGEsupport.
v1:
-Enable UHCI driver inaspeed_g5_defconfig.Signed-off-by Ryan Chen <[email protected]>
Quoted 8 lines
Quoted 1 line
Why do you need this in a defconfig?
I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.
Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it.
Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch, am I right?
Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
In reply to Ryan ChenHEllo!
Quoted 1 line · Ryan Chen
Add EHCI UHCI enable build in
aspeed-ast2600-evb.dts
Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
Quoted 1 line
Signed-off-by Ryan Chen <[email protected]>
[...]
MBR, Sergei
Ryan Chen
reviewerRE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
Hello Segei,
Quoted 10 lines
-----Original Message-----
From: Sergei Shtylyov <[email protected]>
Sent: Friday, October 9, 2020 4:23 PM
To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
Quoted 8 lines
HEllo!
Quoted 1 line · Ryan Chen
Add EHCI UHCI enable build in
aspeed-ast2600-evb.dtsEnable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
Yes, it is enable for AST2600 EVB.
Quoted 4 lines
Quoted 1 line
Signed-off-by Ryan Chen <[email protected]>[...]
MBR, Sergei
Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
Hi Ryan,
Quoted 14 lines · Ryan Chen
Hello Segei,
Quoted 12 lines
-----Original Message-----
From: Sergei Shtylyov <[email protected]>
Sent: Friday, October 9, 2020 4:23 PM
To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dtsHEllo!
Quoted 8 lines
Quoted 6 lines · Ryan Chen
Quoted 2 lines
Add EHCI UHCI enable build in
aspeed-ast2600-evb.dtsEnable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
Yes, it is enable for AST2600 EVB.
I think Sergei was suggesting you change the wording of the commit message.
Andrew
Ryan Chen
reviewerRE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
Quoted 31 lines
-----Original Message-----
From: Andrew Jeffery <[email protected]>
Sent: Thursday, October 22, 2020 7:45 AM
To: Ryan Chen <[email protected]>; Sergei Shtylyov <[email protected]>; Joel Stanley <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dtsHi Ryan,
Quoted 18 lines · Ryan Chen
Hello Segei,
Quoted 16 lines
-----Original Message-----
From: Sergei Shtylyov <[email protected]>
Sent: Friday, October 9, 2020 4:23 PM
To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org;
linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dtsHEllo!
On 09.10.2020 5:49, Ryan Chen wrote:
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Add EHCI UHCI enable build in
aspeed-ast2600-evb.dtsEnable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
Yes, it is enable for AST2600 EVB.
I think Sergei was suggesting you change the wording of the commit message.
Thanks, will resend the patch with modification.