Skip to contentSkip to conversation

Enable USB host for AST2600

PATCH Superseded Ryan Chen 7 participants 26 messages Sep 30, 2020 – Oct 22, 2020

Subsystems (5)
lore
Share & tools
lore

Ryan Chen

author reviewer
#0 lore raw

cover Enable USB host for AST2600

The patches enable UHCI driver in AST2600 and also enable USB host in aspeed-ast2600-evb.dts.

Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts

 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 arch/arm/configs/aspeed_g5_defconfig     | 1 +
 drivers/usb/host/uhci-platform.c         | 3 ++-
 3 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 1/3 configs: aspeed: enable UHCI driver in defconfig

Enable UHCI driver in aspeed_g5_defconfig.

---
 arch/arm/configs/aspeed_g5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/aspeed_g5_defconfig +1 -0
index 2bacd8c90f4b..a57009d1a3b8 100644
@@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_ROOT_HUB_TT=y
 CONFIG_USB_EHCI_HCD_PLATFORM=y
+CONFIG_USB_UHCI_HCD=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_ASPEED_VHUB=y
 CONFIG_USB_CONFIGFS=y
Signature · 1 line
2.17.1
author reviewer
#4 lore raw

PATCH 2/3 usb: host: add uhci compatible support for ast2600-uhci

In reply to Ryan Chen

Add support for AST2600 SOC UHCI driver.

---
 drivers/usb/host/uhci-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -1
index 70dbd95c3f06..fa40fe125c2a 100644
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
 				num_ports);
 		}
 		if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
-		    of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
+			of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+			of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
 			uhci->is_aspeed = 1;
 			dev_info(&pdev->dev,
 				 "Enabled Aspeed implementation workarounds\n");
Signature · 1 line
2.17.1
author reviewer
#8 lore raw

PATCH 3/3 ARM: dts: add ehci uhci enable in evb dts

In reply to Ryan Chen

Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

---
 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-ast2600-evb.dts +8 -0
index 89be13197780..2772796e215e 100644
@@ -237,3 +237,11 @@
 &fsim0 {
 	status = "okay";
 };
+
+&ehci1 {
+	status = "okay";
+};
+
+&uhci {
+	status = "okay";
+};
Signature · 1 line
2.17.1
author reviewer
#25 lore raw
In reply to Ryan Chen

Hello Joel,
Have you take time review this patches ?

Ryan Chen

Tel : 886-3-5751185 ext:8857

Quoted 25 lines

-----Original Message-----
From: Ryan Chen <[email protected]>
Sent: Wednesday, September 30, 2020 12:08 PM
To: Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>
Cc: Ryan Chen <[email protected]>
Subject: [PATCH 0/3] Enable USB host for AST2600

The patches enable UHCI driver in AST2600 and also enable USB host in aspeed-ast2600-evb.dts.

Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts

 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 arch/arm/configs/aspeed_g5_defconfig     | 1 +
 drivers/usb/host/uhci-platform.c         | 3 ++-
 3 files changed, 11 insertions(+), 1 deletion(-)

--
2.17.1

maintainer Reviewed-by on v1 1/3
#3 lore raw

Re: [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig

In reply to Ryan Chen
Quoted 4 lines · Ryan Chen

Enable UHCI driver in aspeed_g5_defconfig.

Quoted 19 lines
---
 arch/arm/configs/aspeed_g5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/aspeed_g5_defconfig +1 -1
index 2bacd8c90f4b..a57009d1a3b8 100644
@@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_ROOT_HUB_TT=y
 CONFIG_USB_EHCI_HCD_PLATFORM=y
+CONFIG_USB_UHCI_HCD=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_ASPEED_VHUB=y
 CONFIG_USB_CONFIGFS=y
--

2.17.1

maintainer Reviewed-by on v1 2/3
#6 lore raw

Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci

In reply to Ryan Chen
Quoted 4 lines · Ryan Chen

Add support for AST2600 SOC UHCI driver.

USB maintainers, can you please take this patch (2/3)? I will take the others in this series through the aspeed tree.

Cheers,

Joel

Quoted 21 lines
---
 drivers/usb/host/uhci-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -2
index 70dbd95c3f06..fa40fe125c2a 100644
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
                                num_ports);
                }
                if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
-                   of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
+                       of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+                       of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
                        uhci->is_aspeed = 1;
                        dev_info(&pdev->dev,
                                 "Enabled Aspeed implementation workarounds\n");
--

2.17.1

maintainer Reviewed-by on v1 3/3
#10 lore raw

Re: [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts

In reply to Ryan Chen
Quoted 4 lines · Ryan Chen

Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

Quoted 23 lines
---
 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-ast2600-evb.dts +8 -1
index 89be13197780..2772796e215e 100644
@@ -237,3 +237,11 @@
 &fsim0 {
        status = "okay";
 };
+
+&ehci1 {
+       status = "okay";
+};
+
+&uhci {
+       status = "okay";
+};
--

2.17.1

maintainer Acked-by
#7 lore raw

Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci

In reply to Joel Stanley
Quoted 29 lines · Joel Stanley
Quoted 4 lines · Ryan Chen

Add support for AST2600 SOC UHCI driver.

USB maintainers, can you please take this patch (2/3)? I will take the others in this series through the aspeed tree.

Cheers,

Joel

Quoted 13 lines
---
 drivers/usb/host/uhci-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +0 -1
index 70dbd95c3f06..fa40fe125c2a 100644
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
                                num_ports);
                }
                if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
-                   of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
Quoted 8 lines
Quoted 8 lines
drivers/usb/host/uhci-platform.c +2 -1
+                       of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+                       of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
                        uhci->is_aspeed = 1;
                        dev_info(&pdev->dev,
                                 "Enabled Aspeed implementation workarounds\n");
--

2.17.1

The indentation of the continuation lines isn't good, because the continued parts are aligned with the lines in the conditional block. They should be visually distinct. Either align with the "of_device..." at the start or indent by two extra tab stops.

Once this is fixed, you can add:

Alan Stern

author reviewer
#11 lore raw

v2 cover Enable USB host for AST2600

In reply to Ryan Chen

v2:
-[1/3]: Add SCSI,BLK_DEV_SD,USB_STORAGE in defconfig. -[2/3]: Fix continuation lines.
v1:
-The patches enable UHCI driver in AST2600 and also
enable USB host in aspeed-ast2600-evb.dts.

Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts

 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 arch/arm/configs/aspeed_g5_defconfig     | 4 ++++
 drivers/usb/host/uhci-platform.c         | 3 ++-
 3 files changed, 14 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
author reviewer
#12 lore raw

PATCH v2 1/3 configs: aspeed: enable UHCI driver in defconfig

v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.

---
 arch/arm/configs/aspeed_g5_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/configs/aspeed_g5_defconfig +4 -0
index 2bacd8c90f4b..7a6b0b79be9f 100644
@@ -90,6 +90,8 @@ CONFIG_BLK_DEV_NBD=y
 CONFIG_MCTP_LPC=y
 CONFIG_EEPROM_AT24=y
 CONFIG_EEPROM_AT25=y
+CONFIG_SCSI=y
+CONFIG_BLK_DEV_SD=y
 CONFIG_MD=y
 CONFIG_BLK_DEV_DM=y
 CONFIG_DM_VERITY=y
@@ -212,6 +214,8 @@ CONFIG_USB_DYNAMIC_MINORS=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_ROOT_HUB_TT=y
 CONFIG_USB_EHCI_HCD_PLATFORM=y
+CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_ASPEED_VHUB=y
 CONFIG_USB_CONFIGFS=y
Signature · 1 line
2.17.1
author reviewer
#18 lore raw

PATCH v2 2/3 usb: host: add uhci compatible support for ast2600-uhci

In reply to Ryan Chen

v2:
- Fix continuation lines, align with "of_device"
v1:
- Add support for AST2600 SOC UHCI driver.

---
 drivers/usb/host/uhci-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -1
index 70dbd95c3f06..be9e9db7cad1 100644
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
 				num_ports);
 		}
 		if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
-		    of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
+		    of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+		    of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
 			uhci->is_aspeed = 1;
 			dev_info(&pdev->dev,
 				 "Enabled Aspeed implementation workarounds\n");
Signature · 1 line
2.17.1
author reviewer
#20 lore raw

PATCH v2 3/3 ARM: dts: add ehci uhci enable in evb dts

In reply to Ryan Chen

Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

---
 arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-ast2600-evb.dts +8 -0
index 89be13197780..2772796e215e 100644
@@ -237,3 +237,11 @@
 &fsim0 {
 	status = "okay";
 };
+
+&ehci1 {
+	status = "okay";
+};
+
+&uhci {
+	status = "okay";
+};
Signature · 1 line
2.17.1
#19 lore raw

Re: [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci

In reply to Ryan Chen
Quoted 4 lines · Ryan Chen

v2:
- Fix continuation lines, align with "of_device"
v1:
- Add support for AST2600 SOC UHCI driver.

These all go below the --- line, as the kernel documentation asks for.

Quoted 1 line

You have no changelog text here at all, and I can't take that, sorry. Please fix this up and resend with a proper changelog text.

thanks,

greg k-h

#13 lore raw

Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

In reply to Ryan Chen
Quoted 6 lines · Ryan Chen

v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.

Why do you need this in a defconfig?

maintainer
#14 lore raw

Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

Quoted 10 lines · Greg KH
Quoted 6 lines · Ryan Chen

v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.

Why do you need this in a defconfig?

I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.

Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it.

Cheers,

Joel

#15 lore raw

Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

Quoted 8 lines · Joel Stanley
Quoted 7 lines · Greg KH
Quoted 5 lines · Ryan Chen

v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Why do you need this in a defconfig?

I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.

Then it needs to be described in the changelog, otherwise we have no idea why this is happening :)

thanks,

greg k-h

author reviewer
#16 lore raw

RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

Quoted 22 lines

-----Original Message-----
From: Greg KH <[email protected]>
Sent: Friday, October 9, 2020 1:47 PM
To: Joel Stanley <[email protected]>
Cc: Ryan Chen <[email protected]>; Andrew Jeffery <[email protected]>; Linux ARM <[email protected]>; linux-aspeed <[email protected]>; Linux Kernel Mailing List <[email protected]>; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

Quoted 10 lines · Joel Stanley
Quoted 9 lines · Greg KH
Quoted 6 lines · Ryan Chen

v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Why do you need this in a defconfig?

I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.

Then it needs to be described in the changelog, otherwise we have no idea why this is happening :)

Ok, will send new version describe it.

author reviewer
#17 lore raw

RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

In reply to Joel Stanley
Quoted 21 lines

-----Original Message-----
From: Joel Stanley <[email protected]>
Sent: Friday, October 9, 2020 12:55 PM
To: Greg KH <[email protected]>
Cc: Ryan Chen <[email protected]>; Andrew Jeffery <[email protected]>; Linux ARM <[email protected]>; linux-aspeed <[email protected]>; Linux Kernel Mailing List <[email protected]>; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

Quoted 9 lines · Greg KH
Quoted 6 lines · Ryan Chen

v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.

Quoted 8 lines
Quoted 1 line

Why do you need this in a defconfig?

I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change.

Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it.

Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch, am I right?

author reviewer
#22 lore raw

RE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

Hello Segei,

Quoted 10 lines

-----Original Message-----
From: Sergei Shtylyov <[email protected]>
Sent: Friday, October 9, 2020 4:23 PM
To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

Quoted 8 lines

HEllo!

Quoted 1 line · Ryan Chen

Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?

Yes, it is enable for AST2600 EVB.

Quoted 4 lines
Quoted 1 line

[...]

MBR, Sergei

#23 lore raw

Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

Hi Ryan,

Quoted 14 lines · Ryan Chen

Hello Segei,

Quoted 12 lines

-----Original Message-----
From: Sergei Shtylyov <[email protected]>
Sent: Friday, October 9, 2020 4:23 PM
To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

HEllo!

Quoted 8 lines
Quoted 6 lines · Ryan Chen
Quoted 2 lines

Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?

Yes, it is enable for AST2600 EVB.

I think Sergei was suggesting you change the wording of the commit message.

Andrew

author reviewer
#24 lore raw

RE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

Quoted 31 lines

-----Original Message-----
From: Andrew Jeffery <[email protected]>
Sent: Thursday, October 22, 2020 7:45 AM
To: Ryan Chen <[email protected]>; Sergei Shtylyov <[email protected]>; Joel Stanley <[email protected]>; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

Hi Ryan,

Quoted 18 lines · Ryan Chen

Hello Segei,

Quoted 16 lines

-----Original Message-----
From: Sergei Shtylyov <[email protected]>
Sent: Friday, October 9, 2020 4:23 PM
To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; linux-arm-kernel at lists.infradead.org;
linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; linux-usb at vger.kernel.org; BMC-SW <[email protected]>; Alan Stern <[email protected]>
Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

HEllo!

On 09.10.2020 5:49, Ryan Chen wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Add EHCI UHCI enable build in aspeed-ast2600-evb.dts

Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?

Yes, it is enable for AST2600 EVB.

I think Sergei was suggesting you change the wording of the commit message.

Thanks, will resend the patch with modification.