MAINTAINERS: exclude char maintainers from things they do not maintain
PATCH 1/1 MAINTAINERS: exclude char maintainers from things they do not maintain
There are a number of subdirectories and files in drivers/char/ that have their own maintainers and developers and ways of getting patches to Linus. This includes random.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.
MAINTAINERS +5 -0
@@ -4101,6 +4101,11 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git F: drivers/char/ F: drivers/misc/ F: include/linux/miscdevice.h +X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/ CHECKPATCH M: Andy Whitcroft <[email protected]>
Quoted 10 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Good idea,
Quoted 9 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Yes, please do. No reason for you to get all the noise from these.
Quoted 17 lines
MAINTAINERS +5
-0@@ -4101,6 +4101,11 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git F: drivers/char/ F: drivers/misc/ F: include/linux/miscdevice.h +X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/ CHECKPATCH M: Andy Whitcroft <[email protected]>
Quoted 8 lines · Corey Minyard
Quoted 7 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.
Quoted 6 lines
Quoted 2 lines
Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Yes, please do. No reason for you to get all the noise from these.
Acked-by Corey Minyard <[email protected]>
Thanks!
greg k-h
Quoted 10 lines · Arnd Bergmann
Quoted 8 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.
Quoted 6 lines
Quoted 2 lines
Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Good idea,
Acked-by Arnd Bergmann <[email protected]>
Now our inboxes will be a tiny bit smaller :)
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Corey Minyard
Quoted 9 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 7 lines
Quoted 3 lines
Yes, please do. No reason for you to get all the noise from these.
Acked-by Corey Minyard <[email protected]>Thanks!
greg k-h
Your exclusion list is:
+X: drivers/char/agp/
+X: drivers/char/hw_random/
+X: drivers/char/ipmi/
+X: drivers/char/random.c
+X: drivers/char/tpm/
But the current subdirectories of drivers/char are:
drivers/char/agpdrivers/char/hw_randomdrivers/char/ipmidrivers/char/mwavedrivers/char/pcmciadrivers/char/tpmdrivers/char/tpm/eventlogdrivers/char/tpm/st33zp24drivers/char/xilinx_hwicapdrivers/char/xillybus
do you want to specifically maintain any of them?
Wouldn't it be easier to add a single subdirectory exclusion and add specific inclusions for subdirectories you actually do want to maintain>
X: drivers/char/*/
F: drivers/char/<whatever>
Quoted 42 lines · Joe Perches
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Corey Minyard
Quoted 9 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.Cc Arnd Bergmann <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 7 lines
Quoted 3 lines
Yes, please do. No reason for you to get all the noise from these.
Acked-by Corey Minyard <[email protected]>Thanks!
greg k-h
Your exclusion list is:
MAINTAINERS +5
-0+X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/But the current subdirectories of
drivers/charare:
drivers/char/agpdrivers/char/hw_randomdrivers/char/ipmidrivers/char/mwavedrivers/char/pcmciadrivers/char/tpmdrivers/char/tpm/eventlogdrivers/char/tpm/st33zp24drivers/char/xilinx_hwicapdrivers/char/xillybus
Quoted 1 line
do you want to specifically maintain any of them?
Yes, the other ones we do maintain.
Quoted 7 lines
Wouldn't it be easier to add a single subdirectory exclusion and add specific inclusions for subdirectories you actually do want to maintain>
X:
drivers/char/*/
F: drivers/char/<whatever>
If we do that, it will be one extra line in the MAINTAINERS file, as we are dealing with 4 we want, and 4 we don't :)
I like being explicit as to what we do NOT want to review, it's easier to see when glancing at the file.
thanks,
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Joe Perches
Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Corey Minyard
Quoted 6 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.
[]
Quoted 30 lines
Quoted 21 lines
Your exclusion list is:
MAINTAINERS +5
-0+X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/But the current subdirectories of
drivers/charare:
drivers/char/agpdrivers/char/hw_randomdrivers/char/ipmidrivers/char/mwavedrivers/char/pcmciadrivers/char/tpmdrivers/char/tpm/eventlogdrivers/char/tpm/st33zp24drivers/char/xilinx_hwicapdrivers/char/xillybusQuoted 1 line
do you want to specifically maintain any of them?
Yes, the other ones we do maintain.
Quoted 5 lines
Wouldn't it be easier to add a single subdirectory exclusion and add specific inclusions for subdirectories you actually do want to maintain>
Quoted 8 lines
Quoted 2 lines
X:
drivers/char/*/
F: drivers/char/<whatever>If we do that, it will be one extra line in the
MAINTAINERSfile, as we are dealing with 4 we want, and 4 we don't :)I like being explicit as to what we do NOT want to review, it's easier to see when glancing at the file.
No worries, it just wasn't obvious that all the other directories were ones you actually want to maintain.
btw: xillybus nominally has its own maintainer too.
XILLYBUS DRIVER
M: Eli Billauer <[email protected]>
L: [email protected]
S: Supported
F: drivers/char/xillybus/
cheers, Joe
Quoted 45 lines · Joe Perches
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Joe Perches
Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Corey Minyard
Quoted 6 lines · Greg Kroah-Hartman
There are a number of subdirectories and files in
drivers/char/that have their own maintainers and developers and ways of getting patches to Linus. This includesrandom.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead.[]
Quoted 33 lines
Quoted 21 lines
Your exclusion list is:
MAINTAINERS +5
-0+X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/But the current subdirectories of
drivers/charare:
drivers/char/agpdrivers/char/hw_randomdrivers/char/ipmidrivers/char/mwavedrivers/char/pcmciadrivers/char/tpmdrivers/char/tpm/eventlogdrivers/char/tpm/st33zp24drivers/char/xilinx_hwicapdrivers/char/xillybusQuoted 1 line
do you want to specifically maintain any of them?
Yes, the other ones we do maintain.
Quoted 7 lines
Wouldn't it be easier to add a single subdirectory exclusion and add specific inclusions for subdirectories you actually do want to maintain>
X:
drivers/char/*/
F: drivers/char/<whatever>
Quoted 8 lines
Quoted 5 lines
If we do that, it will be one extra line in the
MAINTAINERSfile, as we are dealing with 4 we want, and 4 we don't :)I like being explicit as to what we do NOT want to review, it's easier to see when glancing at the file.
No worries, it just wasn't obvious that all the other directories were ones you actually want to maintain.
Someone has to :)
Quoted 7 lines
btw: xillybus nominally has its own maintainer too.
XILLYBUS DRIVER
M: Eli Billauer <[email protected]>
L: [email protected]
S: Supported
F:drivers/char/xillybus/
I end up usually taking the patches from here so leaving it as part of the "umbrella" for char/misc patches is fine.
thanks,
greg k-h