Skip to contentSkip to conversation

libxfs: disallow filesystems with reverse mapping and reflink and realtime

PATCH In review Darrick J. Wong 2 participants 5 messages Sep 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libxfs: disallow filesystems with reverse mapping and reflink and realtime

From: Darrick J. Wong <[email protected]>

Neither the kernel nor the code in xfsprogs support filesystems that have (either reverse mapping btrees or reflink) enabled and a realtime volume configured. The kernel rejects such combinations and mkfs refuses to format such a config, but xfsprogs doesn't check and can do Bad Things, so port those checks before someone shreds their filesystem.

---
v2: move code to rtmount_init where it belongs

---
 libxfs/init.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
libxfs/init.c +15 -0
index cb8967bc77d4..330c645190d9 100644
@@ -428,6 +428,21 @@ rtmount_init(
 	sbp = &mp->m_sb;
 	if (sbp->sb_rblocks == 0)
 		return 0;
+
+	if (xfs_sb_version_hasreflink(sbp)) {
+		fprintf(stderr,
+	_("%s: Reflink not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
+	if (xfs_sb_version_hasrmapbt(sbp)) {
+		fprintf(stderr,
+	_("%s: Reverse mapping btree not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
 	if (mp->m_rtdev_targp->dev == 0 && !(flags & LIBXFS_MOUNT_DEBUGGER)) {
 		fprintf(stderr, _("%s: filesystem has a realtime subvolume\n"),
 			progname);
#1 lore raw
Quoted 9 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Neither the kernel nor the code in xfsprogs support filesystems that have (either reverse mapping btrees or reflink) enabled and a realtime volume configured. The kernel rejects such combinations and mkfs refuses to format such a config, but xfsprogs doesn't check and can do Bad Things, so port those checks before someone shreds their filesystem.

so now xfs_db won't even touch it, I'm not sure that's desirable.

# db/xfs_db fsfile
xfs_db: Reflink not compatible with realtime device. Please try a newer xfsprogs.
xfs_db: realtime device init failed
xfs_db: device fsfile unusable (not an XFS filesystem?)

-Eric

Quoted 33 lines

---
v2: move code to rtmount_init where it belongs

---
 libxfs/init.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
libxfs/init.c +15 -0
index cb8967bc77d4..330c645190d9 100644
@@ -428,6 +428,21 @@ rtmount_init(
 	sbp = &mp->m_sb;
 	if (sbp->sb_rblocks == 0)
 		return 0;
+
+	if (xfs_sb_version_hasreflink(sbp)) {
+		fprintf(stderr,
+	_("%s: Reflink not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
+	if (xfs_sb_version_hasrmapbt(sbp)) {
+		fprintf(stderr,
+	_("%s: Reverse mapping btree not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
 	if (mp->m_rtdev_targp->dev == 0 && !(flags & LIBXFS_MOUNT_DEBUGGER)) {
 		fprintf(stderr, _("%s: filesystem has a realtime subvolume\n"),
 			progname);
#2 lore raw
Quoted 12 lines · Eric Sandeen
Quoted 9 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Neither the kernel nor the code in xfsprogs support filesystems that have (either reverse mapping btrees or reflink) enabled and a realtime volume configured. The kernel rejects such combinations and mkfs refuses to format such a config, but xfsprogs doesn't check and can do Bad Things, so port those checks before someone shreds their filesystem.

Quoted 6 lines

so now xfs_db won't even touch it, I'm not sure that's desirable.

# db/xfs_db fsfile
xfs_db: Reflink not compatible with realtime device. Please try a newer xfsprogs.
xfs_db: realtime device init failed
xfs_db: device fsfile unusable (not an XFS filesystem?)

Er... did you specially craft fsfile to have rblocks>0 and reflink=1? Or are you saying that it rejects any reflink=1 filesystem now?

--D

Quoted 36 lines

-Eric

Quoted 33 lines

---
v2: move code to rtmount_init where it belongs

---
 libxfs/init.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
libxfs/init.c +15 -0
index cb8967bc77d4..330c645190d9 100644
@@ -428,6 +428,21 @@ rtmount_init(
 	sbp = &mp->m_sb;
 	if (sbp->sb_rblocks == 0)
 		return 0;
+
+	if (xfs_sb_version_hasreflink(sbp)) {
+		fprintf(stderr,
+	_("%s: Reflink not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
+	if (xfs_sb_version_hasrmapbt(sbp)) {
+		fprintf(stderr,
+	_("%s: Reverse mapping btree not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
 	if (mp->m_rtdev_targp->dev == 0 && !(flags & LIBXFS_MOUNT_DEBUGGER)) {
 		fprintf(stderr, _("%s: filesystem has a realtime subvolume\n"),
 			progname);
#3 lore raw
Quoted 15 lines · Darrick J. Wong
Quoted 14 lines · Eric Sandeen
Quoted 9 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Neither the kernel nor the code in xfsprogs support filesystems that have (either reverse mapping btrees or reflink) enabled and a realtime volume configured. The kernel rejects such combinations and mkfs refuses to format such a config, but xfsprogs doesn't check and can do Bad Things, so port those checks before someone shreds their filesystem.

so now xfs_db won't even touch it, I'm not sure that's desirable.

Quoted 7 lines
Quoted 4 lines
# db/xfs_db fsfile
xfs_db: Reflink not compatible with realtime device. Please try a newer xfsprogs.
xfs_db: realtime device init failed
xfs_db: device fsfile unusable (not an XFS filesystem?)

Er... did you specially craft fsfile to have rblocks>0 and reflink=1? Or are you saying that it rejects any reflink=1 filesystem now?

crafted. sorry didn't mean to scare you ;)

-Eric

Reviewed-by on v2 1/1
#4 lore raw
In reply to Darrick J. Wong
Quoted 9 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Neither the kernel nor the code in xfsprogs support filesystems that have (either reverse mapping btrees or reflink) enabled and a realtime volume configured. The kernel rejects such combinations and mkfs refuses to format such a config, but xfsprogs doesn't check and can do Bad Things, so port those checks before someone shreds their filesystem.

Ok, we already reject any other incompatibilities elsewehre, for any user of the libxfs_mount callchain, so this is consistent.

Quoted 33 lines

---
v2: move code to rtmount_init where it belongs

---
 libxfs/init.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
libxfs/init.c +15 -0
index cb8967bc77d4..330c645190d9 100644
@@ -428,6 +428,21 @@ rtmount_init(
 	sbp = &mp->m_sb;
 	if (sbp->sb_rblocks == 0)
 		return 0;
+
+	if (xfs_sb_version_hasreflink(sbp)) {
+		fprintf(stderr,
+	_("%s: Reflink not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
+	if (xfs_sb_version_hasrmapbt(sbp)) {
+		fprintf(stderr,
+	_("%s: Reverse mapping btree not compatible with realtime device. Please try a newer xfsprogs.\n"),
+				progname);
+		return -1;
+	}
+
 	if (mp->m_rtdev_targp->dev == 0 && !(flags & LIBXFS_MOUNT_DEBUGGER)) {
 		fprintf(stderr, _("%s: filesystem has a realtime subvolume\n"),
 			progname);