Skip to contentSkip to conversation

ARM: dts: imx: Board compatibles cleanup

PATCH In review Krzysztof Kozlowski 7 participants 32 messages Sep 30, 2020 – Oct 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: imx: Board compatibles cleanup

Hi,

Changes since v1:
1. Drop applied vendor-prefix patches.
2. Add Reviews from Rob.
3. Use ABB prefix for Aristainetos boards.
4. Add missed compatibles for i.MX51, i.MX53 and i.MX6DL.
5. Fix typo (VF600 -> VF610) in VF boards.
6. New vendor prefixes (patches): #1 and #2.

Best regards,
Krzysztof

Krzysztof Kozlowski (12):
dt-bindings: vendor-prefixes: add MicroSys
dt-bindings: vendor-prefixes: add Revotics
dt-bindings: arm: fsl: document i.MX25 and i.MX27 boards
dt-bindings: arm: fsl: document i.MX51 boards
dt-bindings: arm: fsl: document i.MX53 boards
dt-bindings: arm: fsl: document VF boards
dt-bindings: arm: fsl: document i.MX6DL boards
ARM: dts: imx6dl-pico: fix board compatibles
dt-bindings: vendor-prefixes: add ABB
dt-bindings: arm: fsl: document i.MX6DL Aristainetos boards
ARM: dts: imx6dl: add compatibles for Aristainetos boards
dt-bindings: arm: fsl: document i.MX6Q boards

 .../devicetree/bindings/arm/fsl.yaml          | 223 ++++++++++++++++--
 .../devicetree/bindings/vendor-prefixes.yaml  |   6 +
 arch/arm/boot/dts/imx6dl-aristainetos2_4.dts  |   2 +-
 arch/arm/boot/dts/imx6dl-aristainetos2_7.dts  |   2 +-
 arch/arm/boot/dts/imx6dl-aristainetos_4.dts   |   2 +-
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts   |   2 +-
 arch/arm/boot/dts/imx6dl-pico-dwarf.dts       |   2 +-
 arch/arm/boot/dts/imx6dl-pico-hobbit.dts      |   2 +-
 arch/arm/boot/dts/imx6dl-pico-nymph.dts       |   2 +-
 arch/arm/boot/dts/imx6dl-pico-pi.dts          |   2 +-
 10 files changed, 216 insertions(+), 29 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/12 dt-bindings: vendor-prefixes: add MicroSys

Document vendor prefix for MicroSys Electronics GmbH.

---

Changes since v1:
1. New patch

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 789a01b3d93a..8c8fb8d90c8e 100644
@@ -665,6 +665,8 @@ patternProperties:
     description: Micron Technology Inc.
   "^microsoft,.*":
     description: Microsoft Corporation
+  "^microsys,.*":
+    description: MicroSys Electronics GmbH
   "^mikroe,.*":
     description: MikroElektronika d.o.o.
   "^mikrotik,.*":
Signature · 1 line
2.17.1
#3 lore raw

PATCH v2 2/12 dt-bindings: vendor-prefixes: add Revotics

In reply to Krzysztof Kozlowski

Document vendor prefix for Revotics (Revolution Robotics, Inc.).

---

Changes since v1:
1. New patch

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 8c8fb8d90c8e..3e2b5acf4463 100644
@@ -892,6 +892,8 @@ patternProperties:
     description: iMX6 Rex Project
   "^rervision,.*":
     description: Shenzhen Rervision Technology Co., Ltd.
+  "^revotics,.*":
+    description: Revolution Robotics, Inc. (Revotics)
   "^richtek,.*":
     description: Richtek Technology Corporation
   "^ricoh,.*":
Signature · 1 line
2.17.1
#5 lore raw

PATCH v2 3/12 dt-bindings: arm: fsl: document i.MX25 and i.MX27 boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for i.MX25 and i.MX27 based boards to fix dtbs_check warnings like:

arch/arm/boot/dts/imx27-apf27dev.dt.yaml: /: compatible:
['armadeus,imx27-apf27dev', 'armadeus,imx27-apf27', 'fsl,imx27'] is not valid under any of the given schemas

---

Changes since v1:
1. Add Review

---
 .../devicetree/bindings/arm/fsl.yaml          | 45 ++++++++++++++++++-
 1 file changed, 43 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/fsl.yaml +43 -2
index 1ca9dfa8ce9a..93229f9746c7 100644
@@ -33,16 +33,57 @@ properties:
         items:
           - enum:
               - fsl,imx25-pdk
+              - karo,imx25-tx25
           - const: fsl,imx25
 
-      - description: i.MX27 Product Development Kit
+      - description: i.MX25 Eukrea CPUIMX25 Boards
+        items:
+          - enum:
+              - eukrea,mbimxsd25-baseboard   # Eukrea MBIMXSD25
+          - const: eukrea,cpuimx25
+          - const: fsl,imx25
+
+      - description: i.MX25 Eukrea MBIMXSD25 Boards
+        items:
+          - enum:
+              - eukrea,mbimxsd25-baseboard-cmo-qvga
+              - eukrea,mbimxsd25-baseboard-dvi-svga
+              - eukrea,mbimxsd25-baseboard-dvi-vga
+          - const: eukrea,mbimxsd25-baseboard
+          - const: eukrea,cpuimx25
+          - const: fsl,imx25
+
+      - description: i.MX27 based Boards
         items:
           - enum:
               - armadeus,imx27-apf27      # APF27 SoM
-              - armadeus,imx27-apf27dev   # APF27 SoM on APF27Dev board
               - fsl,imx27-pdk
           - const: fsl,imx27
 
+      - description: i.MX27 APF27 SoM Board
+        items:
+          - const: armadeus,imx27-apf27dev
+          - const: armadeus,imx27-apf27
+          - const: fsl,imx27
+
+      - description: i.MX27 Eukrea CPUIMX27 SoM Board
+        items:
+          - const: eukrea,mbimxsd27-baseboard
+          - const: eukrea,cpuimx27
+          - const: fsl,imx27
+
+      - description: i.MX27 Phytec pca100 Board
+        items:
+          - const: phytec,imx27-pca100-rdk
+          - const: phytec,imx27-pca100
+          - const: fsl,imx27
+
+      - description: i.MX27 Phytec pcm970 Board
+        items:
+          - const: phytec,imx27-pcm970
+          - const: phytec,imx27-pcm038
+          - const: fsl,imx27
+
       - description: i.MX28 based Boards
         items:
           - enum:
Signature · 1 line
2.17.1
#6 lore raw

PATCH v2 4/12 dt-bindings: arm: fsl: document i.MX51 boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for i.MX51 based boards.

---

Changes since v1:
1. Add missed: zii,imx51-scu2-mezz and zii,imx51-rdu1
2. Add Ack

---
 .../devicetree/bindings/arm/fsl.yaml          | 26 ++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/arm/fsl.yaml +23 -3
index 93229f9746c7..d34617ad4af6 100644
@@ -129,13 +129,33 @@ properties:
               - kobo,aura
           - const: fsl,imx50
 
-      - description: i.MX51 Babbage Board
+      - description: i.MX51 based Boards
         items:
           - enum:
-              - armadeus,imx51-apf51    # APF51 SoM
-              - armadeus,imx51-apf51dev # APF51 SoM on APF51Dev board
+              - armadeus,imx51-apf51      # Armadeus Systems APF51 module
               - fsl,imx51-babbage
               - technologic,imx51-ts4800
+              - zii,imx51-scu3-esb
+              - zii,imx51-scu2-mezz
+              - zii,imx51-rdu1
+          - const: fsl,imx51
+
+      - description: i.MX51 based Armadeus Systems APF51Dev Board
+        items:
+          - const: armadeus,imx51-apf51dev
+          - const: armadeus,imx51-apf51
+          - const: fsl,imx51
+
+      - description: i.MX51 based Digi ConnectCore CC(W)-MX51 JSK Board
+        items:
+          - const: digi,connectcore-ccxmx51-jsk
+          - const: digi,connectcore-ccxmx51-som
+          - const: fsl,imx51
+
+      - description: i.MX51 based Eukrea CPUIMX51 Board
+        items:
+          - const: eukrea,mbimxsd51
+          - const: eukrea,cpuimx51
           - const: fsl,imx51
 
       - description: i.MX53 based Boards
Signature · 1 line
2.17.1
#8 lore raw

PATCH v2 6/12 dt-bindings: arm: fsl: document VF boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for VF500 and VF600 based boards. The Toradex Colibri Evaluation Boards use multiple compatibles.

---

Changes since v1:
1. Fix VF610 Toradex compatibles.
2. Add Review (assuming changes are not significant so keep the review).

---
 .../devicetree/bindings/arm/fsl.yaml          | 24 +++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/arm/fsl.yaml +20 -4
index e96af40bf22d..cec7818c51f9 100644
@@ -571,10 +571,26 @@ properties:
               - fsl,vf600
               - fsl,vf610
               - fsl,vf610m4
-              - toradex,vf500-colibri_vf50              # Colibri VF50 Module
-              - toradex,vf500-colibri_vf50-on-eval      # Colibri VF50 Module on Colibri Evaluation Board
-              - toradex,vf610-colibri_vf61              # Colibri VF61 Module
-              - toradex,vf610-colibri_vf61-on-eval      # Colibri VF61 Module on Colibri Evaluation Board
+
+      - description: Toradex Colibri VF50 Module on Colibri Evaluation Board
+        items:
+          - const: toradex,vf500-colibri_vf50-on-eval
+          - const: toradex,vf500-colibri_vf50
+          - const: fsl,vf500
+
+      - description: VF610 based Boards
+        items:
+          - enum:
+              - lwn,bk4                   # Liebherr BK4 controller
+              - phytec,vf610-cosmic       # PHYTEC Cosmic/Cosmic+ Board
+              - fsl,vf610-twr             # VF610 Tower Board
+          - const: fsl,vf610
+
+      - description: Toradex Colibri VF61 Module on Colibri Evaluation Board
+        items:
+          - const: toradex,vf610-colibri_vf61-on-eval
+          - const: toradex,vf610-colibri_vf61
+          - const: fsl,vf610
 
       - description: ZII's VF610 based Boards
         items:
Signature · 1 line
2.17.1
#7 lore raw

PATCH v2 5/12 dt-bindings: arm: fsl: document i.MX53 boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for i.MX53 based boards.

---

Changes since v1:
1. Add missed: fsl,imx53-qsrb, karo,tx53, kiebackpeter,imx53-ddc, kiebackpeter,imx53-hsc, aries,imx53-m53evk and denx,imx53-m53evk
2. Add Review (assuming changes are not significant so keep the review).

---
 .../devicetree/bindings/arm/fsl.yaml          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +19 -0
index d34617ad4af6..e96af40bf22d 100644
@@ -165,8 +165,27 @@ properties:
               - fsl,imx53-ard
               - fsl,imx53-evk
               - fsl,imx53-qsb
+              - fsl,imx53-qsrb                # Freescale i.MX53 Quick Start-R Board
               - fsl,imx53-smd
+              - ge,imx53-cpuvo                # General Electric CS ONE
+              - inversepath,imx53-usbarmory   # Inverse Path USB armory
+              - karo,tx53                     # Ka-Ro electronics TX53 module
+              - kiebackpeter,imx53-ddc        # K+P imx53 DDC
+              - kiebackpeter,imx53-hsc        # K+P imx53 HSC
               - menlo,m53menlo
+              - voipac,imx53-dmm-668          # Voipac i.MX53 X53-DMM-668
+          - const: fsl,imx53
+
+      - description: i.MX53 based Aries/DENX M53EVK Board
+        items:
+          - const: aries,imx53-m53evk
+          - const: denx,imx53-m53evk
+          - const: fsl,imx53
+
+      - description: i.MX53 based TQ MBa53 Board
+        items:
+          - const: tq,mba53
+          - const: tq,tqma53
           - const: fsl,imx53
 
       - description: i.MX6Q based Boards
Signature · 1 line
2.17.1
#9 lore raw

PATCH v2 7/12 dt-bindings: arm: fsl: document i.MX6DL boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for i.MX6DL based boards.

---

Changes since v1:
1. Add missed: solidrun,cubox-i/dl, solidrun,hummingboard2/dl.
2. Fix Toradex (multiple compatibles).
3. Add Review (assuming changes are not significant so keep the review).

---
 .../devicetree/bindings/arm/fsl.yaml          | 49 ++++++++++++++++---
 1 file changed, 43 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/arm/fsl.yaml +43 -6
index cec7818c51f9..c90050ca3384 100644
@@ -269,32 +269,53 @@ properties:
       - description: i.MX6DL based Boards
         items:
           - enum:
-              - armadeus,imx6dl-apf6      # APF6 (Solo) SoM
-              - armadeus,imx6dl-apf6dev   # APF6 (Solo) SoM on APF6Dev board
+              - boundary,imx6dl-nit6xlite     # Boundary Devices Nitrogen6 Lite
+              - boundary,imx6dl-nitrogen6x    # Boundary Devices Nitrogen6x
+              - bticino,imx6dl-mamoj      # BTicino i.MX6DL Mamoj
               - eckelmann,imx6dl-ci4x10
               - emtrion,emcon-mx6         # emCON-MX6S or emCON-MX6DL SoM
               - emtrion,emcon-mx6-avari   # emCON-MX6S or emCON-MX6DL SoM on Avari Base
+              - engicam,imx6-icore        # Engicam i.CoreM6 Starter Kit
+              - engicam,imx6-icore-rqs    # Engicam i.CoreM6 RQS Starter Kit
               - fsl,imx6dl-sabreauto      # i.MX6 DualLite/Solo SABRE Automotive Board
+              - fsl,imx6dl-sabrelite      # i.MX6 DualLite SABRE Lite Board
               - fsl,imx6dl-sabresd        # i.MX6 DualLite SABRE Smart Device Board
+              - karo,imx6dl-tx6dl         # Ka-Ro electronics TX6U Modules
               - kontron,imx6dl-samx6i     # Kontron i.MX6 Solo SMARC Module
+              - poslab,imx6dl-savageboard # Poslab SavageBoard Dual
               - prt,prtrvt                # Protonic RVT board
               - prt,prtvt7                # Protonic VT7 board
+              - rex,imx6dl-rex-basic      # Rex Basic i.MX6 Dual Lite Board
+              - riot,imx6s-riotboard      # RIoTboard i.MX6S
+              - solidrun,cubox-i/dl            # SolidRun Cubox-i Solo/DualLite
+              - solidrun,hummingboard/dl
+              - solidrun,hummingboard2/dl      # SolidRun HummingBoard2 Solo/DualLite
               - technexion,imx6dl-pico-dwarf   # TechNexion i.MX6DL Pico-Dwarf
               - technexion,imx6dl-pico-hobbit  # TechNexion i.MX6DL Pico-Hobbit
               - technexion,imx6dl-pico-nymph   # TechNexion i.MX6DL Pico-Nymph
               - technexion,imx6dl-pico-pi      # TechNexion i.MX6DL Pico-Pi
               - technologic,imx6dl-ts4900
               - technologic,imx6dl-ts7970
-              - toradex,colibri_imx6dl          # Colibri iMX6 Module
-              - toradex,colibri_imx6dl-v1_1     # Colibri iMX6 Module V1.1
-              - toradex,colibri_imx6dl-eval-v3  # Colibri iMX6 Module on Colibri Evaluation Board V3
-              - toradex,colibri_imx6dl-v1_1-eval-v3 # Colibri iMX6 Module V1.1 on Colibri Evaluation Board V3
+              - udoo,imx6dl-udoo          # Udoo i.MX6 Dual-lite Board
+              - wand,imx6dl-wandboard     # Wandboard i.MX6 Dual Lite Board
               - ysoft,imx6dl-yapp4-draco  # i.MX6 DualLite Y Soft IOTA Draco board
               - ysoft,imx6dl-yapp4-hydra  # i.MX6 DualLite Y Soft IOTA Hydra board
               - ysoft,imx6dl-yapp4-orion  # i.MX6 DualLite Y Soft IOTA Orion board
               - ysoft,imx6dl-yapp4-ursa   # i.MX6 Solo Y Soft IOTA Ursa board
           - const: fsl,imx6dl
 
+      - description: i.MX6DL based Armadeus AFP6 Board
+        items:
+          - const: armadeus,imx6dl-apf6dev
+          - const: armadeus,imx6dl-apf6         # APF6 (Solo) SoM
+          - const: fsl,imx6dl
+
+      - description: i.MX6DL based DFI FS700-M60-6DL Board
+        items:
+          - const: dfi,fs700-m60-6dl
+          - const: dfi,fs700e-m60
+          - const: fsl,imx6dl
+
       - description: i.MX6DL Gateworks Ventana Boards
         items:
           - enum:
@@ -330,6 +351,22 @@ properties:
           - const: phytec,imx6dl-pfla02   # PHYTEC phyFLEX-i.MX6 Quad
           - const: fsl,imx6dl
 
+      - description: i.MX6DL Toradex Colibri iMX6 Module on Colibri
+                     Evaluation Board V3
+        items:
+          - const: toradex,colibri_imx6dl-eval-v3
+          - const: toradex,colibri_imx6dl          # Colibri iMX6 Module
+          - const: fsl,imx6dl
+
+      - description: i.MX6DL Toradex Colibri iMX6 Module V1.1 on Colibri
+                     Evaluation Board V3
+        items:
+          - const: toradex,colibri_imx6dl-v1_1-eval-v3
+          - const: toradex,colibri_imx6dl-v1_1     # Colibri iMX6 Module V1.1
+          - const: toradex,colibri_imx6dl-eval-v3
+          - const: toradex,colibri_imx6dl          # Colibri iMX6 Module
+          - const: fsl,imx6dl
+
       - description: i.MX6SL based Boards
         items:
           - enum:
Signature · 1 line
2.17.1
#10 lore raw

PATCH v2 8/12 ARM: dts: imx6dl-pico: fix board compatibles

In reply to Krzysztof Kozlowski

There are four flavors of TechNexion PICO-IMX6 boards. They have their own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. They also have their own bindings so adjust the compatibles to match the bindings.

---

Changes since v1:
1. None

---
 arch/arm/boot/dts/imx6dl-pico-dwarf.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +-
 arch/arm/boot/dts/imx6dl-pico-nymph.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-pico-pi.dts     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +1 -1
index 659a8e8714ea..d85b15a8c127 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +1 -1
index d7403c5c4337..08fedcbcc91b 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-nymph.dts +1 -1
index b282dbf953aa..32ccfc5d41ce 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-pi.dts +1 -1
index b7b1c07f96f3..4590e8ad9a91 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and PI baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-pi", "fsl,imx6dl";
 };
Signature · 1 line
2.17.1
#24 lore raw

PATCH v2 10/12 dt-bindings: arm: fsl: document i.MX6DL Aristainetos boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for i.MX6DL based Aristainetos boards from ABB.

---

Changes since v1:
1. Use ABB vendor prefix

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +4 -0
index c90050ca3384..fc3a837d7dba 100644
@@ -269,6 +269,10 @@ properties:
       - description: i.MX6DL based Boards
         items:
           - enum:
+              - abb,aristainetos-imx6dl-4     # aristainetos i.MX6 Dual Lite Board 4
+              - abb,aristainetos-imx6dl-7     # aristainetos i.MX6 Dual Lite Board 7
+              - abb,aristainetos2-imx6dl-4    # aristainetos2 i.MX6 Dual Lite Board 4
+              - abb,aristainetos2-imx6dl-7    # aristainetos2 i.MX6 Dual Lite Board 7
               - boundary,imx6dl-nit6xlite     # Boundary Devices Nitrogen6 Lite
               - boundary,imx6dl-nitrogen6x    # Boundary Devices Nitrogen6x
               - bticino,imx6dl-mamoj      # BTicino i.MX6DL Mamoj
Signature · 1 line
2.17.1
#27 lore raw

PATCH v2 11/12 ARM: dts: imx6dl: add compatibles for Aristainetos boards

In reply to Krzysztof Kozlowski

The Aristainetos and Aristainetos2 boards have only SoC compatible.

---

Changes since v1:
1. Use ABB vendor prefix

---
 arch/arm/boot/dts/imx6dl-aristainetos2_4.dts | 2 +-
 arch/arm/boot/dts/imx6dl-aristainetos2_7.dts | 2 +-
 arch/arm/boot/dts/imx6dl-aristainetos_4.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6dl-aristainetos2_4.dts +1 -1
index b16603f27dce..dfa6f64d43cc 100644
@@ -46,7 +46,7 @@
 
 / {
 	model = "aristainetos2 i.MX6 Dual Lite Board 4";
-	compatible = "fsl,imx6dl";
+	compatible = "abb,aristainetos2-imx6dl-4", "fsl,imx6dl";
 
 	memory@10000000 {
 		device_type = "memory";
arch/arm/boot/dts/imx6dl-aristainetos2_7.dts +1 -1
index abb2a1b9ce08..5e15212eaf3a 100644
@@ -46,7 +46,7 @@
 
 / {
 	model = "aristainetos2 i.MX6 Dual Lite Board 7";
-	compatible = "fsl,imx6dl";
+	compatible = "abb,aristainetos2-imx6dl-7", "fsl,imx6dl";
 
 	memory@10000000 {
 		device_type = "memory";
arch/arm/boot/dts/imx6dl-aristainetos_4.dts +1 -1
index 5c7e85300695..cc861a43eb58 100644
@@ -10,7 +10,7 @@
 
 / {
 	model = "aristainetos i.MX6 Dual Lite Board 4";
-	compatible = "fsl,imx6dl";
+	compatible = "abb,aristainetos-imx6dl-4", "fsl,imx6dl";
 
 	backlight {
 		compatible = "pwm-backlight";
arch/arm/boot/dts/imx6dl-aristainetos_7.dts +1 -1
index 4d58cb4436d9..b6cb78870cd5 100644
@@ -10,7 +10,7 @@
 
 / {
 	model = "aristainetos i.MX6 Dual Lite Board 7";
-	compatible = "fsl,imx6dl";
+	compatible = "abb,aristainetos-imx6dl-7", "fsl,imx6dl";
 
 	memory@10000000 {
 		device_type = "memory";
Signature · 1 line
2.17.1
#21 lore raw

PATCH v2 9/12 dt-bindings: vendor-prefixes: add ABB

In reply to Krzysztof Kozlowski

Document binding for ABB.

---

Changes since v1:
1. Use ABB vendor prefix

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 3e2b5acf4463..7c77d9e6b339 100644
@@ -25,6 +25,8 @@ patternProperties:
   # Keep list in alphabetical order.
   "^70mai,.*":
     description: 70mai Co., Ltd.
+  "^abb,.*":
+    description: ABB
   "^abilis,.*":
     description: Abilis Systems
   "^abracon,.*":
Signature · 1 line
2.17.1
#29 lore raw

PATCH v2 12/12 dt-bindings: arm: fsl: document i.MX6Q boards

In reply to Krzysztof Kozlowski

Document and adjust the compatibles for i.MX6Q based boards. The Toradex Boards use multiple compatibles.

---
 .../devicetree/bindings/arm/fsl.yaml          | 56 +++++++++++++++++--
 1 file changed, 50 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/arm/fsl.yaml +50 -6
index fc3a837d7dba..0e4da88b81af 100644
@@ -191,29 +191,58 @@ properties:
       - description: i.MX6Q based Boards
         items:
           - enum:
-              - armadeus,imx6q-apf6       # APF6 (Quad/Dual) SoM
-              - armadeus,imx6q-apf6dev    # APF6 (Quad/Dual) SoM on APF6Dev board
+              - auvidea,h100              # Auvidea H100
+              - dmo,imx6q-edmqmx6         # Data Modul eDM-QMX6 Board
+              - embest,imx6q-marsboard    # Embest MarS Board i.MX6Dual
               - emtrion,emcon-mx6         # emCON-MX6D or emCON-MX6Q SoM
               - emtrion,emcon-mx6-avari   # emCON-MX6D or emCON-MX6Q SoM on Avari Base
+              - engicam,imx6-icore        # Engicam i.CoreM6 Starter Kit
+              - engicam,imx6-icore-rqs    # Engicam i.CoreM6 RQS Starter Kit
               - fsl,imx6q-arm2
               - fsl,imx6q-sabreauto
               - fsl,imx6q-sabrelite
               - fsl,imx6q-sabresd
+              - karo,imx6q-tx6q           # Ka-Ro electronics TX6Q Modules
+              - kiebackpeter,imx6q-tpc    # K+P i.MX6 Quad TPC Board
               - kontron,imx6q-samx6i      # Kontron i.MX6 Dual/Quad SMARC Module
               - logicpd,imx6q-logicpd
               - prt,prti6q                # Protonic PRTI6Q board
               - prt,prtwd2                # Protonic WD2 board
+              - solidrun,cubox-i/q        # SolidRun Cubox-i Dual/Quad
+              - solidrun,hummingboard/q
+              - solidrun,hummingboard2/q
               - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
               - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
               - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
               - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi
               - technologic,imx6q-ts4900
               - technologic,imx6q-ts7970
-              - toradex,apalis_imx6q            # Apalis iMX6 Module
-              - toradex,apalis_imx6q-eval       # Apalis iMX6 Module on Apalis Evaluation Board
-              - toradex,apalis_imx6q-ixora      # Apalis iMX6 Module on Ixora
-              - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1
+              - toradex,apalis_imx6q      # Apalis iMX6 Module
+              - uniwest,imx6q-evi         # Uniwest Evi
               - variscite,dt6customboard
+              - zealz,imx6q-gk802         # Zealz GK802
+          - const: fsl,imx6q
+
+      - description: i.MX6Q Advantech DMS-BA16 Boards
+        items:
+          - enum:
+              - advantech,imx6q-dms-ba16  # Advantech DMS-BA16
+              - ge,imx6q-b450v3           # General Electric B450v3
+              - ge,imx6q-b650v3           # General Electric B650v3
+              - ge,imx6q-b850v3           # General Electric B850v3
+          - const: advantech,imx6q-ba16
+          - const: fsl,imx6q
+
+      - description: i.MX6Q Armadeus APF6 Boards
+        items:
+          - const: armadeus,imx6q-apf6dev
+          - const: armadeus,imx6q-apf6
+          - const: fsl,imx6q
+
+      - description: i.MX6Q DFI FS700-M60-6QD Board
+        items:
+          - const: dfi,fs700-m60-6qd
+          - const: dfi,fs700e-m60
           - const: fsl,imx6q
 
       - description: i.MX6Q Gateworks Ventana Boards
@@ -252,6 +281,21 @@ properties:
           - const: phytec,imx6q-pfla02    # PHYTEC phyFLEX-i.MX6 Quad
           - const: fsl,imx6q
 
+      - description: i.MX6Q Toradex Apalis iMX6Q/D Module Boards
+        items:
+          - enum:
+              - toradex,apalis_imx6q-ixora  # Apalis iMX6Q/D Module on Ixora Carrier Board
+              - toradex,apalis_imx6q-eval   # Apalis iMX6Q/D Module on Apalis Evaluation Board
+          - const: toradex,apalis_imx6q
+          - const: fsl,imx6q
+
+      - description: i.MX6Q Toradex Apalis iMX6Q/D Module on Ixora Carrier Board V1.1
+        items:
+          - const: toradex,apalis_imx6q-ixora-v1.1
+          - const: toradex,apalis_imx6q-ixora
+          - const: toradex,apalis_imx6q
+          - const: fsl,imx6q
+
       - description: i.MX6QP based Boards
         items:
           - enum:
Signature · 1 line
2.17.1
#30 lore raw

Re: [PATCH v2 12/12] dt-bindings: arm: fsl: document i.MX6Q boards

Quoted 7 lines · Krzysztof Kozlowski

Document and adjust the compatibles for i.MX6Q based boards. The Toradex Boards use multiple compatibles.

---
 .../devicetree/bindings/arm/fsl.yaml          | 56 +++++++++++++++++--
 1 file changed, 50 insertions(+), 6 deletions(-)

Please skip this one, I sent it too fast. I did not finish yet all other i.MX 6 and need to squash here some work-in-progress.

Best regards,
Krzysztof

Reviewed-by on v2 9/12
#22 lore raw

Re: [PATCH v2 09/12] dt-bindings: vendor-prefixes: add ABB

In reply to Krzysztof Kozlowski

Hello Krzysztof,

Am 30.09.2020 um 21:01 schrieb Krzysztof Kozlowski:

Quoted 5 lines

Document binding for ABB.

Quoted 7 lines

---

Changes since v1:
1. Use ABB vendor prefix

---
  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
  1 file changed, 2 insertions(+)

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
Reviewed-by on v2 10/12
#25 lore raw

Re: [PATCH v2 10/12] dt-bindings: arm: fsl: document i.MX6DL Aristainetos boards

In reply to Krzysztof Kozlowski

Hello Krzysztof,

Am 30.09.2020 um 21:01 schrieb Krzysztof Kozlowski:

Quoted 6 lines

Document and adjust the compatibles for i.MX6DL based Aristainetos boards from ABB.

Quoted 7 lines

---

Changes since v1:
1. Use ABB vendor prefix

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++++
  1 file changed, 4 insertions(+)

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
Reviewed-by on v2 11/12
#28 lore raw

Re: [PATCH v2 11/12] ARM: dts: imx6dl: add compatibles for Aristainetos boards

In reply to Krzysztof Kozlowski

Hello Krzysztof,

Am 30.09.2020 um 21:01 schrieb Krzysztof Kozlowski:

Quoted 7 lines

The Aristainetos and Aristainetos2 boards have only SoC compatible.

---

Quoted 8 lines

Changes since v1:
1. Use ABB vendor prefix

---
  arch/arm/boot/dts/imx6dl-aristainetos2_4.dts | 2 +-
  arch/arm/boot/dts/imx6dl-aristainetos2_7.dts | 2 +-
  arch/arm/boot/dts/imx6dl-aristainetos_4.dts  | 2 +-
  arch/arm/boot/dts/imx6dl-aristainetos_7.dts  | 2 +-
  4 files changed, 4 insertions(+), 4 deletions(-)

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#11 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

In reply to Krzysztof Kozlowski

Hello Krzysztof,

Quoted 23 lines · Krzysztof Kozlowski

There are four flavors of TechNexion PICO-IMX6 boards. They have their own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. They also have their own bindings so adjust the compatibles to match the bindings.

---

Changes since v1:
1. None

---
 arch/arm/boot/dts/imx6dl-pico-dwarf.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +-
 arch/arm/boot/dts/imx6dl-pico-nymph.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-pico-pi.dts     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +0 -0
index 659a8e8714ea..d85b15a8c127 100644

arch/arm/boot/dts/imx6dl-pico-dwarf.dts line 16

Quoted 5 lines
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +1 -1
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";

Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", "fsl,imx6dl") and likewise for the other files?
That way other firmware that reuses the Linux device tree files and match against the SoM compatible continues to work after update.

Quoted 35 lines
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +0 -0
 };
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +1 -1
index d7403c5c4337..08fedcbcc91b 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-nymph.dts +1 -1
index b282dbf953aa..32ccfc5d41ce 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-pi.dts +1 -1
index b7b1c07f96f3..4590e8ad9a91 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and PI baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-pi", "fsl,imx6dl";
 };
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#12 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Quoted 55 lines · Ahmad Fatoum

Hello Krzysztof,

Quoted 23 lines · Krzysztof Kozlowski

There are four flavors of TechNexion PICO-IMX6 boards. They have their own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. They also have their own bindings so adjust the compatibles to match the bindings.

---

Changes since v1:
1. None

---
 arch/arm/boot/dts/imx6dl-pico-dwarf.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +-
 arch/arm/boot/dts/imx6dl-pico-nymph.dts  | 2 +-
 arch/arm/boot/dts/imx6dl-pico-pi.dts     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +0 -0
index 659a8e8714ea..d85b15a8c127 100644

arch/arm/boot/dts/imx6dl-pico-dwarf.dts line 16

Quoted 5 lines
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +1 -1
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";

Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", "fsl,imx6dl") and likewise for the other files?
That way other firmware that reuses the Linux device tree files and match against the SoM compatible continues to work after update.

Quoted 18 lines
arch/arm/boot/dts/imx6dl-pico-dwarf.dts +0 -0
 };
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +1 -1
index d7403c5c4337..08fedcbcc91b 100644
@@ -13,5 +13,5 @@
 
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-nymph.dts +0 -0
index b282dbf953aa..32ccfc5d41ce 100644
@@ -13,5 +13,5 @@
 
Quoted 9 lines

arch/arm/boot/dts/imx6dl-pico-pi.dts

Quoted 9 lines
arch/arm/boot/dts/imx6dl-pico-nymph.dts +1 -1
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
 };
arch/arm/boot/dts/imx6dl-pico-pi.dts +0 -0
index b7b1c07f96f3..4590e8ad9a91 100644

The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add TechNexion boards"), describe that these are the only valid compatibles. "technexion,imx6dl-pico" is not valid and would require changing the bindings, thus breaking compatibility which you want to avoid.

The bindings, not what is present in DTS, is considered ABI.

Best regards,
Krzysztof

#13 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Hi,

Quoted 7 lines · Krzysztof Kozlowski
Quoted 6 lines · Ahmad Fatoum
Quoted 6 lines
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +0 -0
index d7403c5c4337..08fedcbcc91b 100644
@@ -13,5 +13,5 @@
 
Quoted 11 lines
Quoted 5 lines

arch/arm/boot/dts/imx6dl-pico-hobbit.dts line 17

Quoted 5 lines
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +1 -1
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
 };

The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add TechNexion boards"), describe that these are the only valid compatibles. "technexion,imx6dl-pico" is not valid and would require changing the bindings, thus breaking compatibility which you want to avoid.> The bindings, not what is present in DTS, is considered ABI.

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

Cheers,
Ahmad

-------------------------8<---------------------------

From d2e44951f900a1774ef289db22812969e72925d6 Mon Sep 17 00:00:00 2001
From: Ahmad Fatoum <[email protected]>
Date: Thu, 1 Oct 2020 12:03:36 +0200
Subject: [RFC PATCH] dt-bindings: arm: fsl: add technexion,imx6dl-pico compatible

The technexion,imx6dl-pico -dwarf, -hobbit, -nymph and -pi all use the same SoM. Reflect this compatibility with the SoM in the binding.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +10 -0
index 6da9d734cdb7..b7110305ce81 100644
@@ -211,6 +211,16 @@ properties:
           - const: gw,ventana
           - const: fsl,imx6dl
 
+      - description: i.MX6DL TechNexion Pico Boards
+        items:
+          - enum:
+              - technexion,imx6dl-pico-dwarf   # TechNexion i.MX6DL Pico-Dwarf
+              - technexion,imx6dl-pico-hobbit  # TechNexion i.MX6DL Pico-Hobbit
+              - technexion,imx6dl-pico-nymph   # TechNexion i.MX6DL Pico-Nymph
+              - technexion,imx6dl-pico-pi      # TechNexion i.MX6DL Pico-Pi
+          - const: technexion,imx6dl-pico
+          - const: fsl,imx6dl
+
       - description: i.MX6SL based Boards
         items:
           - enum:
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#14 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Quoted 22 lines · Ahmad Fatoum

Hi,

Quoted 7 lines · Krzysztof Kozlowski
Quoted 6 lines · Ahmad Fatoum
Quoted 6 lines
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +0 -0
index d7403c5c4337..08fedcbcc91b 100644
@@ -13,5 +13,5 @@
 
Quoted 11 lines
Quoted 5 lines

arch/arm/boot/dts/imx6dl-pico-hobbit.dts line 17

Quoted 5 lines
arch/arm/boot/dts/imx6dl-pico-hobbit.dts +1 -1
 / {
 	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
-	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
+	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
 };

The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add TechNexion boards"), describe that these are the only valid compatibles. "technexion,imx6dl-pico" is not valid and would require changing the bindings, thus breaking compatibility which you want to avoid.> The bindings, not what is present in DTS, is considered ABI.

Quoted 2 lines

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:

+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi
Quoted 3 lines

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all?

I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken.

Best regards,
Krzysztof

#15 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Hello,

Review

Quoted 9 lines · Krzysztof Kozlowski
Quoted 2 lines

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:

(quoted diff) +4 -0
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi

Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users.

Quoted 5 lines
Quoted 2 lines

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all?

If we leave the old two-compatible enumeration intact, there is no ABI broken.

Quoted 3 lines

I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken.

IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use.

Cheers
Ahmad

Quoted 4 lines

Best regards,
Krzysztof

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#16 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Quoted 13 lines · Ahmad Fatoum

Hello,

Review

Quoted 9 lines · Krzysztof Kozlowski
Quoted 2 lines

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:

(quoted diff) +4 -0
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi
Quoted 2 lines

Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users.

OK, let's assume the binding is not correct and DTSes are good.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all?

If we leave the old two-compatible enumeration intact, there is no ABI broken.

Just to clarify, because I don't get here the "no ABI broken" part:
ABI is the binding, not the DTS. We can change intree DTS as we like, replace compatibles, add nodes, remove nodes. There is no stability requirement for DTS contents.

If we leave two-compatible binding intact, it is a broken binding since beginning. Removing non-working, fake ABI is not breaking it because it could never work.

Quoted 8 lines
Quoted 4 lines

I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken.

IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use.

OK, we can go with DTS approach. I fixed few of such cases as well, assuming that DTS was intended and binding was incorrect. In such case all boards will be documented under one compatible technexion,imx6q-pico and DTS will not be changed.

Best regards,
Krzysztof

#17 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Hello,

Quoted 28 lines · Krzysztof Kozlowski
Quoted 13 lines · Ahmad Fatoum

Hello,

Review

Quoted 9 lines · Krzysztof Kozlowski
Quoted 2 lines

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:

(quoted diff) +4 -0
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi
Quoted 2 lines

Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users.

OK, let's assume the binding is not correct and DTSes are good.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all?

If we leave the old two-compatible enumeration intact, there is no ABI broken.

Quoted 7 lines

Just to clarify, because I don't get here the "no ABI broken" part:
ABI is the binding, not the DTS. We can change intree DTS as we like, replace compatibles, add nodes, remove nodes. There is no stability requirement for DTS contents.
If we leave two-compatible binding intact, it is a broken binding since beginning. Removing non-working, fake ABI is not breaking it because it could never work.

Then I misunderstood you. I was thinking about possible out-of-tree users that have boards based on this and are adhering to the binding. Dropping the binding would break those (albeit it's a quite manageable form of brokenness here).

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken.

Quoted 8 lines
Quoted 3 lines

IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use.

OK, we can go with DTS approach. I fixed few of such cases as well, assuming that DTS was intended and binding was incorrect. In such case all boards will be documented under one compatible technexion,imx6q-pico and DTS will not be changed.

Sounds good. If further differentiation proves to be needed, it can be a new compatible added in a separate commit.

Thanks
Ahmad

Quoted 4 lines

Best regards,
Krzysztof

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#18 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

In reply to Krzysztof Kozlowski

Hi,

sorry for jumping in.

Quoted 28 lines · Krzysztof Kozlowski
Quoted 13 lines · Ahmad Fatoum

Hello,

Review

Quoted 9 lines · Krzysztof Kozlowski
Quoted 2 lines

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:

(quoted diff) +4 -0
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi
Quoted 2 lines

Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users.

OK, let's assume the binding is not correct and DTSes are good.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all?

If we leave the old two-compatible enumeration intact, there is no ABI broken.

Quoted 8 lines

Just to clarify, because I don't get here the "no ABI broken" part:
ABI is the binding, not the DTS. We can change intree DTS as we like, replace compatibles, add nodes, remove nodes. There is no stability requirement for DTS contents.

If we leave two-compatible binding intact, it is a broken binding since beginning. Removing non-working, fake ABI is not breaking it because it could never work.

The problem here is that it wasn't covered by the review and now we have the mess. I see the DTB and the Bootloader as Firmware. Now imagine if the bootloader for these boards had some dt-fixup logic which won't apply anymore or if the bootloader board init won't get called anymore since the bootloader folks used the compatible found in the DTS. This can cause a regression if the old Bootloader tries to boot the new Kernel+DTS.

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken.

IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use.

Question is what was the author's intention? @Fabio do you have any comments here?

Quoted 4 lines

OK, we can go with DTS approach. I fixed few of such cases as well, assuming that DTS was intended and binding was incorrect. In such case all boards will be documented under one compatible technexion,imx6q-pico and DTS will not be changed.

Or keep the exisiting bindings and adding the new one. Therefore the yaml needs to handle two cases for each imx6[qdl]:
compatible = "technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", "fsl,imx6dl";
and
compatible = "technexion,imx6dl-pico", "fsl,imx6dl";

Regards,
Marco

#19 lore raw

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Quoted 42 lines · Marco Felsch

Hi,

sorry for jumping in.

Quoted 28 lines · Krzysztof Kozlowski
Quoted 13 lines · Ahmad Fatoum

Hello,

Review

Quoted 9 lines · Krzysztof Kozlowski
Quoted 2 lines

The existing binding doesn't cover these boards then and needs to be extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:

(quoted diff) +4 -0
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi
Quoted 2 lines

Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users.

OK, let's assume the binding is not correct and DTSes are good.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

[I guess we need to keep the two-compatible list they were originally
in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all?

If we leave the old two-compatible enumeration intact, there is no ABI broken.

Quoted 8 lines

Just to clarify, because I don't get here the "no ABI broken" part:
ABI is the binding, not the DTS. We can change intree DTS as we like, replace compatibles, add nodes, remove nodes. There is no stability requirement for DTS contents.

If we leave two-compatible binding intact, it is a broken binding since beginning. Removing non-working, fake ABI is not breaking it because it could never work.

Quoted 7 lines

The problem here is that it wasn't covered by the review and now we have the mess. I see the DTB and the Bootloader as Firmware. Now imagine if the bootloader for these boards had some dt-fixup logic which won't apply anymore or if the bootloader board init won't get called anymore since the bootloader folks used the compatible found in the DTS. This can cause a regression if the old Bootloader tries to boot the new Kernel+DTS.

Good points. It's nice to have a binding documented but it is more likely that bootloader guys were depending on actual contents of DTS.

Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken.

IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use.

Question is what was the author's intention? @Fabio do you have any comments here?

Quoted 4 lines

OK, we can go with DTS approach. I fixed few of such cases as well, assuming that DTS was intended and binding was incorrect. In such case all boards will be documented under one compatible technexion,imx6q-pico and DTS will not be changed.

Quoted 5 lines

Or keep the exisiting bindings and adding the new one. Therefore the yaml needs to handle two cases for each imx6[qdl]:
compatible = "technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", "fsl,imx6dl";
and
compatible = "technexion,imx6dl-pico", "fsl,imx6dl";

This is the combination I wanted to avoid because it kind of proofs that both (binding and DTS) were incorrect or insufficient. If both are incorrect, then there might be no point to keep it stable.

Few other i.MX boards use one compatible for multiple DTS. Usually it is a module's compatible and boards just do not add their own.

Best regards,
Krzysztof

maintainer Acked-by on v2 1/12
#2 lore raw

Re: [PATCH v2 01/12] dt-bindings: vendor-prefixes: add MicroSys

In reply to Krzysztof Kozlowski
Quoted 4 lines · Krzysztof Kozlowski

Document vendor prefix for MicroSys Electronics GmbH.

Quoted 8 lines

---

Changes since v1:
1. New patch

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
maintainer Acked-by on v2 2/12
#4 lore raw

Re: [PATCH v2 02/12] dt-bindings: vendor-prefixes: add Revotics

In reply to Krzysztof Kozlowski
Quoted 4 lines · Krzysztof Kozlowski

Document vendor prefix for Revotics (Revolution Robotics, Inc.).

Quoted 8 lines

---

Changes since v1:
1. New patch

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
maintainer Acked-by on v2 9/12
#23 lore raw

Re: [PATCH v2 09/12] dt-bindings: vendor-prefixes: add ABB

In reply to Krzysztof Kozlowski
Quoted 5 lines · Krzysztof Kozlowski

Document binding for ABB.

Quoted 8 lines

---

Changes since v1:
1. Use ABB vendor prefix

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
maintainer Acked-by on v2 10/12
#26 lore raw

Re: [PATCH v2 10/12] dt-bindings: arm: fsl: document i.MX6DL Aristainetos boards

In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Document and adjust the compatibles for i.MX6DL based Aristainetos boards from ABB.

Quoted 8 lines

---

Changes since v1:
1. Use ABB vendor prefix

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++++
 1 file changed, 4 insertions(+)
#31 lore raw
In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski

Hi,

Changes since v1:
1. Drop applied vendor-prefix patches.
2. Add Reviews from Rob.
3. Use ABB prefix for Aristainetos boards.
4. Add missed compatibles for i.MX51, i.MX53 and i.MX6DL.
5. Fix typo (VF600 -> VF610) in VF boards.
6. New vendor prefixes (patches): #1 and #2.

Quoted 8 lines

Best regards,
Krzysztof

Krzysztof Kozlowski (12):
dt-bindings: vendor-prefixes: add MicroSys
dt-bindings: vendor-prefixes: add Revotics
dt-bindings: arm: fsl: document i.MX25 and i.MX27 boards

This one was applied from v1.

Quoted 8 lines

dt-bindings: arm: fsl: document i.MX51 boards
dt-bindings: arm: fsl: document i.MX53 boards
dt-bindings: arm: fsl: document VF boards
dt-bindings: arm: fsl: document i.MX6DL boards
ARM: dts: imx6dl-pico: fix board compatibles
dt-bindings: vendor-prefixes: add ABB
dt-bindings: arm: fsl: document i.MX6DL Aristainetos boards
ARM: dts: imx6dl: add compatibles for Aristainetos boards

Applied all above.

Shawn

Quoted 17 lines

dt-bindings: arm: fsl: document i.MX6Q boards

 .../devicetree/bindings/arm/fsl.yaml          | 223 ++++++++++++++++--
 .../devicetree/bindings/vendor-prefixes.yaml  |   6 +
 arch/arm/boot/dts/imx6dl-aristainetos2_4.dts  |   2 +-
 arch/arm/boot/dts/imx6dl-aristainetos2_7.dts  |   2 +-
 arch/arm/boot/dts/imx6dl-aristainetos_4.dts   |   2 +-
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts   |   2 +-
 arch/arm/boot/dts/imx6dl-pico-dwarf.dts       |   2 +-
 arch/arm/boot/dts/imx6dl-pico-hobbit.dts      |   2 +-
 arch/arm/boot/dts/imx6dl-pico-nymph.dts       |   2 +-
 arch/arm/boot/dts/imx6dl-pico-pi.dts          |   2 +-
 10 files changed, 216 insertions(+), 29 deletions(-)
Signature · 1 line
2.17.1