Skip to contentSkip to conversation

oeqa/selftest/cases/devtool.py: avoid .pyc race

PATCH Superseded Tim Orling 1 participant 1 message Sep 30, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

PATCH 1/1 oeqa/selftest/cases/devtool.py: avoid .pyc race

From: Tim Orling <[email protected]>

In certain conditions, most likely under heavy load on the AutoBuilder, the prebuilt .pyc files are attempting to be executed before they have been completely copied. Avoid this by not copying the .pyc files (nor the __pycache__ directory). The impact of python3-native recreating the .pyc files should hopefully be negligible.

YOCTO#13421
YOCTO#13803

---

This has already been merged to 3.2 tree and as a bug fix qualifies for backport to dunfell/3.1

 meta/lib/oeqa/selftest/cases/devtool.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/lib/oeqa/selftest/cases/devtool.py +2 -1
index 5003f08c75f..d8bf4aea081 100644
@@ -56,7 +56,8 @@ def setUpModule():
                     if pth.startswith(canonical_layerpath):
                         if relpth.endswith('/'):
                             destdir = os.path.join(corecopydir, relpth)
-                            shutil.copytree(pth, destdir)
+                            # avoid race condition by not copying .pyc files YPBZ#13421,13803
+                            shutil.copytree(pth, destdir, ignore=ignore_patterns('*.pyc', '__pycache__'))
                         else:
                             destdir = os.path.join(corecopydir, os.path.dirname(relpth))
                             bb.utils.mkdirhier(destdir)
Signature · 1 line
2.25.0