Skip to contentSkip to conversation

x86/kvm: hide KVM options from menuconfig when KVM is not compiled

PATCH Applied Matteo Croce 3 participants 4 messages Oct 1, 2020 – Oct 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/kvm: hide KVM options from menuconfig when KVM is not compiled

From: Matteo Croce <[email protected]>

Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.

---
 arch/x86/kvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kvm/Kconfig +1 -0
index fbd5bd7a945a..f92dfd8ef10d 100644
@@ -66,6 +66,7 @@ config KVM_WERROR
 	default y if X86_64 && !KASAN
 	# We use the dependency on !COMPILE_TEST to not be enabled
 	# blindly in allmodconfig or allyesconfig configurations
+	depends on KVM
 	depends on (X86_64 && !KASAN) || !COMPILE_TEST
 	depends on EXPERT
 	help
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Matteo Croce

From: Matteo Croce <[email protected]>

Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.

I'd even say

Fixes 4f337faf1c55e ("KVM: allow disabling -Werror")
Quoted 9 lines
---
 arch/x86/kvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kvm/Kconfig +0 -0
index fbd5bd7a945a..f92dfd8ef10d 100644

arch/x86/kvm/Kconfig config KVM_WERROR · line 72

Quoted 7 lines
arch/x86/kvm/Kconfig +1 -0
@@ -66,6 +66,7 @@ config KVM_WERROR
 	default y if X86_64 && !KASAN
 	# We use the dependency on !COMPILE_TEST to not be enabled
 	# blindly in allmodconfig or allyesconfig configurations
+	depends on KVM
 	depends on (X86_64 && !KASAN) || !COMPILE_TEST
 	depends on EXPERT
 	help
Signature · 1 line
Vitaly
#2 lore raw
Quoted 5 lines · Vitaly Kuznetsov
Quoted 2 lines · Matteo Croce

From: Matteo Croce <[email protected]>

Quoted 8 lines
Quoted 3 lines

Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.

I'd even say

Fixes 4f337faf1c55e ("KVM: allow disabling -Werror")

Indeed, thanks

Quoted 22 lines
Quoted 9 lines
---
 arch/x86/kvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kvm/Kconfig +0 -0
index fbd5bd7a945a..f92dfd8ef10d 100644

arch/x86/kvm/Kconfig config KVM_WERROR · line 72

Quoted 7 lines
arch/x86/kvm/Kconfig +1 -0
@@ -66,6 +66,7 @@ config KVM_WERROR
      default y if X86_64 && !KASAN
      # We use the dependency on !COMPILE_TEST to not be enabled
      # blindly in allmodconfig or allyesconfig configurations
+     depends on KVM
      depends on (X86_64 && !KASAN) || !COMPILE_TEST
      depends on EXPERT
      help

--
Vitaly

Signature · 1 line
per aspera ad upstream
maintainer Applied
#3 lore raw
In reply to Matteo Croce
Quoted 15 lines · Matteo Croce

From: Matteo Croce <[email protected]>

Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.

---
 arch/x86/kvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kvm/Kconfig +0 -0
index fbd5bd7a945a..f92dfd8ef10d 100644

arch/x86/kvm/Kconfig config KVM_WERROR · line 72

Quoted 7 lines
arch/x86/kvm/Kconfig +1 -0
@@ -66,6 +66,7 @@ config KVM_WERROR
 	default y if X86_64 && !KASAN
 	# We use the dependency on !COMPILE_TEST to not be enabled
 	# blindly in allmodconfig or allyesconfig configurations
+	depends on KVM
 	depends on (X86_64 && !KASAN) || !COMPILE_TEST
 	depends on EXPERT
 	help

Queued, thanks.

Paolo