Skip to contentSkip to conversation

maintainers: New Reviewer entry type added to MAINTAINERS

PATCH In review [email protected] 3 participants 6 messages Oct 1, 2020 – Oct 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maintainers: New Reviewer entry type added to MAINTAINERS

From: Tom Rix <[email protected]>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes in areas of interest.

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.

---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
MAINTAINERS +3 -1
index c0abbe0fc..30faf2455 100644
@@ -17,7 +17,8 @@ Descriptions of section entries:
 	X: Files and directories exclusion, same rules as F:
 	K: Keyword regex pattern to match content.
 	   One regex pattern per line. Multiple K: lines acceptable.
-
+	R: Designated *Reviewer*: FullName <address@domain>
+	   These reviewers should be CCed on patches.
 
 General Project Administration
 ------------------------------
@@ -392,6 +393,7 @@ F: lib/librte_ethdev/rte_mtr*
 
 Baseband API - EXPERIMENTAL
 M: Nicolas Chautru <[email protected]>
+R: Tom Rix <[email protected]>
 T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/librte_bbdev/
 F: doc/guides/prog_guide/bbdev.rst
Signature · 1 line
2.18.1
Acked-by on v1 1/1
#1 lore raw

Hi Tom,

Thanks for the help.
Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of.
https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

Quoted 49 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Thursday, October 1, 2020 7:31 AM
To: [email protected]; Chautru, Nicolas <[email protected]>
Cc: [email protected]; Tom Rix <[email protected]>
Subject: [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

From: Tom Rix <[email protected]>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes in areas of interest.

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.

---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
MAINTAINERS +3 -2
index c0abbe0fc..30faf2455 100644
@@ -17,7 +17,8 @@ Descriptions of section entries:
 	X: Files and directories exclusion, same rules as F:
 	K: Keyword regex pattern to match content.
 	   One regex pattern per line. Multiple K: lines acceptable.
-
+	R: Designated *Reviewer*: FullName <address@domain>
+	   These reviewers should be CCed on patches.
 
 General Project Administration
 ------------------------------
@@ -392,6 +393,7 @@ F: lib/librte_ethdev/rte_mtr*
 
 Baseband API - EXPERIMENTAL
 M: Nicolas Chautru <[email protected]>
+R: Tom Rix <[email protected]>
 T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/librte_bbdev/
 F: doc/guides/prog_guide/bbdev.rst
--

2.18.1

#2 lore raw

01/10/2020 23:22, Chautru, Nicolas:

Quoted 20 lines

From: [email protected] <[email protected]>

Quoted 6 lines

From: Tom Rix <[email protected]>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes in areas of interest.

Quoted 7 lines

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.

Thanks for the help.
Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of.
https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

[...]

Quoted 3 lines
Quoted 3 lines

Baseband API - EXPERIMENTAL
M: Nicolas Chautru <[email protected]>
+R: Tom Rix <[email protected]>

I don't understand the need of differenciating maintainer and reviewer. If you are trusted enough, why not just being co-maintainer?

author
#3 lore raw
Quoted 19 lines · Thomas Monjalon

01/10/2020 23:22, Chautru, Nicolas:

Quoted 18 lines

From: [email protected] <[email protected]>

Quoted 6 lines

From: Tom Rix <[email protected]>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes in areas of interest.

Quoted 7 lines

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.

Thanks for the help.
Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of.
https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

Quoted 8 lines
Quoted 1 line

[...]

Quoted 3 lines
Quoted 3 lines

Baseband API - EXPERIMENTAL
M: Nicolas Chautru <[email protected]>
+R: Tom Rix <[email protected]>

I don't understand the need of differenciating maintainer and reviewer. If you are trusted enough, why not just being co-maintainer?

I want to help out with the reviews, the reviewer type makes clear this level of commitment.

Maintainer is the next, higher level of commitment.

Trust wise, this would allow the maintainer verify the reviewer does have the bandwidth to be responsive

and effective before committing to sharing responsibility.

Tom

Quoted 1 line
#4 lore raw

02/10/2020 16:59, Tom Rix:

Quoted 29 lines · Thomas Monjalon
Quoted 19 lines

01/10/2020 23:22, Chautru, Nicolas:

Quoted 18 lines

From: [email protected] <[email protected]>

Quoted 6 lines

From: Tom Rix <[email protected]>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes in areas of interest.

Quoted 7 lines

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.

Thanks for the help.
Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of.
https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

Quoted 8 lines
Quoted 1 line

[...]

Quoted 3 lines
Quoted 3 lines

Baseband API - EXPERIMENTAL
M: Nicolas Chautru <[email protected]>
+R: Tom Rix <[email protected]>

I don't understand the need of differenciating maintainer and reviewer. If you are trusted enough, why not just being co-maintainer?

Quoted 8 lines

I want to help out with the reviews, the reviewer type makes clear this level of commitment.

Maintainer is the next, higher level of commitment.

Trust wise, this would allow the maintainer verify the reviewer does have the bandwidth to be responsive

and effective before committing to sharing responsibility.

Sorry I fail to understand.
My understanding is that you want to be Cc
but not committing for responsibility.
Would it be the same if you create a mail filter on your side?

This model is really not clear to me so I'm reluctant to add such new category until I understand the benefit.

author
#5 lore raw
Quoted 36 lines · Thomas Monjalon

02/10/2020 16:59, Tom Rix:

Quoted 35 lines · Thomas Monjalon
Quoted 19 lines

01/10/2020 23:22, Chautru, Nicolas:

Quoted 18 lines

From: [email protected] <[email protected]>

Quoted 6 lines

From: Tom Rix <[email protected]>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes in areas of interest.

Quoted 7 lines

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.

Thanks for the help.
Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of.
https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

Quoted 8 lines
Quoted 1 line

[...]

Quoted 3 lines
Quoted 3 lines

Baseband API - EXPERIMENTAL
M: Nicolas Chautru <[email protected]>
+R: Tom Rix <[email protected]>

I don't understand the need of differenciating maintainer and reviewer. If you are trusted enough, why not just being co-maintainer?

I want to help out with the reviews, the reviewer type makes clear this level of commitment.

Maintainer is the next, higher level of commitment.

Trust wise, this would allow the maintainer verify the reviewer does have the bandwidth to be responsive

Quoted 9 lines
Quoted 1 line

and effective before committing to sharing responsibility.

Sorry I fail to understand.
My understanding is that you want to be Cc
but not committing for responsibility.
Would it be the same if you create a mail filter on your side?

This model is really not clear to me so I'm reluctant to add such new category until I understand the benefit.

That's fine, i will change the patch and use the existing process.

Tom