Skip to contentSkip to conversation

dt-bindings: arm: Add missing root node constraint for board/SoC bindings

PATCH In review Rob Herring 6 participants 6 messages Oct 1, 2020 – Oct 5, 2020

Subsystems (11)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: arm: Add missing root node constraint for board/SoC bindings

Board/SoC top-level compatible bindings should be constrained to the root node. Add the missing constraints that the node name must be "/".

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Baruch Siach <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Imre Kaloz <[email protected]>
Cc Krzysztof Halasa <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Anders Berg <[email protected]>
---
 Documentation/devicetree/bindings/arm/actions.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/altera.yaml       | 2 ++
 Documentation/devicetree/bindings/arm/axxia.yaml        | 2 ++
 Documentation/devicetree/bindings/arm/bitmain.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/digicolor.yaml    | 2 ++
 Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
 Documentation/devicetree/bindings/arm/qcom.yaml         | 2 ++
 Documentation/devicetree/bindings/arm/rda.yaml          | 2 ++
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml  | 2 ++
 Documentation/devicetree/bindings/arm/tegra.yaml        | 2 ++
 10 files changed, 20 insertions(+)
Documentation/devicetree/bindings/arm/actions.yaml +2 -0
index ace3fdaa8396..14023f0a8552 100644
@@ -11,6 +11,8 @@ maintainers:
   - Manivannan Sadhasivam <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       # The Actions Semi S500 is a quad-core ARM Cortex-A9 SoC.
Documentation/devicetree/bindings/arm/altera.yaml +2 -0
index b388c5aa7984..0bc5020b7539 100644
@@ -10,6 +10,8 @@ maintainers:
   - Dinh Nguyen <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
Documentation/devicetree/bindings/arm/axxia.yaml +2 -0
index 98780a569f22..3ea5f2fdcd96 100644
@@ -10,6 +10,8 @@ maintainers:
   - Anders Berg <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     description: LSI AXM5516 Validation board (Amarillo)
     items:
Documentation/devicetree/bindings/arm/bitmain.yaml +2 -0
index 5cd5b36cff2d..5880083ab8d0 100644
@@ -10,6 +10,8 @@ maintainers:
   - Manivannan Sadhasivam <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
Documentation/devicetree/bindings/arm/digicolor.yaml +2 -0
index d9c80b827e9b..849e20518339 100644
@@ -10,6 +10,8 @@ maintainers:
   - Baruch Siach <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     const: cnxt,cx92755
 
Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml +2 -0
index f4f7451e5e8a..f18302efb90e 100644
@@ -10,6 +10,8 @@ maintainers:
   - Linus Walleij <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Documentation/devicetree/bindings/arm/qcom.yaml +2 -0
index 6031aee0f5a8..ae6284be9fef 100644
@@ -73,6 +73,8 @@ description: |
   foundry 2.
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Documentation/devicetree/bindings/arm/rda.yaml +2 -0
index 51cec2b63b04..9672aa0c760d 100644
@@ -10,6 +10,8 @@ maintainers:
   - Manivannan Sadhasivam <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +2 -0
index 790e6dd48e34..696a0101ebcc 100644
@@ -10,6 +10,8 @@ maintainers:
   - Alexandre Torgue <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Documentation/devicetree/bindings/arm/tegra.yaml +2 -0
index e0b3debaee9e..b4d53290c5f0 100644
@@ -11,6 +11,8 @@ maintainers:
   - Jonathan Hunter <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Rob Herring

Board/SoC top-level compatible bindings should be constrained to the root node. Add the missing constraints that the node name must be "/".

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Baruch Siach <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Imre Kaloz <[email protected]>
Cc Krzysztof Halasa <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Anders Berg <[email protected]>

Makes sense.

Yours,
Linus Walleij

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring

Am 01.10.20 um 22:09 schrieb Rob Herring:

Quoted 19 lines

Board/SoC top-level compatible bindings should be constrained to the root node. Add the missing constraints that the node name must be "/".

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Baruch Siach <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Imre Kaloz <[email protected]>
Cc Krzysztof Halasa <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Anders Berg <[email protected]>
Quoted 12 lines
---
 Documentation/devicetree/bindings/arm/actions.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/altera.yaml       | 2 ++
 Documentation/devicetree/bindings/arm/axxia.yaml        | 2 ++
 Documentation/devicetree/bindings/arm/bitmain.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/digicolor.yaml    | 2 ++
 Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
 Documentation/devicetree/bindings/arm/qcom.yaml         | 2 ++
 Documentation/devicetree/bindings/arm/rda.yaml          | 2 ++
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml  | 2 ++
 Documentation/devicetree/bindings/arm/tegra.yaml        | 2 ++
 10 files changed, 20 insertions(+)

Looks like for realtek.yaml we already have it, although in single quotes, but I assume that's equivalent.

Regards,
Andreas

Signature · 4 lines
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
Reviewed-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 19 lines · Rob Herring

Board/SoC top-level compatible bindings should be constrained to the root node. Add the missing constraints that the node name must be "/".

Cc "Andreas Färber" <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Baruch Siach <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Imre Kaloz <[email protected]>
Cc Krzysztof Halasa <[email protected]>
Cc Andy Gross <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Anders Berg <[email protected]>
Quoted 2 lines
---
 Documentation/devicetree/bindings/arm/actions.yaml      | 2 ++

For actions,

Thanks,
Mani

Quoted 144 lines
 Documentation/devicetree/bindings/arm/altera.yaml       | 2 ++
 Documentation/devicetree/bindings/arm/axxia.yaml        | 2 ++
 Documentation/devicetree/bindings/arm/bitmain.yaml      | 2 ++
 Documentation/devicetree/bindings/arm/digicolor.yaml    | 2 ++
 Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
 Documentation/devicetree/bindings/arm/qcom.yaml         | 2 ++
 Documentation/devicetree/bindings/arm/rda.yaml          | 2 ++
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml  | 2 ++
 Documentation/devicetree/bindings/arm/tegra.yaml        | 2 ++
 10 files changed, 20 insertions(+)
Documentation/devicetree/bindings/arm/actions.yaml +2 -0
index ace3fdaa8396..14023f0a8552 100644
@@ -11,6 +11,8 @@ maintainers:
   - Manivannan Sadhasivam <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       # The Actions Semi S500 is a quad-core ARM Cortex-A9 SoC.
Documentation/devicetree/bindings/arm/altera.yaml +2 -0
index b388c5aa7984..0bc5020b7539 100644
@@ -10,6 +10,8 @@ maintainers:
   - Dinh Nguyen <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
Documentation/devicetree/bindings/arm/axxia.yaml +2 -0
index 98780a569f22..3ea5f2fdcd96 100644
@@ -10,6 +10,8 @@ maintainers:
   - Anders Berg <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     description: LSI AXM5516 Validation board (Amarillo)
     items:
Documentation/devicetree/bindings/arm/bitmain.yaml +2 -0
index 5cd5b36cff2d..5880083ab8d0 100644
@@ -10,6 +10,8 @@ maintainers:
   - Manivannan Sadhasivam <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
Documentation/devicetree/bindings/arm/digicolor.yaml +2 -0
index d9c80b827e9b..849e20518339 100644
@@ -10,6 +10,8 @@ maintainers:
   - Baruch Siach <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     const: cnxt,cx92755
 
Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml +2 -0
index f4f7451e5e8a..f18302efb90e 100644
@@ -10,6 +10,8 @@ maintainers:
   - Linus Walleij <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Documentation/devicetree/bindings/arm/qcom.yaml +2 -0
index 6031aee0f5a8..ae6284be9fef 100644
@@ -73,6 +73,8 @@ description: |
   foundry 2.
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Documentation/devicetree/bindings/arm/rda.yaml +2 -0
index 51cec2b63b04..9672aa0c760d 100644
@@ -10,6 +10,8 @@ maintainers:
   - Manivannan Sadhasivam <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     items:
       - enum:
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +2 -0
index 790e6dd48e34..696a0101ebcc 100644
@@ -10,6 +10,8 @@ maintainers:
   - Alexandre Torgue <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Documentation/devicetree/bindings/arm/tegra.yaml +2 -0
index e0b3debaee9e..b4d53290c5f0 100644
@@ -11,6 +11,8 @@ maintainers:
   - Jonathan Hunter <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#4 lore raw
In reply to Rob Herring

On Thu, Oct 01, 2020 at 03:09:43PM -0500, Rob Herring wrote:
[...]

Documentation/devicetree/bindings/arm/tegra.yaml maintainers: · line 18

Quoted 13 lines
Documentation/devicetree/bindings/arm/tegra.yaml +2 -0
index e0b3debaee9e..b4d53290c5f0 100644
@@ -11,6 +11,8 @@ maintainers:
   - Jonathan Hunter <[email protected]>
 
 properties:
+  $nodename:
+    const: "/"
   compatible:
     oneOf:
       - items:
Reviewed-by on v1 1/1
#5 lore raw
In reply to Rob Herring

Hi Rob,

Quoted 3 lines · Rob Herring

Board/SoC top-level compatible bindings should be constrained to the root node. Add the missing constraints that the node name must be "/".

...

Documentation/devicetree/bindings/arm/stm32/stm32.yaml maintainers: · line 17

Quoted 13 lines
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +2 -0
index 790e6dd48e34..696a0101ebcc 100644
@@ -10,6 +10,8 @@ maintainers:
    - Alexandre Torgue <[email protected]>
 
  properties:
+  $nodename:
+    const: "/"
    compatible:
      oneOf:
        - items:

thanks
Alex