Skip to contentSkip to conversation

Revert "Bluetooth: Update resolving list when updating whitelist"

PATCH In review Greg Kroah-Hartman 3 participants 23 messages Oct 3, 2020 – Oct 7, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "Bluetooth: Update resolving list when updating whitelist"

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
---
 net/bluetooth/hci_request.c | 41 ++-----------------------------------
 1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

net/bluetooth/hci_request.c +2 -39
index e0269192f2e5..75b0a4776f10 100644
@@ -697,21 +697,6 @@ static void del_from_white_list(struct hci_request *req, bdaddr_t *bdaddr,
 	bt_dev_dbg(req->hdev, "Remove %pMR (0x%x) from whitelist", &cp.bdaddr,
 		   cp.bdaddr_type);
 	hci_req_add(req, HCI_OP_LE_DEL_FROM_WHITE_LIST, sizeof(cp), &cp);
-
-	if (use_ll_privacy(req->hdev)) {
-		struct smp_irk *irk;
-
-		irk = hci_find_irk_by_addr(req->hdev, bdaddr, bdaddr_type);
-		if (irk) {
-			struct hci_cp_le_del_from_resolv_list cp;
-
-			cp.bdaddr_type = bdaddr_type;
-			bacpy(&cp.bdaddr, bdaddr);
-
-			hci_req_add(req, HCI_OP_LE_DEL_FROM_RESOLV_LIST,
-				    sizeof(cp), &cp);
-		}
-	}
 }
 
 /* Adds connection to white list if needed. On error, returns -1. */
@@ -732,7 +717,7 @@ static int add_to_white_list(struct hci_request *req,
 		return -1;
 
 	/* White list can not be used with RPAs */
-	if (!allow_rpa && !use_ll_privacy(hdev) &&
+	if (!allow_rpa &&
 	    hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
 		return -1;
 	}
@@ -750,28 +735,6 @@ static int add_to_white_list(struct hci_request *req,
 		   cp.bdaddr_type);
 	hci_req_add(req, HCI_OP_LE_ADD_TO_WHITE_LIST, sizeof(cp), &cp);
 
-	if (use_ll_privacy(hdev)) {
-		struct smp_irk *irk;
-
-		irk = hci_find_irk_by_addr(hdev, &params->addr,
-					   params->addr_type);
-		if (irk) {
-			struct hci_cp_le_add_to_resolv_list cp;
-
-			cp.bdaddr_type = params->addr_type;
-			bacpy(&cp.bdaddr, &params->addr);
-			memcpy(cp.peer_irk, irk->val, 16);
-
-			if (hci_dev_test_flag(hdev, HCI_PRIVACY))
-				memcpy(cp.local_irk, hdev->irk, 16);
-			else
-				memset(cp.local_irk, 0, 16);
-
-			hci_req_add(req, HCI_OP_LE_ADD_TO_RESOLV_LIST,
-				    sizeof(cp), &cp);
-		}
-	}
-
 	return 0;
 }
 
@@ -812,7 +775,7 @@ static u8 update_white_list(struct hci_request *req)
 		}
 
 		/* White list can not be used with RPAs */
-		if (!allow_rpa && !use_ll_privacy(hdev) &&
+		if (!allow_rpa &&
 		    hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
 			return 0x00;
 		}
Signature · 1 line
2.28.0
maintainer
#1 lore raw

Hi Greg,

Quoted 11 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)
Quoted 8 lines

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

When you run btmon does it indicate any errors?

Do you have a chance to test net-next and see the LL Privacy there might have addressed this?

Regards

Marcel

#2 lore raw
Quoted 19 lines · Marcel Holtmann

Hi Greg,

Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

Quoted 1 line

Do you have a chance to test net-next and see the LL Privacy there might have addressed this?

Have a specific set of patches I can test? It wouldn't be good to have 5.9-final go out with this not working at all.

thanks,

greg k-h

maintainer
#3 lore raw

Hi Greg,

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 4 lines
Quoted 1 line

Do you have a chance to test net-next and see the LL Privacy there might have addressed this?

Have a specific set of patches I can test? It wouldn't be good to have 5.9-final go out with this not working at all.

Of course not, but so far you are the only one reported a problem. Maybe you have some funky hardware in your machine that needs a quirk.

Regards

Marcel

#4 lore raw
Quoted 28 lines · Marcel Holtmann

Hi Greg,

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

thanks,

greg k-h

btsnoop�55�� ⎉,~�Linux version 5.9.0-rc7-00004-g0216685bdd99 (x86_64)!!�� ⎉,~�Bluetooth subsystem version 2.22⎉,~�pe���Phci0⎉,~�
⎉,~�pe���P��⎉,~�bluetoothd⎉-:�L  ⎉-:�Y �
⎉-:�p ⎉-:�q

⎉-:��: ⎉-:��B ⎉-<�_B ⎉-<�n 
���.&⎉-<� ⎉-<�$A $⎉-<��A ⎉-<��B ⎉-<�lB ⎉-<�t3��⎉-<�'

⎉-<�T:⎉-<�^⎉-<Ŗ�4�_��3��⎉-<ŻR � thread
kF7
 
 3⎉-<��R ⎉-<� ⎉-<�0�4�_��2��⎉-<�<R � thread
kF7
 
 32⎉-<ܓR ⎉-<ܵ ⎉-<���4�_��/⎉-<��$ ⎉-<�M$ ⎉-<�o��⎉-<�xR � thread
kF7
 
 32/⎉-<�R ⎉-<�*⎉-<�a�4�_����⎉-<�mR � thread
kF7
 
 32/⎉-<��R ⎉-<��⎉-=�4�_����⎉-=#R � thread
kF7
 
 32/⎉-= sR ⎉-= �⎉-= ��4�_����⎉-= �R � thread
kF7
 
 32/⎉-=+R ⎉-=M⎉-=���P��⎉-=�R � thread
kF7
 
 32/��P⎉-="�R ⎉-=#55⎉->k%>3 ��!lT��& MyRun 18004074##⎉->r�>! ��!lT��&44⎉->s��!lT� & MyRun 18004074&88⎉-?��>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-?�V>3 ���c��� UDM-PRO!-�-II⎉-?�a���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�- ⎉-A��B ⎉-A��B ⎉-A��B ⎉-A�YB 55⎉-B$K>3 ��!lT��& MyRun 18004074##⎉-B, >! ��!lT��&44⎉-B,+��!lT� & MyRun 18004074&;;⎉-B?�>9 �r�Ѳ��o�o���
��7�rs� �Jjn�T�)�33⎉-B?��r�Ѳ�o�o���
��7�rs� �Jjn�T�)�⎉-D�7/�6�ZV(<�[�⎉-D�W6�ZV(� <⎉-D��%6�ZV(⎉-D��%6�ZV(44⎉-D��>2 oC��{���������r�&v �&&⎉-Dۈ>$ oC��{��

		Eetkamer66⎉-D��oC��{�"�������r�&v   �		Eetkamer;;⎉-D��>9
��!5%��o�o��wk��;QF*t����4�33⎉-D�=��!5%�o�o��wk��;QF*t����4�		⎉-E=pB ⎉-EH�B 		⎉-EH�B ⎉-ET�B ::⎉-H�Y>8
*�!�o����Lt'�ڶDE �r��5IP�44⎉-H�!>2
*�!�o���"	S19743271de39a3d6CJJ⎉-H�@*�!�o��6�Lt'�ڶDE �r��5IP�"	S19743271de39a3d6C55⎉-I�>3
��!lT��&	MyRun 18004074##⎉-I
�>!
��!lT��&44⎉-I
���!lT� &	MyRun 18004074&		⎉-L�B ⎉-L�B 		⎉-L�B ⎉-L&�B ⎉-L�/�6�ZV(<�[�	KD-43XD8305	

 =d�d
BB⎉-L�'6�ZV(�. KD-43XD8305 
 =d�d
 <55⎉-M8%>3 ��!lT��& MyRun 18004074##⎉-M?�>! ��!lT��&44⎉-M@��!lT� & MyRun 18004074& ⎉-O�SB ⎉-O��B ⎉-O��B ⎉-O�VB 55⎉-P�>3 ��!lT��& MyRun 18004074##⎉-P
�>! ��!lT��&44⎉-P
���!lT� & MyRun 18004074& ⎉-S$]B ⎉-S38B ⎉-S3]B ⎉-S@�B ::⎉-TB�>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-TH�>2 *�!�o���" S19743271de39a3d6CJJ⎉-TH�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-WZuB ⎉-Wi�B ⎉-WjB ⎉-Wy]B ::⎉-X �>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-XW>2 *�!�o���" S19743271de39a3d6CJJ⎉-X�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C11⎉-[I>/ 6�ZV(����г˄��B�����⎉-[�> 6�ZV(��))⎉-[ 6�ZV(���г˄��B����� ⎉-[+B ..⎉-[0:>, �J�!�s��
�L��� ⎉-[2> �J�!�s��&&⎉-[2.�J�!�s�
�L��� 55⎉-[B:>3 ��!lT��& MyRun 18004074##⎉-[I�>! ��!lT��&44⎉-[J��!lT� & MyRun 18004074&⎉-[QEB ⎉-[QlB ⎉-[`�B 55⎉-\OO>3 ��!lT��& MyRun 1800407488⎉-\n�>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�--⎉-\n���!lT�& MyRun 1800407455⎉-\vN>3 ���c��� UDM-PRO!-�-II⎉-\vk���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�- ⎉-^BOB ⎉-^J�B ⎉-^KB ⎉-^Z�B 55⎉-b�'>3 ��!lT��& MyRun 18004074##⎉-b��>! ��!lT��&44⎉-b�
��!lT� & MyRun 18004074&::⎉-c�>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-c�i>2 *�!�o���" S19743271de39a3d6CJJ⎉-c�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-e�}B ⎉-e� B ⎉-e�+B ⎉-e�B 55⎉-f��>3 ��!lT��& MyRun 1800407488⎉-iKz>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�--⎉-iK���!lT�& MyRun 1800407455⎉-iS7>3 ���c��� UDM-PRO!-�-II⎉-iSV���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�-##⎉-j��>! ��!lT��&⎉-j����!lT�&::⎉-j��>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-j�>2 *�!�o���" S19743271de39a3d6CJJ⎉-j��*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-lYB ⎉-ld9B ⎉-ldTB ⎉-ls�B 55⎉-mR�>3 ��!lT��& MyRun 18004074##⎉-mZb>! ��!lT��&44⎉-mZ���!lT� & MyRun 18004074&44⎉-pG�>2 oC��{���������r�&v �&&⎉-pN:>$ oC��{��

		Eetkamer66⎉-pNzoC��{�"�������r�&v   �		Eetkamer		⎉-pk7B ⎉-pw�B 		⎉-pw�B ⎉-p�RB 55⎉-p�*>3
��!lT��&	MyRun 18004074##⎉-p��>!
��!lT��&44⎉-p���!lT� &	MyRun 18004074&::⎉-s:g>8
*�!�o����Lt'�ڶDE �r��5IP�44⎉-sD	>2
*�!�o���"	S19743271de39a3d6CJJ⎉-sDF*�!�o��6�Lt'�ڶDE �r��5IP�"	S19743271de39a3d6C		⎉-s�>B ⎉-s�*B 		⎉-s�CB ⎉-s��B ::⎉-u��>8
*�!�o����Lt'�ڶDE �r��5IP�44⎉-u�|>2
*�!�o���"	S19743271de39a3d6CJJ⎉-u��*�!�o��6�Lt'�ڶDE �r��5IP�"	S19743271de39a3d6C88⎉-w\�>6
���c���>��.��?��EK3�l�&	*%�c�Ϧ�55⎉-wd�>3
���c��� UDM-PRO!-�-II⎉-wd����c��5>��.��?��EK3�l�&	*%�c�Ϧ� UDM-PRO!-�-55⎉-w�>3
��!lT��&	MyRun 18004074##⎉-w��>!
��!lT��&44⎉-w����!lT� &	MyRun 18004074&		⎉-yIB ;;⎉-y�>9
�r�Ѳ��o�o���

��7�rs� �Jjn�T�)�33⎉-y��r�Ѳ�o�o���
��7�rs� �Jjn�T�)�⎉-yB ⎉-yDB ⎉-y!�B 55⎉-{��>3 ��!lT��& MyRun 1800407444⎉-|9>2 oC��{���������r�&v �--⎉-|[��!lT�& MyRun 18004074 ⎉-|�B ⎉-|+)B ,,⎉-|+BoC��{��������r�&v � ⎉-|+GB ⎉-|6�B ;;⎉-}Hw>9 �r�Ѳ��o�o���
��7�rs� �Jjn�T�)�33⎉-}H��r�Ѳ�o�o���
��7�rs� �Jjn�T�)�55⎉-}_�>3 ��!lT��& MyRun 18004074##⎉-}g�>! ��!lT��&44⎉-}g���!lT� & MyRun 18004074&::⎉-~��>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-~��>2 *�!�o���" S19743271de39a3d6CJJ⎉-~��*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-D�B ⎉-O�B ⎉-O�B ⎉-_rB 55⎉-�&�>3 ��!lT��& MyRun 18004074##⎉-�.�>! ��!lT��&44⎉-�.���!lT� & MyRun 18004074& ⎉-�<dB ⎉-�GZB ⎉-�G}B ⎉-�W
B 88⎉-��f>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-��/>3 ���c��� UDM-PRO!-�-II⎉-��S���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�-::⎉-��>8 *�!�o����Lt'�ڶDE � r��5IP� ⎉-���B ⎉-���B 22⎉-��*�!�o���Lt'�ڶDE � r��5IP� ⎉-��B ⎉-�şB 55⎉-��1>3 ��!lT��& MyRun 18004074##⎉-���>! ��!lT��&44⎉-����!lT� & MyRun 18004074& ⎉-���B ⎉-���B ⎉-���B ⎉-��xB ::⎉-���>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-�ح>2 *�!�o���" S19743271de39a3d6CJJ⎉-���*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C55⎉-��f>3 ��!lT��& MyRun 18004074##⎉-��B>! ��!lT��&44⎉-��`��!lT� & MyRun 18004074& ⎉-��B ⎉-��hB ⎉-���B ⎉-�B 88⎉-��>6 (���Z������55⎉-�F�>3 ��!lT��& MyRun 1800407400⎉-�F�(���Z�����##⎉-�LU>! ��!lT��&44⎉-�Lv��!lT� & MyRun 18004074&88⎉-���>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-��c>3 ���c��� UDM-PRO!-�-II⎉-������c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�- ⎉-�aB ⎉-�mB ⎉-�mB ⎉-�x�B 55⎉-�_V>3 ��!lT��& MyRun 18004074##⎉-�c+>! ��!lT��&44⎉-�cK��!lT� & MyRun 18004074&::⎉-�M>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-� >2 *�!�o���" S19743271de39a3d6CJJ⎉-� 3*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-�r�B ⎉-��B ⎉-�� B ⎉-���B ::⎉-���>8 *�!�o����Lt'�ڶDE � r��5IP�⎉-��/���k�<
Q�⎉-���k�� <⎉-� 9%��k�⎉-� ?%��k�55⎉-���>3 ��!lT��& MyRun 1800407422⎉-�� *�!�o���Lt'�ڶDE � r��5IP� ⎉-�1�B ⎉-�<�B --⎉-�<���!lT�& MyRun 18004074 ⎉-�<�B ⎉-�LFB 55⎉-� >3 ��!lT��& MyRun 18004074##⎉-�&�>! ��!lT��&44⎉-�&���!lT� & MyRun 18004074& ⎉-�L_B ⎉-�YsB ⎉-�Y�B ⎉-�i"B 55⎉-���>3 ��!lT��& MyRun 18004074##⎉-��t>! ��!lT��&44⎉-�����!lT� & MyRun 18004074&11⎉-��%>/ 6�ZV(����г˄��B�����⎉-���> 6�ZV(��))⎉-��6�ZV(���г˄��B����� ⎉-���B ⎉-���B ⎉-���B ⎉-��HB 88⎉-�$>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-�,n>3 ���c��� UDM-PRO!-�-II⎉-�,����c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�-;;⎉-��^>9 lO �n��� ��
���u��m���R+p\>Ge�33⎉-���lO �n�� ��
���u��m���R+p\>Ge� ⎉-�A�B ⎉-�N�B ⎉-�N�B ⎉-�\B 55⎉-�<o>3 ��!lT��& MyRun 18004074##⎉-�D>! ��!lT��&44⎉-�D[��!lT� & MyRun 18004074& ⎉-�TB ⎉-�a/B ⎉-�agB ⎉-�n�B 11⎉-���>/ 6�ZV(����г˄��B�����⎉-��K> 6�ZV(��))⎉-��l6�ZV(���г˄��B�����55⎉-���>3 ��!lT��& MyRun 18004074##⎉-��O>! ��!lT��&44⎉-��o��!lT� & MyRun 18004074&88⎉-�#�>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉-�+�> .��op��00⎉-�+�`.��op�o�o���*�U��4Cu�Xf�C=u$::⎉-�J�>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-�R�>2 *�!�o���" S19743271de39a3d6CJJ⎉-�R�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-���B ⎉-���B ⎉-���B ⎉-��EB ;;⎉-�s�>9 ��i��o�o��*^Tr�� u���bpu:�33⎉-�s���i�o�o��*^Tr�� u���bpu:�88⎉-�:�>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉-�Bu> .��op��00⎉-�B�`.��op�o�o���*�U��4Cu�Xf�C=u$ ⎉-��-B ⎉-���B ⎉-���B ⎉-��>B 88⎉-�Yb>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-�a->3 ���c��� UDM-PRO!-�-II⎉-�aM���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�-::⎉-�Cx>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-�K?>2 *�!�o���" S19743271de39a3d6CJJ⎉-�K_*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-�y�B ⎉-Ɖ�B ⎉-Ɖ�B ⎉-ƕWB 55⎉-�&�>3 ��!lT��& MyRun 18004074##⎉-�>=>! ��!lT��&44⎉-�>���!lT� & MyRun 18004074& ⎉-�U�B ⎉-�b�B ⎉-�b�B ⎉-�p�B 55⎉-�p`>3 ��!lT��& MyRun 18004074##⎉-�x">! ��!lT��&44⎉-�xa��!lT� & MyRun 18004074&88⎉-�z>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉-Ӂ�> .��op��00⎉-Ӂ�`.��op�o�o���*�U��4Cu�Xf�C=u$;;⎉-�j>9 lO �n��� ��
���u��m���R+p\>Ge�33⎉-�jYlO �n�� ��
���u��m���R+p\>Ge� ⎉-֎�B ⎉-֝RB ⎉-֝�B ⎉-֦B 55⎉-��;>3 ��!lT��& MyRun 18004074##⎉-���>! ��!lT��&44⎉-�����!lT� & MyRun 18004074&88⎉-�q�>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-�yd>3 ���c��� UDM-PRO!-�iII⎉-�y����c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i**⎉-��*>( PyE�\��
�L|�:⎉-�h ⎉-�
�B ::⎉-�t>8 *�!�o����Lt'�ڶDE � r��5IP�""⎉-��PyE�\�
�L|�:44⎉-�>2 *�!�o���" S19743271de39a3d6CJJ⎉-��*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C⎉-�#&B ⎉-�#f ⎉-�#vA `0⎉-�.�A ⎉-�/B ⎉-�>wB

⎉-ߺ2: ⎉-ߺ�B ⎉-�sB ⎉-�� �p=⎉-�&� ⎉-�'7A $⎉-�/�A ⎉-�/�B ⎉-�?�B ⎉-�@3��⎉-�K-

⎉-�Kj:⎉-�Ks88⎉-�l�>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-�rY>3 ���c��� UDM-PRO!-�iII⎉-�ry���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i::⎉-���>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-��O>2 *�!�o���" S19743271de39a3d6CJJ⎉-��o*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C⎉-��/�6�ZV(<�[�⎉-��6�ZV(� < ⎉-�B ⎉-㕪B ⎉-��B ⎉-㞲B ⎉-撃/�6�ZV(<�[� KD-43XD8305 
 =d�d
BB⎉-��6�ZV(�. KD-43XD8305 
 =d�d
 <::⎉-���>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-���>2 *�!�o���" S19743271de39a3d6CJJ⎉-��*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-鮒B ⎉-�,B ⎉-�vB ⎉-���B 88⎉-�߯>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉-��g>3 ���c��� UDM-PRO!-�iII⎉-�����c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i::⎉-�'�>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-�/�>2 *�!�o���" S19743271de39a3d6CJJ⎉-�0N*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉-���B ⎉-� B ⎉-�SB ⎉-��B --⎉-�2�>+ �cN0Q@��

�LW�7S⎉-�4l> �cN0Q@��%%⎉-�4��cN0Q@�

�LW�7S55⎉-��(>3 ��!lT��& MyRun 18004074##⎉-���>! ��!lT��&44⎉-����!lT� & MyRun 18004074&::⎉-��V>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉-��>2 *�!�o���" S19743271de39a3d6CJJ⎉-��[*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C88⎉-��>6 �4U�m������IGkVs73kojAt�;��&&⎉-��>$ �4U�m��

	��B�y�::⎉-���4U�m�&����IGkVs73kojAt�;��	��B�y�		⎉-�I�B ⎉-�YvB 		⎉-�Y�B ⎉-�e.B 55⎉-��>3
��!lT��&	MyRun 18004074##⎉-��/>!
��!lT��&44⎉-��j��!lT� &	MyRun 18004074&::⎉-��]>8
*�!�o����Lt'�ڶDE �r��5IP�44⎉-���>2
*�!�o���"	S19743271de39a3d6CJJ⎉-���*�!�o��6�Lt'�ڶDE �r��5IP�"	S19743271de39a3d6C..⎉-��\>,
�J�!�s��

�L��� ⎉-��> �J�!�s��&&⎉-��'�J�!�s�
�L��� ⎉-�ZB ⎉-�^B ⎉-��B ⎉-��B 55⎉-�H�>3 ��!lT��& MyRun 18004074##⎉-�N�>! ��!lT��&44⎉-�N���!lT� & MyRun 18004074& ⎉.`0B ⎉.oHB ⎉.opB ⎉.z�B ..⎉.�y>, 1ư>Z��
 �Lv��C�88⎉. �$>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�&&⎉. �o1ư>Z�
 �Lv��C�55⎉. ��>3 ���c��� UDM-PRO!-�iII⎉. �����c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i55⎉. H�>3 ��!lT��& MyRun 18004074::⎉. X}>8 *�!�o����Lt'�ڶDE � r��5IP�--⎉. X���!lT�& MyRun 1800407444⎉. ^;>2 *�!�o���" S19743271de39a3d6CJJ⎉. ^Y*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉. B ⎉. �B ⎉. �B ⎉. ]B 55⎉.c�>3 ��!lT��& MyRun 18004074##⎉.j�>! ��!lT��&44⎉.j���!lT� & MyRun 18004074&⎉.*�/���k�<
Q�⎉.*���k�� <88⎉.K>>6 a��5�{������Tw0B151k44Ut�;�i ⎉.��B ⎉.��B 00⎉.��a��5�{�����Tw0B151k44Ut�;�i ⎉.��B ⎉.�B 88⎉.�_>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.�)>3 ���c��� UDM-PRO!-�iII⎉.�I���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i ⎉.��B ⎉.�B ⎉.�/B ⎉.ǥB ::⎉.�M>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.�T>2 *�!�o���" S19743271de39a3d6CJJ⎉.�2*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C88⎉.��>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.�>>3 ���c��� UDM-PRO!-�iII⎉.�a���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i;;⎉.�d>9 ��i��o�o��*^Tr�� u���bpu:�33⎉.؇��i�o�o��*^Tr�� u���bpu:� ⎉.!�yB ⎉.!߲B ⎉.!��B ⎉.!�TB 55⎉.%~>3 ��!lT��& MyRun 18004074##⎉.%�V>! ��!lT��&44⎉.%�g��!lT� & MyRun 18004074&88⎉.&��>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.&�>3 ���c��� UDM-PRO!-�iII⎉.&�����c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i ⎉.(�BB ⎉.(�B ⎉.(�-B ⎉.(��B ::⎉.)�Q>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.)�>2 *�!�o���" S19743271de39a3d6CJJ⎉.)�**�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C55⎉.)��>3 ��!lT��& MyRun 18004074##⎉.)ڭ>! ��!lT��&44⎉.)ھ��!lT� & MyRun 18004074& ⎉.,��B ⎉.-�}B ⎉.-�B ⎉.-��B 55⎉.2)�>3 ��!lT��& MyRun 18004074##⎉.21]>! ��!lT��&44⎉.21���!lT� & MyRun 18004074& ⎉.5CtB --⎉.5Y�>+ �>�p��

�L�:�⎉.5a�B %%⎉.5a��>�p�

�L�:� ⎉.5a�B ⎉.5kqB 88⎉.5�.>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉.5��> .��op��00⎉.5��`.��op�o�o���*�U��4Cu�Xf�C=u$ ⎉.8w�B ⎉.8�jB ⎉.8��B ⎉.8��B 55⎉.9�C>3 ��!lT��& MyRun 18004074##⎉.9�>! ��!lT��&44⎉.9����!lT� & MyRun 18004074&88⎉.9��>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉.9��> .��op��00⎉.9��`.��op�o�o���*�U��4Cu�Xf�C=u$ ⎉.<��B ⎉.<�/B ⎉.<�pB ⎉.<��B --⎉.@�>+ ��8C��

�LY��⎉.@�> ��8C��%%⎉.@�M��8C�
�LY��55⎉.@ɡ>3 ��!lT��& MyRun 18004074##⎉.@�V>! ��!lT��&44⎉.@Ӆ��!lT� & MyRun 18004074&::⎉.@�E>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.@�>2 *�!�o���" S19743271de39a3d6CJJ⎉.@�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C--⎉.@��>+ �cN0Q@��

�LW�7S⎉.@�> �cN0Q@��%%⎉.@��cN0Q@�
�LW�7S ⎉.C�wB ⎉.C�KB ⎉.C�wB ⎉.C�kB 88⎉.D�:>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.D��>3 ���c��� UDM-PRO!-�iII⎉.D�"���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i ⎉.H!B ⎉.H�B ⎉.H�B ⎉.H(�B 55⎉.I\�>3 ��!lT��& MyRun 18004074##⎉.If�>! ��!lT��&44⎉.If���!lT� & MyRun 18004074&44⎉.L<>2 oC��{���������r�&v �&&⎉.LD�>$ oC��{��

		Eetkamer66⎉.LE'oC��{�"�������r�&v   �		Eetkamer		⎉.L��B ⎉.L��B 		⎉.L��B ⎉.L�HB 88⎉.M�l>6
`.��op��o�o���*�U��4Cu�Xf�C=u$⎉.N>
`.��op��00⎉.NM`.��op�o�o���*�U��4Cu�Xf�C=u$::⎉.ONg>8
*�!�o����Lt'�ڶDE �r��5IP�44⎉.OV>2
*�!�o���"	S19743271de39a3d6CJJ⎉.OVL*�!�o��6�Lt'�ڶDE �r��5IP�"	S19743271de39a3d6C		⎉.QzB ⎉.Q,�B 		⎉.Q-�B ⎉.Q>AB --⎉.R:�>+
�T'�*_��


�LV�^⎉.RB> �T'�*_��%%⎉.RB(�T'�*_�
�LV�^55⎉.T�>3 ��!lT��& MyRun 18004074##⎉.T��>! ��!lT��&44⎉.T����!lT� & MyRun 18004074& ⎉.UY�B ⎉.Ub�B ⎉.Ub�B ⎉.UrgB 55⎉.Zс>3 ��!lT��& MyRun 18004074##⎉.Z�@>! ��!lT��&44⎉.Z�Q��!lT� & MyRun 18004074& ⎉.]� B ⎉.]��B ⎉.]��B ⎉.^ uB ::⎉.^��>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.^ܛ>2 *�!�o���" S19743271de39a3d6CJJ⎉.^ܫ*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C55⎉.a�7>3 ��!lT��& MyRun 18004074##⎉.a��>! ��!lT��&44⎉.a� ��!lT� & MyRun 18004074&--⎉.a��>+ �cN0Q@��

�LW�7S ⎉.a��B ⎉.b�B %%⎉.b �cN0Q@�

�LW�7S ⎉.b "B ⎉.b�B ⎉.e@B ⎉.e)�B ⎉.e)�B ⎉.e9WB ::⎉.f?5>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.fF�>2 *�!�o���" S19743271de39a3d6CJJ⎉.fG *�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C88⎉.g{�>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.g�b>3 ���c��� UDM-PRO!-�iII⎉.g�s���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i ⎉.iV�B ⎉.i_�B ⎉.i_�B ⎉.iodB 55⎉.j��>3 ��!lT��& MyRun 18004074##⎉.j��>! ��!lT��&44⎉.j����!lT� & MyRun 18004074&88⎉.j��>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉.j��> .��op��00⎉.j��`.��op�o�o���*�U��4Cu�Xf�C=u$::⎉.j��>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.j�K>2 *�!�o���" S19743271de39a3d6CJJ⎉.j�[*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉.m�wB ⎉.m��B ⎉.m��B ⎉.m�%B 11⎉.sV�>/ 6�ZV(����г˄��B�����⎉.sa�> 6�ZV(��))⎉.sa�6�ZV(���г˄��B�����::⎉.vJ�>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.vRh>2 *�!�o���" S19743271de39a3d6CJJ⎉.vR�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉.vx�B ⎉.v�lB ⎉.v��B ⎉.v�!B 88⎉.y#>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.y:>3 ���c��� UDM-PRO!-�iII⎉.yi���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i ⎉.|*�B ⎉.|3�B ⎉.|4/B ⎉.|DB ⎉.|�H ⎉.|��B ::⎉.|��>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.|��>2 *�!�o���" S19743271de39a3d6CJJ⎉.|�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C⎉.|��B ⎉.|�� ⎉.|��A `0⎉.|�fA ⎉.|ȊB ⎉.|�B

⎉.���: ⎉.��-B ⎉.���B ⎉.��� V]4��5⎉.��b ⎉.���A $⎉.��A ⎉.��PB ⎉.��'B ⎉.��K3��⎉.���

⎉.��:⎉.��55⎉.��2>3 ��!lT��& MyRun 18004074##⎉.�� >! ��!lT��&44⎉.��,��!lT� & MyRun 18004074&::⎉.�$g>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.�*}>2 *�!�o���" S19743271de39a3d6CJJ⎉.�*�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉.��B ⎉.��B ⎉.��B ⎉.�@B 55⎉.�G[>3 ��!lT��& MyRun 18004074##⎉.�O>! ��!lT��&44⎉.�O<��!lT� & MyRun 18004074&::⎉.���>8 *�!�o����Lt'�ڶDE � r��5IP�..⎉.�)�>, �J�!�s��
�L��� 22⎉.�)�*�!�o���Lt'�ڶDE � r��5IP�⎉.�-q> �J�!�s��&&⎉.�-��J�!�s�
�L��� ⎉.�]�B ⎉.�k�B ⎉.�l
B ⎉.�w�B ⎉.��]/�6�ZV(<�[� KD-43XD8305 
 =d�d
BB⎉.��~6�ZV(�. KD-43XD8305 
 =d�d
 <88⎉.��^>6 .��op��o�o���*�U��4Cu�Xf�C=u$⎉.��> .��op��00⎉.��>`.��op�o�o���*�U��4Cu�Xf�C=u$ ⎉.��5B ⎉.��;B ⎉.��]B ⎉.���B ..⎉.�HB>, �J�!�s��
�L��� ⎉.�P> �J�!�s��&&⎉.�P!�J�!�s�
�L��� 55⎉.��*>3 ��!lT��& MyRun 18004074##⎉.���>! ��!lT��&44⎉.�� ��!lT� & MyRun 18004074&::⎉.�O�>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.�W�>2 *�!�o���" S19743271de39a3d6CJJ⎉.�W�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉.�b�B ⎉.�p�B ⎉.�p�B ⎉.�|kB 88⎉.��@>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.��

Quoted 1 line

3 ���c��� UDM-PRO!-�iII⎉.��)���c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i55⎉.�vC>3 ��!lT��& MyRun 18004074##⎉.�~>! ��!lT��&44⎉.�~ ��!lT� & MyRun 18004074&::⎉.��>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.��K>2 *�!�o���" S19743271de39a3d6CJJ⎉.��k*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉.��B ⎉.���B ⎉.���B ⎉.�ߔB 55⎉.��>3 ��!lT��& MyRun 18004074##⎉.���>! ��!lT��&44⎉.�����!lT� & MyRun 18004074& ⎉.� B ::⎉.�# >8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.�*�>2 *�!�o���" S19743271de39a3d6CJJ⎉.�*�*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C⎉.�2zB ⎉.�2�B ⎉.�B%B 55⎉.�M�>3 ��!lT��& MyRun 18004074##⎉.�U�>! ��!lT��&44⎉.�U���!lT� & MyRun 18004074&::⎉.�,]>8 *�!�o����Lt'�ڶDE � r��5IP� ⎉.�8ZB ⎉.��`B 22⎉.�Ɓ*�!�o���Lt'�ڶDE � r��5IP� ⎉.�ƉB ⎉.���B 55⎉.�r>3 ��!lT��& MyRun 18004074##⎉.�y�>! ��!lT��&44⎉.�y���!lT� & MyRun 18004074&::⎉.��8>8 *�!�o����Lt'�ڶDE � r��5IP�44⎉.��>2 *�!�o���" S19743271de39a3d6CJJ⎉.��#*�!�o��6�Lt'�ڶDE � r��5IP�" S19743271de39a3d6C ⎉.��JB ⎉.��B ⎉.��@B ⎉.���B 55⎉.��0>3 ��!lT��& MyRun 18004074##⎉.���>! ��!lT��&44⎉.����!lT� & MyRun 18004074&88⎉.���>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�55⎉.�ͤ>3 ���c��� UDM-PRO!-�iII⎉.������c��5>��.��?��EK3�l�& *%�c�Ϧ� UDM-PRO!-�i ⎉.���B ⎉.��B ⎉.��B ⎉.��<B 55⎉.�#!>3 ��!lT��& MyRun 18004074##⎉.�(�>! ��!lT��&44⎉.�(���!lT� & MyRun 18004074&11⎉.���>/ 6�ZV(����г˄��B�����⎉.�‡> 6�ZV(��))⎉.�§6�ZV(���г˄��B����� ⎉.�=�B ⎉.�IB ⎉.�I:B ⎉.�X�B

#5 lore raw
Quoted 36 lines · Greg Kroah-Hartman
Quoted 35 lines · Marcel Holtmann

Hi Greg,

Quoted 32 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

Quoted 8 lines
Quoted 1 line

you can do btmon -w trace.log and just let it run like tcdpump.

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

And any hints on how to read this file? 'btsnoop' has no man page, and the --help options are pretty sparse :(

thanks,

greg k-h

#6 lore raw
In reply to Greg Kroah-Hartman
Quoted 51 lines · Greg Kroah-Hartman
Quoted 44 lines · Marcel Holtmann

Hi Greg,

Quoted 42 lines
Quoted 25 lines
Quoted 25 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when

updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++--------------------------
---------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system.  I finally got the time to do
bisection today, and it came down to this patch.  Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

Quoted 8 lines
Quoted 3 lines

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all.  With this reverted, it
all "just works".

Same I think for a Bluetooth headset, can check that again if you really
need me to, but the trackball is reliable here.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 8 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog
and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

Use bluetoothctl instead, the Bluetooth Settings from GNOME also run a discovery the whole time the panel is opened, and this breaks a fair number of poor quality adapters. This is worked-around in the most recent version, but using bluetoothctl is a better debugging option in all cases.

Cheers

#7 lore raw
Quoted 59 lines · Bastien Nocera
Quoted 58 lines · Greg Kroah-Hartman
Quoted 44 lines · Marcel Holtmann

Hi Greg,

Quoted 42 lines
Quoted 25 lines
Quoted 25 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when

updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++--------------------------
---------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system.  I finally got the time to do
bisection today, and it came down to this patch.  Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

Quoted 8 lines
Quoted 3 lines

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all.  With this reverted, it
all "just works".

Same I think for a Bluetooth headset, can check that again if you really
need me to, but the trackball is reliable here.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog
and it scans for devices in the area, but does not connect to my existing devices at all.

Quoted 7 lines
Quoted 1 line

Any ideas?

Use bluetoothctl instead, the Bluetooth Settings from GNOME also run a discovery the whole time the panel is opened, and this breaks a fair number of poor quality adapters. This is worked-around in the most recent version, but using bluetoothctl is a better debugging option in all cases.

Ok, but how do I use that tool? How do I shut down the gnome bluetooth stuff?

I need newbie steps here please for what to run and what to show you.

thanks,

greg k-h

#8 lore raw
Quoted 80 lines · Greg Kroah-Hartman
Quoted 70 lines · Bastien Nocera
Quoted 60 lines · Greg Kroah-Hartman
Quoted 53 lines · Marcel Holtmann

Hi Greg,

Quoted 51 lines
Quoted 36 lines
Quoted 31 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2
as it
breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list

when
updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++----------------------
----
---------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system.  I finally got the time
to do
bisection today, and it came down to this patch. Reverting
it on top of
5.9-rc7 restored bluetooth devices and now my input devices
properly
work.

Quoted 4 lines

As it's almost 5.9-final, any chance this can be merged now
to fix the
issue?

Quoted 5 lines

can you be specific what breaks since our guys and I also think
the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all.  With this reverted, it
all "just works".

Same I think for a Bluetooth headset, can check that again if you
really
need me to, but the trackball is reliable here.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 8 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog
and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

Quoted 8 lines

Use bluetoothctl instead, the Bluetooth Settings from GNOME also run a
discovery the whole time the panel is opened, and this breaks a fair
number of poor quality adapters. This is worked-around in the most recent version, but using bluetoothctl is a better debugging option in
all cases.

Quoted 3 lines

Ok, but how do I use that tool?  How do I shut down the gnome bluetooth
stuff?

You close the settings window...

Quoted 1 line

I need newbie steps here please for what to run and what to show you.

bluetoothctl connect "bluetooth address"
eg.
bluetoothctl connect "12:34:56:78:90"

maintainer
#10 lore raw
In reply to Greg Kroah-Hartman

Hi Greg,

Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
                return -1;
 
        /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
            hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
                return -1;
        }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
                }
 
                /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                    hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                        return 0x00;
                }

If you just do the above, does thing work for you again?

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

Regards

Marcel

#9 lore raw
In reply to Bastien Nocera
Quoted 85 lines · Bastien Nocera
Quoted 80 lines · Greg Kroah-Hartman
Quoted 70 lines · Bastien Nocera
Quoted 60 lines · Greg Kroah-Hartman
Quoted 53 lines · Marcel Holtmann

Hi Greg,

Quoted 51 lines
Quoted 36 lines
Quoted 31 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2
as it
breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list

when
updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++----------------------
----
---------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system.  I finally got the time
to do
bisection today, and it came down to this patch. Reverting
it on top of
5.9-rc7 restored bluetooth devices and now my input devices
properly
work.

Quoted 4 lines

As it's almost 5.9-final, any chance this can be merged now
to fix the
issue?

Quoted 5 lines

can you be specific what breaks since our guys and I also think
the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all.  With this reverted, it
all "just works".

Same I think for a Bluetooth headset, can check that again if you
really
need me to, but the trackball is reliable here.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 8 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog
and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

Quoted 8 lines

Use bluetoothctl instead, the Bluetooth Settings from GNOME also run a
discovery the whole time the panel is opened, and this breaks a fair
number of poor quality adapters. This is worked-around in the most recent version, but using bluetoothctl is a better debugging option in
all cases.

Quoted 3 lines

Ok, but how do I use that tool?  How do I shut down the gnome bluetooth
stuff?

Quoted 7 lines

You close the settings window...

Quoted 1 line

I need newbie steps here please for what to run and what to show you.

bluetoothctl connect "bluetooth address"
eg.
bluetoothctl connect "12:34:56:78:90"

Ok, here that is on a clean 5.9-rc8 release:

$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed

I've attached the trace log from that effort.

I'll go try Marcel's proposed patch now as well...

thanks,

greg k-h

btsnoop�!!�� ⎛M#=�Linux version 5.9.0-rc8 (x86_64)!!�� ⎛M#=�Bluetooth subsystem version 2.22⎛M#=�pe���Phci0⎛M#=�
⎛M#=�pe���P��⎛M#=�bluetoothd ⎛N�B ⎛N�gB ⎛N݌A ⎛N�tA ⎛N��B ⎛N�B ⎛P�.)B ⎛P� �B ⎛P� �A 0⎛P�,NA ⎛P�,�B ⎛P�:B

author Tested-by
#11 lore raw
In reply to Marcel Holtmann
Quoted 73 lines · Marcel Holtmann

Hi Greg,

Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
                return -1;
 
        /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
            hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
                return -1;
        }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
                }
 
                /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                    hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                        return 0x00;
                }
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

Anyway, feel free to put:

on the above patch and hopefully get it to Linus for 5.9-final.

thanks,

greg k-h

maintainer
#12 lore raw

Hi Greg,

Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
               return -1;
 
       /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
           hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
               return -1;
       }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
               }
 
               /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                   hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                       return 0x00;
               }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 7 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

Quoted 5 lines

Anyway, feel free to put:

on the above patch and hopefully get it to Linus for 5.9-final.

Sadly, it is a poor hot-needle fix.

Regards

Marcel

#13 lore raw
Quoted 82 lines · Marcel Holtmann

Hi Greg,

Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
               return -1;
 
       /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
           hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
               return -1;
       }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
               }
 
               /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                   hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                       return 0x00;
               }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

thanks,

greg k-h

maintainer
#14 lore raw

Hi Greg,

Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
              return -1;
 
      /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
          hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
              return -1;
      }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
              }
 
              /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                  hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                      return 0x00;
              }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Anyhow, if my suspicion is correct, then I just need to figure out on how we fix this for 5.9-rc8 and also net-next. We might have to have two different patches. Just carrying the revert forward is going to cause some complicated merging and a broken -next.

Regards

Marcel

#15 lore raw
Quoted 105 lines · Marcel Holtmann

Hi Greg,

Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
              return -1;
 
      /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
          hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
              return -1;
      }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
              }
 
              /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                  hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                      return 0x00;
              }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

If there's anything else you need, just let me know.

thanks,

greg k-h

btsnoop�''�� ⎡�o��Linux version 5.9.0-rc8-dirty (x86_64)!!�� ⎡�o��Bluetooth subsystem version 2.22⎡�o��pe���Phci0⎡�o��
⎡�o��pe���P��⎡�o��bluetoothd ⎡�±�psy���⎡�²=⎡�ć>⎡��}B⎡��}qpsy��� ⎡�ɳBA `0⎡�ɾ�A ⎡�ɾ�B ⎡����B 55⎡��@�>3 ��!lT��& MyRun 1800407488⎡��Y/>6  Ҵ��X��o�o�>�w&�g��e�P���j =�77⎡��t�>5 ��k����LPv\���N!�������{�C��..⎡��k>, +S�nPU��
�LǑf�..⎡�̺�>, �o3q�f��
 �L<Ic�88⎡��b>6 ���c���>��.��?��EK3�l�& *%�c�Ϧ�88⎡�ͼh>6 h�)nZs������fM4Wt-UVwuAt���|&&⎡���v>$ 3�C�7��
�L
--⎡��JO>+ 3��;n��

�LE��;;⎡��R>9 �����o�o��$��̅�1JM�a�90�N}�;;⎡��Y�>9 ƃ�F��� '��w�eb���%�UD�9Q4��;;⎡��B>9 "Nʤ+��� w�.��C[��{���|�Z�r:��m--⎡��za>+ ��7�q��

�LW�� --⎡���>+ y{�"U��

�L�;�%%⎡��A�># Ix���� �� �⎡��b�> psy�����pe���P ⎡��b�B ⎡��n:B ⎡��naC psy��� ,�⎡��}�C !!⎡��H>
psy���,�⎡��h psy���⎡�� ⎡��>⎡��� ⎡��׻> ⎡���0 ���SΡ�1�C�A�:��+~,G�� ]$\⎡���i ⎡����⎡����| � ⎡���⎡��`| ⎡��2.+�⎡���⎡��5�. '�� ⎡��7�. ⎡��8�
⎡��S�.
'4��⎡��V

⎡���F. d ⎡����
⎡����.
'⎡����.
'⎡���n⎡���.  m�" ⎡���^
⎡���Z.
'⎡���K.
'⎡����⎡���.  MX Ergo ⎡���
⎡���.
'⎡�� �.
'⎡��!� ⎡��=. � ⎡��=e
⎡��?b.
'⎡��\6 ⎡��w�.   ⎡��x 
%⎡��z.
'��⎡���.
'���⎡����⎡����.  �� ��u% ⎡���0
)⎡��Ю.
'��⎡���T ⎡����.  ⎡���-
-⎡���*.
'��⎡�� � ⎡��'e.  ⎡��'�
0⎡��F� ⎡��a�.  ⎡��bJ
4⎡���*

⎡����. ⎡���� ��:+⎡���� ⎡���@. 
⎡��׏ ��(⎡���Z⎡��U.  
 ⎡���  %⎡��0�⎡��M. )��&�u � 0 1 ⎡��MW
(⎡��k� ⎡����.  ⎡���B
,⎡���" ⎡����. ⎡���� ��(⎡���⎡����.4 ⎡����  %,⎡��P⎡��7g. ��%u� 8��
8� ⎡��7� (⎡��U� ⎡��qI. ⎡��q� ,⎡���~ ⎡����.⎡���0 5��(⎡���⎡���%.5��m � ⎡���  %B⎡��.⎡��H. ��C�
��u�&� ⎡��H�  ⎡��h� ⎡����. ⎡���E  %X⎡���%⎡����.
 � ��

maintainer
#16 lore raw

Hi Greg,

Quoted 123 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
             return -1;
 
     /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
         hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
             return -1;
     }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
             }
 
             /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                 hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                     return 0x00;
             }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected
Quoted 5 lines

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Regards

Marcel

#17 lore raw
Quoted 129 lines · Marcel Holtmann

Hi Greg,

Quoted 127 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it breaks all bluetooth connections on my machine.

Cc Marcel Holtmann <[email protected]>
Cc Sathish Narsimman <[email protected]>
Fixes 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")

---
net/bluetooth/hci_request.c | 41 ++-----------------------------------

1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices stopped working on my desktop system. I finally got the time to do bisection today, and it came down to this patch. Reverting it on top of 5.9-rc7 restored bluetooth devices and now my input devices properly work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
             return -1;
 
     /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
         hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
             return -1;
     }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
             }
 
             /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                 hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                     return 0x00;
             }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

Quoted 5 lines
Quoted 1 line

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

f1:85:91:79:73:70 (type 1) f02567096e8537e5dac1cadf548fa750 00:00:00:00:00:00

Quoted 3 lines

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Ok, I did that, and reconnected, this is still with the kernel that has the patch. Want me to reboot to a "clean" 5.9-rc8?

thanks,

greg k-h

#18 lore raw
Quoted 130 lines · Greg Kroah-Hartman
Quoted 129 lines · Marcel Holtmann

Hi Greg,

Quoted 127 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc: Marcel Holtmann <[email protected]>
Cc: Sathish Narsimman <[email protected]>
Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++-----------------------------------
1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system. I finally got the time to do
bisection today, and it came down to this patch. Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

Quoted 5 lines
Quoted 2 lines

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
             return -1;
 
     /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
         hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
             return -1;
     }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
             }
 
             /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                 hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                     return 0x00;
             }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

f1:85:91:79:73:70 (type 1) f02567096e8537e5dac1cadf548fa750 00:00:00:00:00:00

I rebooted, and the same value was there.

Quoted 6 lines
Quoted 3 lines

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Ok, I did that, and reconnected, this is still with the kernel that has the patch. Want me to reboot to a "clean" 5.9-rc8?

I rebooted into a clean 5.9-rc8 and the device does not connect.

So I did the following to trace this:

$ sudo btmgmt irks
Identity Resolving Keys successfully loaded
$ sudo cat /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys
$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed

and ran another btmon session to see this, it is attached.

thanks,

greg k-h

btsnoop�!!�� ⎣L��Linux version 5.9.0-rc8 (x86_64)!!�� ⎣L��Bluetooth subsystem version 2.22⎣L��pe���Phci0⎣L��
⎣L��pe���P��⎣L��bluetoothd��⎣L@fbtmgmt⎣L@�0 ⎣L@�0��⎣L@� ⎣L{��B ⎣L~rB ⎣L~'A 0⎣L~ �A ⎣L~B ⎣L~DB ⎣ḾB ⎣M�UB ⎣M��A `⎣M�A ⎣M�,B ⎣MǨB ⎣O��2B ⎣O��8B ⎣O���A `0⎣O���A ⎣O���B ⎣O��\B

maintainer
#19 lore raw

Hi Greg,

Quoted 148 lines
Quoted 127 lines
Quoted 127 lines
Quoted 127 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines
Quoted 22 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc: Marcel Holtmann <[email protected]>
Cc: Sathish Narsimman <[email protected]>
Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++-----------------------------------
1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system. I finally got the time to do
bisection today, and it came down to this patch. Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really need me to, but the trackball is reliable here.

Quoted 1 line

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
            return -1;
 
    /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
        hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
            return -1;
    }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
            }
 
            /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                    return 0x00;
            }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

f1:85:91:79:73:70 (type 1) f02567096e8537e5dac1cadf548fa750 00:00:00:00:00:00

I rebooted, and the same value was there.

Quoted 6 lines
Quoted 3 lines

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Ok, I did that, and reconnected, this is still with the kernel that has the patch. Want me to reboot to a "clean" 5.9-rc8?

I rebooted into a clean 5.9-rc8 and the device does not connect.

So I did the following to trace this:

Quoted 8 lines
$ sudo btmgmt irks
Identity Resolving Keys successfully loaded
$ sudo cat /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys
$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed

and ran another btmon session to see this, it is attached.

this is confusing and makes no sense :(

What is the content of debug/bluetooth/hci0/whitelist and debug/bluetooth/hci0/device_list?

The only way I can explain this is that somehow the whitelist filter doesn’t get programmed correctly and thus the scan will not find your device. Why this points to use_ll_privacy() is totally unclear to me.

Btw. reboots won’t help since bluetoothd will restore from settings. You need to go into the files in /var/lib/bluetooth/ and look for an entry of IdentityResolvingKey for your device and remove it and then restart bluetoothd.

You can run btmon and will even show you what bluetoothd loads during start.

Can you try to do systemctl stop bluetooth, then start btmon and then systemctl start bluetooth. It should reprogram the controller and I could see the complete trace on how it sets up your hardware.

If this really breaks for your, it should have been broken for weeks for everybody. So this is the part that is confusing to me. And my original suspicion turned out to be wrong.

Regards

Marcel

#20 lore raw
Quoted 157 lines · Marcel Holtmann

Hi Greg,

Quoted 155 lines
Quoted 127 lines
Quoted 127 lines
Quoted 127 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 26 lines
Quoted 26 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc: Marcel Holtmann <[email protected]>
Cc: Sathish Narsimman <[email protected]>
Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++-----------------------------------
1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system. I finally got the time to do
bisection today, and it came down to this patch. Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it
all "just works".

Quoted 8 lines
Quoted 6 lines

Same I think for a Bluetooth headset, can check that again if you really
need me to, but the trackball is reliable here.

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
            return -1;
 
    /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
        hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
            return -1;
    }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
            }
 
            /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                    return 0x00;
            }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

f1:85:91:79:73:70 (type 1) f02567096e8537e5dac1cadf548fa750 00:00:00:00:00:00

I rebooted, and the same value was there.

Quoted 6 lines
Quoted 3 lines

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Ok, I did that, and reconnected, this is still with the kernel that has the patch. Want me to reboot to a "clean" 5.9-rc8?

I rebooted into a clean 5.9-rc8 and the device does not connect.

So I did the following to trace this:

$ sudo btmgmt irks
Identity Resolving Keys successfully loaded
$ sudo cat /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys
$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed
Quoted 5 lines
Quoted 1 line

and ran another btmon session to see this, it is attached.

this is confusing and makes no sense :(

What is the content of debug/bluetooth/hci0/whitelist and

# cat white_list
f1:85:91:79:73:70 (type 1)
Quoted 1 line

debug/bluetooth/hci0/device_list?

# cat device_list
2c:41:a1:4d:f2:2c (type 0)
f1:85:91:79:73:70 (type 1) 3
Quoted 8 lines

The only way I can explain this is that somehow the whitelist filter doesn’t get programmed correctly and thus the scan will not find your device. Why this points to use_ll_privacy() is totally unclear to me.

Btw. reboots won’t help since bluetoothd will restore from settings. You need to go into the files in /var/lib/bluetooth/ and look for an entry of IdentityResolvingKey for your device and remove it and then restart bluetoothd.

I see that entry in there, let me remove it...

Quoted 5 lines

You can run btmon and will even show you what bluetoothd loads during start.

Can you try to do systemctl stop bluetooth, then start btmon and then systemctl start bluetooth. It should reprogram the controller and I could see the complete trace on how it sets up your hardware.

Ok, I remove the entry for IdentityResolvingKey and restarted bluetoothd and now it works on a clean 5.9-rc8!

I'll stop it again and run the monitor and attach it below when it starts back up.

Ah, I did just that, and it did not connect this time. Attached is the trace. No IdentityResolvingKey entries anywhere...

Quoted 3 lines

If this really breaks for your, it should have been broken for weeks for everybody. So this is the part that is confusing to me. And my original suspicion turned out to be wrong.

Some bluetoothd interaction?

thanks,

greg k-h

btsnoop�!!�� �ǥ��8Linux version 5.9.0-rc8 (x86_64)!!�� �ǥ��:Bluetooth subsystem version 2.22�ǥ��;pe���Phci0##�� �Ǧ�# bluetoothdBluetooth daemon 5.55||�� �Ǧ�| bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRPageScanType” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRPageScanInterval” in group “Controller”~~�� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRPageScanWindow” in group “Controller”�� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRInquiryScanType” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRInquiryScanInterval” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRInquiryScanWindow” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRLinkSupervisionTimeout” in group “Controller”{{�� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRPageTimeout” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRMinSniffInterval” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “BRMaxSniffInterval” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEMinAdvertisementInterval” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEMaxAdvertisementInterval” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEMultiAdvertisementRotationInterval” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanIntervalAutoConnect” in group “Controller”���� �Ǧ� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanWindowAutoConnect” in group “Controller”���� �Ǧ�
 bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanIntervalSuspend” in group “Controller”���� �Ǧ� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanWindowSuspend” in group “Controller”���� �Ǧ� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanIntervalDiscovery” in group “Controller”���� �Ǧ�% bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanWindowDiscovery” in group “Controller”���� �Ǧ�. bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanIntervalAdvMonitor” in group “Controller”���� �Ǧ�6 bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanWindowAdvMonitor” in group “Controller”���� �Ǧ�? bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanIntervalConnect” in group “Controller”���� �Ǧ�G bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEScanWindowConnect” in group “Controller”���� �Ǧ�P bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEMinConnectionInterval” in group “Controller”���� �Ǧ�Y bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEMaxConnectionInterval” in group “Controller”���� �Ǧ�q bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEConnectionLatency” in group “Controller”���� �Ǧ�z bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEConnectionSupervisionTimeout” in group “Controller”���� �Ǧ�� bluetoothdsrc/main.c:parse_controller_config() Key file does not have key “LEAutoconnecttimeout” in group “Controller”���Ǧ�abluetoothd!!�� �Ǧ�� bluetoothdStarting SDP server���Ǧ � ���Ǧ �==�� �Ǧ � bluetoothdBluetooth management interface 1.18 initialized���Ǧ ������Ǧ �O&
 !"#$%&'()*+,-./0123456789:;<=>?@ABCFGHIJKLMNOPQRS
 !"#$%&'*���Ǧ � ���Ǧ ��Ǧ �!!�Ǧ �pe���P
���
thread�Ǧ� �Ǧ� �Ǧ�4�Ǧ�4�Ǧ/ �Ǧ/�
�ǦI33�ǦI�I��(�'��F�B�g�B޳�s�H���Ǧ4�4�_�� �Ǧ6�ǦN�4�_�� �ǦP�Ǧg�4�_��
 �Ǧi�Ǧ�=�Ǧ�=��Ǧ� �Ǧ��Ǧ��4�_�� �Ǧ��Ǧ��4�_��  �Ǧ� �Ǧ�'�Ǧ�'�Ǧ�3,�M�A,�Ǧ*,�M�A,�Ǧ3,�M�A,""�Ǧ(,�M�A,M������R t��*� �Ǧ,,,�ǦCpsy����C���SΡ�1�A�:��+~,G�� ]$\ �ǦD�Ǧ\0 �Ǧ^0�Ǧt5psy��� ,� �Ǧv5�Ǧ�3psy����Ǧ�*psy����Ǧ�3psy����Ǧ��4�_�� �Ǧ��Ǧ�(kF7 �Ǧ�(�Ǧ� �Ǧ�

�Ǧ�BlueZ 5.55  �ǦBlueZ 5.55**�ǦF���N�6�t�9A8hL�����|�"�V��_ �ǦF�Ǧ3 �Ǧ5�
�Ǧ%  �Ǧ%�
�Ǧ%. �Ǧ%0�
�Ǧ4[Ppsy����Ǧ4fPpsy���ZZ�� �ǦXh bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSource/VENDOR/LDAC\\�� �ǦX� bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSource/VENDOR/APTXHDZZ�� �ǦX� bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSource/VENDOR/APTXRR�� �ǦX� bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSource/AACRR�� �ǦX� bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSource/SBCZZ�� �ǦX� bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSink/VENDOR/APTXHDXX�� �ǦX� bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSink/VENDOR/APTXPP�� �ǦY bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSink/AACPP�� �ǦY bluetoothdEndpoint registered: sender=:1.76 path=/MediaEndpoint/A2DPSink/SBC�ǦY��4�_��
 �ǦY��ǦZ�4�_��  �ǦZ�ǦZ�4�_�� �ǦZ�ǦZ7�4�_�� �ǦZ9

�Ǧfthread  �Ǧf thread

#21 lore raw
Quoted 196 lines · Greg Kroah-Hartman
Quoted 157 lines · Marcel Holtmann

Hi Greg,

Quoted 155 lines
Quoted 127 lines
Quoted 127 lines
Quoted 127 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 35 lines
Quoted 34 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc: Marcel Holtmann <[email protected]>
Cc: Sathish Narsimman <[email protected]>
Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++-----------------------------------
1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system. I finally got the time to do
bisection today, and it came down to this patch. Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it
all "just works".

Same I think for a Bluetooth headset, can check that again if you really
need me to, but the trackball is reliable here.

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Quoted 7 lines

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog and it scans for devices in the area, but does not connect to my existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
            return -1;
 
    /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
        hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
            return -1;
    }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
            }
 
            /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                    return 0x00;
            }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

f1:85:91:79:73:70 (type 1) f02567096e8537e5dac1cadf548fa750 00:00:00:00:00:00

I rebooted, and the same value was there.

Quoted 6 lines
Quoted 3 lines

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Ok, I did that, and reconnected, this is still with the kernel that has the patch. Want me to reboot to a "clean" 5.9-rc8?

I rebooted into a clean 5.9-rc8 and the device does not connect.

So I did the following to trace this:

$ sudo btmgmt irks
Identity Resolving Keys successfully loaded
$ sudo cat /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys
$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed
Quoted 5 lines
Quoted 1 line

and ran another btmon session to see this, it is attached.

this is confusing and makes no sense :(

What is the content of debug/bluetooth/hci0/whitelist and

# cat white_list
f1:85:91:79:73:70 (type 1)
Quoted 1 line

debug/bluetooth/hci0/device_list?

# cat device_list
2c:41:a1:4d:f2:2c (type 0)
f1:85:91:79:73:70 (type 1) 3
Quoted 8 lines

The only way I can explain this is that somehow the whitelist filter doesn’t get programmed correctly and thus the scan will not find your device. Why this points to use_ll_privacy() is totally unclear to me.

Btw. reboots won’t help since bluetoothd will restore from settings. You need to go into the files in /var/lib/bluetooth/ and look for an entry of IdentityResolvingKey for your device and remove it and then restart bluetoothd.

I see that entry in there, let me remove it...

Quoted 5 lines

You can run btmon and will even show you what bluetoothd loads during start.

Can you try to do systemctl stop bluetooth, then start btmon and then systemctl start bluetooth. It should reprogram the controller and I could see the complete trace on how it sets up your hardware.

Ok, I remove the entry for IdentityResolvingKey and restarted bluetoothd and now it works on a clean 5.9-rc8!

I'll stop it again and run the monitor and attach it below when it starts back up.

Quoted 8 lines

Ah, I did just that, and it did not connect this time. Attached is the trace. No IdentityResolvingKey entries anywhere...

Quoted 3 lines

If this really breaks for your, it should have been broken for weeks for everybody. So this is the part that is confusing to me. And my original suspicion turned out to be wrong.

Some bluetoothd interaction?

Ok, rebooting to 5.9-rc8 again, all works fine. Restarting bluetoothd a few times, and then it stops working on the 2nd restart.

Logging out of GNOME and then back in, it's working again.

Ugh. Don't know what to say now, but 5.9-rc8 is working for me. I guess. Watch out for this with users when 5.9 is released if they end up with the same problem.

Let me do a jump back to 5.8 and then to 5.9 and see if that changes anything...

thanks,

greg k-h

#22 lore raw
Quoted 209 lines · Greg Kroah-Hartman
Quoted 196 lines · Greg Kroah-Hartman
Quoted 157 lines · Marcel Holtmann

Hi Greg,

Quoted 155 lines
Quoted 127 lines
Quoted 127 lines
Quoted 127 lines
Quoted 103 lines
Quoted 95 lines
Quoted 80 lines
Quoted 71 lines
Quoted 71 lines
Quoted 42 lines

This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
breaks all bluetooth connections on my machine.

Cc: Marcel Holtmann <[email protected]>
Cc: Sathish Narsimman <[email protected]>
Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/bluetooth/hci_request.c | 41 ++-----------------------------------
1 file changed, 2 insertions(+), 39 deletions(-)

This has been bugging me for since 5.9-rc1, when all bluetooth devices
stopped working on my desktop system. I finally got the time to do
bisection today, and it came down to this patch. Reverting it on top of
5.9-rc7 restored bluetooth devices and now my input devices properly
work.

As it's almost 5.9-final, any chance this can be merged now to fix the
issue?

can you be specific what breaks since our guys and I also think the
ChromeOS guys have been testing these series of patches heavily.

My bluetooth trackball does not connect at all. With this reverted, it
all "just works".

Same I think for a Bluetooth headset, can check that again if you really
need me to, but the trackball is reliable here.

When you run btmon does it indicate any errors?

How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

Ok, attached.

The device is not connecting, and then I open the gnome bluetooth dialog
and it scans for devices in the area, but does not connect to my
existing devices at all.

Any ideas?

the trace file is from -rc7 or from -rc7 with this patch reverted?

I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.

net/bluetooth/hci_request.c +2 -2
index e0269192f2e5..94c0daa9f28d 100644
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
            return -1;
 
    /* White list can not be used with RPAs */
-       if (!allow_rpa && !use_ll_privacy(hdev) &&
+       if (!allow_rpa &&
        hci_find_irk_by_addr(hdev, &params->addr, params->addr_type)) {
            return -1;
    }
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
            }
 
            /* White list can not be used with RPAs */
-               if (!allow_rpa && !use_ll_privacy(hdev) &&
+               if (!allow_rpa &&
                hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
                    return 0x00;
            }
Quoted 3 lines
Quoted 1 line

If you just do the above, does thing work for you again?

Corrupted white-space issues aside, yes, it works!

I just pasted it from a different terminal ;)

Quoted 3 lines

I am running 5.9-rc8 with just this change on it and my tracball works just fine.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.

How would one go about enabling such a hardware feature if they wanted to? :)

I need to understand what is going wrong for you. I have a suspicion, but first I need to understand what kind of device you have. I hope the trace file is enough.

If you need any other information, just let me know, this is a USB Bluetooth controller from Intel:

	$ lsusb | grep Blue
	Bus 009 Device 002: ID 8087:0029 Intel Corp. AX200 Bluetooth
Quoted 7 lines

And the output of usb-devices for it:

	T:  Bus=09 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
	D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
	P:  Vendor=8087 ProdID=0029 Rev=00.01
	C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
	I:  If#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
	I:  If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
Quoted 3 lines

I already figured out that it is one of our controllers. The trace file gives it away.

So my suspicion is that the device you want to connect to uses RPA (aka random addresses). And we added support for resolving them in the firmware. Your hardware does support that, but the host side is not fully utilizing it and thus your device is filtered out.

Dude, get an email client that line-wraps :)

Quoted 3 lines

If I am not mistaken, then the use_ll_privacy() check in these two specific places need to be replaced with LL Privacy Enabled check. And then the allow_rpa condition will do its job as expected.

We can confirm this if you send me a trace with the patch applied.

Want me to disconnect the device and then reconnect it using bluetootctl? I'll go do that now...

Ok, it's attached, I did:

$ bluetoothctl disconnect F1:85:91:79:73:70
Attempting to disconnect from F1:85:91:79:73:70
[CHG] Device F1:85:91:79:73:70 ServicesResolved: no
Successful disconnected

And then the gnome bluetooth daemon (or whatever it has) reconnected it automatically, so you can see the connection happen, and some movements in the log.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

If there's anything else you need, just let me know.

so the trace file indicates that you are using static addresses and not RPAs. Now I am confused.

What is the content of /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys?

f1:85:91:79:73:70 (type 1) f02567096e8537e5dac1cadf548fa750 00:00:00:00:00:00

I rebooted, and the same value was there.

Quoted 6 lines
Quoted 3 lines

The only way I can explain this if you have an entry in that file, but the device is not using it.

If you have btmgmt (from bluez.git) you can try "./tools/btmgmt irks” to clear that list and try again.

Ok, I did that, and reconnected, this is still with the kernel that has the patch. Want me to reboot to a "clean" 5.9-rc8?

I rebooted into a clean 5.9-rc8 and the device does not connect.

So I did the following to trace this:

$ sudo btmgmt irks
Identity Resolving Keys successfully loaded
$ sudo cat /sys/kernel/debug/bluetooth/hci0/identity_resolving_keys
$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed
Quoted 5 lines
Quoted 1 line

and ran another btmon session to see this, it is attached.

this is confusing and makes no sense :(

What is the content of debug/bluetooth/hci0/whitelist and

# cat white_list
f1:85:91:79:73:70 (type 1)
Quoted 1 line

debug/bluetooth/hci0/device_list?

# cat device_list
2c:41:a1:4d:f2:2c (type 0)
f1:85:91:79:73:70 (type 1) 3
Quoted 8 lines

The only way I can explain this is that somehow the whitelist filter doesn’t get programmed correctly and thus the scan will not find your device. Why this points to use_ll_privacy() is totally unclear to me.

Btw. reboots won’t help since bluetoothd will restore from settings. You need to go into the files in /var/lib/bluetooth/ and look for an entry of IdentityResolvingKey for your device and remove it and then restart bluetoothd.

I see that entry in there, let me remove it...

Quoted 5 lines

You can run btmon and will even show you what bluetoothd loads during start.

Can you try to do systemctl stop bluetooth, then start btmon and then systemctl start bluetooth. It should reprogram the controller and I could see the complete trace on how it sets up your hardware.

Ok, I remove the entry for IdentityResolvingKey and restarted bluetoothd and now it works on a clean 5.9-rc8!

I'll stop it again and run the monitor and attach it below when it starts back up.

Quoted 8 lines

Ah, I did just that, and it did not connect this time. Attached is the trace. No IdentityResolvingKey entries anywhere...

Quoted 3 lines

If this really breaks for your, it should have been broken for weeks for everybody. So this is the part that is confusing to me. And my original suspicion turned out to be wrong.

Some bluetoothd interaction?

Ok, rebooting to 5.9-rc8 again, all works fine. Restarting bluetoothd a few times, and then it stops working on the 2nd restart.

Quoted 8 lines

Logging out of GNOME and then back in, it's working again.

Ugh. Don't know what to say now, but 5.9-rc8 is working for me. I guess. Watch out for this with users when 5.9 is released if they end up with the same problem.

Let me do a jump back to 5.8 and then to 5.9 and see if that changes anything...

And in 5.8.14 the "restart bluetoothd a bunch of times causes problems" is the same thing here, and logging out and then back into GNOME solves it.

So that's not 5.9-rc specific.

Anything else you want me to try?

thanks,

greg k-h