Skip to contentSkip to conversation

USB: serial: option: Add Telit FT980-KS composition

PATCH In review Leonid Bloch 2 participants 2 messages Oct 4, 2020 – Oct 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 USB: serial: option: Add Telit FT980-KS composition

This commit adds the following Telit FT980-KS composition:

0x1054: rndis, diag, adb, nmea, modem, modem, aux

AT commands can be sent to /dev/ttyUSB2.

---

The full composition is not tested, and it is the default one according to Telit support. What is tested, is that this commit makes /dev/ttyUSB{0..4} appear upon connecting the FT980-KS, and allows sending AT commands to /dev/ttyUSB2.

Changes since v1:

* Interface #3 (ADB) is blacklisted.
* NCTRL flag is set to the diag interface.

These changes (relative to v1) also allow ModemManager to recognize the device.

 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/serial/option.c +2 -0
index 0c6f160a214a..fe76710167f8 100644
@@ -1186,6 +1186,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = NCTRL(2) | RSVD(3) },
 	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1053, 0xff),	/* Telit FN980 (ECM) */
 	  .driver_info = NCTRL(0) | RSVD(1) },
+	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1054, 0xff),	/* Telit FT980-KS */
+	  .driver_info = NCTRL(2) | RSVD(3) },
 	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910),
 	  .driver_info = NCTRL(0) | RSVD(1) | RSVD(3) },
 	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
Signature · 1 line
2.28.0
maintainer
#1 lore raw
Quoted 14 lines · Leonid Bloch

This commit adds the following Telit FT980-KS composition:

0x1054: rndis, diag, adb, nmea, modem, modem, aux

AT commands can be sent to /dev/ttyUSB2.

---

The full composition is not tested, and it is the default one according to Telit support. What is tested, is that this commit makes /dev/ttyUSB{0..4} appear upon connecting the FT980-KS, and allows sending AT commands to /dev/ttyUSB2.

Quoted 7 lines

Changes since v1:

* Interface #3 (ADB) is blacklisted.
* NCTRL flag is set to the diag interface.

These changes (relative to v1) also allow ModemManager to recognize the device.

Now applied.

And thanks for reviewing, Lars.

Johan