maintainers: add self to baseband maintainers
PATCH 1/1 maintainers: add self to baseband maintainers
From: Tom Rix <[email protected]>
I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.
--- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
@@ -18,7 +18,6 @@ Descriptions of section entries: K: Keyword regex pattern to match content. One regex pattern per line. Multiple K: lines acceptable. - General Project Administration ------------------------------
@@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr* Baseband API - EXPERIMENTAL M: Nicolas Chautru <[email protected]> +M: Tom Rix <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_bbdev/ F: doc/guides/prog_guide/bbdev.rst
Signature · 1 line
2.18.1
Hey Tom,
Thanks for your recent reviews.
My only concern with this is how in reality you would be able to serve the role of maintainer for these drivers/lib/test and engage in meaningful discussions?
Do you understand 3GPP and the related processing and what these devices are actually doing? Supporting them in linux and generic coding guide line review is one thing, but maintainer would need broader understanding arguably. I think you reviews are super valuable (dpdk coding guide lines, error handling...) and I can make sure to include you generally for review for all related contributions, I am just unsure whether in reality that corresponds to what would be required to be a maintainer. I am just thinking aloud here, let me know what you think
Thanks
Nic
Quoted 40 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 5, 2020 8:00 AM
To: [email protected]; Chautru, Nicolas <[email protected]>
Cc: [email protected]; Tom Rix <[email protected]>
Subject: [PATCH] maintainers: add self to baseband maintainersFrom: Tom Rix <[email protected]>
I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.
Signed-off-by Tom Rix <[email protected]>--- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)MAINTAINERS +1
-2@@ -18,7 +18,6 @@ Descriptions of section entries: K: Keyword regex pattern to match content. One regex pattern per line. Multiple K: lines acceptable. - General Project Administration ------------------------------@@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr* Baseband API - EXPERIMENTAL M: Nicolas Chautru <[email protected]> +M: Tom Rix <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_bbdev/ F: doc/guides/prog_guide/bbdev.rst --2.18.1
Quoted 6 lines · Nicolas
Hey Tom,
Thanks for your recent reviews.
My only concern with this is how in reality you would be able to serve the role of maintainer for thesedrivers/lib/testand engage in meaningful discussions?
Do you understand 3GPP and the related processing and what these devices are actually doing? Supporting them in linux and generic coding guide line review is one thing, but maintainer would need broader understanding arguably. I think you reviews are super valuable (dpdk coding guide lines, error handling...) and I can make sure to include you generally for review for all related contributions, I am just unsure whether in reality that corresponds to what would be required to be a maintainer. I am just thinking aloud here, let me know what you think
I share your concern.
I am interested in reviewing baseband changes.
In the kernel this is handled by the R: Reviewer tag which was part of the original patch.
When i submit kernel patches, i use the get_maintainter.pl script so i do not need to remember everyone interested. When i receive patches i look at just the cc,to's to figure out which project needs help. While you can create rules to look for strings in the subject line, it does not scale at all.
I went this new route based on Thomas' feed back on my original change.
Now with your feedback, is there a strong enough reason to accept my original change ?
If not, well that's ok.
Tom
Quoted 43 lines
Thanks
NicQuoted 40 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 5, 2020 8:00 AM
To: [email protected]; Chautru, Nicolas <[email protected]>
Cc: [email protected]; Tom Rix <[email protected]>
Subject: [PATCH] maintainers: add self to baseband maintainersFrom: Tom Rix <[email protected]>
I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.
Signed-off-by Tom Rix <[email protected]>--- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)MAINTAINERS +1
-2@@ -18,7 +18,6 @@ Descriptions of section entries: K: Keyword regex pattern to match content. One regex pattern per line. Multiple K: lines acceptable. - General Project Administration ------------------------------@@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr* Baseband API - EXPERIMENTAL M: Nicolas Chautru <[email protected]> +M: Tom Rix <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_bbdev/ F: doc/guides/prog_guide/bbdev.rst --2.18.1
Hi Tom,
I will let Thomas and Bruce chime in on this Reviewer-list concept, there is arguably merit to this given this is used in some linux foundation projects but probably needs generic discussion on the DPDK tech board. Specifically for bbdev for now, I can make sure to include you in.
Quoted 89 lines
-----Original Message-----
From: Tom Rix <[email protected]>
Sent: Monday, October 5, 2020 10:22 AM
To: Chautru, Nicolas <[email protected]>; [email protected]
Cc: [email protected]; Richardson, Bruce <[email protected]>
Subject: Re: [PATCH] maintainers: add self to baseband maintainersQuoted 3 lines · Nicolas
Hey Tom,
Thanks for your recent reviews.
My only concern with this is how in reality you would be able to serve therole of maintainer for these
drivers/lib/testand engage in meaningful discussions?Quoted 1 line
Do you understand 3GPP and the related processing and what these
devices are actually doing? Supporting them in linux and generic coding guide line review is one thing, but maintainer would need broader understanding arguably.
Quoted 1 line
I think you reviews are super valuable (dpdk coding guide lines, error
handling...) and I can make sure to include you generally for review for all related contributions, I am just unsure whether in reality that corresponds to what would be required to be a maintainer.
Quoted 1 line
I am just thinking aloud here, let me know what you think
I share your concern.
I am interested in reviewing baseband changes.
In the kernel this is handled by the R: Reviewer tag which was part of the original patch.
When i submit kernel patches, i use the get_maintainter.pl script so i do not need to remember everyone interested. When i receive patches i look at just the cc,to's to figure out which project needs help. While you can create rules to look for strings in the subject line, it does not scale at all.
I went this new route based on Thomas' feed back on my original change.
Now with your feedback, is there a strong enough reason to accept my original change ?
If not, well that's ok.
Tom
Quoted 7 lines
Thanks
NicQuoted 4 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 5, 2020 8:00 AM
To: [email protected]; Chautru, NicolasQuoted 36 lines
Quoted 36 lines
Cc: [email protected]; Tom Rix <[email protected]>
Subject: [PATCH] maintainers: add self to baseband maintainersFrom: Tom Rix <[email protected]>
I am a Linux kernel Reviewer for the fpga n3000/vista creek which has several bitstream based baseband devices. So I want to help out here as well.
Signed-off-by Tom Rix <[email protected]>--- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)MAINTAINERS index c0abbe0fc..22e80580a renamed from MAINTAINERS +0
-0100644
MAINTAINERS +1
-2@@ -18,7 +18,6 @@ Descriptions of section entries: K: Keyword regex pattern to match content. One regex pattern per line. Multiple K: lines acceptable. - General Project Administration ------------------------------@@ -392,6 +391,7 @@ F: lib/librte_ethdev/rte_mtr* Baseband API - EXPERIMENTAL M: Nicolas Chautru <[email protected]> +M: Tom Rix <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_bbdev/ F: doc/guides/prog_guide/bbdev.rst --2.18.1