drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns
PATCH 1/1 drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns
tree: https://android.googlesource.com/kernel/common android-mainline head: fedfc101f8f5356727d023c3ad47b2bafe316c8b commit: fedfc101f8f5356727d023c3ad47b2bafe316c8b [1/1] FROMLIST: scsi: ufs: clear uac for rpmb lun config: i386-randconfig-m021-20201004 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
smatch warnings:drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns '*hba->host->host_lock'. drivers/scsi/ufs/ufshcd.c:7443 ufshcd_clear_ua_wlun() warn: inconsistent returns 'flags'.
vim +7443 drivers/scsi/ufs/ufshcd.c
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7410 static int ufshcd_clear_ua_wlun(struct ufs_hba *hba, u8 wlun)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7411 {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7412 struct scsi_device *sdp;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7413 unsigned long flags;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7414 int ret = 0;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7415
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7416 spin_lock_irqsave(hba->host->host_lock, flags);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7417 if (wlun == UFS_UPIU_UFS_DEVICE_WLUN)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7418 sdp = hba->sdev_ufs_device;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7419 else if (wlun == UFS_UPIU_RPMB_WLUN)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7420 sdp = hba->sdev_rpmb;
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7421 else
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7422 return -EINVAL;
^^^^^^^^^^^^^^^Need to unlock before returning.
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7423
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7424 if (sdp) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7425 ret = scsi_device_get(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7426 if (!ret && !scsi_device_online(sdp)) {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7427 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7428 scsi_device_put(sdp);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7429 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7430 } else {
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7431 ret = -ENODEV;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7432 }
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7433 spin_unlock_irqrestore(hba->host->host_lock, flags);
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7434 if (ret)
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7435 goto out_err;
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7436
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7437 ret = ufshcd_send_request_sense(hba, sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7438 scsi_device_put(sdp);
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7439 out_err:
fc6762d925fd9e Jaegeuk Kim 2020-05-11 7440 if (ret)
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7441 dev_err(hba->dev, "%s: UAC clear LU=%x ret = %d\n",
fedfc101f8f535 Jaegeuk Kim 2020-10-05 7442 __func__, wlun, ret);fedfc101f8f535 Jaegeuk Kim 2020-10-05 @7443 return ret;fedfc101f8f535 Jaegeuk Kim 2020-10-05 7444 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org