drm/radeon: Add new callback that exposes vddc
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/3 drm/radeon: Add new callback that exposes vddc
From: Sandeep Raghuraman <[email protected]>
--- drivers/gpu/drm/radeon/radeon.h | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/radeon/radeon.h +1 -0
@@ -1992,6 +1992,7 @@ struct radeon_asic {int (*get_fan_speed_percent)(struct radeon_device *rdev,u32 *speed);u32 (*get_current_sclk)(struct radeon_device *rdev);u32 (*get_current_mclk)(struct radeon_device *rdev); +u16 (*get_current_vddc)(struct radeon_device *rdev); } dpm;/* pageflipping */ struct {
Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/3 drm/radeon: Add implementation of get_current_vddc for Sumo
In reply to a message not in the archiveFrom: Sandeep Raghuraman <[email protected]>
--- drivers/gpu/drm/radeon/radeon_asic.c | 1 + drivers/gpu/drm/radeon/radeon_asic.h | 1 + drivers/gpu/drm/radeon/sumo_dpm.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+)
drivers/gpu/drm/radeon/radeon_asic.c +1 -0
@@ -1513,6 +1513,7 @@ static struct radeon_asic sumo_asic = { .force_performance_level = &sumo_dpm_force_performance_level, .get_current_sclk = &sumo_dpm_get_current_sclk, .get_current_mclk = &sumo_dpm_get_current_mclk, + .get_current_vddc = &sumo_dpm_get_current_vddc, }, .pflip = { .page_flip = &evergreen_page_flip,
drivers/gpu/drm/radeon/radeon_asic.h +1 -0
@@ -596,6 +596,7 @@ int sumo_dpm_force_performance_level(struct radeon_device *rdev, enum radeon_dpm_forced_level level);u32 sumo_dpm_get_current_sclk (struct radeon_device *rdev);u32 sumo_dpm_get_current_mclk (struct radeon_device *rdev); +u16 sumo_dpm_get_current_vddc (struct radeon_device *rdev);/* * cayman
drivers/gpu/drm/radeon/sumo_dpm.c +20 -0
@@ -1865,6 +1865,26 @@ u32 sumo_dpm_get_current_mclk(struct radeon_device *rdev)return pi->sys_info.bootup_uma_clk; } +u16 sumo_dpm_get_current_vddc (struct radeon_device *rdev) +{ +struct sumo_power_info *pi =sumo_get_pi (rdev); +struct radeon_ps *rps = &pi->current_rps; +struct sumo_ps *ps =sumo_get_ps (rps); +struct sumo_pl *pl; +u32 current_index = + (RREG32 (TARGET_AND_CURRENT_PROFILE_INDEX ) &CURR_INDEX_MASK ) >> +CURR_INDEX_SHIFT ; + +if (current_index ==BOOST_DPM_LEVEL ) { + pl = &pi->boost_pl; + }else if (current_index >= ps->num_levels) { +return 0 ; + }else { + pl = &ps->levels[current_index]; + } +return sumo_convert_voltage_index_to_value (rdev, pl->vddc_index); +} +void sumo_dpm_fini (struct radeon_device *rdev) {int i;
Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 3/3 drm/radeon: Expose vddc through hwmon
In reply to a message not in the archiveFrom: Sandeep Raghuraman <[email protected]>
--- drivers/gpu/drm/radeon/radeon_pm.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_pm.c +28 -1
@@ -737,6 +737,26 @@ static ssize_t radeon_hwmon_show_sclk(struct device *dev, static SENSOR_DEVICE_ATTR(freq1_input, S_IRUGO, radeon_hwmon_show_sclk, NULL, 0); +static ssize_t radeon_hwmon_show_vddc (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct radeon_device *rdev =dev_get_drvdata (dev); +struct drm_device *ddev = rdev->ddev; +u16 vddc =0 ; + +/* Can't get vddc when the card is off */ +if ((rdev->flags &RADEON_IS_PX ) && + (ddev->switch_power_state !=DRM_SWITCH_POWER_ON )) +return -EINVAL ; + +if (rdev->asic->dpm.get_current_vddc) + vddc = rdev->asic->dpm.get_current_vddc (rdev); + +return snprintf (buf,PAGE_SIZE ,"%u\n" , vddc); +} + +static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, radeon_hwmon_show_vddc, NULL, + 0);static struct attribute *hwmon_attributes[] = { &sensor_dev_attr_temp1_input.dev_attr.attr,
@@ -747,6 +767,7 @@ static struct attribute *hwmon_attributes[] = { &sensor_dev_attr_pwm1_min.dev_attr.attr, &sensor_dev_attr_pwm1_max.dev_attr.attr, &sensor_dev_attr_freq1_input.dev_attr.attr, + &sensor_dev_attr_in0_input.dev_attr.attr, NULL };
@@ -765,7 +786,13 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, attr == &sensor_dev_attr_pwm1_enable.dev_attr.attr || attr == &sensor_dev_attr_pwm1_max.dev_attr.attr || attr == &sensor_dev_attr_pwm1_min.dev_attr.attr || - attr == &sensor_dev_attr_freq1_input.dev_attr.attr)) + attr == &sensor_dev_attr_freq1_input.dev_attr.attr || + attr == &sensor_dev_attr_in0_input.dev_attr.attr)) + return 0; + +/* Skip vddc attribute if get_current_vddc is not implemented */ +if (attr == &sensor_dev_attr_in0_input.dev_attr.attr && + !rdev->asic->dpm.get_current_vddc)return 0 ;/* Skip fan attributes if fan is not present */
Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re:
In reply to a message not in the archiveNACK for the entire lack of any form of commit description.
Am 08.10.20 um 20:16 schrieb [email protected]:
Quoted 8 lines
Signed-off-by Sandeep Raghuraman <[email protected]>_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: Re:
Hi
Am 09.10.20 um 08:47 schrieb Thomas Zimmermann:
Quoted 1 line
NACK for the entire lack of any form of commit description.
Please see the documentation at [1] on how to describe the changes and getting your patches merged.
Best regards
Thomas
[1]
https://dri.freedesktop.org/docs/drm/process/submitting-patches.html#describe-your-changes
Quoted 17 lines
Am 08.10.20 um 20:16 schrieb [email protected]:
Quoted 8 lines
Signed-off-by Sandeep Raghuraman <[email protected]>_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re:
Quoted 7 lines · Thomas Zimmermann
Hi
Am 09.10.20 um 08:47 schrieb Thomas Zimmermann:
Quoted 1 line
NACK for the entire lack of any form of commit description.
Please see the documentation at [1] on how to describe the changes and getting your patches merged.
Yes, I tried to use git send-email to send patches this time, and it resulted in this disaster. I'll stick to sending them through Thunderbird.
Quoted 5 lines
Best regards
Thomas[1]
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re:
Hi
Am 09.10.20 um 09:38 schrieb Sandeep Raghuraman:
Quoted 12 lines · Thomas Zimmermann
Quoted 7 lines
Hi
Am 09.10.20 um 08:47 schrieb Thomas Zimmermann:
Quoted 1 line
NACK for the entire lack of any form of commit description.
Please see the documentation at [1] on how to describe the changes and getting your patches merged.
Yes, I tried to use git send-email to send patches this time, and it resulted in this disaster. I'll stick to sending them through Thunderbird.
What's the problem with send-email?
A typical call for your patchset would look like
git send-mail <upstream-branch>...HEAD --cover-letter --annotate
--to=... --cc=...
That allows you to write the cover letter and have it sent out. IIRC you need ot set $EDITOR to your favorite text editor; and configure the SMTP server in ~/.gitconfig, under [sendemail].
Best regards
Thomas
Quoted 11 lines
Quoted 6 lines
Best regards
Thomas[1]
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re:
Quoted 19 lines · Thomas Zimmermann
Hi
Am 09.10.20 um 09:38 schrieb Sandeep Raghuraman:
Quoted 12 lines · Thomas Zimmermann
Quoted 7 lines
Hi
Am 09.10.20 um 08:47 schrieb Thomas Zimmermann:
Quoted 1 line
NACK for the entire lack of any form of commit description.
Please see the documentation at [1] on how to describe the changes and getting your patches merged.
Yes, I tried to use git send-email to send patches this time, and it resulted in this disaster. I'll stick to sending them through Thunderbird.
What's the problem with send-email?
Quoted 9 lines
A typical call for your patchset would look like
git send-mail <upstream-branch>...HEAD --cover-letter --annotate
--to=... --cc=...That allows you to write the cover letter and have it sent out. IIRC you need ot set $EDITOR to your favorite text editor; and configure the SMTP server in ~/.gitconfig, under [sendemail].
You can also do git format-patch -3 --cover-letter and manually edit the coverletter as needed then send them with git send-email.
Alex
Quoted 23 lines
Best regards
ThomasQuoted 11 lines
Quoted 6 lines
Best regards
Thomas[1]
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel