Skip to contentSkip to conversation

Fixing Lesser GPL version number [1/5]

PATCH In review Chetan Pant 3 participants 5 messages Oct 9, 2020 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 Fixing Lesser GPL version number [1/5]

There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Also, It came to notice that some of the files that were edited for the change were not following latest comment rules. For example using "//" to mark comment instead of "/*". That is also fixed in this patch.

This patch is divided in 5 parts, directory wise, in order to make reviewing process easier. Below listed are the parts of the patch, where asterisk denotes the part you are currently viewing.

[*] Files in authz/backends/block/linux-user/tests/migration directory (82 Files) [ ] Files in hw/include/disas (100 files)
[ ] Files inside target/ 'alpha,arm,cris,hppa,i386' (96 files)
[ ] Files inside target/ 'lm32,microblaze,mips,ppc,rx,sparc,tilegx,tricore,xtensa' (63 files) [ ] Files in ui/util/include/scripts and QEMU root directory (76 Files)

Below is how the license version was corrected:

1. To find the number of file having "Lesser GPL version 2 ":

	grep -l Lesser $(grep -rl "version 2 " * ) > result.dat

Total of 417 files were found (After manually exluding the files like COPYING and COPYING.LIB from the result)

2. To find the number of occurences of "version 2 " in the resulted files:

	egrep -c "version 2 " $(cat result.dat)

410 files had "version 2" occurence 1 time (name of those files was saved in one_timers.dat) and in 7 files "version 2" occurences were multiple times.

3. Files having occurence exactly 1 time were corrected using below command:

	sed -i "s/version 2 /version 2.1 /g" $(cat one_timers.dat)

For rest of 7 files, correction was done manually.

---
 authz/base.c                               | 2 +-
 authz/list.c                               | 2 +-
 authz/listfile.c                           | 2 +-
 authz/pamacct.c                            | 2 +-
 authz/simple.c                             | 2 +-
 backends/cryptodev-builtin.c               | 2 +-
 backends/cryptodev-vhost-user.c            | 2 +-
 backends/cryptodev-vhost.c                 | 2 +-
 backends/cryptodev.c                       | 2 +-
 backends/tpm/tpm_emulator.c                | 2 +-
 backends/tpm/tpm_passthrough.c             | 2 +-
 backends/tpm/tpm_util.c                    | 2 +-
 block/crypto.c                             | 2 +-
 block/crypto.h                             | 2 +-
 linux-user/aarch64/target_cpu.h            | 2 +-
 linux-user/aarch64/target_structs.h        | 2 +-
 linux-user/alpha/target_cpu.h              | 2 +-
 linux-user/alpha/target_structs.h          | 2 +-
 linux-user/arm/target_cpu.h                | 2 +-
 linux-user/arm/target_structs.h            | 2 +-
 linux-user/cris/target_cpu.h               | 2 +-
 linux-user/cris/target_structs.h           | 2 +-
 linux-user/hppa/target_cpu.h               | 2 +-
 linux-user/hppa/target_structs.h           | 2 +-
 linux-user/i386/target_cpu.h               | 2 +-
 linux-user/i386/target_structs.h           | 2 +-
 linux-user/microblaze/target_cpu.h         | 2 +-
 linux-user/microblaze/target_structs.h     | 2 +-
 linux-user/mips/target_cpu.h               | 2 +-
 linux-user/mips/target_structs.h           | 2 +-
 linux-user/mips64/target_cpu.h             | 2 +-
 linux-user/nios2/target_cpu.h              | 2 +-
 linux-user/nios2/target_structs.h          | 2 +-
 linux-user/ppc/target_cpu.h                | 2 +-
 linux-user/ppc/target_structs.h            | 2 +-
 linux-user/ppc/target_syscall.h            | 2 +-
 linux-user/s390x/target_structs.h          | 2 +-
 linux-user/sparc/target_cpu.h              | 2 +-
 linux-user/sparc/target_structs.h          | 2 +-
 linux-user/sparc64/target_structs.h        | 2 +-
 linux-user/tilegx/target_cpu.h             | 2 +-
 linux-user/tilegx/target_structs.h         | 2 +-
 linux-user/x86_64/target_structs.h         | 2 +-
 migration/tls.c                            | 2 +-
 migration/tls.h                            | 2 +-
 tests/acceptance/pc_cpu_hotplug_props.py   | 2 +-
 tests/acceptance/x86_cpu_model_versions.py | 2 +-
 tests/io-channel-helpers.c                 | 2 +-
 tests/io-channel-helpers.h                 | 2 +-
 tests/migration/guestperf-batch.py         | 2 +-
 tests/migration/guestperf-plot.py          | 2 +-
 tests/migration/guestperf.py               | 2 +-
 tests/migration/guestperf/comparison.py    | 2 +-
 tests/migration/guestperf/engine.py        | 2 +-
 tests/migration/guestperf/hardware.py      | 2 +-
 tests/migration/guestperf/plot.py          | 2 +-
 tests/migration/guestperf/progress.py      | 2 +-
 tests/migration/guestperf/report.py        | 2 +-
 tests/migration/guestperf/scenario.py      | 2 +-
 tests/migration/guestperf/shell.py         | 2 +-
 tests/migration/guestperf/timings.py       | 2 +-
 tests/migration/stress.c                   | 2 +-
 tests/test-authz-list.c                    | 2 +-
 tests/test-authz-listfile.c                | 2 +-
 tests/test-authz-pam.c                     | 2 +-
 tests/test-authz-simple.c                  | 2 +-
 tests/test-base64.c                        | 2 +-
 tests/test-bufferiszero.c                  | 2 +-
 tests/test-crypto-afsplit.c                | 2 +-
 tests/test-crypto-block.c                  | 2 +-
 tests/test-crypto-cipher.c                 | 2 +-
 tests/test-crypto-hash.c                   | 2 +-
 tests/test-crypto-ivgen.c                  | 2 +-
 tests/test-crypto-secret.c                 | 2 +-
 tests/test-crypto-xts.c                    | 2 +-
 tests/test-io-channel-buffer.c             | 2 +-
 tests/test-io-channel-command.c            | 2 +-
 tests/test-io-channel-file.c               | 2 +-
 tests/test-io-channel-socket.c             | 2 +-
 tests/test-io-task.c                       | 2 +-
 tests/test-qgraph.c                        | 2 +-
 tests/test-uuid.c                          | 2 +-
 82 files changed, 82 insertions(+), 82 deletions(-)
authz/base.c +1 -1
index c75bce3..f2b7fbe 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
authz/list.c +1 -1
index 28b9909..0e17eed 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
authz/listfile.c +1 -1
index cd6163a..c9dd116 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
authz/pamacct.c +1 -1
index c91593b..e67195f 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
authz/simple.c +1 -1
index ee061e9..18db035 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/cryptodev-builtin.c +1 -1
index c6edb1b..0671bf9 100644
@@ -9,7 +9,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/cryptodev-vhost-user.c +1 -1
index e1df073..bedb452 100644
@@ -9,7 +9,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/cryptodev-vhost.c +1 -1
index 8337c9a..8231e7f 100644
@@ -10,7 +10,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/cryptodev.c +1 -1
index 3f141f6..bf52476 100644
@@ -9,7 +9,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/tpm/tpm_emulator.c +1 -1
index 201cd38..a012adc 100644
@@ -14,7 +14,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/tpm/tpm_passthrough.c +1 -1
index 8f6f499..21b7459 100644
@@ -11,7 +11,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
backends/tpm/tpm_util.c +1 -1
index b58d298..e6aeb63 100644
@@ -8,7 +8,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
block/crypto.c +1 -1
index 0807557..aef5a57 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
block/crypto.h +1 -1
index c72c3de..72e792c 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/aarch64/target_cpu.h +1 -1
index 6cc02e7..97a477b 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/aarch64/target_structs.h +1 -1
index a4998a7..7c74834 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/alpha/target_cpu.h +1 -1
index ad408ab..dc2dd65 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/alpha/target_structs.h +1 -1
index db2bfe2..d91cebd 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/arm/target_cpu.h +1 -1
index 2747211..709d19b 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/arm/target_structs.h +1 -1
index 9a3dbce..339b070 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/cris/target_cpu.h +1 -1
index 74ead55..7f6cade 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/cris/target_structs.h +1 -1
index 76f9653..f949d23 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/hppa/target_cpu.h +1 -1
index 71654b3..aacf3e9 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/hppa/target_structs.h +1 -1
index b560b18..b7cf4a3 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/i386/target_cpu.h +1 -1
index 2207d24..52caf78 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/i386/target_structs.h +1 -1
index 25388a7..e22847f 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/microblaze/target_cpu.h +1 -1
index ce7b22e..dcae2ab 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/microblaze/target_structs.h +1 -1
index 70dbdb6..d08f6a5 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/mips/target_cpu.h +1 -1
index 758ae4d..c375616 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/mips/target_structs.h +1 -1
index 909ba89..c1150fd 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/mips64/target_cpu.h +1 -1
index f16991b..2857a76 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/nios2/target_cpu.h +1 -1
index 50f0381..2d2008f 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/nios2/target_structs.h +1 -1
index 7145251..daa2886 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/ppc/target_cpu.h +1 -1
index 76b67d2..51ee148 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/ppc/target_structs.h +1 -1
index 6b1f579..520e326 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/ppc/target_syscall.h +1 -1
index c461f87..b9c4b81 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/s390x/target_structs.h +1 -1
index cadff6d..aab716e 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/sparc/target_cpu.h +1 -1
index 14b2158..1fa1011 100644
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/sparc/target_structs.h +1 -1
index ee24c3b..9953540 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/sparc64/target_structs.h +1 -1
index 1808132..4a8ed48 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/tilegx/target_cpu.h +1 -1
index 316b7a6..5fa9e2a 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/tilegx/target_structs.h +1 -1
index de8b1f2..1df000c 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
linux-user/x86_64/target_structs.h +1 -1
index b6e82a8..ce367b2 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
migration/tls.c +1 -1
index 66c6f43..abb149d 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
migration/tls.h +1 -1
index 0cfbe36..de4fe2c 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/acceptance/pc_cpu_hotplug_props.py +1 -1
index 08b7e63..e49bf33 100644
@@ -9,7 +9,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/acceptance/x86_cpu_model_versions.py +1 -1
index 01ff614..2b7461b 100644
@@ -9,7 +9,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/io-channel-helpers.c +1 -1
index ab988ef..ff156ed 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/io-channel-helpers.h +1 -1
index bb2de6f..3d14043 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf-batch.py +1 -1
index f1e9009..ab6bdb9 100755
@@ -7,7 +7,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf-plot.py +1 -1
index 9071510..32977b4 100755
@@ -7,7 +7,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf.py +1 -1
index ba1c4bc..e8cc127 100755
@@ -7,7 +7,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/comparison.py +1 -1
index d0b7df9..ba2edbe 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/engine.py +1 -1
index fd63c66..e2a214b 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/hardware.py +1 -1
index a66c9dd..3145785 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/plot.py +1 -1
index 34cebd5..30b3f66 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/progress.py +1 -1
index 46d2157..ab1ee57 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/report.py +1 -1
index 6a1f971..1efd40c 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/scenario.py +1 -1
index 705c2e8..28ef36c 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/shell.py +1 -1
index 5bcc066..f838888 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/guestperf/timings.py +1 -1
index f94d809..2374010 100644
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/migration/stress.c +1 -1
index 0c72a42..de45e8e 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-authz-list.c +1 -1
index d80e6a6..5351992 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-authz-listfile.c +1 -1
index 26166b6..64d0e15 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-authz-pam.c +1 -1
index 02bb149..1baeade 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-authz-simple.c +1 -1
index d21d43e..6f9034d 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-base64.c +1 -1
index a7f722c..3012d7b 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-bufferiszero.c +1 -1
index 42d194c..e45fd31 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-afsplit.c +1 -1
index f9f2fcd..00a7c18 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-block.c +1 -1
index 7c1ab07..3b1f0d5 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-cipher.c +1 -1
index bebba1a..280319a 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-hash.c +1 -1
index 214a9f7..ce7d0ab 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-ivgen.c +1 -1
index a5ff5d3..f581e6a 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-secret.c +1 -1
index 9d06176..34a4aec 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-crypto-xts.c +1 -1
index 6fb61cf..7acbc95 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-io-channel-buffer.c +1 -1
index 59d6c64..9c6724d 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-io-channel-command.c +1 -1
index 3bc5266..99056e0 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-io-channel-file.c +1 -1
index 0aa0477..29038e6 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-io-channel-socket.c +1 -1
index 743577d..c49eec1 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-io-task.c +1 -1
index 85e7a98..953a50a 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-qgraph.c +1 -1
index 267291c..ae2f7b2 100644
@@ -5,7 +5,7 @@
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
- * License version 2 as published by the Free Software Foundation.
+ * License version 2.1 as published by the Free Software Foundation.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
tests/test-uuid.c +1 -1
index 22b4b07..c111de5 100644
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
Signature · 1 line
2.17.1
#1 lore raw

On 10/9/20 1:37 AM, Chetan Pant wrote:

Thank you for contributing. However, it will require more work before this is ready to merge; while I have a lot of comments below, I hope you read them in the intended tone of ideas on making your v2 better. For more thoughts on patch submission, see
https://wiki.qemu.org/Contribute/SubmitAPatch

Your message was not threaded with the other 4 patches, nor did you put them in-reply-to a 0/5 cover letter. This makes it harder to keep the patches together in mail clients that sort by thread activity.

Quoted 3 lines

There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section.

I'm not a copyright lawyer; there may be legal ramifications for doing this on files where you are not the copyright owner, although to me it looks like an obvious correction of intent, so I'm okay with the idea.

Your subject line is awkward, for several reasons. First, it does not use imperative tense. A handy rule of thumb: try mentally prepending the phrase "apply this patch in order to..." in front of your git commit; where the implied lead-in tends to make sense only if the explicit text used imperative tense. So in this case, you would do s/Fixing/Fix/. More comments below [1]

Quoted 1 line

Also, It came to notice that some of the files that were edited for the change

s/It/I/

Quoted 2 lines

were not following latest comment rules. For example using "//" to mark comment instead of "/*". That is also fixed in this patch.

When writing a commit message that starts with "Also," that is a strong indication that you are fixing two distinct problems in one commit. Don't fall for that temptation - logically separate changes should be separate commits, as it makes review easier. I had to go check in this patch which file had the // comment change, but based on the diffstat alone, none of them did, which makes it feel like this is a stale copy-and-paste from one of your other commits in the series that merged too much work into one commit.

Quoted 9 lines

This patch is divided in 5 parts, directory wise, in order to make reviewing process easier. Below listed are the parts of the patch, where asterisk denotes the part you are currently viewing.

[*] Files in authz/backends/block/linux-user/tests/migration directory (82 Files) [ ] Files in hw/include/disas (100 files)
[ ] Files inside target/ 'alpha,arm,cris,hppa,i386' (96 files)
[ ] Files inside target/ 'lm32,microblaze,mips,ppc,rx,sparc,tilegx,tricore,xtensa' (63 files) [ ] Files in ui/util/include/scripts and QEMU root directory (76 Files)

[1]Back to the topic of the commit subject. A quick search of qemu.git history shows that using a [1/5] designation is invention:

$ git shortlog | grep '\[[0-9]*/[0-9]*'
      tests/fp: enable f128_to_ui[32/64] tests in float-to-uint
      fpu: convert float[16/32/64]_squash_denormal to new modern style

But if you drop the [1/5] designation, then you would be submitting five distinct patches with identical subjects, which is a backport nightmare.
Better is to leave the patch ordering information in JUST the initial
[PATCH n/m] prefix (since that prefix is auto-stripped by git am), and instead differentiate your subject lines with a topic.

Thus, maybe something like:

backends: Fix LGPL version number
disas: Fix LGPL version number
target: Fix LGPL version number

and so on. There may be a smarter division of the work based on which maintainer(s) will have to ack various patches; breaking the series into more than 5 chunks may be easier, although it then requires more topic lines. Or, if it truly is automated, doing it all in one shot may be best after all.

Quoted 6 lines

Below is how the license version was corrected:

1. To find the number of file having "Lesser GPL version 2 ":

	grep -l Lesser $(grep -rl "version 2 " * ) > result.dat

Total of 417 files were found (After manually exluding the files like COPYING and COPYING.LIB from the result)

excluding

Long line; try to keep commit message bodies wrapped at column 72 or less (since 'git log' displays them with indentation, and it is still common to read git log in an 80-column window)

Quoted 2 lines

2. To find the number of occurences of "version 2 " in the resulted files:

occurrances

Quoted 5 lines
	egrep -c "version 2 " $(cat result.dat)

410 files had "version 2" occurence 1 time (name of those files was saved in one_timers.dat) and in 7 files "version 2" occurences were multiple times.

3. Files having occurence exactly 1 time were corrected using below command:

three more of the same typo

Quoted 5 lines
	sed -i "s/version 2 /version 2.1 /g" $(cat one_timers.dat)

For rest of 7 files, correction was done manually.

---

I did not actually inspect the generated changes to see if they all look reasonable.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
#4 lore raw
In reply to Chetan Pant

On Fri, Oct 09, 2020 at 06:37:34AM +0000, Chetan Pant wrote:

I'll take the following if you can split them up into a couple of patches

Quoted 6 lines
---
 authz/base.c                               | 2 +-
 authz/list.c                               | 2 +-
 authz/listfile.c                           | 2 +-
 authz/pamacct.c                            | 2 +-
 authz/simple.c                             | 2 +-

Split these into an "authz" patch.

Quoted 2 lines
 block/crypto.c                             | 2 +-
 block/crypto.h                             | 2 +-

Split these two into a "crypto" patch.

Quoted 2 lines
 tests/io-channel-helpers.c                 | 2 +-
 tests/io-channel-helpers.h                 | 2 +-

Split these into an "io" patch.

Also combine with the io/* cleanups in patch 2, and the tests/test-io-* cleanups later.

Quoted 5 lines
 tests/migration/guestperf-batch.py         | 2 +-
 tests/migration/guestperf-plot.py          | 2 +-
 tests/migration/guestperf.py               | 2 +-
 tests/migration/guestperf/comparison.py    | 2 +-
 tests/migration/guestperf/engine.py        | 2 +-
Quoted 8 lines
 tests/migration/guestperf/hardware.py      | 2 +-
 tests/migration/guestperf/plot.py          | 2 +-
 tests/migration/guestperf/progress.py      | 2 +-
 tests/migration/guestperf/report.py        | 2 +-
 tests/migration/guestperf/scenario.py      | 2 +-
 tests/migration/guestperf/shell.py         | 2 +-
 tests/migration/guestperf/timings.py       | 2 +-
 tests/migration/stress.c                   | 2 +-

Split these.

Quoted 4 lines
 tests/test-authz-list.c                    | 2 +-
 tests/test-authz-listfile.c                | 2 +-
 tests/test-authz-pam.c                     | 2 +-
 tests/test-authz-simple.c                  | 2 +-

Include in "authz" patch.

Quoted 7 lines
 tests/test-crypto-afsplit.c                | 2 +-
 tests/test-crypto-block.c                  | 2 +-
 tests/test-crypto-cipher.c                 | 2 +-
 tests/test-crypto-hash.c                   | 2 +-
 tests/test-crypto-ivgen.c                  | 2 +-
 tests/test-crypto-secret.c                 | 2 +-
 tests/test-crypto-xts.c                    | 2 +-

SPlit into a "crypto" patch

Quoted 5 lines
 tests/test-io-channel-buffer.c             | 2 +-
 tests/test-io-channel-command.c            | 2 +-
 tests/test-io-channel-file.c               | 2 +-
 tests/test-io-channel-socket.c             | 2 +-
 tests/test-io-task.c                       | 2 +-

Include in an "io" patch

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
In reply to Eric Blake
Quoted 7 lines · Eric Blake
Quoted 3 lines

There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section.

I'm not a copyright lawyer; there may be legal ramifications for doing this on files where you are not the copyright owner, although to me it looks like an obvious correction of intent, so I'm okay with the idea.

Yes, we've done exactly this same cleanup for various files before, and considered it acceptable since it is matching the intent.

Quoted 11 lines

Thus, maybe something like:

backends: Fix LGPL version number
disas: Fix LGPL version number
target: Fix LGPL version number

and so on. There may be a smarter division of the work based on which maintainer(s) will have to ack various patches; breaking the series into more than 5 chunks may be easier, although it then requires more topic lines. Or, if it truly is automated, doing it all in one shot may be best after all.

I'm happy to queue 80% of this patch, and a patch of patch 2, since they cover files in subsystems I maintain and the typos are largely my fault :-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
author
#3 lore raw

Hello,

Quoted 5 lines · Eric Blake

Thank you for contributing. However, it will require more work before this is ready to merge; while I have a lot of comments below, I hope you read them in the intended tone of ideas on making your v2 better. For more thoughts on patch submission, see
.

Thanks for the remarks Eric, they are definitely going to help me a lot in making v2 better.

Quoted 3 lines · Daniel P. Berrangé

I'm happy to queue 80% of this patch, and a patch of patch 2, since they cover files in subsystems I maintain and the typos are largely my fault :-)

Thanks Daniel, as the idea was to get familiar with the process of sending patches.
I’ll draft and split the patches again as per your and Eric’s comments and then send them again.

Regards,
Chetan P.

Quoted 45 lines · Daniel P. Berrangé
Quoted 2 lines · Eric Blake
Quoted 2 lines

There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch

replaces all

Quoted 1 line
Quoted 1 line

occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in

comment section.

Quoted 4 lines

I'm not a copyright lawyer; there may be legal ramifications for doing this on files where you are not the copyright owner, although to me it looks like an obvious correction of intent, so I'm okay with the idea.

Yes, we've done exactly this same cleanup for various files before, and considered it acceptable since it is matching the intent.

Quoted 11 lines

Thus, maybe something like:

backends: Fix LGPL version number
disas: Fix LGPL version number
target: Fix LGPL version number

and so on. There may be a smarter division of the work based on which maintainer(s) will have to ack various patches; breaking the series into more than 5 chunks may be easier, although it then requires more topic lines. Or, if it truly is automated, doing it all in one shot may be best after all.

I'm happy to queue 80% of this patch, and a patch of patch 2, since they cover files in subsystems I maintain and the typos are largely my fault :-)

Regards,
Daniel
--
|: https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
https://fstop138.berrange.com :|
|: https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|