Skip to contentSkip to conversation

ARM: dts: stm32: Consistently enable internal pull-ups for SD bus

PATCH New Marek Vasut 2 participants 3 messages Oct 9, 2020 – Dec 9, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Consistently enable internal pull-ups for SD bus

The default state of SD bus and clock line is logical HI. SD card IO is open-drain and pulls the bus lines LO. Always enable the SD bus pull ups to guarantee this behavior. Note that on systems with bus voltage level shifter on the SD bus, the pull ups might also be built into the level shifter, however that should have no negative impact.

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/dts/stm32mp15-pinctrl.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/dts/stm32mp15-pinctrl.dtsi +4 -4
index 154832983c..2f8ff44a7a 100644
@@ -1184,13 +1184,13 @@
 				 <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1_CMD */
 			slew-rate = <1>;
 			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
 		};
 		pins2 {
 			pinmux = <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1_CK */
 			slew-rate = <2>;
 			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
 		};
 	};
 
@@ -1340,13 +1340,13 @@
 				 <STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */
 			slew-rate = <1>;
 			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
 		};
 		pins2 {
 			pinmux = <STM32_PINMUX('E', 3, AF9)>; /* SDMMC2_CK */
 			slew-rate = <2>;
 			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
 		};
 	};
 
Signature · 1 line
2.28.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 1/1 ARM: dts: stm32: Consistently enable internal pull-ups for SD bus

Hi Marek,

Quoted 49 lines · Patrick DELAUNAY

From: Marek Vasut <[email protected]>
Sent: vendredi 9 octobre 2020 23:08

The default state of SD bus and clock line is logical HI. SD card IO is open-drain and pulls the bus lines LO. Always enable the SD bus pull ups to guarantee this behavior. Note that on systems with bus voltage level shifter on the SD bus, the pull ups might also be built into the level shifter, however that should have no negative impact.

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
  arch/arm/dts/stm32mp15-pinctrl.dtsi | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/dts/stm32mp15-pinctrl.dtsi +4 -5
index 154832983c..2f8ff44a7a 100644
@@ -1184,13 +1184,13 @@
  				 <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1_CMD */
  			slew-rate = <1>;
  			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
  		};
  		pins2 {
  			pinmux = <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1_CK */
  			slew-rate = <2>;
  			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
  		};
  	};
 
@@ -1340,13 +1340,13 @@
  				 <STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */
  			slew-rate = <1>;
  			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
  		};
  		pins2 {
  			pinmux = <STM32_PINMUX('E', 3, AF9)>; /* SDMMC2_CK */
  			slew-rate = <2>;
  			drive-push-pull;
-			bias-disable;
+			bias-pull-up;
  		};
  	};
 
--
Quoted 2 lines

2.28.0

I don't see consensus on this device tree modification in Linux kernel side [1].

And for the DH board the modification is now done in SOM dtsi files after [2].

So can I close this patchset in patchwork ?

And if the modification is accepted in kernel device tree , I will get it with my next device

tree alignment...

[1]
https://st-md-mailman.stormreply.com/pipermail/linux-stm32/2020-October/008554.html

[2] "ARM: dts: stm32: Enable internal pull-ups for SDMMC1 on DHCOM SoM
<http://patchwork.ozlabs.org/project/uboot/list/?series=217761>"

http://patchwork.ozlabs.org/project/uboot/list/?series=217761&state=*

Regards

Patrick

#3 lore raw

PATCH 1/1 ARM: dts: stm32: Consistently enable internal pull-ups for SD bus

On 12/9/20 11:22 AM, Patrick DELAUNAY wrote:

Hi,

[...]

Quoted 21 lines
Quoted 7 lines
(quoted diff) +0 -0
@@ -1340,13 +1340,13 @@

?????????????????? <STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */ ????????????? slew-rate = <1>;
????????????? drive-push-pull;
-??????????? bias-disable;
+??????????? bias-pull-up;
????????? };

Quoted 11 lines

????????? pins2 {
????????????? pinmux = <STM32_PINMUX('E', 3, AF9)>; /* SDMMC2_CK */ ????????????? slew-rate = <2>;
????????????? drive-push-pull;
-??????????? bias-disable;
+??????????? bias-pull-up;
????????? };
????? };

Signature · 1 line
2.28.0

I don't see consensus on this device tree modification in Linux kernel side [1].

Quoted 4 lines

And for the DH board the modification is now done in SOM dtsi files after [2].

So can I close this patchset in patchwork ?

Yes

Quoted 4 lines

And if the modification is accepted in kernel device tree , I will get it with my next device

tree alignment...

I plan to realign the DTs after 2021.01 is out too.