Skip to contentSkip to conversation

docs: submitting-patches: describe preserving review/test tags

PATCH Applied Krzysztof Kozlowski 2 participants 2 messages Oct 13, 2020 – Oct 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 docs: submitting-patches: describe preserving review/test tags

From time to time, the novice kernel contributors do not add Reviewed-by or Tested-by tags to the next versions of the patches. Mostly because they are unaware that responsibility of adding these tags in next version is on submitter, not maintainer.

---

Changes since v1:
1. Reword, following Jonathan suggestions.

---
 Documentation/process/submitting-patches.rst | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/process/submitting-patches.rst +7 -0
index 58586ffe2808..83d9a82055a7 100644
@@ -527,6 +527,13 @@ done on the patch.  Reviewed-by: tags, when supplied by reviewers known to
 understand the subject area and to perform thorough reviews, will normally
 increase the likelihood of your patch getting into the kernel.
 
+Both Tested-by and Reviewed-by tags, once received on mailing list from tester
+or reviewer, should be added by author to the applicable patches when sending
+next versions.  However if the patch has changed substantially in following
+version, these tags might not be applicable anymore and thus should be removed.
+Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
+in the patch changelog (after the '---' separator).
+
 A Suggested-by: tag indicates that the patch idea is suggested by the person
 named and ensures credit to the person for the idea. Please note that this
 tag should not be added without the reporter's permission, especially if the
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 7 lines · On Tue, 13 Oct 2020 18:27:25 +0200 Krzysztof Kozlowski <[email protected]> wrote:

From time to time, the novice kernel contributors do not add Reviewed-by or Tested-by tags to the next versions of the patches. Mostly because they are unaware that responsibility of adding these tags in next version is on submitter, not maintainer.

Quoted 7 lines

---

Changes since v1:
1. Reword, following Jonathan suggestions.

---
 Documentation/process/submitting-patches.rst | 7 +++++++
 1 file changed, 7 insertions(+)

Applied, thanks.

jon