Skip to contentSkip to conversation

RDMA/rxe - Respond to skb_clone failure in rxe_recv.c

PATCH In review Bob Pearson 3 participants 3 messages Oct 13, 2020 – Oct 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/rxe - Respond to skb_clone failure in rxe_recv.c

If skb_clone is unable to allocate memory for a new sk_buff this is not detected by the current code.

Check for a NULL return and continue. This is similar to other errors in this loop over QPs attached to the multicast address and consistent with the unreliable UD transport.

Fixes e7ec96fc7932f ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")
---
 drivers/infiniband/sw/rxe/rxe_recv.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/infiniband/sw/rxe/rxe_recv.c +3 -0
index 11f3daf20768..c9984a28eecc 100644
@@ -271,6 +271,9 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
 		else
 			per_qp_skb = skb;
 
+		if (unlikely(!per_qp_skb))
+			continue;
+
 		per_qp_pkt = SKB_TO_PKT(per_qp_skb);
 		per_qp_pkt->qp = qp;
 		rxe_add_ref(qp);
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 9 lines · Bob Pearson

If skb_clone is unable to allocate memory for a new sk_buff this is not detected by the current code.

Check for a NULL return and continue. This is similar to other errors in this loop over QPs attached to the multicast address and consistent with the unreliable UD transport.

Fixes e7ec96fc7932f ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")

Addresses-Coverity-ID: 1497804: Null pointer dereferences (NULL_RETURNS)

Thanks
Zhu Yanjun

Quoted 22 lines
---
 drivers/infiniband/sw/rxe/rxe_recv.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/infiniband/sw/rxe/rxe_recv.c +3 -1
index 11f3daf20768..c9984a28eecc 100644
@@ -271,6 +271,9 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
                else
                        per_qp_skb = skb;
 
+               if (unlikely(!per_qp_skb))
+                       continue;
+
                per_qp_pkt = SKB_TO_PKT(per_qp_skb);
                per_qp_pkt->qp = qp;
                rxe_add_ref(qp);
--

2.25.1

maintainer
#2 lore raw
In reply to Bob Pearson
Quoted 7 lines · Bob Pearson

If skb_clone is unable to allocate memory for a new sk_buff this is not detected by the current code.

Check for a NULL return and continue. This is similar to other errors in this loop over QPs attached to the multicast address and consistent with the unreliable UD transport.

Quoted 5 lines
Fixes e7ec96fc7932f ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")
---
 drivers/infiniband/sw/rxe/rxe_recv.c | 3 +++
 1 file changed, 3 insertions(+)

Subject should be 'RDMA/rxe:' not '-'

Place () after function names for clarity

Flow text to the full 76 lines

I fixed it all up and applied to for-next

Thanks,
Jason