Skip to contentSkip to conversation

gpio: 104-idi-48: improve code indentation

PATCH In review Deepak R Varma 2 participants 3 messages Oct 13, 2020 – Oct 14, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gpio: 104-idi-48: improve code indentation

Address code indentation warning messages by checkpatch script. Combine split function parameters on one line. This also resolves the "use tabs instead of space" warning by checkpatch script.

---
Changes since v1:
- Correct subject line per feedback from Greg KH.

 drivers/gpio/gpio-104-idi-48.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpio/gpio-104-idi-48.c +2 -4
index 94c3a9bc4e75..b132afaf7d99 100644
@@ -132,8 +132,7 @@ static void idi_48_irq_mask(struct irq_data *data)
 
 				outb(idi48gpio->cos_enb, idi48gpio->base + 7);
 
-				raw_spin_unlock_irqrestore(&idi48gpio->lock,
-						           flags);
+				raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
 			}
 
 			return;
@@ -166,8 +165,7 @@ static void idi_48_irq_unmask(struct irq_data *data)
 
 				outb(idi48gpio->cos_enb, idi48gpio->base + 7);
 
-				raw_spin_unlock_irqrestore(&idi48gpio->lock,
-						           flags);
+				raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
 			}
 
 			return;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 11 lines · Deepak R Varma

Address code indentation warning messages by checkpatch script. Combine split function parameters on one line. This also resolves the "use tabs instead of space" warning by checkpatch script.

---
Changes since v1:
- Correct subject line per feedback from Greg KH.

 drivers/gpio/gpio-104-idi-48.c | 6 ++----

For the outreachy project application, they do not accept patches outside of drivers/staging, as per the documentation. So I do not know why you are sending a patch for this to the outreachy list and not to the "correct" list for gpio patches.

Please do not work outside of drivers/staging/ for the outreachy process at this point in time.

thanks,

greg k-h

#2 lore raw
Quoted 13 lines · Greg KH
Quoted 11 lines · Deepak R Varma

Address code indentation warning messages by checkpatch script. Combine split function parameters on one line. This also resolves the "use tabs instead of space" warning by checkpatch script.

---
Changes since v1:
- Correct subject line per feedback from Greg KH.

 drivers/gpio/gpio-104-idi-48.c | 6 ++----
Quoted 7 lines

For the outreachy project application, they do not accept patches outside of drivers/staging, as per the documentation. So I do not know why you are sending a patch for this to the outreachy list and not to the "correct" list for gpio patches.

Please do not work outside of drivers/staging/ for the outreachy process at this point in time.

My apologies. I definitely missed the directory track. Will look into the drivers/staging only for now.

Thank you,
Deepak.

Quoted 4 lines

thanks,

greg k-h