xen/arm: Document the erratum #853709 related to Cortex A72
PATCH 1/1 xen/arm: Document the erratum #853709 related to Cortex A72
Workaround for Cortex-A57 erratum #852523 is already in Xen but Cortex-A72 erratum #853709 is not although it applies to the same issue.
--- docs/misc/arm/silicon-errata.txt | 1 + xen/arch/arm/domain.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-)
docs/misc/arm/silicon-errata.txt +1 -0
@@ -50,6 +50,7 @@ stable hypervisors. | ARM | Cortex-A57 | #834220 | ARM64_ERRATUM_834220 | | ARM | Cortex-A57 | #1319537 | N/A | | ARM | Cortex-A72 | #1319367 | N/A | +| ARM | Cortex-A72 | #853709 | N/A | | ARM | Cortex-A76 | #1165522 | N/A | | ARM | Neoverse-N1 | #1165522 | N/A | ARM | MMU-500 | #842869 | N/A |
xen/arch/arm/domain.c +4 -2
@@ -216,7 +216,8 @@ static void ctxt_switch_to(struct vcpu *n)WRITE_SYSREG64 (n->arch.ttbr1,TTBR1_EL1 );/* -* Erratum #852523: DACR32_EL2 must be restored before one of the +* Erratum #852523 (Cortex-A57) or erratum #853709 (Cortex-A72): +* DACR32_EL2 must be restored before one of the * following sysregs: SCTLR_EL1, TCR_EL1, TTBR0_EL1, TTBR1_EL1 or * CONTEXTIDR_EL1. */
@@ -245,7 +246,8 @@ static void ctxt_switch_to(struct vcpu *n)/* * This write to sysreg CONTEXTIDR_EL1 ensures we don't hit erratum -* #852523. I.e DACR32_EL2 is not correctly synchronized. +* #852523 (Cortex-A57) or #853709 (Cortex-A72). +* I.e DACR32_EL2 is not correctly synchronized. */ WRITE_SYSREG (n->arch.contextidr,CONTEXTIDR_EL1 );WRITE_SYSREG (n->arch.tpidr_el0,TPIDR_EL0 );
Signature · 1 line
2.28.0
Hi Michal,
Quoted 3 lines · Michal Orzel
Workaround for Cortex-A57 erratum #852523 is already in Xen but Cortex-A72 erratum #853709 is not although it applies to the same issue.
This commit message is a bit confusing because it implies that Xen doesn't workaround #852523. However, we do workaround it (there is no runtime check) but not document it.
So how about the following commit message?
"The Cortex-A72 erratum #853709 is the same as the Cortex-A57 erratum #852523. As the latter is already workaround, we only need to update the documentation."
Quoted 1 line
Signed-off-by Michal Orzel <[email protected]>
Other than the commit message, I have cross-checked with the documentation ([1]):
I can update the commit message on commit.
Cheers,
Quoted 33 lines
--- docs/misc/arm/silicon-errata.txt | 1 + xen/arch/arm/domain.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-)docs/misc/arm/silicon-errata.txt +1
-0@@ -50,6 +50,7 @@ stable hypervisors. | ARM | Cortex-A57 | #834220 | ARM64_ERRATUM_834220 | | ARM | Cortex-A57 | #1319537 | N/A | | ARM | Cortex-A72 | #1319367 | N/A | +| ARM | Cortex-A72 | #853709 | N/A | | ARM | Cortex-A76 | #1165522 | N/A | | ARM | Neoverse-N1 | #1165522 | N/A | ARM | MMU-500 | #842869 | N/A |xen/arch/arm/domain.c +2
-1@@ -216,7 +216,8 @@ static void ctxt_switch_to(struct vcpu *n)WRITE_SYSREG64 (n->arch.ttbr1,TTBR1_EL1 );/* -* Erratum #852523: DACR32_EL2 must be restored before one of the +* Erratum #852523 (Cortex-A57) or erratum #853709 (Cortex-A72): +* DACR32_EL2 must be restored before one of the * following sysregs: SCTLR_EL1, TCR_EL1, TTBR0_EL1, TTBR1_EL1 or * CONTEXTIDR_EL1. */
xen/arch/arm/domain.c static void ctxt_switch_to(struct vcpu *n) · line 253
Quoted 9 lines
xen/arch/arm/domain.c +2
-1@@ -245,7 +246,8 @@ static void ctxt_switch_to(struct vcpu *n)/* * This write to sysreg CONTEXTIDR_EL1 ensures we don't hit erratum -* #852523. I.e DACR32_EL2 is not correctly synchronized. +* #852523 (Cortex-A57) or #853709 (Cortex-A72). +* I.e DACR32_EL2 is not correctly synchronized. */ WRITE_SYSREG (n->arch.contextidr,CONTEXTIDR_EL1 );WRITE_SYSREG (n->arch.tpidr_el0,TPIDR_EL0 );
[1] https://developer.arm.com/documentation/epm012079/11/
Signature · 1 line
Julien Grall
Michal Orzel
Reviewed-by Julien GrallHi Julien,
I agree. You can update the commit message.
Thanks for review.
Michal
________________________________
From: Julien Grall <[email protected]>
Sent: Wednesday, October 14, 2020 12:56 PM
To: Michal Orzel <[email protected]>; [email protected] <[email protected]>
Cc: Stefano Stabellini <[email protected]>; Volodymyr Babchuk <[email protected]>; Bertrand Marquis <[email protected]>
Subject: Re: [PATCH] xen/arm: Document the erratum #853709 related to Cortex A72
Hi Michal,
Quoted 3 lines · Michal Orzel
Workaround for Cortex-A57 erratum #852523 is already in Xen but Cortex-A72 erratum #853709 is not although it applies to the same issue.
This commit message is a bit confusing because it implies that Xen doesn't workaround #852523. However, we do workaround it (there is no runtime check) but not document it.
So how about the following commit message?
"The Cortex-A72 erratum #853709 is the same as the Cortex-A57 erratum #852523. As the latter is already workaround, we only need to update the documentation."
Quoted 1 line
Signed-off-by Michal Orzel <[email protected]>
Other than the commit message, I have cross-checked with the documentation ([1]):
I can update the commit message on commit.
Cheers,
Quoted 33 lines
--- docs/misc/arm/silicon-errata.txt | 1 + xen/arch/arm/domain.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-)docs/misc/arm/silicon-errata.txt +1
-0@@ -50,6 +50,7 @@ stable hypervisors. | ARM | Cortex-A57 | #834220 | ARM64_ERRATUM_834220 | | ARM | Cortex-A57 | #1319537 | N/A | | ARM | Cortex-A72 | #1319367 | N/A | +| ARM | Cortex-A72 | #853709 | N/A | | ARM | Cortex-A76 | #1165522 | N/A | | ARM | Neoverse-N1 | #1165522 | N/A | ARM | MMU-500 | #842869 | N/A |xen/arch/arm/domain.c +2
-1@@ -216,7 +216,8 @@ static void ctxt_switch_to(struct vcpu *n)WRITE_SYSREG64 (n->arch.ttbr1,TTBR1_EL1 );/* -* Erratum #852523: DACR32_EL2 must be restored before one of the +* Erratum #852523 (Cortex-A57) or erratum #853709 (Cortex-A72): +* DACR32_EL2 must be restored before one of the * following sysregs: SCTLR_EL1, TCR_EL1, TTBR0_EL1, TTBR1_EL1 or * CONTEXTIDR_EL1. */
xen/arch/arm/domain.c static void ctxt_switch_to(struct vcpu *n) · line 253
Quoted 9 lines
xen/arch/arm/domain.c +2
-1@@ -245,7 +246,8 @@ static void ctxt_switch_to(struct vcpu *n)/* * This write to sysreg CONTEXTIDR_EL1 ensures we don't hit erratum -* #852523. I.e DACR32_EL2 is not correctly synchronized. +* #852523 (Cortex-A57) or #853709 (Cortex-A72). +* I.e DACR32_EL2 is not correctly synchronized. */ WRITE_SYSREG (n->arch.contextidr,CONTEXTIDR_EL1 );WRITE_SYSREG (n->arch.tpidr_el0,TPIDR_EL0 );
[1] https://developer.arm.com/documentation/epm012079/11/
--
Julien Grall
Quoted 3 lines · Michal Orzel
Hi Julien,
I agree. You can update the commit message.
Thanks. I have updated the commit message and committed it.
On a different topic, it looks like you are sending the e-mail with HTML. Would you mind to configure it to send plain text?
Cheers,
Signature · 1 line
Julien Grall
Hi,
Quoted 7 lines · Michal Orzel
Workaround for Cortex-A57 erratum #852523 is already in Xen but Cortex-A72 erratum #853709 is not although it applies to the same issue.
Signed-off-by Michal Orzel <[email protected]>
Change in commit message suggested by Julien is quite right and should be added.
Bertrand
Quoted 44 lines
---
docs/misc/arm/silicon-errata.txt| 1 +xen/arch/arm/domain.c| 6 ++++--2 files changed, 5 insertions(+), 2 deletions(-)docs/misc/arm/silicon-errata.txt +0
-0@@ -50,6 +50,7 @@ stable hypervisors.| ARM | Cortex-A57 | #834220 | ARM64_ERRATUM_834220 | | ARM | Cortex-A57 | #1319537 | N/A | | ARM | Cortex-A72 | #1319367 | N/A | +| ARM | Cortex-A72 | #853709 | N/A | | ARM | Cortex-A76 | #1165522 | N/A | | ARM | Neoverse-N1 | #1165522 | N/A | ARM | MMU-500 | #842869 | N/A |xen/arch/arm/domain.c +4
-2@@ -216,7 +216,8 @@ static void ctxt_switch_to(struct vcpu *n)WRITE_SYSREG64 (n->arch.ttbr1,TTBR1_EL1 );/* -* Erratum #852523: DACR32_EL2 must be restored before one of the +* Erratum #852523 (Cortex-A57) or erratum #853709 (Cortex-A72): +* DACR32_EL2 must be restored before one of the * following sysregs: SCTLR_EL1, TCR_EL1, TTBR0_EL1, TTBR1_EL1 or * CONTEXTIDR_EL1. */ @@ -245,7 +246,8 @@ static void ctxt_switch_to(struct vcpu *n)/* * This write to sysreg CONTEXTIDR_EL1 ensures we don't hit erratum -* #852523. I.e DACR32_EL2 is not correctly synchronized. +* #852523 (Cortex-A57) or #853709 (Cortex-A72). +* I.e DACR32_EL2 is not correctly synchronized. */ WRITE_SYSREG (n->arch.contextidr,CONTEXTIDR_EL1 );WRITE_SYSREG (n->arch.tpidr_el0,TPIDR_EL0 );Signature · 1 line
2.28.0