Skip to contentSkip to conversation

b4 Cc: lines

DISCUSSION Konstantin Ryabitsev 2 participants 2 messages Nov 24, 2020 – Nov 26, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Arnaldo Carvalho de Melo

First of all, thanks a lot for b4, I'm now using it regularly,
great tool!

My previous workflow involved a 'am' script that I would have to
use patch by patch, would go on it and collect Cc: lines, not just the ones in the patch itself, but the ones in the e-mail containing it, as I wanted to record that that group of people was actually made aware of that change.

Would it be possible to have something like a --cc to have that?

I added this feature to the latest master, but I'm not 100% sure if it's doing the right/useful thing. If we only look for Cc: addresses, then more often than not we just find mailing lists there:

----

$ b4 am -o/tmp [email protected] --cc-trailers
Looking up https://lore.kernel.org/r/20201124143848.874894-1-antonio.borneo%40st.com
Grabbing thread from lore.kernel.org/lkml
Analyzing 12 messages in the thread
Will use the latest revision: v2
You can pick other revisions using the -vN flag
---
Writing /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
  ✓ [PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift
    + Cc: [email protected]
    + Cc: Salil Mehta <[email protected]>
    + Cc: [email protected]
    + Cc: [email protected]
  ---
  ✓ Attestation-by: DKIM/st.com (From: [email protected])
---
Total patches: 1
---
 Link: https://lore.kernel.org/r/[email protected]
 Base: 9bd2702d292cb7b565b09e949d30288ab7a26d51
       git checkout -b v2_20201124_antonio_borneo_st_com 9bd2702d292cb7b565b09e949d30288ab7a26d51
       git am /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
----

Is it better to look both in To: and Cc:, or did you specifically intend to have just the Cc: header copied into the commit?

I'm also a bit worried that on some patches the Cc trailer list ends up fairly huge. Is that expected and okay?

-K

#2 lore raw

Em Tue, Nov 24, 2020 at 05:27:56PM -0500, Konstantin Ryabitsev escreveu:

Quoted 10 lines · Arnaldo Carvalho de Melo
Quoted 8 lines

First of all, thanks a lot for b4, I'm now using it regularly,
great tool!

My previous workflow involved a 'am' script that I would have to
use patch by patch, would go on it and collect Cc: lines, not just the ones in the patch itself, but the ones in the e-mail containing it, as I wanted to record that that group of people was actually made aware of that change.

Quoted 5 lines
Quoted 1 line

Would it be possible to have something like a --cc to have that?

I added this feature to the latest master, but I'm not 100% sure if it's doing the right/useful thing. If we only look for Cc: addresses, then more often than not we just find mailing lists there:

I'm using b4 and going thru all the patches, to read them one last time and do whatever adjustments to the cset logs, so I'll see how this goes with --cc.

Thanks for adding this feature!

- Arnaldo

Quoted 34 lines

----

$ b4 am -o/tmp [email protected] --cc-trailers
Looking up https://lore.kernel.org/r/20201124143848.874894-1-antonio.borneo%40st.com
Grabbing thread from lore.kernel.org/lkml
Analyzing 12 messages in the thread
Will use the latest revision: v2
You can pick other revisions using the -vN flag
---
Writing /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
  ✓ [PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift
    + Cc: [email protected]
    + Cc: Salil Mehta <[email protected]>
    + Cc: [email protected]
    + Cc: [email protected]
  ---
  ✓ Attestation-by: DKIM/st.com (From: [email protected])
---
Total patches: 1
---
 Link: https://lore.kernel.org/r/[email protected]
 Base: 9bd2702d292cb7b565b09e949d30288ab7a26d51
       git checkout -b v2_20201124_antonio_borneo_st_com 9bd2702d292cb7b565b09e949d30288ab7a26d51
       git am /tmp/v2_20201124_antonio_borneo_net_phy_realtek_read_actual_speed_on_rtl8211f_to_detect_downshift.mbx
----

Is it better to look both in To: and Cc:, or did you specifically intend to have just the Cc: header copied into the commit?

I'm also a bit worried that on some patches the Cc trailer list ends up fairly huge. Is that expected and okay?

-K

Signature · 1 line
- Arnaldo