Skip to contentSkip to conversation

mm-remove-src-dst-mm-parameter-in-copy_page_range.patch removed from -mm tree

merged [email protected] 1 participant 1 message Oct 14, 2020

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: mm: remove src/dst mm parameter in copy_page_range()
has been removed from the -mm tree. Its filename was
mm-remove-src-dst-mm-parameter-in-copy_page_range.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Peter Xu <[email protected]>
Subject: mm: remove src/dst mm parameter in copy_page_range()

Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork: Pass new vma pointer into copy_page_range()").

Jason Gunthorpe also reported that the ordering of copy_page_range() is odd. Since working at it, reorder the parameters to be logical, by (1) always put the dst_* fields to be before src_* fields, and (2) keep the same type of parameters together.

---

 include/linux/mm.h |    4 -
 kernel/fork.c      |    2 
 mm/memory.c        |  141 ++++++++++++++++++++++---------------------
 3 files changed, 76 insertions(+), 71 deletions(-)
include/linux/mm.h renamed from include/linux/mm.h~mm-remove-src-dst-mm-parameter-in-copy_page_range +2 -2
@@ -1653,8 +1653,8 @@ struct mmu_notifier_range;
 
 void free_pgd_range(struct mmu_gather *tlb, unsigned long addr,
 		unsigned long end, unsigned long floor, unsigned long ceiling);
-int copy_page_range(struct mm_struct *dst, struct mm_struct *src,
-		    struct vm_area_struct *vma, struct vm_area_struct *new);
+int
+copy_page_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma);
 int follow_pte_pmd(struct mm_struct *mm, unsigned long address,
 		   struct mmu_notifier_range *range,
 		   pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp);
kernel/fork.c renamed from kernel/fork.c~mm-remove-src-dst-mm-parameter-in-copy_page_range +1 -1
@@ -590,7 +590,7 @@ static __latent_entropy int dup_mmap(str
 
 		mm->map_count++;
 		if (!(tmp->vm_flags & VM_WIPEONFORK))
-			retval = copy_page_range(mm, oldmm, mpnt, tmp);
+			retval = copy_page_range(tmp, mpnt);
 
 		if (tmp->vm_ops && tmp->vm_ops->open)
 			tmp->vm_ops->open(tmp);
mm/memory.c renamed from mm/memory.c~mm-remove-src-dst-mm-parameter-in-copy_page_range +73 -68

291 lines not on this page · raw message

_

Patches currently in -mm which might be from [email protected] are