Skip to contentSkip to conversation

mmc: mtk-sd: change some dev_err into dev_dbg

PATCH New Fabien Parent 3 participants 3 messages Oct 15, 2020 – Oct 23, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: mtk-sd: change some dev_err into dev_dbg

dev_err has been used for debugging and a few dev_err message are printed for normal code execution. Make them dev_dbg instead.

---
 drivers/mmc/mtk-sd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/mmc/mtk-sd.c +3 -3
index bd1fb09d1c9b..40b0deb6b756 100644
@@ -1169,7 +1169,7 @@ skip_fall:
 			internal_delay |= (1 << i);
 	}
 
-	dev_err(dev, "Final internal delay: 0x%x\n", internal_delay);
+	dev_dbg(dev, "Final internal delay: 0x%x\n", internal_delay);
 
 	internal_delay_phase = get_best_delay(host, internal_delay);
 	clrsetbits_le32(tune_reg, MSDC_PAD_TUNE_CMDRRDLY_M,
@@ -1177,7 +1177,7 @@ skip_fall:
 			MSDC_PAD_TUNE_CMDRRDLY_S);
 
 skip_internal:
-	dev_err(dev, "Final cmd pad delay: %x\n", final_delay);
+	dev_dbg(dev, "Final cmd pad delay: %x\n", final_delay);
 	return final_delay == 0xff ? -EIO : 0;
 }
 
@@ -1263,7 +1263,7 @@ skip_fall:
 				host->hs200_write_int_delay <<
 				MSDC_PAD_TUNE_DATWRDLY_S);
 
-	dev_err(dev, "Final data pad delay: %x\n", final_delay);
+	dev_dbg(dev, "Final data pad delay: %x\n", final_delay);
 
 	return final_delay == 0xff ? -EIO : 0;
 }
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 mmc: mtk-sd: change some dev_err into dev_dbg

Quoted 32 lines

Subject: [PATCH] mmc: mtk-sd: change some dev_err into dev_dbg

dev_err has been used for debugging and a few dev_err message are printed for normal code execution. Make them dev_dbg instead.

---
 drivers/mmc/mtk-sd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/mmc/mtk-sd.c index renamed from drivers/mmc/mtk-sd.c +0 -0

bd1fb09d1c9b..40b0deb6b756 100644

drivers/mmc/mtk-sd.c +2 -3
@@ -1169,7 +1169,7 @@ skip_fall:
 			internal_delay |= (1 << i);
 	}
 
-	dev_err(dev, "Final internal delay: 0x%x\n", internal_delay);
+	dev_dbg(dev, "Final internal delay: 0x%x\n", internal_delay);
 
 	internal_delay_phase = get_best_delay(host, internal_delay);
 	clrsetbits_le32(tune_reg, MSDC_PAD_TUNE_CMDRRDLY_M, @@
-1177,7 +1177,7 @@ skip_fall:
 			MSDC_PAD_TUNE_CMDRRDLY_S);
 
 skip_internal:
-	dev_err(dev, "Final cmd pad delay: %x\n", final_delay);
+	dev_dbg(dev, "Final cmd pad delay: %x\n", final_delay);
 	return final_delay == 0xff ? -EIO : 0;  }

drivers/mmc/mtk-sd.c skip_fall: · line 1269

Quoted 8 lines
drivers/mmc/mtk-sd.c +1 -2
@@ -1263,7 +1263,7 @@ skip_fall:
 				host->hs200_write_int_delay <<
 				MSDC_PAD_TUNE_DATWRDLY_S);
 
-	dev_err(dev, "Final data pad delay: %x\n", final_delay);
+	dev_dbg(dev, "Final data pad delay: %x\n", final_delay);
 
 	return final_delay == 0xff ? -EIO : 0;  }
--
#2 lore raw

PATCH 1/1 mmc: mtk-sd: change some dev_err into dev_dbg

In reply to Fabien Parent
Quoted 5 lines · Fabien Parent

dev_err has been used for debugging and a few dev_err message are printed for normal code execution. Make them dev_dbg instead.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/b54cf971/attachment.sig>