Skip to contentSkip to conversation

mmc: sdhci-of-esdhc: set timeout to max before tuning

PATCH Superseded Michael Walle 3 participants 6 messages Oct 15, 2020 – Oct 21, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci-of-esdhc: set timeout to max before tuning

On rare occations there is the following error:

mmc0: Tuning timeout, falling back to fixed sampling clock

There are SD cards which takes a significant longer time to reply to the first CMD19 command. The eSDHC takes the data timeout value into account during the tuning period. The SDHCI core doesn't explicitly set this timeout for the tuning procedure. Thus on the slow cards, there might be a spurious "Buffer Read Ready" interrupt, which in turn triggers a wrong sequence of events. In the end this will lead to an unsuccessful tuning procedure and to the above error.

To workaround this, set the timeout to the maximum value (which is the best we can do) and the SDHCI core will take care of the proper timeout handling.

---
 drivers/mmc/host/sdhci-of-esdhc.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/mmc/host/sdhci-of-esdhc.c +11 -0
index 0b45eff6fed4..baf7801a1804 100644
@@ -1052,6 +1052,17 @@ static int esdhc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 
 	esdhc_tuning_block_enable(host, true);
 
+	/*
+	 * The eSDHC controller takes the data timeout value into account
+	 * during tuning. If the SD card is too slow sending the response, the
+	 * timer will expire and a "Buffer Read Ready" interrupt without data
+	 * is triggered. This leads to tuning errors.
+	 *
+	 * Just set the timeout to the maximum value because the core will
+	 * already take care of it in sdhci_send_tuning().
+	 */
+	sdhci_writeb(host, 0xe, SDHCI_TIMEOUT_CONTROL);
+
 	hs400_tuning = host->flags & SDHCI_HS400_TUNING;
 
 	do {
Signature · 1 line
2.20.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Michael Walle

On rare occations there is the following error:

mmc0: Tuning timeout, falling back to fixed sampling clock

There are SD cards which takes a significant longer time to reply to the first CMD19 command. The eSDHC takes the data timeout value into account during the tuning period. The SDHCI core doesn't explicitly set this timeout for the tuning procedure. Thus on the slow cards, there might be a spurious "Buffer Read Ready" interrupt, which in turn triggers a wrong sequence of events. In the end this will lead to an unsuccessful tuning procedure and to the above error.

Quoted 5 lines

To workaround this, set the timeout to the maximum value (which is the best we can do) and the SDHCI core will take care of the proper timeout handling.

Quoted 27 lines
---
 drivers/mmc/host/sdhci-of-esdhc.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/mmc/host/sdhci-of-esdhc.c +11 -0
index 0b45eff6fed4..baf7801a1804 100644
@@ -1052,6 +1052,17 @@ static int esdhc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 
 	esdhc_tuning_block_enable(host, true);
 
+	/*
+	 * The eSDHC controller takes the data timeout value into account
+	 * during tuning. If the SD card is too slow sending the response, the
+	 * timer will expire and a "Buffer Read Ready" interrupt without data
+	 * is triggered. This leads to tuning errors.
+	 *
+	 * Just set the timeout to the maximum value because the core will
+	 * already take care of it in sdhci_send_tuning().
+	 */
+	sdhci_writeb(host, 0xe, SDHCI_TIMEOUT_CONTROL);
+
 	hs400_tuning = host->flags & SDHCI_HS400_TUNING;
 
 	do {
#2 lore raw
In reply to Michael Walle
Quoted 13 lines · Michael Walle

On rare occations there is the following error:

mmc0: Tuning timeout, falling back to fixed sampling clock

There are SD cards which takes a significant longer time to reply to the first CMD19 command. The eSDHC takes the data timeout value into account during the tuning period. The SDHCI core doesn't explicitly set this timeout for the tuning procedure. Thus on the slow cards, there might be a spurious "Buffer Read Ready" interrupt, which in turn triggers a wrong sequence of events. In the end this will lead to an unsuccessful tuning procedure and to the above error.

Quoted 5 lines

To workaround this, set the timeout to the maximum value (which is the best we can do) and the SDHCI core will take care of the proper timeout handling.

Sound like this should be tagged for stable, right?

Kind regards
Uffe

Quoted 29 lines
---
 drivers/mmc/host/sdhci-of-esdhc.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/mmc/host/sdhci-of-esdhc.c +11 -1
index 0b45eff6fed4..baf7801a1804 100644
@@ -1052,6 +1052,17 @@ static int esdhc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 
        esdhc_tuning_block_enable(host, true);
 
+       /*
+        * The eSDHC controller takes the data timeout value into account
+        * during tuning. If the SD card is too slow sending the response, the
+        * timer will expire and a "Buffer Read Ready" interrupt without data
+        * is triggered. This leads to tuning errors.
+        *
+        * Just set the timeout to the maximum value because the core will
+        * already take care of it in sdhci_send_tuning().
+        */
+       sdhci_writeb(host, 0xe, SDHCI_TIMEOUT_CONTROL);
+
        hs400_tuning = host->flags & SDHCI_HS400_TUNING;
 
        do {
--

2.20.1

#3 lore raw

Am 2020-10-16 12:53, schrieb Ulf Hansson:

Quoted 14 lines · Michael Walle
Quoted 13 lines

On rare occations there is the following error:

mmc0: Tuning timeout, falling back to fixed sampling clock

There are SD cards which takes a significant longer time to reply to the first CMD19 command. The eSDHC takes the data timeout value into account during the tuning period. The SDHCI core doesn't explicitly set this timeout for the tuning procedure. Thus on the slow cards, there might be a spurious "Buffer Read Ready" interrupt, which in turn triggers a wrong sequence of events. In the end this will lead to an unsuccessful tuning procedure and to the above error.

Quoted 7 lines
Quoted 5 lines

To workaround this, set the timeout to the maximum value (which is the best we can do) and the SDHCI core will take care of the proper timeout handling.

Sound like this should be tagged for stable, right?

Yes, but I was unsure about that. I didn't find a lot of Fixes: tags in the history of this driver (eg. for errata etc.)

I could repost a v2 with a fixes tag if you like.

-michael

#4 lore raw
Quoted 26 lines · Michael Walle

Am 2020-10-16 12:53, schrieb Ulf Hansson:

Quoted 24 lines · Michael Walle
Quoted 23 lines

On rare occations there is the following error:

mmc0: Tuning timeout, falling back to fixed sampling clock

There are SD cards which takes a significant longer time to reply to the
first CMD19 command. The eSDHC takes the data timeout value into account
during the tuning period. The SDHCI core doesn't explicitly set this timeout for the tuning procedure. Thus on the slow cards, there might be
a spurious "Buffer Read Ready" interrupt, which in turn triggers a wrong
sequence of events. In the end this will lead to an unsuccessful tuning
procedure and to the above error.

To workaround this, set the timeout to the maximum value (which is the best we can do) and the SDHCI core will take care of the proper timeout
handling.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Sound like this should be tagged for stable, right?

Yes, but I was unsure about that. I didn't find a lot of Fixes: tags in the history of this driver (eg. for errata etc.)

I could repost a v2 with a fixes tag if you like.

If this is regression and you can point to a specific commit it fixes, then please yes!

Kind regards
Uffe

#5 lore raw

Am 2020-10-21 17:04, schrieb Ulf Hansson:

Quoted 31 lines · Michael Walle
Quoted 30 lines

Am 2020-10-16 12:53, schrieb Ulf Hansson:

Quoted 27 lines · Michael Walle
Quoted 18 lines

On rare occations there is the following error:

mmc0: Tuning timeout, falling back to fixed sampling clock

There are SD cards which takes a significant longer time to reply to the
first CMD19 command. The eSDHC takes the data timeout value into account
during the tuning period. The SDHCI core doesn't explicitly set this timeout for the tuning procedure. Thus on the slow cards, there might be
a spurious "Buffer Read Ready" interrupt, which in turn triggers a wrong
sequence of events. In the end this will lead to an unsuccessful tuning
procedure and to the above error.

Quoted 6 lines

To workaround this, set the timeout to the maximum value (which is the best we can do) and the SDHCI core will take care of the proper timeout
handling.

Sound like this should be tagged for stable, right?

Quoted 7 lines
Quoted 4 lines

Yes, but I was unsure about that. I didn't find a lot of Fixes: tags in the history of this driver (eg. for errata etc.)

I could repost a v2 with a fixes tag if you like.

If this is regression and you can point to a specific commit it fixes, then please yes!

That would be commit ba49cbd0936e ("mmc: sdhci-of-esdhc: add tuning support"). But as of today it isn't much left of that original code. So I don't know if adding that fixes tag will help a lot. Correct me if I'm wrong.

-michael