mmc: fsl_esdhc: fix up for eMMC HS400
cover mmc: fsl_esdhc: fix up for eMMC HS400
This patch-set provides fix up for eMMC HS400 for a potential DLL lock issue during mmc rescan.
Yangbo Lu (2):
mmc: fsl_esdhc: set sysctl register for clock initialization
mmc: fsl_esdhc: make sure delay chain locked for HS400
drivers/mmc/fsl_esdhc.c | 30 ++++++++++++++++++++++++++---- include/fsl_esdhc.h | 4 ++++ 2 files changed, 30 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 mmc: fsl_esdhc: set sysctl register for clock initialization
The initial clock setting should be through sysctl register only, while the mmc_set_clock() will call mmc_set_ios() introduce other configurations like bus width, mode, and so on.
--- drivers/mmc/fsl_esdhc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/fsl_esdhc.c +1 -1
@@ -715,7 +715,7 @@ static int esdhc_init_common(struct fsl_esdhc_priv *priv, struct mmc *mmc)esdhc_setbits32 (®s->sysctl,SYSCTL_HCKEN |SYSCTL_IPGEN );/* Set the initial clock speed */ -mmc_set_clock (mmc,400000 ,MMC_CLK_ENABLE ); +set_sysctl (priv, mmc,400000 );/* Disable the BRR and BWR bits in IRQSTAT */ esdhc_clrbits32 (®s->irqstaten,IRQSTATEN_BRR |IRQSTATEN_BWR );
Signature · 1 line
2.7.4
PATCH 1/2 mmc: fsl_esdhc: set sysctl register for clock initialization
Dear Yangbo,
Quoted 5 lines · Yangbo Lu
The initial clock setting should be through sysctl register only, while the
mmc_set_clock()will callmmc_set_ios()introduce other configurations like bus width, mode, and so on.Signed-off-by Yangbo Lu <[email protected]>
Best Regards,
Jaehoon Chung
Quoted 18 lines
--- drivers/mmc/fsl_esdhc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/fsl_esdhc.c +1
-1@@ -715,7 +715,7 @@ static int esdhc_init_common(struct fsl_esdhc_priv *priv, struct mmc *mmc)esdhc_setbits32 (®s->sysctl,SYSCTL_HCKEN |SYSCTL_IPGEN );/* Set the initial clock speed */ -mmc_set_clock (mmc,400000 ,MMC_CLK_ENABLE ); +set_sysctl (priv, mmc,400000 );/* Disable the BRR and BWR bits in IRQSTAT */ esdhc_clrbits32 (®s->irqstaten,IRQSTATEN_BRR |IRQSTATEN_BWR );
PATCH 2/2 mmc: fsl_esdhc: make sure delay chain locked for HS400
In reply to Yangbo LuFor eMMC HS400 mode, the DLL reset is a required step for mmc rescan. This step has not been documented in reference manual, but the RM will be fixed sooner or later.
This patch is to add the step of DLL reset, and make sure delay chain locked for HS400.
--- drivers/mmc/fsl_esdhc.c | 28 +++++++++++++++++++++++++--- include/fsl_esdhc.h | 4 ++++ 2 files changed, 29 insertions(+), 3 deletions(-)
drivers/mmc/fsl_esdhc.c +25 -3
@@ -70,7 +70,9 @@ struct fsl_esdhc {uint sdtimingctl;/* SD timing control register */ char reserved8[20 ];/* reserved */ uint dllcfg0;/* DLL config 0 register */ -char reserved9[680 ];/* reserved */ +char reserved9[12 ];/* reserved */ +uint dllstat0;/* DLL status 0 register */ +char reserved10[664 ];/* reserved */ uint esdhcctl;/* eSDHC control register */ };
@@ -617,9 +619,11 @@ static void esdhc_exit_hs400(struct fsl_esdhc_priv *priv)esdhc_tuning_block_enable (priv, false); } -static void esdhc_set_timing (struct fsl_esdhc_priv *priv,enum bus_mode mode) +static int esdhc_set_timing (struct fsl_esdhc_priv *priv,enum bus_mode mode) {struct fsl_esdhc *regs = priv->esdhc_regs; +ulong start; +u32 val;/* Exit HS400 mode before setting any other mode */ if (esdhc_read32(®s->tbctl) & HS400_MODE &&
@@ -640,17 +644,33 @@ static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode)esdhc_setbits32 (®s->dllcfg0,DLL_FREQ_SEL );esdhc_setbits32 (®s->dllcfg0,DLL_ENABLE ); + +esdhc_setbits32 (®s->dllcfg0,DLL_RESET ); +udelay (1 ); +esdhc_clrbits32 (®s->dllcfg0,DLL_RESET ); + + start =get_timer (0 ); + val =DLL_STS_SLV_LOCK ; +while (!(esdhc_read32 (®s->dllstat0) & val)) { +if (get_timer (start) >1000 ) { +printf ("fsl_esdhc: delay chain lock timeout\n" ); +return -ETIMEDOUT ; + } + } +esdhc_setbits32 (®s->tbctl,HS400_WNDW_ADJUST );esdhc_clock_control (priv, false);esdhc_flush_async_fifo (priv); }esdhc_clock_control (priv, true); +return 0 ; }static int esdhc_set_ios_common (struct fsl_esdhc_priv *priv,struct mmc *mmc) {struct fsl_esdhc *regs = priv->esdhc_regs; +int ret;if (priv->is_sdhc_per_clk) {/* Select to use peripheral clock */
@@ -667,7 +687,9 @@ static int esdhc_set_ios_common(struct fsl_esdhc_priv *priv, struct mmc *mmc)set_sysctl (priv, mmc, mmc->clock);/* Set timing */ -esdhc_set_timing (priv, mmc->selected_mode); + ret =esdhc_set_timing (priv, mmc->selected_mode); +if (ret) +return ret;/* Set the bus width */ esdhc_clrbits32 (®s->proctl,PROCTL_DTW_4 |PROCTL_DTW_8 );
include/fsl_esdhc.h +4 -0
@@ -187,8 +187,12 @@/* DLL config 0 register */ #define DLL_ENABLE 0x80000000 +#define DLL_RESET 0x40000000#define DLL_FREQ_SEL 0x08000000 +/* DLL status 0 register */ +#define DLL_STS_SLV_LOCK 0x08000000 +#define MAX_TUNING_LOOP 40#define HOSTVER_VENDOR (x) (((x) >> 8) & 0xff)
Signature · 1 line
2.7.4
PATCH 2/2 mmc: fsl_esdhc: make sure delay chain locked for HS400
Dear Yangbo,
Quoted 9 lines · Yangbo Lu
For eMMC HS400 mode, the DLL reset is a required step for mmc rescan. This step has not been documented in reference manual, but the RM will be fixed sooner or later.
This patch is to add the step of DLL reset, and make sure delay chain locked for HS400.
Fixes db8f93672b42 ("mmc: fsl_esdhc: support eMMC HS400 mode")Signed-off-by Yangbo Lu <[email protected]>
Just added minor comments.
Quoted 34 lines
--- drivers/mmc/fsl_esdhc.c | 28 +++++++++++++++++++++++++--- include/fsl_esdhc.h | 4 ++++ 2 files changed, 29 insertions(+), 3 deletions(-)drivers/mmc/fsl_esdhc.c +6
-2@@ -70,7 +70,9 @@ struct fsl_esdhc {uint sdtimingctl;/* SD timing control register */ char reserved8[20 ];/* reserved */ uint dllcfg0;/* DLL config 0 register */ -char reserved9[680 ];/* reserved */ +char reserved9[12 ];/* reserved */ +uint dllstat0;/* DLL status 0 register */ +char reserved10[664 ];/* reserved */ uint esdhcctl;/* eSDHC control register */ };@@ -617,9 +619,11 @@ static void esdhc_exit_hs400(struct fsl_esdhc_priv *priv)esdhc_tuning_block_enable (priv, false); } -static void esdhc_set_timing (struct fsl_esdhc_priv *priv,enum bus_mode mode) +static int esdhc_set_timing (struct fsl_esdhc_priv *priv,enum bus_mode mode) {struct fsl_esdhc *regs = priv->esdhc_regs; +ulong start; +u32 val;/* Exit HS400 mode before setting any other mode */ if (esdhc_read32(®s->tbctl) & HS400_MODE &&
drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode) · line 649
Quoted 6 lines
drivers/mmc/fsl_esdhc.c +3
-0@@ -640,17 +644,33 @@ static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode)esdhc_setbits32 (®s->dllcfg0,DLL_FREQ_SEL );esdhc_setbits32 (®s->dllcfg0,DLL_ENABLE ); + +esdhc_setbits32 (®s->dllcfg0,DLL_RESET ); +udelay (1 );
Could you add a light comment why need to put udelay(1)?
Best Regards,
Jaehoon Chung
Quoted 56 lines
drivers/mmc/fsl_esdhc.c +16
-1+esdhc_clrbits32 (®s->dllcfg0,DLL_RESET ); + + start =get_timer (0 ); + val =DLL_STS_SLV_LOCK ; +while (!(esdhc_read32 (®s->dllstat0) & val)) { +if (get_timer (start) >1000 ) { +printf ("fsl_esdhc: delay chain lock timeout\n" ); +return -ETIMEDOUT ; + } + } +esdhc_setbits32 (®s->tbctl,HS400_WNDW_ADJUST );esdhc_clock_control (priv, false);esdhc_flush_async_fifo (priv); }esdhc_clock_control (priv, true); +return 0 ; }static int esdhc_set_ios_common (struct fsl_esdhc_priv *priv,struct mmc *mmc) {struct fsl_esdhc *regs = priv->esdhc_regs; +int ret;if (priv->is_sdhc_per_clk) {/* Select to use peripheral clock */ @@ -667,7 +687,9 @@ static int esdhc_set_ios_common(struct fsl_esdhc_priv *priv, struct mmc *mmc)set_sysctl (priv, mmc, mmc->clock);/* Set timing */ -esdhc_set_timing (priv, mmc->selected_mode); + ret =esdhc_set_timing (priv, mmc->selected_mode); +if (ret) +return ret;/* Set the bus width */ esdhc_clrbits32 (®s->proctl,PROCTL_DTW_4 |PROCTL_DTW_8 );include/fsl_esdhc.h +4
-0@@ -187,8 +187,12 @@/* DLL config 0 register */ #define DLL_ENABLE 0x80000000 +#define DLL_RESET 0x40000000#define DLL_FREQ_SEL 0x08000000 +/* DLL status 0 register */ +#define DLL_STS_SLV_LOCK 0x08000000 +#define MAX_TUNING_LOOP 40#define HOSTVER_VENDOR (x) (((x) >> 8) & 0xff)
PATCH 2/2 mmc: fsl_esdhc: make sure delay chain locked for HS400
Hi Jaehoon,
Quoted 64 lines
-----Original Message-----
From: Jaehoon Chung <[email protected]>
Sent: Tuesday, October 20, 2020 5:52 AM
To: Y.b. Lu <[email protected]>; u-boot at lists.denx.de; Peng Fan <[email protected]>
Subject: Re: [PATCH 2/2] mmc:fsl_esdhc: make sure delay chain locked for HS400Dear Yangbo,
Quoted 9 lines · Yangbo Lu
For eMMC HS400 mode, the DLL reset is a required step for mmc rescan. This step has not been documented in reference manual, but the RM will be fixed sooner or later.
This patch is to add the step of DLL reset, and make sure delay chain locked for HS400.
Fixes db8f93672b42 ("mmc: fsl_esdhc: support eMMC HS400 mode")Signed-off-by Yangbo Lu <[email protected]>Reviewed-by Jaehoon Chung <[email protected]>Just added minor comments.
drivers/mmc/fsl_esdhc.c static void esdhc_exit_hs400(struct fsl_esdhc_priv
Quoted 21 lines
--- drivers/mmc/fsl_esdhc.c | 28 +++++++++++++++++++++++++--- include/fsl_esdhc.h | 4 ++++ 2 files changed, 29 insertions(+), 3 deletions(-)drivers/mmc/fsl_esdhc.c +3
-1@@ -70,7 +70,9 @@ struct fsl_esdhc {uint sdtimingctl;/* SD timing control register */ char reserved8[20 ];/* reserved */ uint dllcfg0;/* DLL config 0 register */ -char reserved9[680 ];/* reserved */ +char reserved9[12 ];/* reserved */ +uint dllstat0;/* DLL status 0 register */ +char reserved10[664 ];/* reserved */ uint esdhcctl;/* eSDHC control register */ };@@ -617,9 +619,11 @@ static void esdhc_exit_hs400(struct fsl_esdhc_priv*priv)
drivers/mmc/fsl_esdhc.c static void esdhc_exit_hs400(struct fsl_esdhc_priv *priv)
Quoted 4 lines
drivers/mmc/fsl_esdhc.c +0
-1esdhc_tuning_block_enable (priv, false); } -static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_modemode)
drivers/mmc/fsl_esdhc.c static void esdhc_exit_hs400(struct fsl_esdhc_priv · line 622
Quoted 1 line
drivers/mmc/fsl_esdhc.c +1
-0+static int esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_modemode)
drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv
Quoted 8 lines
drivers/mmc/fsl_esdhc.c +2
-0{struct fsl_esdhc *regs = priv->esdhc_regs; +ulong start; +u32 val;/* Exit HS400 mode before setting any other mode */ if (esdhc_read32(®s->tbctl) & HS400_MODE &&@@ -640,17 +644,33 @@ static void esdhc_set_timing(struct fsl_esdhc_priv*priv, enum
bus_modemode)
Quoted 8 lines
drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode) · line 649
Quoted 6 lines
drivers/mmc/fsl_esdhc.c +3
-0esdhc_setbits32 (®s->dllcfg0,DLL_FREQ_SEL );esdhc_setbits32 (®s->dllcfg0,DLL_ENABLE ); + +esdhc_setbits32 (®s->dllcfg0,DLL_RESET ); +udelay (1 );Could you add a light comment why need to put udelay(1)?
Actually this is just per fixed reference manual.
I sent out v2 patch, to explain in commit message in case some one what to know why.
" In previous commit to support eMMC HS400,
db8f936 mmc: fsl_esdhc: support eMMC HS400 mode
the steps to configure DLL could be found in commit message,
13. Set DLLCFG0[DLL_ENABLE] and DLLCFG0[DLL_FREQ_SEL].
14. Wait for delay chain to lock.
these would be fixed as,
13. Set DLLCFG0[DLL_ENABLE] and DLLCFG0[DLL_FREQ_SEL].
13.1 Write DLLCFG0[DLL_RESET] to 1 and wait for 1us,
then write DLLCFG0[DLL_RESET]
14. Wait for delay chain to lock."
Thanks.
Quoted 62 lines
Best Regards,
Jaehoon ChungQuoted 11 lines
drivers/mmc/fsl_esdhc.c +11
-0+esdhc_clrbits32 (®s->dllcfg0,DLL_RESET ); + + start =get_timer (0 ); + val =DLL_STS_SLV_LOCK ; +while (!(esdhc_read32 (®s->dllstat0) & val)) { +if (get_timer (start) >1000 ) { +printf ("fsl_esdhc: delay chain lock timeout\n" ); +return -ETIMEDOUT ; + } + } +drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode)
Quoted 10 lines
drivers/mmc/fsl_esdhc.c +1
-0esdhc_setbits32 (®s->tbctl,HS400_WNDW_ADJUST );esdhc_clock_control (priv, false);esdhc_flush_async_fifo (priv); }esdhc_clock_control (priv, true); +return 0 ; } static int esdhc_set_ios_common(struct fsl_esdhc_priv *priv, struct mmc*mmc)
drivers/mmc/fsl_esdhc.c static int esdhc_set_ios_common(struct
Quoted 7 lines
drivers/mmc/fsl_esdhc.c +1
-0{struct fsl_esdhc *regs = priv->esdhc_regs; +int ret;if (priv->is_sdhc_per_clk) {/* Select to use peripheral clock */ @@ -667,7 +687,9 @@ static int esdhc_set_ios_common(struct
fsl_esdhc_priv*priv, struct mmc *mmc)Quoted 28 lines
drivers/mmc/fsl_esdhc.c +3
-1set_sysctl (priv, mmc, mmc->clock);/* Set timing */ -esdhc_set_timing (priv, mmc->selected_mode); + ret =esdhc_set_timing (priv, mmc->selected_mode); +if (ret) +return ret;/* Set the bus width */ esdhc_clrbits32 (®s->proctl,PROCTL_DTW_4 |PROCTL_DTW_8 );include/fsl_esdhc.h +4
-0@@ -187,8 +187,12 @@/* DLL config 0 register */ #define DLL_ENABLE 0x80000000 +#define DLL_RESET 0x40000000#define DLL_FREQ_SEL 0x08000000 +/* DLL status 0 register */ +#define DLL_STS_SLV_LOCK 0x08000000 +#define MAX_TUNING_LOOP 40#define HOSTVER_VENDOR (x) (((x) >> 8) & 0xff)
PATCH 2/2 mmc: fsl_esdhc: make sure delay chain locked for HS400
Quoted 85 lines · Y.b. Lu
Hi Jaehoon,
Quoted 64 lines
-----Original Message-----
From: Jaehoon Chung <[email protected]>
Sent: Tuesday, October 20, 2020 5:52 AM
To: Y.b. Lu <[email protected]>; u-boot at lists.denx.de; Peng Fan <[email protected]>
Subject: Re: [PATCH 2/2] mmc:fsl_esdhc: make sure delay chain locked for HS400Dear Yangbo,
Quoted 9 lines · Yangbo Lu
For eMMC HS400 mode, the DLL reset is a required step for mmc rescan. This step has not been documented in reference manual, but the RM will be fixed sooner or later.
This patch is to add the step of DLL reset, and make sure delay chain locked for HS400.
Fixes db8f93672b42 ("mmc: fsl_esdhc: support eMMC HS400 mode")Signed-off-by Yangbo Lu <[email protected]>Reviewed-by Jaehoon Chung <[email protected]>Just added minor comments.
drivers/mmc/fsl_esdhc.c static void esdhc_exit_hs400(struct fsl_esdhc_priv
Quoted 21 lines
--- drivers/mmc/fsl_esdhc.c | 28 +++++++++++++++++++++++++--- include/fsl_esdhc.h | 4 ++++ 2 files changed, 29 insertions(+), 3 deletions(-)drivers/mmc/fsl_esdhc.c +3
-1@@ -70,7 +70,9 @@ struct fsl_esdhc {uint sdtimingctl;/* SD timing control register */ char reserved8[20 ];/* reserved */ uint dllcfg0;/* DLL config 0 register */ -char reserved9[680 ];/* reserved */ +char reserved9[12 ];/* reserved */ +uint dllstat0;/* DLL status 0 register */ +char reserved10[664 ];/* reserved */ uint esdhcctl;/* eSDHC control register */ };@@ -617,9 +619,11 @@ static void esdhc_exit_hs400(struct fsl_esdhc_priv*priv)
drivers/mmc/fsl_esdhc.c static void esdhc_exit_hs400(struct fsl_esdhc_priv *priv)
Quoted 4 lines
drivers/mmc/fsl_esdhc.c +0
-1esdhc_tuning_block_enable (priv, false); } -static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_modemode)
drivers/mmc/fsl_esdhc.c static void esdhc_exit_hs400(struct fsl_esdhc_priv · line 622
Quoted 1 line
drivers/mmc/fsl_esdhc.c +1
-0+static int esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_modemode)
drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv
Quoted 8 lines
drivers/mmc/fsl_esdhc.c +2
-0{struct fsl_esdhc *regs = priv->esdhc_regs; +ulong start; +u32 val;/* Exit HS400 mode before setting any other mode */ if (esdhc_read32(®s->tbctl) & HS400_MODE &&@@ -640,17 +644,33 @@ static void esdhc_set_timing(struct fsl_esdhc_priv*priv, enum
bus_modemode)Quoted 8 lines
drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode) · line 649
Quoted 6 lines
drivers/mmc/fsl_esdhc.c +3
-0esdhc_setbits32 (®s->dllcfg0,DLL_FREQ_SEL );esdhc_setbits32 (®s->dllcfg0,DLL_ENABLE ); + +esdhc_setbits32 (®s->dllcfg0,DLL_RESET ); +udelay (1 );Could you add a light comment why need to put udelay(1)?
Actually this is just per fixed reference manual.
I sent out v2 patch, to explain in commit message in case some one what to know why." In previous commit to support eMMC HS400,
db8f936 mmc:fsl_esdhc: support eMMC HS400 modethe steps to configure DLL could be found in commit message,
13. Set DLLCFG0[DLL_ENABLE] and DLLCFG0[DLL_FREQ_SEL].
14. Wait for delay chain to lock.
Quoted 7 lines
these would be fixed as,
13. Set DLLCFG0[DLL_ENABLE] and DLLCFG0[DLL_FREQ_SEL].
13.1 Write DLLCFG0[DLL_RESET] to 1 and wait for 1us,
then write DLLCFG0[DLL_RESET]
14. Wait for delay chain to lock."Thanks.
Thanks you for kindly explanation.
Best Regards,
Jaehoon Chung
Quoted 64 lines
Quoted 63 lines
Best Regards,
Jaehoon ChungQuoted 11 lines
drivers/mmc/fsl_esdhc.c +11
-0+esdhc_clrbits32 (®s->dllcfg0,DLL_RESET ); + + start =get_timer (0 ); + val =DLL_STS_SLV_LOCK ; +while (!(esdhc_read32 (®s->dllstat0) & val)) { +if (get_timer (start) >1000 ) { +printf ("fsl_esdhc: delay chain lock timeout\n" ); +return -ETIMEDOUT ; + } + } +drivers/mmc/fsl_esdhc.c static void esdhc_set_timing(struct fsl_esdhc_priv *priv, enum bus_mode mode)
Quoted 10 lines
drivers/mmc/fsl_esdhc.c +1
-0esdhc_setbits32 (®s->tbctl,HS400_WNDW_ADJUST );esdhc_clock_control (priv, false);esdhc_flush_async_fifo (priv); }esdhc_clock_control (priv, true); +return 0 ; } static int esdhc_set_ios_common(struct fsl_esdhc_priv *priv, struct mmc*mmc)
drivers/mmc/fsl_esdhc.c static int esdhc_set_ios_common(struct
Quoted 7 lines
drivers/mmc/fsl_esdhc.c +1
-0{struct fsl_esdhc *regs = priv->esdhc_regs; +int ret;if (priv->is_sdhc_per_clk) {/* Select to use peripheral clock */ @@ -667,7 +687,9 @@ static int esdhc_set_ios_common(struct
fsl_esdhc_priv*priv, struct mmc *mmc)Quoted 28 lines
drivers/mmc/fsl_esdhc.c +3
-1set_sysctl (priv, mmc, mmc->clock);/* Set timing */ -esdhc_set_timing (priv, mmc->selected_mode); + ret =esdhc_set_timing (priv, mmc->selected_mode); +if (ret) +return ret;/* Set the bus width */ esdhc_clrbits32 (®s->proctl,PROCTL_DTW_4 |PROCTL_DTW_8 );include/fsl_esdhc.h +4
-0@@ -187,8 +187,12 @@/* DLL config 0 register */ #define DLL_ENABLE 0x80000000 +#define DLL_RESET 0x40000000#define DLL_FREQ_SEL 0x08000000 +/* DLL status 0 register */ +#define DLL_STS_SLV_LOCK 0x08000000 +#define MAX_TUNING_LOOP 40#define HOSTVER_VENDOR (x) (((x) >> 8) & 0xff)