Skip to contentSkip to conversation

lib/list_kunit: Follow new file name convention for KUnit tests

PATCH Superseded Andy Shevchenko 3 participants 7 messages Oct 16, 2020 – Oct 30, 2020

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/3 lib/list_kunit: Follow new file name convention for KUnit tests

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

---
v3: added Rb (David), expanded Cc (Mark)

 MAINTAINERS                       | 2 +-
 lib/Makefile                      | 2 +-
 lib/{list-test.c => list_kunit.c} | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename lib/{list-test.c => list_kunit.c} (100%)
MAINTAINERS +1 -1
index 4538378de6f5..20facbca9388 100644
@@ -10188,7 +10188,7 @@ M:	David Gow <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
-F:	lib/list-test.c
+F:	lib/list_kunit.c
 
 LIVE PATCHING
 M:	Josh Poimboeuf <[email protected]>
lib/Makefile +1 -1
index 5ca03ba6ee45..1a5e6a6ebe8d 100644
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
-obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
+obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
 obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
 obj-$(CONFIG_BITS_TEST) += test_bits.o
lib/list_kunit.c renamed from lib/list-test.c +0 -0
similarity index 100%
rename from lib/list-test.c
rename to lib/list_kunit.c
Signature · 1 line
2.28.0
#3 lore raw

PATCH v3 3/3 lib/bits_kunit: Follow new file name convention for KUnit tests

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

---
v3: added Rb (David), expanded Cc (Mark)

 lib/Makefile                      | 2 +-
 lib/{test_bits.c => bits_kunit.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename lib/{test_bits.c => bits_kunit.c} (100%)
lib/Makefile +1 -1
index 5c18519d6733..70a4a21ff5d6 100644
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
+obj-$(CONFIG_BITS_TEST) += bits_kunit.o
 obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o
 obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
-obj-$(CONFIG_BITS_TEST) += test_bits.o
lib/bits_kunit.c renamed from lib/test_bits.c +0 -0
similarity index 100%
rename from lib/test_bits.c
rename to lib/bits_kunit.c
Signature · 1 line
2.28.0
#1 lore raw

PATCH v3 2/3 lib/linear_ranges_kunit: Follow new file name convention for KUnit tests

In reply to Andy Shevchenko

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

---
v3: added Rb (David)

 MAINTAINERS                                         | 3 +--
 lib/Makefile                                        | 2 +-
 lib/{test_linear_ranges.c => linear_ranges_kunit.c} | 0
 3 files changed, 2 insertions(+), 3 deletions(-)
 rename lib/{test_linear_ranges.c => linear_ranges_kunit.c} (100%)
MAINTAINERS +1 -2
index 20facbca9388..249417a036f9 100644
@@ -10069,8 +10069,7 @@ F:	include/uapi/linux/lightnvm.h
 LINEAR RANGES HELPERS
 M:	Mark Brown <[email protected]>
 R:	Matti Vaittinen <[email protected]>
-F:	lib/linear_ranges.c
-F:	lib/test_linear_ranges.c
+F:	lib/linear_ranges*.c
 F:	include/linux/linear_range.h
 
 LINUX FOR POWER MACINTOSH
lib/Makefile +1 -1
index 1a5e6a6ebe8d..5c18519d6733 100644
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
+obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o
 obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
-obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
 obj-$(CONFIG_BITS_TEST) += test_bits.o
lib/linear_ranges_kunit.c renamed from lib/test_linear_ranges.c +0 -0
similarity index 100%
rename from lib/test_linear_ranges.c
rename to lib/linear_ranges_kunit.c
Signature · 1 line
2.28.0
Acked-by on v3 2/3
#2 lore raw

Re: [PATCH v3 2/3] lib/linear_ranges_kunit: Follow new file name convention for KUnit tests

Quoted 4 lines · Andy Shevchenko

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

Acked-by on v3 1/3
#5 lore raw
In reply to Andy Shevchenko
Quoted 9 lines · Andy Shevchenko

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

Thanks for taking care of this!

Acked-by on v3 3/3
#4 lore raw

Re: [PATCH v3 3/3] lib/bits_kunit: Follow new file name convention for KUnit tests

In reply to Andy Shevchenko
Quoted 9 lines · Andy Shevchenko

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

#6 lore raw
In reply to Andy Shevchenko
Quoted 4 lines · Andy Shevchenko

Follow new file name convention for the KUnit tests. Since we have lib/*test*.c in a few variations, use 'kunit' suffix to distinguish usual test cases with KUnit-based ones.

Can we get this applied?

Quoted 43 lines

---
v3: added Rb (David), expanded Cc (Mark)

 MAINTAINERS                       | 2 +-
 lib/Makefile                      | 2 +-
 lib/{list-test.c => list_kunit.c} | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename lib/{list-test.c => list_kunit.c} (100%)
MAINTAINERS +1 -1
index 4538378de6f5..20facbca9388 100644
@@ -10188,7 +10188,7 @@ M:	David Gow <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
-F:	lib/list-test.c
+F:	lib/list_kunit.c
 
 LIVE PATCHING
 M:	Josh Poimboeuf <[email protected]>
lib/Makefile +1 -1
index 5ca03ba6ee45..1a5e6a6ebe8d 100644
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
-obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
+obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
 obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
 obj-$(CONFIG_BITS_TEST) += test_bits.o
lib/list_kunit.c renamed from lib/list-test.c +0 -0
similarity index 100%
rename from lib/list-test.c
rename to lib/list_kunit.c
Signature · 1 line
2.28.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko