Skip to contentSkip to conversation

drm/i915/display: Program DBUF_CTL tracker state service

PATCH In review José Roberto de Souza 3 participants 5 messages Oct 16, 2020 – Oct 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/display: Program DBUF_CTL tracker state service

This sequence is not part of "Sequences to Initialize Display" but as noted in the MBus page the DBUF_CTL.Tracker_state_service needs to be set to 8.

BSpec: 49213

---
 drivers/gpu/drm/i915/display/intel_display_power.c | 13 +++++++++++++
 drivers/gpu/drm/i915/i915_reg.h                    | 14 +++++++++-----
 2 files changed, 22 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +13 -0
index 45806cfc679a..db36ab02e7d7 100644
@@ -4771,6 +4771,17 @@ static void gen9_dbuf_disable(struct drm_i915_private *dev_priv)
 	gen9_dbuf_slices_update(dev_priv, 0);
 }
 
+static void gen12_dbuf_slices_config(struct drm_i915_private *dev_priv)
+{
+	const int num_slices = INTEL_INFO(dev_priv)->num_supported_dbuf_slices;
+	enum dbuf_slice slice;
+
+	for (slice = DBUF_S1; slice < num_slices; slice++)
+		intel_de_rmw(dev_priv, DBUF_CTL_S(slice),
+			     DBUF_TRACKER_STATE_SERVICE_MASK,
+			     DBUF_TRACKER_STATE_SERVICE(8));
+}
+
 static void icl_mbus_init(struct drm_i915_private *dev_priv)
 {
 	unsigned long abox_regs = INTEL_INFO(dev_priv)->abox_mask;
@@ -5340,6 +5351,8 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
 	/* 4. Enable CDCLK. */
 	intel_cdclk_init_hw(dev_priv);
 
+	if (INTEL_GEN(dev_priv) >= 12)
+		gen12_dbuf_slices_config(dev_priv);
 	/* 5. Enable DBUF. */
 	gen9_dbuf_enable(dev_priv);
 
drivers/gpu/drm/i915/i915_reg.h +9 -5
index 6d97e6286c2d..c38901e2f81c 100644
@@ -7927,11 +7927,15 @@ enum {
 #define DISP_ARB_CTL2	_MMIO(0x45004)
 #define  DISP_DATA_PARTITION_5_6	(1 << 6)
 #define  DISP_IPC_ENABLE		(1 << 3)
-#define _DBUF_CTL_S1			0x45008
-#define _DBUF_CTL_S2			0x44FE8
-#define DBUF_CTL_S(slice)		_MMIO(_PICK_EVEN(slice, _DBUF_CTL_S1, _DBUF_CTL_S2))
-#define  DBUF_POWER_REQUEST		(1 << 31)
-#define  DBUF_POWER_STATE		(1 << 30)
+
+#define _DBUF_CTL_S1				0x45008
+#define _DBUF_CTL_S2				0x44FE8
+#define DBUF_CTL_S(slice)			_MMIO(_PICK_EVEN(slice, _DBUF_CTL_S1, _DBUF_CTL_S2))
+#define  DBUF_POWER_REQUEST			REG_BIT(31)
+#define  DBUF_POWER_STATE			REG_BIT(30)
+#define  DBUF_TRACKER_STATE_SERVICE_MASK	REG_GENMASK(23, 19)
+#define  DBUF_TRACKER_STATE_SERVICE(x)		REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x)
+
 #define GEN7_MSG_CTL	_MMIO(0x45010)
 #define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
 #define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
Signature · 6 lines
2.28.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Program DBUF_CTL tracker state service

== Series Details ==

== Series Details ==

Series: drm/i915/display: Program DBUF_CTL tracker state service
URL : https://patchwork.freedesktop.org/series/82785/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9152 -> Patchwork_18723
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/index.html

Known issues
------------

Here are the changes found in Patchwork_18723 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_flink_basic@basic:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-y/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-cfl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#2089])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-cfl-guc/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-cfl-guc/igt@i915_selftest@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([i915#1161] / [i915#262])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-kbl-7500u/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-kbl-7500u/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-icl-u2/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-icl-u2/igt@kms_flip@[email protected]

* igt@kms_psr@sprite_plane_onoff:
- fi-tgl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-y/igt@kms_psr@sprite_plane_onoff.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-y/igt@kms_psr@sprite_plane_onoff.html

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-icl-y: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-icl-y/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-icl-y/igt@[email protected]

* igt@gem_sync@basic-all:
- fi-tgl-y: [DMESG-WARN][15] ([i915#402]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-y/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-y/igt@[email protected]

* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][17] ([i915#1982] / [k.org#205379]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-dsi/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-dsi/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-bsw-kefka/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-bsw-kefka/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-tgl-y: [INCOMPLETE][21] ([i915#2268]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-y/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-y/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-u2: [INCOMPLETE][23] ([i915#2557]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][25] ([i915#1982]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-icl-u2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-icl-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-tgl-y: [DMESG-WARN][27] ([i915#1982]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-y/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-y/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- {fi-tgl-dsi}: [DMESG-WARN][29] ([i915#1982]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-dsi/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-dsi/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@basic-rte:
- fi-tgl-y: [DMESG-WARN][31] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][32] ([i915#2411])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/fi-tgl-y/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/fi-tgl-y/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2089]: https://gitlab.freedesktop.org/drm/intel/issues/2089
[i915#2268]: https://gitlab.freedesktop.org/drm/intel/issues/2268
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2557]: https://gitlab.freedesktop.org/drm/intel/issues/2557
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379

Participating hosts (47 -> 41)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper

Build changes
-------------

* Linux: CI_DRM_9152 -> Patchwork_18723

CI-20190529: 20190529
CI_DRM_9152: d47ddb24612c12fafd1556560db11a86d934ec5b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5821: 2bf22b1cff7905f7e214c0707941929a09450257 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18723: c69a5c7016137379c7c074b07abb89755c65e944 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c69a5c701613 drm/i915/display: Program DBUF_CTL tracker state service

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Program DBUF_CTL tracker state service

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915/display: Program DBUF_CTL tracker state service
URL : https://patchwork.freedesktop.org/series/82785/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9152_full -> Patchwork_18723_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_18723_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18723_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18723_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_addfb_basic@size-max:
- shard-skl: [PASS][1] -> [TIMEOUT][2] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@ab-vga1-hdmi-a1:
- shard-hsw: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-hsw4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: NOTRUN -> [TIMEOUT][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl4/igt@[email protected]

#### Warnings ####

* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-skl: [SKIP][5] ([fdo#109271]) -> [TIMEOUT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl4/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_18723_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3-devices:
- shard-hsw: [PASS][7] -> [FAIL][8] ([i915#1888])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-hsw6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-hsw6/igt@[email protected]

* igt@gem_exec_whisper@basic-normal:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#118] / [i915#95]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-glk4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-glk2/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup@gtt:
- shard-snb: [PASS][11] -> [INCOMPLETE][12] ([i915#82])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-snb2/igt@gem_userptr_blits@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-snb6/igt@gem_userptr_blits@[email protected]

* igt@kms_concurrent@pipe-a:
- shard-iclb: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-iclb8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-iclb2/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-c-256x256-bottom-edge:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +11 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl1/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2346]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl10/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2122])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-glk2/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-glk4/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl3/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-tglb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([i915#123])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl9/igt@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#1188]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl4/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_vblank@pipe-c-wait-idle:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-kbl6/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-glk: [PASS][35] -> [FAIL][36] ([i915#1542])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-glk3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-glk1/igt@[email protected]
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#1542])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl7/igt@[email protected]

* igt@perf@polling-small-buf:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#1722])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl3/igt@[email protected]

#### Possible fixes ####

* igt@drm_read@empty-nonblock:
- shard-skl: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl7/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-hsw: [INCOMPLETE][43] ([i915#1888]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-hsw4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-hsw7/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-skl: [TIMEOUT][45] ([i915#2424]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl9/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl7/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-apl: [DMESG-WARN][47] ([i915#1635] / [i915#1982]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-apl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-apl1/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][49] ([i915#96]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-hsw6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-hsw2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][51] ([i915#2055]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-hsw2/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-hsw4/igt@kms_flip@[email protected]

* igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-kbl3/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][55] ([i915#1188]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [DMESG-FAIL][57] ([fdo#108145] / [i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl3/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_psr@suspend:
- shard-skl: [INCOMPLETE][61] ([i915#198]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl9/igt@[email protected]

* igt@kms_vblank@pipe-b-wait-forked-hang:
- shard-hsw: [INCOMPLETE][63] -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-hsw6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-hsw4/igt@[email protected]

* igt@perf_pmu@module-unload:
- shard-tglb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-tglb8/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-tglb1/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@srm:
- shard-apl: [TIMEOUT][67] ([i915#1319] / [i915#1635]) -> [FAIL][68] ([fdo#110321] / [i915#1635])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-apl7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-apl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-tglb: [DMESG-WARN][69] ([i915#2411]) -> [INCOMPLETE][70] ([i915#2411] / [i915#456])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-tglb8/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-tglb1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [DMESG-WARN][71] ([i915#1982]) -> [DMESG-FAIL][72] ([fdo#108145] / [i915#1982])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9152/shard-skl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/shard-skl4/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96

Participating hosts (11 -> 12)
------------------------------

Additional (1): pig-snb-2600

Build changes
-------------

* Linux: CI_DRM_9152 -> Patchwork_18723

CI-20190529: 20190529
CI_DRM_9152: d47ddb24612c12fafd1556560db11a86d934ec5b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5821: 2bf22b1cff7905f7e214c0707941929a09450257 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18723: c69a5c7016137379c7c074b07abb89755c65e944 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18723/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#3 lore raw
In reply to José Roberto de Souza
Quoted 16 lines · José Roberto de Souza

This sequence is not part of "Sequences to Initialize Display" but as noted in the MBus page the DBUF_CTL.Tracker_state_service needs to be set to 8.

BSpec: 49213

---
 drivers/gpu/drm/i915/display/intel_display_power.c | 13 +++++++++++++
 drivers/gpu/drm/i915/i915_reg.h                    | 14 +++++++++-----
 2 files changed, 22 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
index 45806cfc679a..db36ab02e7d7 100644

drivers/gpu/drm/i915/display/intel_display_power.c static void gen9_dbuf_disable(struct drm_i915_private *dev_priv) · line 4779

Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_power.c +6 -0
@@ -4771,6 +4771,17 @@ static void gen9_dbuf_disable(struct drm_i915_private *dev_priv)
 	gen9_dbuf_slices_update(dev_priv, 0);
 }
 
+static void gen12_dbuf_slices_config(struct drm_i915_private *dev_priv)
+{
+	const int num_slices = INTEL_INFO(dev_priv)->num_supported_dbuf_slices;
+	enum dbuf_slice slice;
+
+	for (slice = DBUF_S1; slice < num_slices; slice++)

Minor nitpick; if we're starting from symbolic value DBUF_S1, we should probably end at 'DBUF_S1 + num_slices' for consistency.

Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_power.c +5 -0
+		intel_de_rmw(dev_priv, DBUF_CTL_S(slice),
+			     DBUF_TRACKER_STATE_SERVICE_MASK,
+			     DBUF_TRACKER_STATE_SERVICE(8));
+}
+
 static void icl_mbus_init(struct drm_i915_private *dev_priv)
 {
 	unsigned long abox_regs = INTEL_INFO(dev_priv)->abox_mask;

drivers/gpu/drm/i915/display/intel_display_power.c static void icl_display_core_init(struct drm_i915_private *dev_priv, · line 5356

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display_power.c +2 -0
@@ -5340,6 +5351,8 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
 	/* 4. Enable CDCLK. */
 	intel_cdclk_init_hw(dev_priv);
 
+	if (INTEL_GEN(dev_priv) >= 12)
+		gen12_dbuf_slices_config(dev_priv);
 	/* 5. Enable DBUF. */

Minor nitpick: should there be a blank between these additions and the comment?

Aside from those two minor things,

Quoted 34 lines
drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
 	gen9_dbuf_enable(dev_priv);
 
drivers/gpu/drm/i915/i915_reg.h +9 -5
index 6d97e6286c2d..c38901e2f81c 100644
@@ -7927,11 +7927,15 @@ enum {
 #define DISP_ARB_CTL2	_MMIO(0x45004)
 #define  DISP_DATA_PARTITION_5_6	(1 << 6)
 #define  DISP_IPC_ENABLE		(1 << 3)
-#define _DBUF_CTL_S1			0x45008
-#define _DBUF_CTL_S2			0x44FE8
-#define DBUF_CTL_S(slice)		_MMIO(_PICK_EVEN(slice, _DBUF_CTL_S1, _DBUF_CTL_S2))
-#define  DBUF_POWER_REQUEST		(1 << 31)
-#define  DBUF_POWER_STATE		(1 << 30)
+
+#define _DBUF_CTL_S1				0x45008
+#define _DBUF_CTL_S2				0x44FE8
+#define DBUF_CTL_S(slice)			_MMIO(_PICK_EVEN(slice, _DBUF_CTL_S1, _DBUF_CTL_S2))
+#define  DBUF_POWER_REQUEST			REG_BIT(31)
+#define  DBUF_POWER_STATE			REG_BIT(30)
+#define  DBUF_TRACKER_STATE_SERVICE_MASK	REG_GENMASK(23, 19)
+#define  DBUF_TRACKER_STATE_SERVICE(x)		REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x)
+
 #define GEN7_MSG_CTL	_MMIO(0x45010)
 #define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
 #define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
Signature · 6 lines
2.28.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 23 lines · Matt Roper
Quoted 22 lines · José Roberto de Souza

This sequence is not part of "Sequences to Initialize Display" but as noted in the MBus page the DBUF_CTL.Tracker_state_service needs to be set to 8.

BSpec: 49213

---
 drivers/gpu/drm/i915/display/intel_display_power.c | 13 +++++++++++++
 drivers/gpu/drm/i915/i915_reg.h | 14 +++++++++-----

 2 files changed, 22 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
index 45806cfc679a..db36ab02e7d7 100644
@@ -4771,6 +4771,17 @@ static void gen9_dbuf_disable(struct drm_i915_private *dev_priv)
  	gen9_dbuf_slices_update(dev_priv, 0);
  }

Quoted 9 lines

drivers/gpu/drm/i915/display/intel_display_power.c static void gen9_dbuf_disable(struct drm_i915_private *dev_priv) · line 4779

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display_power.c +6 -0
+static void gen12_dbuf_slices_config(struct drm_i915_private *dev_priv)
+{
+	const int num_slices = INTEL_INFO(dev_priv)->num_supported_dbuf_slices;
+	enum dbuf_slice slice;
+
+	for (slice = DBUF_S1; slice < num_slices; slice++)

Minor nitpick; if we're starting from symbolic value DBUF_S1, we should probably end at 'DBUF_S1 + num_slices' for consistency.

Current user of num_supported_dbuf_slices don't do that but anyways looks a good idea.

Quoted 20 lines
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_display_power.c +5 -0
+		intel_de_rmw(dev_priv, DBUF_CTL_S(slice),
+			     DBUF_TRACKER_STATE_SERVICE_MASK,
+			     DBUF_TRACKER_STATE_SERVICE(8));
+}
+

 static void icl_mbus_init(struct drm_i915_private *dev_priv) {
  unsigned long abox_regs = INTEL_INFO(dev_priv)->abox_mask;

drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
@@ -5340,6 +5351,8 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
  	/* 4. Enable CDCLK. */
  	intel_cdclk_init_hw(dev_priv);

Quoted 6 lines
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display_power.c +2 -0
+	if (INTEL_GEN(dev_priv) >= 12)
+		gen12_dbuf_slices_config(dev_priv);

  /* 5. Enable DBUF. */

Minor nitpick: should there be a blank between these additions and the comment?

sure.

Quoted 4 lines

Aside from those two minor things,

thanks

Quoted 46 lines
Quoted 46 lines

  gen9_dbuf_enable(dev_priv);

drivers/gpu/drm/i915/i915_reg.h +9 -5
index 6d97e6286c2d..c38901e2f81c 100644
@@ -7927,11 +7927,15 @@ enum {
  #define DISP_ARB_CTL2	_MMIO(0x45004)
  #define  DISP_DATA_PARTITION_5_6	(1 << 6)
  #define  DISP_IPC_ENABLE		(1 << 3)
-#define _DBUF_CTL_S1			0x45008
-#define _DBUF_CTL_S2			0x44FE8
-#define DBUF_CTL_S(slice)		_MMIO(_PICK_EVEN(slice, _DBUF_CTL_S1, _DBUF_CTL_S2))
-#define  DBUF_POWER_REQUEST		(1 << 31)
-#define  DBUF_POWER_STATE		(1 << 30)
+
+#define _DBUF_CTL_S1				0x45008
+#define _DBUF_CTL_S2				0x44FE8
+#define DBUF_CTL_S(slice)			_MMIO(_PICK_EVEN(slice, _DBUF_CTL_S1, _DBUF_CTL_S2))
+#define  DBUF_POWER_REQUEST			REG_BIT(31)
+#define  DBUF_POWER_STATE			REG_BIT(30)
+#define  DBUF_TRACKER_STATE_SERVICE_MASK	REG_GENMASK(23, 19)
+#define  DBUF_TRACKER_STATE_SERVICE(x)		REG_FIELD_PREP(DBUF_TRACKER_STATE_SERVICE_MASK, x)
+
  #define GEN7_MSG_CTL	_MMIO(0x45010)
  #define  WAIT_FOR_PCH_RESET_ACK		(1 << 1)
  #define  WAIT_FOR_PCH_FLR_ACK		(1 << 0)
Signature · 1 line
2.28.0
Quoted 5 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx