Skip to contentSkip to conversation

lib-crc32c-fix-trivial-typo-in-preprocessor-condition.patch removed from -mm tree

merged [email protected] 1 participant 1 message Oct 16, 2020

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: lib/crc32.c: fix trivial typo in preprocessor condition
has been removed from the -mm tree. Its filename was
lib-crc32c-fix-trivial-typo-in-preprocessor-condition.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Tobias Jordan <[email protected]>
Subject: lib/crc32.c: fix trivial typo in preprocessor condition

Whether crc32_be needs a lookup table is chosen based on CRC_LE_BITS. Obviously, the _be function should be governed by the _BE_ define.

This probably never pops up as it's hard to come up with a configuration where CRC_BE_BITS isn't the same as CRC_LE_BITS and as nobody is using bitwise CRC anyway.

Fixes 46c5801eaf86 ("crc32: bolt on crc32c")
Cc Krzysztof Kozlowski <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>

---

 lib/crc32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/crc32.c renamed from lib/crc32.c~lib-crc32c-fix-trivial-typo-in-preprocessor-condition +1 -1
@@ -331,7 +331,7 @@ static inline u32 __pure crc32_be_generi
 	return crc;
 }
 
-#if CRC_LE_BITS == 1
+#if CRC_BE_BITS == 1
 u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len)
 {
 	return crc32_be_generic(crc, p, len, NULL, CRC32_POLY_BE);

_

Patches currently in -mm which might be from [email protected] are