Skip to contentSkip to conversation

iio: light: vcnl4035 add i2c_device_id

PATCH Superseded Vaishnav M A 2 participants 3 messages Oct 18, 2020 IIO

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iio: light: vcnl4035 add i2c_device_id

add i2c_device_id for the vcnl4035 driver so that the device can be instantiated using i2c_new_client_device or from userspace, useful in cases where device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus)

---
v2:
- fix commit message

 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/light/vcnl4035.c +7 -0
index 765c44adac57..73a28e30dddc 100644
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 7 lines · On Sun, 18 Oct 2020 09:06:02 +0530 Vaishnav M A <[email protected]>…

add i2c_device_id for the vcnl4035 driver so that the device can be instantiated using i2c_new_client_device or from userspace, useful in cases where device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus)

Rewrite the description and this should be fine.

Thanks,

Jonathan

Quoted 31 lines

---
v2:
- fix commit message

 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/light/vcnl4035.c +7 -0
index 765c44adac57..73a28e30dddc 100644
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
#2 lore raw
Quoted 10 lines · Jonathan Cameron
Quoted 6 lines · On Sun, 18 Oct 2020 09:06:02 +0530 Vaishnav M A <[email protected]>…

add i2c_device_id for the vcnl4035 driver so that the device can be instantiated using i2c_new_client_device or from userspace, useful in cases where device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus)

Quoted 7 lines
Quoted 1 line

Rewrite the description and this should be fine.

Thanks,

Jonathan

Thank you Jonathan for the Review, I have submitted v3 patch
with the modified description: https://lore.kernel.org/patchwork/patch/1322195/

Thanks,
Vaishnav

Quoted 32 lines
Quoted 31 lines

---
v2:
- fix commit message

 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/light/vcnl4035.c +7 -0
index 765c44adac57..73a28e30dddc 100644
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
                         vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+     { "vcnl4035", 0},
+     { }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
      { .compatible = "vishay,vcnl4035", },
      { }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
      },
      .probe  = vcnl4035_probe,
      .remove = vcnl4035_remove,
+     .id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);