drm/amdgpu: remove unneeded break
Subsystems (3)
PATCH 1/1 drm/amdgpu: remove unneeded break
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return or break
--- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 - drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 ------- 7 files changed, 43 deletions(-)
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0 -1
@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,0 );break ; -break ;case COLOR_SPACE_SRGB_LIMITED :/* TV RGB */ REG_SET(OUTPUT_CSC_CONTROL, 0,
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +0 -7
@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -7
@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0 -7
@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -7
@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c +0 -7
@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0 -7
@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 19.10.20 um 16:43 schrieb [email protected]:
Quoted 5 lines
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return or break
Signed-off-by Tom Rix <[email protected]>
Quoted 192 lines
--- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 - drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 ------- 7 files changed, 43 deletions(-)drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0
-1@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,0 );break ; -break ;case COLOR_SPACE_SRGB_LIMITED :/* TV RGB */ REG_SET(OUTPUT_CSC_CONTROL, 0,drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +0
-7@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0
-7@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0
-7@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0
-7@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c +0
-7@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0
-4@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ;
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c static int map_transmitter_id_to_phy_instance( · line 475
Quoted 10 lines
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0
-3-break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 8 lines · Christian König
Am 19.10.20 um 16:43 schrieb [email protected]:
Quoted 5 lines
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return or break
Signed-off-by Tom Rix <[email protected]>Acked-by Christian König <[email protected]>
Harry
Quoted 195 lines
Quoted 195 lines
---
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 ------- 7 files changed, 43 deletions(-)drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0
-1@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode( REG_SET(OUTPUT_CSC_CONTROL, 0, OUTPUT_CSC_GRPH_MODE, 0); break; - break;case
COLOR_SPACE_SRGB_LIMITED:
/* TV RGB */
REG_SET(OUTPUT_CSC_CONTROL, 0,drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +0
-0@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance( switch (transmitter) {case
TRANSMITTER_UNIPHY_A:
return 0;
- break;
caseTRANSMITTER_UNIPHY_B:
return 1;
- break;
caseTRANSMITTER_UNIPHY_C:
return 2;
- break;
caseTRANSMITTER_UNIPHY_D:
return 3;
- break;
caseTRANSMITTER_UNIPHY_E:
return 4;
- break;
caseTRANSMITTER_UNIPHY_F:
return 5;
- break;
caseTRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0
-0@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance( switch (transmitter) {case
TRANSMITTER_UNIPHY_A:
return 0;
- break;
caseTRANSMITTER_UNIPHY_B:
return 1;
- break;
caseTRANSMITTER_UNIPHY_C:
return 2;
- break;
caseTRANSMITTER_UNIPHY_D:
return 3;
- break;
caseTRANSMITTER_UNIPHY_E:
return 4;
- break;
caseTRANSMITTER_UNIPHY_F:
return 5;
- break;
caseTRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0
-0@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance( switch (transmitter) {case
TRANSMITTER_UNIPHY_A:
return 0;
- break;
caseTRANSMITTER_UNIPHY_B:
return 1;
- break;
caseTRANSMITTER_UNIPHY_C:
return 2;
- break;
caseTRANSMITTER_UNIPHY_D:
return 3;
- break;
caseTRANSMITTER_UNIPHY_E:
return 4;
- break;
caseTRANSMITTER_UNIPHY_F:
return 5;
- break;
caseTRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0
-0@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance( switch (transmitter) {case
TRANSMITTER_UNIPHY_A:
return 0;
- break;
caseTRANSMITTER_UNIPHY_B:
return 1;
- break;
caseTRANSMITTER_UNIPHY_C:
return 2;
- break;
caseTRANSMITTER_UNIPHY_D:
return 3;
- break;
caseTRANSMITTER_UNIPHY_E:
return 4;
- break;
caseTRANSMITTER_UNIPHY_F:
return 5;
- break;
caseTRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c +0
-0@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance( switch (transmitter) {case
TRANSMITTER_UNIPHY_A:
return 0;
- break;
caseTRANSMITTER_UNIPHY_B:
return 1;
- break;
caseTRANSMITTER_UNIPHY_C:
return 2;
- break;
caseTRANSMITTER_UNIPHY_D:
return 3;
- break;
caseTRANSMITTER_UNIPHY_E:
return 4;
- break;
caseTRANSMITTER_UNIPHY_F:
return 5;
- break;
caseTRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0
-0@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance( switch (transmitter) {case
TRANSMITTER_UNIPHY_A:
return 0;
- break;
caseTRANSMITTER_UNIPHY_B:
return 1;
- break;
caseTRANSMITTER_UNIPHY_C:
return 2;
- break;
caseTRANSMITTER_UNIPHY_D:
return 3;
- break;
caseTRANSMITTER_UNIPHY_E:
return 4;
- break;
caseTRANSMITTER_UNIPHY_F:
Quoted 9 lines
Quoted 8 lines
return 5;
- break;
caseTRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 226 lines · Harry Wentland
Quoted 8 lines · Christian König
Am 19.10.20 um 16:43 schrieb [email protected]:
Quoted 5 lines
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return or break
Signed-off-by Tom Rix <[email protected]>Acked-by Christian König <[email protected]>Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 202 lines
Quoted 202 lines
--- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 - drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 ------- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 ------- 7 files changed, 43 deletions(-)drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0
-1@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,0 );break ; -break ;case COLOR_SPACE_SRGB_LIMITED :/* TV RGB */ REG_SET(OUTPUT_CSC_CONTROL, 0,drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +0
-7@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0
-7@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0
-7@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0
-7@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c +0
-7@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0
-5@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :Quoted 9 lines
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c static int map_transmitter_id_to_phy_instance( · line 475
Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0
-2return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ;
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx