Skip to contentSkip to conversation

mem: close rtemap files

PATCH In review Stephen Hemminger 1 participant 2 messages Oct 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mem: close rtemap files

The memory subsystem is leaving open a file descriptor for each rtemap file. This can lead to hundreds of extra open file descriptors which has negative side effects. For example, the application may go over its maximum file descriptor limit, or the application may be using limited API's like select that only allow 1024 file descriptors.

The EAL memory subsystem does not need to hold the file open. Probably the original intention was to keep the file locked, but that is not necessary. The Linux kernel keeps a reference count on the file, and the mmap counts is a reference and therefore maintains the file as locked.

The fix is one line just close the file after it is setup.

Fixes 582bed1e1d1d ("mem: support mapping hugepages at runtime")
---
 lib/librte_eal/linux/eal_memalloc.c | 6 ++++++
 1 file changed, 6 insertions(+)
lib/librte_eal/linux/eal_memalloc.c +6 -0
index 6dc1b2baecdc..99600adda568 100644
@@ -651,6 +651,12 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
 				__func__);
 #endif
 
+	/*
+	 * reference count is held by mmap() now
+	 * don't need to hold file open to keep it locked
+	 */
+	close(fd);
+
 	ms->addr = addr;
 	ms->hugepage_sz = alloc_sz;
 	ms->len = alloc_sz;
Signature · 1 line
2.27.0
#1 lore raw
Quoted 12 lines · On Mon, 19 Oct 2020 08:42:35 -0700 Stephen Hemminger…

The memory subsystem is leaving open a file descriptor for each rtemap file. This can lead to hundreds of extra open file descriptors which has negative side effects. For example, the application may go over its maximum file descriptor limit, or the application may be using limited API's like select that only allow 1024 file descriptors.

The EAL memory subsystem does not need to hold the file open. Probably the original intention was to keep the file locked, but that is not necessary. The Linux kernel keeps a reference count on the file, and the mmap counts is a reference and therefore maintains the file as locked.

Quoted 5 lines

The fix is one line just close the file after it is setup.

Fixes 582bed1e1d1d ("mem: support mapping hugepages at runtime")

This is fixes the open files, but has issues on shutdown. Will send new version later.