net: remove unneeded break
Subsystems (5)
PATCH 1/1 net: remove unneeded break
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return or goto
Signed-off-by Tom Rix <[email protected]>
--- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 1 - drivers/net/ethernet/cisco/enic/enic_ethtool.c | 1 - drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 1 - drivers/net/wan/lmc/lmc_proto.c | 4 ---- 4 files changed, 7 deletions(-)
drivers/net/ethernet/aquantia/atlantic/aq_nic.c +0 -1
@@ -1163,7 +1163,6 @@ int aq_nic_set_link_ksettings(struct aq_nic_s *self,default : err =-1 ; goto err_exit; -break ; }if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) { err =-1 ;
drivers/net/ethernet/cisco/enic/enic_ethtool.c +0 -1
@@ -434,7 +434,6 @@ static int enic_grxclsrule(struct enic *enic, struct ethtool_rxnfc *cmd)break ;default :return -EINVAL ; -break ; } fsp->h_u.tcp_ip4_spec.ip4src =flow_get_u32_src (&n->keys);
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c +0 -1
@@ -350,7 +350,6 @@ static s32 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)if (ixgbe_read_eerd_generic (hw, pointer, &length)) {hw_dbg (hw,"EEPROM read failed\n" );return IXGBE_ERR_EEPROM ; -break ; }/* Skip pointer section if length is invalid. */
drivers/net/wan/lmc/lmc_proto.c +0 -4
@@ -89,17 +89,13 @@ __be16 lmc_proto_type(lmc_softc_t *sc, struct sk_buff *skb) /*FOLD00*/switch (sc->if_type){case LMC_PPP :return hdlc_type_trans (skb, sc->lmc_device); -break ;case LMC_NET :return htons (ETH_P_802_2 ); -break ;case LMC_RAW :/* Packet type for skbuff kind of useless */ return htons (ETH_P_802_2 ); -break ;default :printk (KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n" , sc->name);return htons (ETH_P_802_2 ); -break ; } }
Signature · 1 line
2.18.1
Quoted 5 lines · On Mon, 19 Oct 2020 10:26:07 -0700 trix at redhat.com wrote:
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return or goto
Signed-off-by Tom Rix <[email protected]>
Applied, thanks!