Skip to contentSkip to conversation

watchdog: remove unneeded break

PATCH In review [email protected] 2 participants 2 messages Oct 19, 2020 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/watchdog/geodewdt.c | 2 --
 1 file changed, 2 deletions(-)
drivers/watchdog/geodewdt.c +0 -2
index 83418924e30a..0b699c783d57 100644
@@ -150,8 +150,6 @@ static long geodewdt_ioctl(struct file *file, unsigned int cmd,
 	case WDIOC_GETSUPPORT:
 		return copy_to_user(argp, &ident,
 				    sizeof(ident)) ? -EFAULT : 0;
-		break;
-
 	case WDIOC_GETSTATUS:
 	case WDIOC_GETBOOTSTATUS:
 		return put_user(0, p);
Signature · 1 line
2.18.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Mon, Oct 19, 2020 at 10:53:42AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Quoted 20 lines
---
 drivers/watchdog/geodewdt.c | 2 --
 1 file changed, 2 deletions(-)
drivers/watchdog/geodewdt.c +0 -2
index 83418924e30a..0b699c783d57 100644
@@ -150,8 +150,6 @@ static long geodewdt_ioctl(struct file *file, unsigned int cmd,
 	case WDIOC_GETSUPPORT:
 		return copy_to_user(argp, &ident,
 				    sizeof(ident)) ? -EFAULT : 0;
-		break;
-
 	case WDIOC_GETSTATUS:
 	case WDIOC_GETBOOTSTATUS:
 		return put_user(0, p);
Signature · 1 line
2.18.1