Skip to contentSkip to conversation

char: ipmi: remove unneeded break

PATCH In review [email protected] 2 participants 2 messages Oct 19, 2020 – Oct 27, 2020 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 char: ipmi: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/char/ipmi/ipmi_devintf.c | 1 -
 1 file changed, 1 deletion(-)
drivers/char/ipmi/ipmi_devintf.c +0 -1
index f7b1c004a12b..3dd1d5abb298 100644
@@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file   *file,
 		}
 
 		return ipmi_set_my_address(priv->user, val.channel, val.value);
-		break;
 	}
 
 	case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
Signature · 1 line
2.18.1
#1 lore raw
Quoted 3 lines · On Mon, Oct 19, 2020 at 12:48:05PM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Ok, it's in my next tree.

Thanks,

-corey

Quoted 21 lines
---
 drivers/char/ipmi/ipmi_devintf.c | 1 -
 1 file changed, 1 deletion(-)
drivers/char/ipmi/ipmi_devintf.c +0 -1
index f7b1c004a12b..3dd1d5abb298 100644
@@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file   *file,
 		}
 
 		return ipmi_set_my_address(priv->user, val.channel, val.value);
-		break;
 	}
 
 	case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
Signature · 1 line
2.18.1