x86/unwind: remove unneeded initialization
Subsystems (2)
PATCH 1/1 x86/unwind: remove unneeded initialization
make clang-analyzer on x86_64 defconfig caught my attention with:
arch/x86/kernel/unwind_orc.c:38:7: warning: Value stored to 'mid' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
int *mid = first, *found = first;
^Commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder") introduced __orc_find() with this unneeded dead-store initialization.
Put the variable in local scope and initialize only once the value is needed to make clang-analyzer happy.
As compilers will detect these unneeded assignments and optimize this anyway, the resulting object code is effectively identical before and after this change.
No functional change. Effectively, no change to object code.
--- arch/x86/kernel/unwind_orc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/unwind_orc.c +2 -2
@@ -35,7 +35,7 @@ static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table, {int *first = ip_table;int *last = ip_table + num_entries -1 ; -int *mid = first, *found = first; +int *found = first;if (!num_entries)return NULL ;
@@ -47,7 +47,7 @@ static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table,* ignored when they conflict with a real entry. */ while (first <= last) { - mid = first + ((last - first) /2 ); +int *mid = first + ((last - first) /2 );if (orc_ip (mid) <= ip) { found = mid;
Signature · 1 line
2.17.1
Quoted 14 lines · Lukas Bulwahn
make clang-analyzer on
x86_64defconfig caught my attention with:
arch/x86/kernel/unwind_orc.c:38:7: warning: Value stored to 'mid' during its initialization is never read [clang-analyzer-deadcode.DeadStores]int *mid = first, *found = first; ^Commit
ee9f8fce9964("x86/unwind: Add the ORC unwinder") introduced__orc_find()with this unneeded dead-store initialization.Put the variable in local scope and initialize only once the value is needed to make clang-analyzer happy.
Quoted 8 lines
As compilers will detect these unneeded assignments and optimize this anyway, the resulting object code is effectively identical before and after this change.
No functional change. Effectively, no change to object code.
Signed-off-by Lukas Bulwahn <[email protected]>---
Please help me with your review.
Also help by compiling and comparing the disassembly before and after with your compiler.
Quoted 28 lines
arch/x86/kernel/unwind_orc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/x86/kernel/unwind_orc.c +2
-3@@ -35,7 +35,7 @@ static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table, {int *first = ip_table;int *last = ip_table + num_entries -1 ; -int *mid = first, *found = first; +int *found = first;if (!num_entries)return NULL ;@@ -47,7 +47,7 @@ static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table,* ignored when they conflict with a real entry. */ while (first <= last) { - mid = first + ((last - first) /2 ); +int *mid = first + ((last - first) /2 );if (orc_ip (mid) <= ip) { found = mid; --2.17.1