tty: serial: imx: remove unneeded break
Subsystems (2)
PATCH v2 1/1 tty: serial: imx: remove unneeded break
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return
Signed-off-by Tom Rix <[email protected]>
---
v2: improve commit log
--- drivers/tty/serial/imx.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/tty/serial/imx.c +0 -5
@@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)switch (offset) {case UCR1 :return sport->ucr1; -break ;case UCR2 :/* * UCR2_SRST is the only bit in the cached registers that might
@@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)if (!(sport->ucr2 &UCR2_SRST )) sport->ucr2 =readl (sport->port.membase + offset);return sport->ucr2; -break ;case UCR3 :return sport->ucr3; -break ;case UCR4 :return sport->ucr4; -break ;case UFCR :return sport->ufcr; -break ;default :return readl (sport->port.membase + offset); }
Signature · 1 line
2.18.1
Hello,
Quoted 5 lines · On Tue, Oct 20, 2020 at 06:07:09AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return
Signed-off-by Tom Rix <[email protected]>
Just for the record: I commented for v1:
Quoted 3 lines
this might be subjective, but I like the break being there for clearity. So I object to make a patch to remove them. In case I'm outvoted I'd at least want empty lines instead.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |