cifs: make const array static, makes object smaller
Subsystems (3)
PATCH 1/1 cifs: make const array static, makes object smaller
From: Colin Ian King <[email protected]>
Don't populate const array smb3_create_tag_posix on the stack but instead make it static. Makes the object code smaller by 50 bytes.
Before:
text data bss dec hex filename
150184 47167 0 197351 302e7 fs/cifs/smb2pdu.o
After:
text data bss dec hex filename
150070 47231 0 197301 302b5 fs/cifs/smb2pdu.o
(gcc version 10.2.0)
--- fs/cifs/smb2pdu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
fs/cifs/smb2pdu.c +5 -3
@@ -1971,9 +1971,11 @@ smb2_parse_contexts(struct TCP_Server_Info *server,unsigned int next;unsigned int remaining;char *name; -const char smb3_create_tag_posix[] = {0x93 ,0xAD ,0x25 ,0x50 ,0x9C , -0xB4 ,0x11 ,0xE7 ,0xB4 ,0x23 ,0x83 , -0xDE ,0x96 ,0x8B ,0xCD ,0x7C }; +static const char smb3_create_tag_posix[] = { +0x93 ,0xAD ,0x25 ,0x50 ,0x9C , +0xB4 ,0x11 ,0xE7 ,0xB4 ,0x23 ,0x83 , +0xDE ,0x96 ,0x8B ,0xCD ,0x7C + }; *oplock =0 ; data_offset = (char *)rsp +le32_to_cpu (rsp->CreateContextsOffset);
Signature · 1 line
2.27.0
Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
added Aurelien's Reviewed-by and merged into cifs-2.6.git for-next
Quoted 43 lines · Colin King
From: Colin Ian King <[email protected]>
Don't populate const array
smb3_create_tag_posixon the stack but instead make it static. Makes the object code smaller by 50 bytes.Before:
text data bss dec hex filename
150184 47167 0 197351 302e7fs/cifs/smb2pdu.oAfter:
text data bss dec hex filename
150070 47231 0 197301 302b5fs/cifs/smb2pdu.o(gcc version 10.2.0)
Signed-off-by Colin Ian King <[email protected]>--- fs/cifs/smb2pdu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)fs/cifs/smb2pdu.c +5
-4@@ -1971,9 +1971,11 @@ smb2_parse_contexts(struct TCP_Server_Info *server,unsigned int next;unsigned int remaining;char *name; -const char smb3_create_tag_posix[] = {0x93 ,0xAD ,0x25 ,0x50 ,0x9C , -0xB4 ,0x11 ,0xE7 ,0xB4 ,0x23 ,0x83 , -0xDE ,0x96 ,0x8B ,0xCD ,0x7C }; +static const char smb3_create_tag_posix[] = { +0x93 ,0xAD ,0x25 ,0x50 ,0x9C , +0xB4 ,0x11 ,0xE7 ,0xB4 ,0x23 ,0x83 , +0xDE ,0x96 ,0x8B ,0xCD ,0x7C + }; *oplock =0 ; data_offset = (char *)rsp +le32_to_cpu (rsp->CreateContextsOffset); --2.27.0
Signature · 3 lines
Thanks, Steve