Remove deprecated -no-kvm option
PATCH 1/1 Remove deprecated -no-kvm option
The option has never been mentioned in our documentation, it's been deprecated since years, it's marked with QEMU_ARCH_I386 (which does not make sense anymore since KVM is available on other architectures, too), it does not do anything by default in upstream QEMU (since TCG is the default here anyway), and we're spending too much precious time each year discussing whether it makes sense to keep this option as a nice suger or not... let's finally put an end on this and remove it.
--- docs/system/deprecated.rst | 5 ----- qemu-options.hx | 3 --- softmmu/vl.c | 4 ---- 3 files changed, 12 deletions(-)
docs/system/deprecated.rst +0 -5
@@ -27,11 +27,6 @@ System emulator command line arguments The ``enforce-config-section`` parameter is replaced by the ``-global migration.send-configuration={on|off}`` option. -``-no-kvm`` (since 1.3.0) -''''''''''''''''''''''''' - -The ``-no-kvm`` argument is now a synonym for setting ``-accel tcg``. - ``-usbdevice`` (since 2.10.0) '''''''''''''''''''''''''''''
qemu-options.hx +0 -3
@@ -4351,9 +4351,6 @@ SRST Enable FIPS 140-2 compliance mode. ERST -HXCOMM Deprecated by -accel tcg -DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) - DEF("msg", HAS_ARG, QEMU_OPTION_msg, "-msg [timestamp[=on|off]][,guest-name=[on|off]]\n" " control error message format\n"
softmmu/vl.c +0 -4
@@ -3502,10 +3502,6 @@ void qemu_init(int argc, char **argv, char **envp)exit (1 ); }break ; -case QEMU_OPTION_no_kvm: - olist =qemu_find_opts ("machine" ); -qemu_opts_parse_noisily (olist,"accel=tcg" , false); -break ;case QEMU_OPTION_accel: accel_opts =qemu_opts_parse_noisily (qemu_find_opts ("accel" ), optarg, true);
Signature · 1 line
2.18.2
Quoted 20 lines · Thomas Huth
The option has never been mentioned in our documentation, it's been deprecated since years, it's marked with
QEMU_ARCH_I386(which does not make sense anymore since KVM is available on other architectures, too), it does not do anything by default in upstream QEMU (since TCG is the default here anyway), and we're spending too much precious time each year discussing whether it makes sense to keep this option as a nice suger or not... let's finally put an end on this and remove it.Signed-off-by Thomas Huth <[email protected]>--- docs/system/deprecated.rst | 5 ----- qemu-options.hx | 3 --- softmmu/vl.c | 4 ---- 3 files changed, 12 deletions(-)docs/system/deprecated.rst +0
-0
docs/system/deprecated.rst System emulator command line arguments · line 34
Quoted 8 lines
docs/system/deprecated.rst +0
-5@@ -27,11 +27,6 @@ System emulator command line arguments The ``enforce-config-section`` parameter is replaced by the ``-global migration.send-configuration={on|off}`` option. -``-no-kvm`` (since 1.3.0) -''''''''''''''''''''''''' - -The ``-no-kvm`` argument is now a synonym for setting ``-accel tcg``. -
And of course it's going to need a v2 because it should be added in the "removed" section. It's really cursed. :)
Paolo