t0000: replace test -f with helper function
PATCH v2 1/1 t0000: replace test -f with helper function
From: Caleb Tillman <[email protected]>
Signed-off-by Caleb Tillman <[email protected]>
--- t/t0000-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
t/t0000-basic.sh +1 -1
@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' ' test_expect_success 'git read-tree followed by write-tree should be idempotent' ' rm -f .git/index && git read-tree $tree && - test -f .git/index && + test_path_is_file .git/index && newtree=$(git write-tree) && test "$newtree" = "$tree" '
Signature · 1 line
2.25.1
Quoted 4 lines · [email protected] writes:
From: Caleb Tillman <[email protected]>
Signed-off-by Caleb Tillman <[email protected]>---
Thanks. Let's declare victory and move on. You've demonstrated through the microproject that you can now comfortably be involved in the review discussion.
I'll keep the copy I queued on the 20th, though, with this title
t0000: use test_path_is_file instead of "test -f"
which is only slightly longer but is much more descriptive than this round.
Thanks.
Quoted 16 lines
t/t0000-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)t/t0000-basic.sh +1
-1@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' ' test_expect_success 'git read-tree followed by write-tree should be idempotent' ' rm -f .git/index && git read-tree $tree && - test -f .git/index && + test_path_is_file .git/index && newtree=$(git write-tree) && test "$newtree" = "$tree" '