Skip to contentSkip to conversation

tcl: adapt to potential psuedo changes

PATCH Superseded Yu, Mingli 3 participants 5 messages Oct 21, 2020 – Oct 22, 2020

lore
Share & tools
lore

Yu, Mingli

author
#0 lore raw

PATCH 1/1 tcl: adapt to potential psuedo changes

From: Mingli Yu <[email protected]>

It failed as below when rerun do_install for tcl:

 $ bitbake tcl
 $ bitbake tcl -f -cinstall
[snip]
 | NOTE: make -j 72 DESTDIR=/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/image install
 | abort()ing pseudo client by server request. See https://wiki.yoctoproject.org/wiki/Pseudo_Abort for more details on this.
 | /build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/temp/run.do_install.3490694: line 184: 3499214 Aborted                 (core dumped) make -j 72 "$@"

Though unpack tcl source to ${WORKDIR}/${BPN}${PV}, but we set S as below:
S = "${WORKDIR}/${BPN}${PV}/unix"

Exclude ${WORKDIR}/${BPN}${PV} from pseudo database to fix the above do_install failure.

---
 meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/tcltk/tcl_8.6.10.bb +1 -0
index aedd96b021..e6feb25a7e 100644
@@ -32,6 +32,7 @@ SRC_URI_class-native = "${BASE_SRC_URI}"
 
 S = "${WORKDIR}/${BPN}${PV}/unix"
 
+PSEUDO_IGNORE_PATHS .= ",${WORKDIR}/${BPN}${PV}"
 VER = "${PV}"
 
 inherit autotools ptest binconfig update-alternatives
Signature · 1 line
2.17.1
#1 lore raw

There is typo in the commit summary and doesn't base.bbclass do this automatically already?

See
https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396

Quoted 46 lines · Mingli

From: Mingli Yu <[email protected]>

It failed as below when rerun do_install for tcl:

 $ bitbake tcl
 $ bitbake tcl -f -cinstall
[snip]
 | NOTE: make -j 72
DESTDIR=/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/image install
 | abort()ing pseudo client by server request. See
https://wiki.yoctoproject.org/wiki/Pseudo_Abort for more details on this.
 |
/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/temp/run.do_install.3490694:
line 184: 3499214 Aborted                 (core dumped) make -j 72 "$@"

Though unpack tcl source to ${WORKDIR}/${BPN}${PV}, but we set S as below:
S = "${WORKDIR}/${BPN}${PV}/unix"

Exclude ${WORKDIR}/${BPN}${PV} from pseudo database to fix the above do_install failure.

---
 meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/tcltk/tcl_8.6.10.bb +1 -1
index aedd96b021..e6feb25a7e 100644
@@ -32,6 +32,7 @@ SRC_URI_class-native = "${BASE_SRC_URI}"
 
 S = "${WORKDIR}/${BPN}${PV}/unix"
 
+PSEUDO_IGNORE_PATHS .= ",${WORKDIR}/${BPN}${PV}"
 VER = "${PV}"
 
 inherit autotools ptest binconfig update-alternatives
--

2.17.1

author
#3 lore raw
Quoted 9 lines · Richard Purdie
Quoted 5 lines · Martin Jansa

There is typo in the commit summary and doesn't base.bbclass do this automatically already?

See
https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396

I think the issue is because the recipe is setting:

Quoted 8 lines

S = ${WORKDIR}/${BPN}${PV}/unix

but we want

${WORKDIR}/${BPN}${PV}
(no /unix suffix)

in the ignored paths so that code won't help?

Yes, I will send v2 to explain more why tcl is special.

Thanks,

Quoted 5 lines

Cheers,

Richard

author
#4 lore raw

PATCH v2 1/1 tcl: adapt to potential pseudo changes

In reply to Richard Purdie

From: Mingli Yu <[email protected]>

It failed as below when rerun do_install for tcl:

 $ bitbake tcl
 $ bitbake tcl -f -cinstall
 [snip]
 | NOTE: make -j 72 DESTDIR=/build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/image install
 | abort()ing pseudo client by server request. See https://wiki.yoctoproject.org/wiki/Pseudo_Abort for more details on this.
 | /build/tmp/work/core2-64-wrs-linux/tcl/8.6.10-r0/temp/run.do_install.3490694: line 184: 3499214 Aborted                 (core dumped) make -j 72 "$@"

By default the S is ${WORKDIR}/${BPN}-${PV}, but after unpack, the tcl source [1] unpacked to ${WORKDIR}/${BPN}${PV} and all the files under ${WORKDIR}/${BPN}${PV} are acutally the source files.

But the the main Makefile.in is under ${WORKDIR}/${BPN}${PV}/unix for tcl, so there is below logic in tcl recipe:
S = "${WORKDIR}/${BPN}${PV}/unix"

To adapt the potential pseudo changes, there is a general logic to exclude ${S} from pseudo database in base.bbclass in [2]. That's to say, just the dir ${WORKDIR}/${BPN}${PV}/unix is excluded from the pseudo database.

But it's not enough for tcl, we need to exclude the actual source dir ${WORKDIR}/${BPN}${PV} from pseudo database specifically to fix the above do_install failure.

[1] https://downloads.sourceforge.net/tcl/tcl8.6.0-src.tar.gz
[2] https://git.openembedded.org/openembedded-core/tree/meta/classes/base.bbclass#n396

---
 meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/tcltk/tcl_8.6.10.bb +1 -0
index aedd96b021..e6feb25a7e 100644
@@ -32,6 +32,7 @@ SRC_URI_class-native = "${BASE_SRC_URI}"
 
 S = "${WORKDIR}/${BPN}${PV}/unix"
 
+PSEUDO_IGNORE_PATHS .= ",${WORKDIR}/${BPN}${PV}"
 VER = "${PV}"
 
 inherit autotools ptest binconfig update-alternatives
Signature · 1 line
2.17.1