drm/i915/region: fix max size calculation
Subsystems (2)
PATCH v2 1/1 drm/i915/region: fix max size calculation
We are incorrectly limiting the max allocation size as per the mm max_order, which is effectively the largest power-of-two that we can fit in the region size. However, it's normal to setup the region or allocator with a non-power-of-two size(for example 3G), which we should already handle correctly, except it seems for the early too-big-check.
v2: make sure we also exercise the I915_BO_ALLOC_CONTIGUOUS path, which is quite different, since for that we are actually limited by the largest power-of-two that we can fit within the region size. (Chris)
--- drivers/gpu/drm/i915/intel_memory_region.c | 2 +- .../drm/i915/selftests/intel_memory_region.c | 77 +++++++++++++++++++ drivers/gpu/drm/i915/selftests/mock_region.c | 2 +- 3 files changed, 79 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_memory_region.c +1 -1
@@ -87,7 +87,7 @@ __intel_memory_region_get_pages_buddy(struct intel_memory_region *mem, min_order =ilog2 (size) -ilog2 (mem->mm.chunk_size); } -if (size >BIT (mem->mm.max_order) * mem->mm.chunk_size) +if (size > mem->mm.size)return -E2BIG ; n_pages = size >>ilog2 (mem->mm.chunk_size);
drivers/gpu/drm/i915/selftests/intel_memory_region.c +77 -0
89 lines not on this page · raw message
drivers/gpu/drm/i915/selftests/mock_region.c +1 -1
@@ -24,7 +24,7 @@ mock_object_create(struct intel_memory_region *mem,struct drm_i915_private *i915 = mem->i915;struct drm_i915_gem_object *obj; -if (size >BIT (mem->mm.max_order) * mem->mm.chunk_size) +if (size > mem->mm.size)return ERR_PTR (-E2BIG ); obj =i915_gem_object_alloc ();
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/region: fix max size calculation (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915/region: fix max size calculation (rev2)
URL : https://patchwork.freedesktop.org/series/82909/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9175 -> Patchwork_18750
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/index.html
Known issues
------------
Here are the changes found in Patchwork_18750 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([i915#2540])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/fi-blb-e6850/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/fi-blb-e6850/igt@[email protected]
* igt@gem_close_race@basic-threads:
- fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#1635])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/fi-apl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/fi-apl-guc/igt@[email protected]
* igt@i915_selftest@live@coherency:
- fi-gdg-551: [PASS][5] -> [DMESG-FAIL][6] ([i915#1748])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/fi-gdg-551/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/fi-gdg-551/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#2203])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-u2: [INCOMPLETE][9] ([i915#2557]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1748]: https://gitlab.freedesktop.org/drm/intel/issues/1748
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2540]: https://gitlab.freedesktop.org/drm/intel/issues/2540
[i915#2557]: https://gitlab.freedesktop.org/drm/intel/issues/2557
Participating hosts (46 -> 39)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9175 -> Patchwork_18750
CI-20190529: 20190529
CI_DRM_9175: 39db87924cbebbf2be2ef849d5be1c761d7865a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18750: 2d5fe19d4d1e6cb712058c319370541c9cfe87cd @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2d5fe19d4d1e drm/i915/region: fix max size calculation
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/region: fix max size calculation (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915/region: fix max size calculation (rev2)
URL : https://patchwork.freedesktop.org/series/82909/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9175_full -> Patchwork_18750_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18750_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18750_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18750_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-tglb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-tglb6/igt@[email protected]
* igt@prime_vgem@coherency-blt:
- shard-snb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-snb2/igt@[email protected]
- shard-hsw: [PASS][4] -> [FAIL][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-hsw8/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-hsw8/igt@[email protected]
### Piglit changes ###
#### Possible regressions ####
* [email protected]@execution@built-in-functions@fs-cosh-float (NEW):
- {pig-icl-1065g7}: NOTRUN -> [INCOMPLETE][6] +7 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/pig-icl-1065g7/[email protected]@execution@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_9175_full and Patchwork_18750_full:
### New Piglit tests (8) ###
* [email protected]@execution@built-in-functions@fs-cosh-float:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-assign-rshift-uvec4-ivec4:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-bitor-ivec3-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-bitxor-ivec3-ivec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@fs-op-rshift-uvec3-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@vs-op-assign-lshift-ivec3-int:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@vs-op-bitand-not-int-ivec2:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* [email protected]@execution@built-in-functions@vs-op-eq-uvec3-uvec3-using-if:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18750_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-glk2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-glk4/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-skl: [PASS][9] -> [TIMEOUT][10] ([i915#2424])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl10/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][11] -> [DMESG-WARN][12] ([i915#1436] / [i915#716])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl10/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][13] -> [DMESG-FAIL][14] ([i915#118] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-glk2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-glk4/igt@[email protected]
* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-kbl1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#300])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl2/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +5 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl9/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#52] / [i915#54])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-glk5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-glk3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#79]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl6/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@b-edp1:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#2122])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl10/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-tglb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-tglb7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-tglb8/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [PASS][29] -> [DMESG-WARN][30] ([i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-iclb6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-iclb8/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-primary-size-256:
- shard-glk: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-glk2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-glk9/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#198])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl8/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#1542])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl10/igt@[email protected]
- shard-tglb: [PASS][39] -> [FAIL][40] ([i915#1542])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-tglb5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-tglb2/igt@[email protected]
* igt@sysfs_timeslice_duration@timeout@rcs0:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#1732])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl8/igt@sysfs_timeslice_duration@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl2/igt@sysfs_timeslice_duration@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +7 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl9/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-kbl: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-kbl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-kbl6/igt@[email protected]
* igt@gem_tiled_pread_pwrite:
- shard-snb: [FAIL][47] -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-snb5/igt@gem_tiled_pread_pwrite.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-snb2/igt@gem_tiled_pread_pwrite.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [TIMEOUT][49] ([i915#2424]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][51] ([i915#454]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl7/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl6/igt@[email protected]
* {igt@kms_async_flips@alternate-sync-async-flip}:
- shard-skl: [FAIL][53] ([i915#2521]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl9/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl5/igt@[email protected]
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][55] ([i915#2521]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-kbl6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-kbl4/igt@[email protected]
- shard-glk: [FAIL][57] ([i915#2521]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-glk7/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-glk1/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][59] ([i915#2122]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl1/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-tglb: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-snb: [FAIL][63] ([i915#2546]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-snb5/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-snb2/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][65] ([i915#1188]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl1/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][67] ([fdo#108145] / [i915#265]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl9/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-iclb3/igt@kms_psr@psr2_dpms.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-iclb2/igt@kms_psr@psr2_dpms.html
#### Warnings ####
* igt@kms_content_protection@lic:
- shard-apl: [FAIL][71] ([fdo#110321] / [i915#1635]) -> [TIMEOUT][72] ([i915#1319] / [i915#1635])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-apl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-apl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [DMESG-WARN][73] ([i915#1982]) -> [FAIL][74] ([fdo#108145] / [i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9175/shard-skl1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/shard-skl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1732]: https://gitlab.freedesktop.org/drm/intel/issues/1732
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9175 -> Patchwork_18750
CI-20190529: 20190529
CI_DRM_9175: 39db87924cbebbf2be2ef849d5be1c761d7865a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18750: 2d5fe19d4d1e6cb712058c319370541c9cfe87cd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18750/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Matthew Auld (2020-10-21 11:36:06)
Quoted 133 lines
We are incorrectly limiting the max allocation size as per the mm
max_order, which is effectively the largest power-of-two that we can fit in the region size. However, it's normal to setup the region or allocator with a non-power-of-two size(for example 3G), which we should already handle correctly, except it seems for the early too-big-check.v2: make sure we also exercise the
I915_BO_ALLOC_CONTIGUOUSpath, which is quite different, since for that we are actually limited by the largest power-of-two that we can fit within the region size. (Chris)Fixes b908be543e44 ("drm/i915: support creating LMEM objects")Signed-off-by Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc CQ Tang <[email protected]>--- drivers/gpu/drm/i915/intel_memory_region.c | 2 +- .../drm/i915/selftests/intel_memory_region.c | 77 +++++++++++++++++++ drivers/gpu/drm/i915/selftests/mock_region.c | 2 +- 3 files changed, 79 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_memory_region.c +1
-1@@ -87,7 +87,7 @@ __intel_memory_region_get_pages_buddy(struct intel_memory_region *mem, min_order =ilog2 (size) -ilog2 (mem->mm.chunk_size); } -if (size >BIT (mem->mm.max_order) * mem->mm.chunk_size) +if (size > mem->mm.size)return -E2BIG ; n_pages = size >>ilog2 (mem->mm.chunk_size);drivers/gpu/drm/i915/selftests/intel_memory_region.c +77
-0@@ -261,6 +261,82 @@ static int igt_mock_contiguous(void *arg)return err; } +static int igt_mock_splintered_region (void *arg) +{ +struct intel_memory_region *mem = arg; +struct drm_i915_private *i915 = mem->i915; +struct drm_i915_gem_object *obj; +unsigned int expected_order; +LIST_HEAD (objects); +u64 size; +int err =0 ; + +/* +* Sanity check we can still allocate everything even if the +* mm.max_order != mm.size. i.e our starting address space size is not a +* power-of-two. +*/ + + size = (SZ_4G -1 ) &PAGE_MASK ; + mem =mock_region_create (i915,0 , size,PAGE_SIZE ,0 ); +if (IS_ERR (mem)) +return PTR_ERR (mem); + +if (mem->mm.size != size) { +pr_err ("%s size mismatch(%llu != %llu)\n" , + __func__, mem->mm.size, size); + err = -EINVAL ; + goto out_put; + } + + expected_order =get_order (rounddown_pow_of_two (size)); +if (mem->mm.max_order != expected_order) { +pr_err ("%s order mismatch(%u != %u)\n" , + __func__, mem->mm.max_order, expected_order); + err = -EINVAL ; + goto out_put; + } + + obj =igt_object_create (mem, &objects, size,0 ); +if (IS_ERR (obj)) { + err =PTR_ERR (obj); + goto out_close; + } + +close_objects (mem, &objects); + +/* +* While we should be able allocate everything without any flag +* restrictions, if we consider I915_BO_ALLOC_CONTIGUOUS then we are +* actually limited to the largest power-of-two for the region size i.e +* max_order, due to the inner workings of the buddy allocator. So make +* sure that does indeed hold true. +*/ + + obj =igt_object_create (mem, &objects, size,I915_BO_ALLOC_CONTIGUOUS ); +if (!IS_ERR (obj)) { +pr_err ("%s too large contiguous allocation was not rejected\n" , + __func__); + err = -EINVAL ; + goto out_close; + } + + obj =igt_object_create (mem, &objects,rounddown_pow_of_two (size), +I915_BO_ALLOC_CONTIGUOUS ); +if (IS_ERR (obj)) { +pr_err ("%s largest possible contiguous allocation failed\n" , + __func__); + err =PTR_ERR (obj); + goto out_close; + } + +out_close: +close_objects (mem, &objects); +out_put: +intel_memory_region_put (mem); +return err; +} + static int igt_gpu_write_dw(struct intel_context *ce, struct i915_vma *vma, u32 dword,@@ -771,6 +847,7 @@ int intel_memory_region_mock_selftests(void)static const struct i915_subtest tests[] = {SUBTEST (igt_mock_fill),SUBTEST (igt_mock_contiguous), +SUBTEST (igt_mock_splintered_region), };struct intel_memory_region *mem;struct drm_i915_private *i915;drivers/gpu/drm/i915/selftests/mock_region.c +0
-0
drivers/gpu/drm/i915/selftests/mock_region.c mock_object_create(struct intel_memory_region *mem, · line 28
Quoted 6 lines
drivers/gpu/drm/i915/selftests/mock_region.c +1
-1@@ -24,7 +24,7 @@ mock_object_create(struct intel_memory_region *mem,struct drm_i915_private *i915 = mem->i915;struct drm_i915_gem_object *obj; -if (size >BIT (mem->mm.max_order) * mem->mm.chunk_size) +if (size > mem->mm.size)return ERR_PTR (-E2BIG );
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx