Skip to contentSkip to conversation

doc: dt-binding: cdns,usb3: add wakeup-irq

PATCH In review Peter Chen 2 participants 3 messages Oct 22, 2020 – Oct 30, 2020

Subsystems (3)
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH 6/6 doc: dt-binding: cdns,usb3: add wakeup-irq

To support low power mode for controller, the driver needs wakeup-irq to reflect the signal changing after controller is stopped, and waking the controller up accordingly.

---
 Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/cdns,usb3.yaml +3 -0
index ac20b98e9910..0171e64ef95e 100644
@@ -30,12 +30,15 @@ properties:
       - description: OTG/DRD controller interrupt
       - description: XHCI host controller interrupt
       - description: Device controller interrupt
+      - description: interrupt used to wake up core, eg: when usbcmd.rs is
+      cleared by xhci core, this interrupt is optional.
 
   interrupt-names:
     items:
       - const: host
       - const: peripheral
       - const: otg
+      - const: wakeup
 
   dr_mode:
     enum: [host, otg, peripheral]
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 14 lines · Peter Chen

To support low power mode for controller, the driver needs wakeup-irq to reflect the signal changing after controller is stopped, and waking the controller up accordingly.

---
 Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/cdns,usb3.yaml +0 -0
index ac20b98e9910..0171e64ef95e 100644

Documentation/devicetree/bindings/usb/cdns,usb3.yaml properties: · line 34

Quoted 5 lines
Documentation/devicetree/bindings/usb/cdns,usb3.yaml +2 -0
@@ -30,12 +30,15 @@ properties:
       - description: OTG/DRD controller interrupt
       - description: XHCI host controller interrupt
       - description: Device controller interrupt
+      - description: interrupt used to wake up core, eg: when usbcmd.rs is
+      cleared by xhci core, this interrupt is optional.

You need 'minItems: 3' here and below to make this optional. I guess we don't have an example for this binding or it would fail.

Quoted 13 lines
Documentation/devicetree/bindings/usb/cdns,usb3.yaml +1 -0
   interrupt-names:
     items:
       - const: host
       - const: peripheral
       - const: otg
+      - const: wakeup
 
   dr_mode:
     enum: [host, otg, peripheral]
Signature · 1 line
2.17.1
author
#2 lore raw
Quoted 11 lines

Documentation/devicetree/bindings/usb/cdns,usb3.yaml properties: · line 34

Quoted 7 lines
Documentation/devicetree/bindings/usb/cdns,usb3.yaml +2 -0
@@ -30,12 +30,15 @@ properties:
       - description: OTG/DRD controller interrupt
       - description: XHCI host controller interrupt
       - description: Device controller interrupt
+      - description: interrupt used to wake up core, eg: when usbcmd.rs is
+      cleared by xhci core, this interrupt is optional.

You need 'minItems: 3' here and below to make this optional. I guess we don't have an example for this binding or it would fail.

Updated, and sent v2. Yes, we don't need it for example, the probe will not fail even this property is not there.

Peter

Quoted 13 lines
Quoted 13 lines
Documentation/devicetree/bindings/usb/cdns,usb3.yaml +1 -1
   interrupt-names:
     items:
       - const: host
       - const: peripheral
       - const: otg
+      - const: wakeup
 
   dr_mode:
     enum: [host, otg, peripheral]
--

2.17.1