Skip to contentSkip to conversation

arm64: dts: imx: Add Beacon i.MX8M Nano development kit

PATCH In review Adam Ford 3 participants 5 messages Oct 22, 2020 – Oct 23, 2020

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 arm64: dts: imx: Add Beacon i.MX8M Nano development kit

Beacon Embeddedworks is launching a development kit based on the i.MX8M Nano SoC. The kit consists of a System on Module (SOM)
+ baseboard. The SOM has the SoC, eMMC, and Ethernet. The baseboard has an wm8962 audio CODEC, and a single USB OTG.

---
Based on top of previous series found:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=366931

arch/arm64/boot/dts/freescale/Makefile +1 -0
index c7890b622587..ab47b3b1de75 100644
@@ -31,6 +31,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mn-beacon-kit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +313 -0

313 lines not on this page · raw message

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +19 -0
new file mode 100644
index 000000000000..faa55d888065
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/dts-v1/;
+
+#include "imx8mn.dtsi"
+#include "imx8mn-beacon-som.dtsi"
+#include "imx8mn-beacon-baseboard.dtsi"
+
+/ {
+	model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit";
+	compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn";
+
+	chosen {
+		stdout-path = &uart2;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi new file +429 -0

429 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Thank you for the patch! Yet something to improve:

Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on soc/for-next next-20201022]
[cannot apply to robh/for-next rockchip/for-next keystone/next arm64/for-next/core clk/clk-next arm/for-next xlnx/master kvmarm/next v5.9] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adam-Ford/arm64-dts-imx-Add-Beacon-i-MX8M-Nano-development-kit/20201023-005857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ec137628378cd7a0840b591f3893dd5fa3370f00
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Adam-Ford/arm64-dts-imx-Add-Beacon-i-MX8M-Nano-development-kit/20201023-005857 git checkout ec137628378cd7a0840b591f3893dd5fa3370f00
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi:155.1-7 Label or path easrc not found
>> Error: arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi:160.1-6 Label or path sai3 not found

FATAL ERROR: Syntax error parsing input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#2 lore raw
In reply to Adam Ford
Quoted 28 lines · Adam Ford

Beacon Embeddedworks is launching a development kit based on the i.MX8M Nano SoC. The kit consists of a System on Module (SOM)
+ baseboard. The SOM has the SoC, eMMC, and Ethernet. The baseboard has an wm8962 audio CODEC, and a single USB OTG.

---
Based on top of previous series found:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=366931

arch/arm64/boot/dts/freescale/Makefile +1 -0
index c7890b622587..ab47b3b1de75 100644
@@ -31,6 +31,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mn-beacon-kit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +0 -0
new file mode 100644
index 000000000000..898715aa79b5

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 10

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +10 -0
@@ -0,0 +1,313 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/ {
+	leds {
+		compatible = "gpio-leds";
+
+		led0 {

led-0

Quoted 28 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +28 -0
+			label = "gen_led0";
+			gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led1 {
+			label = "gen_led1";
+			gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led2 {
+			label = "gen_led2";
+			gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led3 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_led3>;
+			label = "heartbeat";
+			gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+
+	reg_audio: regulator-audio {
+		compatible = "regulator-fixed";

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 48

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +10 -0
+		regulator-name = "3v3_aud";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "VSD_3V3";

lowercase name please to match everything else.

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 57

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +9 -0
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	reg_usb_otg_vbus: regulator-usb {
+		compatible = "regulator-fixed";
+		pinctrl-0 = <&pinctrl_reg_usb_otg>;

pinctrl-names... and test whether it really works after this change. Without it the pinctrl was probably not applied.

Quoted 35 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +35 -0
+		regulator-name = "usb_otg_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	sound {
+		compatible = "fsl,imx-audio-wm8962";
+		model = "wm8962-audio";
+		audio-cpu = <&sai3>;
+		audio-codec = <&wm8962>;
+		audio-routing =
+			"Headphone Jack", "HPOUTL",
+			"Headphone Jack", "HPOUTR",
+			"Ext Spk", "SPKOUTL",
+			"Ext Spk", "SPKOUTR",
+			"AMIC", "MICBIAS",
+			"IN3R", "AMIC";
+	};
+};
+
+&ecspi2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_espi2>;
+	cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
+	status = "okay";
+
+	eeprom@0 {
+		compatible = "microchip,at25160bn", "atmel,at25";
+		reg = <0>;
+		spi-max-frequency = <5000000>;
+		spi-cpha;
+		spi-cpol;
+		pagesize = <32>;

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 102

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +10 -0
+		size = <2048>;
+		address-width = <16>;
+	};
+};
+
+&i2c2 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";

Can you document why you keep empty bus enabled?

Quoted 217 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +211 -0
+};
+
+&i2c4 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c4>;
+	status = "okay";
+
+	pca6416_0: gpio@20 {
+		compatible = "nxp,pcal6416";
+		reg = <0x20>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_pcal6414>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
+	};
+
+	pca6416_1: gpio@21 {
+		compatible = "nxp,pcal6416";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
+	};
+
+	wm8962: audio-codec@1a {
+		compatible = "wlf,wm8962";
+		reg = <0x1a>;
+		clocks = <&clk IMX8MN_CLK_SAI3_ROOT>;
+		clock-names = "xclk";
+		DCVDD-supply = <&reg_audio>;
+		DBVDD-supply = <&reg_audio>;
+		AVDD-supply = <&reg_audio>;
+		CPVDD-supply = <&reg_audio>;
+		MICVDD-supply = <&reg_audio>;
+		PLLVDD-supply = <&reg_audio>;
+		SPKVDD1-supply = <&reg_audio>;
+		SPKVDD2-supply = <&reg_audio>;
+		gpio-cfg = <
+			0x0000 /* 0:Default */
+			0x0000 /* 1:Default */
+			0x0000 /* 2:FN_DMICCLK */
+			0x0000 /* 3:Default */
+			0x0000 /* 4:FN_DMICCDAT */
+			0x0000 /* 5:Default */
+		>;
+	};
+};
+
+&easrc {
+	fsl,asrc-rate  = <48000>;
+	status = "okay";
+};
+
+&sai3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_sai3>;
+	assigned-clocks = <&clk IMX8MN_CLK_SAI3>;
+	assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>;
+	assigned-clock-rates = <24576000>;
+	fsl,sai-mclk-direction-output;
+	status = "okay";
+};
+
+&snvs_pwrkey {
+	status = "okay";
+};
+
+&uart2 { /* console */
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2>;
+	status = "okay";
+};
+
+&uart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	assigned-clocks = <&clk IMX8MN_CLK_UART3>;
+	assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_80M>;
+	status = "okay";
+};
+
+&usbotg1 {
+	vbus-supply = <&reg_usb_otg_vbus>;
+	disable-over-current;
+	dr_mode="otg";
+	status = "okay";
+};
+
+&usdhc2 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+	bus-width = <4>;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl_espi2: espi2grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK		0x82
+			MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI		0x82
+			MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO		0x82
+			MX8MN_IOMUXC_ECSPI1_SS0_GPIO5_IO9		0x41
+		>;
+	};
+
+	pinctrl_i2c2: i2c2grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL		0x400001c3
+			MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA		0x400001c3
+		>;
+	};
+
+	pinctrl_i2c4: i2c4grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_I2C4_SCL_I2C4_SCL		0x400001c3
+			MX8MN_IOMUXC_I2C4_SDA_I2C4_SDA		0x400001c3
+		>;
+	};
+
+	pinctrl_led3: led3grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SAI3_RXFS_GPIO4_IO28	0x41
+		>;
+	};
+
+	pinctrl_pcal6414: pcal6414-gpiogrp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SAI2_MCLK_GPIO4_IO27		0x19
+		>;
+	};
+
+	pinctrl_reg_usb_otg: reg-otggrp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SAI3_RXC_GPIO4_IO29     0x19
+		>;
+	};
+
+	pinctrl_sai3: sai3grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC     0xd6
+			MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK      0xd6
+			MX8MN_IOMUXC_SAI3_MCLK_SAI3_MCLK        0xd6
+			MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0     0xd6
+			MX8MN_IOMUXC_SAI3_RXD_SAI3_RX_DATA0	0xd6
+		>;
+	};
+
+	pinctrl_uart2: uart2grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_UART2_RXD_UART2_DCE_RX	0x140
+			MX8MN_IOMUXC_UART2_TXD_UART2_DCE_TX	0x140
+		>;
+	};
+
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_ECSPI1_SCLK_UART3_DCE_RX	0x40
+			MX8MN_IOMUXC_ECSPI1_MOSI_UART3_DCE_TX	0x40
+		>;
+	};
+
+	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SD2_CD_B_USDHC2_CD_B	0x41
+			MX8MN_IOMUXC_SD2_RESET_B_GPIO2_IO19	0x41
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SD2_CLK_USDHC2_CLK	0x190
+			MX8MN_IOMUXC_SD2_CMD_USDHC2_CMD	0x1d0
+			MX8MN_IOMUXC_SD2_DATA0_USDHC2_DATA0	0x1d0
+			MX8MN_IOMUXC_SD2_DATA1_USDHC2_DATA1	0x1d0
+			MX8MN_IOMUXC_SD2_DATA2_USDHC2_DATA2	0x1d0
+			MX8MN_IOMUXC_SD2_DATA3_USDHC2_DATA3	0x1d0
+			MX8MN_IOMUXC_GPIO1_IO04_USDHC2_VSELECT	0x1d0
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SD2_CLK_USDHC2_CLK	0x194
+			MX8MN_IOMUXC_SD2_CMD_USDHC2_CMD	0x1d4
+			MX8MN_IOMUXC_SD2_DATA0_USDHC2_DATA0	0x1d4
+			MX8MN_IOMUXC_SD2_DATA1_USDHC2_DATA1	0x1d4
+			MX8MN_IOMUXC_SD2_DATA2_USDHC2_DATA2	0x1d4
+			MX8MN_IOMUXC_SD2_DATA3_USDHC2_DATA3	0x1d4
+			MX8MN_IOMUXC_GPIO1_IO04_USDHC2_VSELECT	0x1d0
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+		fsl,pins = <
+			MX8MN_IOMUXC_SD2_CLK_USDHC2_CLK	0x196
+			MX8MN_IOMUXC_SD2_CMD_USDHC2_CMD	0x1d6
+			MX8MN_IOMUXC_SD2_DATA0_USDHC2_DATA0	0x1d6
+			MX8MN_IOMUXC_SD2_DATA1_USDHC2_DATA1	0x1d6
+			MX8MN_IOMUXC_SD2_DATA2_USDHC2_DATA2	0x1d6
+			MX8MN_IOMUXC_SD2_DATA3_USDHC2_DATA3	0x1d6
+			MX8MN_IOMUXC_GPIO1_IO04_USDHC2_VSELECT	0x1d0
+		>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +0 -0
new file mode 100644
index 000000000000..faa55d888065

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts line 10

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +10 -0
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/dts-v1/;
+
+#include "imx8mn.dtsi"
+#include "imx8mn-beacon-som.dtsi"
+#include "imx8mn-beacon-baseboard.dtsi"

Why do you need baseboard as DTSI? Is is separate than kit? Judging by contents look like just empty/fake DTS and the baseboard should be the DTS.

Another hint: Baseboard also does not have its compatible, so it cannot exist in real life separate from the development kit...

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts line 14

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +4 -0
+
+/ {
+	model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit";
+	compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn";

Undocumented compatible.

Quoted 38 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +5 -0
+
+	chosen {
+		stdout-path = &uart2;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi new file +27 -0
new file mode 100644
index 000000000000..a2ce036b37f3
@@ -0,0 +1,429 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/ {
+	usdhc1_pwrseq: usdhc1_pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_usdhc1_gpio>;
+		reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;
+		clocks = <&osc_32k>;
+		clock-names = "ext_clock";
+		post-power-on-delay-ms = <80>;
+	};
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x0 0x40000000 0 0x80000000>;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2_reg>;
+};
+
+&A53_1 {

arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi line 37

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi new file +10 -0
+	cpu-supply = <&buck2_reg>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2_reg>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2_reg>;
+};

Empty line please.

Best regards,
Krzysztof

author
#3 lore raw
Quoted 75 lines · Krzysztof Kozlowski
Quoted 28 lines · Adam Ford

Beacon Embeddedworks is launching a development kit based on the i.MX8M Nano SoC. The kit consists of a System on Module (SOM)
+ baseboard. The SOM has the SoC, eMMC, and Ethernet. The baseboard has an wm8962 audio CODEC, and a single USB OTG.

---
Based on top of previous series found:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=366931

arch/arm64/boot/dts/freescale/Makefile +1 -0
index c7890b622587..ab47b3b1de75 100644
@@ -31,6 +31,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mn-beacon-kit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +0 -0
new file mode 100644
index 000000000000..898715aa79b5

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 10

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +10 -0
@@ -0,0 +1,313 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/ {
+     leds {
+             compatible = "gpio-leds";
+
+             led0 {

led-0

Quoted 32 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +32 -0
+                     label = "gen_led0";
+                     gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led1 {
+                     label = "gen_led1";
+                     gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led2 {
+                     label = "gen_led2";
+                     gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led3 {
+                     pinctrl-names = "default";
+                     pinctrl-0 = <&pinctrl_led3>;
+                     label = "heartbeat";
+                     gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+                     linux,default-trigger = "heartbeat";
+             };
+     };
+
+     reg_audio: regulator-audio {
+             compatible = "regulator-fixed";
+             regulator-name = "3v3_aud";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>;
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 48

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +6 -0
+             enable-active-high;
+     };
+
+     reg_usdhc2_vmmc: regulator-usdhc2 {
+             compatible = "regulator-fixed";
+             regulator-name = "VSD_3V3";

lowercase name please to match everything else.

OK.

Quoted 11 lines

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 57

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +9 -0
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     reg_usb_otg_vbus: regulator-usb {
+             compatible = "regulator-fixed";
+             pinctrl-0 = <&pinctrl_reg_usb_otg>;
Quoted 2 lines

pinctrl-names... and test whether it really works after this change. Without it the pinctrl was probably not applied.

Good catch. I've been tracking some flakey USB support, and this may explain it.

Quoted 40 lines
Quoted 40 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +39 -0
+             regulator-name = "usb_otg_vbus";
+             regulator-min-microvolt = <5000000>;
+             regulator-max-microvolt = <5000000>;
+             gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     sound {
+             compatible = "fsl,imx-audio-wm8962";
+             model = "wm8962-audio";
+             audio-cpu = <&sai3>;
+             audio-codec = <&wm8962>;
+             audio-routing =
+                     "Headphone Jack", "HPOUTL",
+                     "Headphone Jack", "HPOUTR",
+                     "Ext Spk", "SPKOUTL",
+                     "Ext Spk", "SPKOUTR",
+                     "AMIC", "MICBIAS",
+                     "IN3R", "AMIC";
+     };
+};
+
+&ecspi2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_espi2>;
+     cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
+     status = "okay";
+
+     eeprom@0 {
+             compatible = "microchip,at25160bn", "atmel,at25";
+             reg = <0>;
+             spi-max-frequency = <5000000>;
+             spi-cpha;
+             spi-cpol;
+             pagesize = <32>;
+             size = <2048>;
+             address-width = <16>;
+     };
+};
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi line 102

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +6 -0
+
+&i2c2 {
+     clock-frequency = <400000>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_i2c2>;
+     status = "okay";

Can you document why you keep empty bus enabled?

I can disable it for now. It will eventually house a CSI camera once the CSI interface is available.

Quoted 233 lines
Quoted 218 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi new file +211 -0
+};
+
+&i2c4 {
+     clock-frequency = <400000>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_i2c4>;
+     status = "okay";
+
+     pca6416_0: gpio@20 {
+             compatible = "nxp,pcal6416";
+             reg = <0x20>;
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_pcal6414>;
+             gpio-controller;
+             #gpio-cells = <2>;
+             interrupt-parent = <&gpio4>;
+             interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
+     };
+
+     pca6416_1: gpio@21 {
+             compatible = "nxp,pcal6416";
+             reg = <0x21>;
+             gpio-controller;
+             #gpio-cells = <2>;
+             interrupt-parent = <&gpio4>;
+             interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
+     };
+
+     wm8962: audio-codec@1a {
+             compatible = "wlf,wm8962";
+             reg = <0x1a>;
+             clocks = <&clk IMX8MN_CLK_SAI3_ROOT>;
+             clock-names = "xclk";
+             DCVDD-supply = <&reg_audio>;
+             DBVDD-supply = <&reg_audio>;
+             AVDD-supply = <&reg_audio>;
+             CPVDD-supply = <&reg_audio>;
+             MICVDD-supply = <&reg_audio>;
+             PLLVDD-supply = <&reg_audio>;
+             SPKVDD1-supply = <&reg_audio>;
+             SPKVDD2-supply = <&reg_audio>;
+             gpio-cfg = <
+                     0x0000 /* 0:Default */
+                     0x0000 /* 1:Default */
+                     0x0000 /* 2:FN_DMICCLK */
+                     0x0000 /* 3:Default */
+                     0x0000 /* 4:FN_DMICCDAT */
+                     0x0000 /* 5:Default */
+             >;
+     };
+};
+
+&easrc {
+     fsl,asrc-rate  = <48000>;
+     status = "okay";
+};
+
+&sai3 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_sai3>;
+     assigned-clocks = <&clk IMX8MN_CLK_SAI3>;
+     assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>;
+     assigned-clock-rates = <24576000>;
+     fsl,sai-mclk-direction-output;
+     status = "okay";
+};
+
+&snvs_pwrkey {
+     status = "okay";
+};
+
+&uart2 { /* console */
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_uart2>;
+     status = "okay";
+};
+
+&uart3 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_uart3>;
+     assigned-clocks = <&clk IMX8MN_CLK_UART3>;
+     assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_80M>;
+     status = "okay";
+};
+
+&usbotg1 {
+     vbus-supply = <&reg_usb_otg_vbus>;
+     disable-over-current;
+     dr_mode="otg";
+     status = "okay";
+};
+
+&usdhc2 {
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+     pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+     bus-width = <4>;
+     vmmc-supply = <&reg_usdhc2_vmmc>;
+     status = "okay";
+};
+
+&iomuxc {
+     pinctrl_espi2: espi2grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK            0x82
+                     MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI            0x82
+                     MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO            0x82
+                     MX8MN_IOMUXC_ECSPI1_SS0_GPIO5_IO9               0x41
+             >;
+     };
+
+     pinctrl_i2c2: i2c2grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL          0x400001c3
+                     MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA          0x400001c3
+             >;
+     };
+
+     pinctrl_i2c4: i2c4grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_I2C4_SCL_I2C4_SCL          0x400001c3
+                     MX8MN_IOMUXC_I2C4_SDA_I2C4_SDA          0x400001c3
+             >;
+     };
+
+     pinctrl_led3: led3grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SAI3_RXFS_GPIO4_IO28       0x41
+             >;
+     };
+
+     pinctrl_pcal6414: pcal6414-gpiogrp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SAI2_MCLK_GPIO4_IO27               0x19
+             >;
+     };
+
+     pinctrl_reg_usb_otg: reg-otggrp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SAI3_RXC_GPIO4_IO29     0x19
+             >;
+     };
+
+     pinctrl_sai3: sai3grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC     0xd6
+                     MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK      0xd6
+                     MX8MN_IOMUXC_SAI3_MCLK_SAI3_MCLK        0xd6
+                     MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0     0xd6
+                     MX8MN_IOMUXC_SAI3_RXD_SAI3_RX_DATA0     0xd6
+             >;
+     };
+
+     pinctrl_uart2: uart2grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_UART2_RXD_UART2_DCE_RX     0x140
+                     MX8MN_IOMUXC_UART2_TXD_UART2_DCE_TX     0x140
+             >;
+     };
+
+     pinctrl_uart3: uart3grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_ECSPI1_SCLK_UART3_DCE_RX   0x40
+                     MX8MN_IOMUXC_ECSPI1_MOSI_UART3_DCE_TX   0x40
+             >;
+     };
+
+     pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SD2_CD_B_USDHC2_CD_B       0x41
+                     MX8MN_IOMUXC_SD2_RESET_B_GPIO2_IO19     0x41
+             >;
+     };
+
+     pinctrl_usdhc2: usdhc2grp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SD2_CLK_USDHC2_CLK 0x190
+                     MX8MN_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d0
+                     MX8MN_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d0
+                     MX8MN_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d0
+                     MX8MN_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d0
+                     MX8MN_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d0
+                     MX8MN_IOMUXC_GPIO1_IO04_USDHC2_VSELECT  0x1d0
+             >;
+     };
+
+     pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SD2_CLK_USDHC2_CLK 0x194
+                     MX8MN_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d4
+                     MX8MN_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d4
+                     MX8MN_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d4
+                     MX8MN_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d4
+                     MX8MN_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d4
+                     MX8MN_IOMUXC_GPIO1_IO04_USDHC2_VSELECT  0x1d0
+             >;
+     };
+
+     pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+             fsl,pins = <
+                     MX8MN_IOMUXC_SD2_CLK_USDHC2_CLK 0x196
+                     MX8MN_IOMUXC_SD2_CMD_USDHC2_CMD 0x1d6
+                     MX8MN_IOMUXC_SD2_DATA0_USDHC2_DATA0     0x1d6
+                     MX8MN_IOMUXC_SD2_DATA1_USDHC2_DATA1     0x1d6
+                     MX8MN_IOMUXC_SD2_DATA2_USDHC2_DATA2     0x1d6
+                     MX8MN_IOMUXC_SD2_DATA3_USDHC2_DATA3     0x1d6
+                     MX8MN_IOMUXC_GPIO1_IO04_USDHC2_VSELECT  0x1d0
+             >;
+     };
+};
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +0 -0
new file mode 100644
index 000000000000..faa55d888065

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts line 10

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +10 -0
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/dts-v1/;
+
+#include "imx8mn.dtsi"
+#include "imx8mn-beacon-som.dtsi"
+#include "imx8mn-beacon-baseboard.dtsi"

Why do you need baseboard as DTSI? Is is separate than kit? Judging by contents look like just empty/fake DTS and the baseboard should be the DTS.

Quoted 2 lines

Another hint: Baseboard also does not have its compatible, so it cannot exist in real life separate from the development kit...

The baseboard can handle two separate, mutually exclusive video outputs. It has a LVDS bridge chip and an HDMI bridge chip, but without the DSI and LCDIF support, neither can function. Right now, that LVDS chip doesn't have an upstream driver, but I plan to introduce it once the LCDIF, and DSI interfaces are available and functional.

Once there is video support, the kit-level DTS file will get support for one of the video outputs, and a second DTS file will get created to support the other. Both of these kit-level files would include the baseboard and SOM DTSI files since they would be common to both kits.

Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts line 14

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +4 -0
+
+/ {
+     model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit";
+     compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn";

Undocumented compatible.

I am still trying to learn the YAML rules. Do I just add it to the fsl.yaml? 'beacon' is in the vendor-prefixes, but I looked and the 'imx8mm-beacon-kit' which is already in the kernel doesn't have a compatible either and they are virtually identical.

Quoted 43 lines
Quoted 43 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +5 -0
+
+     chosen {
+             stdout-path = &uart2;
+     };
+};
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi new file +31 -0
new file mode 100644
index 000000000000..a2ce036b37f3
@@ -0,0 +1,429 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/ {
+     usdhc1_pwrseq: usdhc1_pwrseq {
+             compatible = "mmc-pwrseq-simple";
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_usdhc1_gpio>;
+             reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;
+             clocks = <&osc_32k>;
+             clock-names = "ext_clock";
+             post-power-on-delay-ms = <80>;
+     };
+
+     memory@40000000 {
+             device_type = "memory";
+             reg = <0x0 0x40000000 0 0x80000000>;
+     };
+};
+
+&A53_0 {
+     cpu-supply = <&buck2_reg>;
+};
+
+&A53_1 {
+     cpu-supply = <&buck2_reg>;
+};
+
+&A53_2 {
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi line 37

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi new file +6 -0
+     cpu-supply = <&buck2_reg>;
+};
+
+&A53_3 {
+     cpu-supply = <&buck2_reg>;
+};

Empty line please.

I'll submit a V2 with the changes you requested

Quoted 3 lines

Best regards,
Krzysztof

#4 lore raw
Quoted 31 lines · Adam Ford
Quoted 21 lines
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +0 -0
new file mode 100644
index 000000000000..faa55d888065

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts line 10

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +10 -0
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2020 Compass Electronics Group, LLC
+ */
+
+/dts-v1/;
+
+#include "imx8mn.dtsi"
+#include "imx8mn-beacon-som.dtsi"
+#include "imx8mn-beacon-baseboard.dtsi"

Why do you need baseboard as DTSI? Is is separate than kit? Judging by contents look like just empty/fake DTS and the baseboard should be the DTS.

Quoted 2 lines

Another hint: Baseboard also does not have its compatible, so it cannot exist in real life separate from the development kit...

The baseboard can handle two separate, mutually exclusive video outputs. It has a LVDS bridge chip and an HDMI bridge chip, but without the DSI and LCDIF support, neither can function. Right now, that LVDS chip doesn't have an upstream driver, but I plan to introduce it once the LCDIF, and DSI interfaces are available and functional.

Quoted 4 lines

Once there is video support, the kit-level DTS file will get support for one of the video outputs, and a second DTS file will get created to support the other. Both of these kit-level files would include the baseboard and SOM DTSI files since they would be common to both kits.

Sounds good.

Quoted 8 lines
Quoted 7 lines

arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts line 14

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts new file +4 -0
+
+/ {
+     model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit";
+     compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn";

Undocumented compatible.

Quoted 4 lines

I am still trying to learn the YAML rules. Do I just add it to the fsl.yaml? 'beacon' is in the vendor-prefixes, but I looked and the 'imx8mm-beacon-kit' which is already in the kernel doesn't have a compatible either and they are virtually identical.

Enough will be adding it to the fsl.yaml. There is no strict need for separate compatible for baseboard, although that's quite common practice since you want to reuse it.

The beacon,imx8mm-beacon-kit is in fsl.yaml, so you can just duplicate for imx8mn.

Best regards,
Krzysztof