Skip to contentSkip to conversation

mm: remove kzfree() compatibility definition

PATCH New Eric Biggers 1 participant 1 message Oct 23, 2020

Subsystems (5)
Networking Memory management Staging Slab allocator +1 more subsystems
lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 mm: remove kzfree() compatibility definition

From: Eric Biggers <[email protected]>

Commit 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()") renamed kzfree() to kfree_sensitive(), but it left a compatibility definition of kzfree() to avoid being too disruptive. Since then a few more instances of kzfree() have slipped in. Just get rid of them and remove the compatibility definition once and for all.

Signed-off-by Eric Biggers <[email protected]>

---

Linus, are you interested in applying this around the time of v5.10-rc1? There's not really any reason to keep this around, and people will otherwise keep introducing new uses.

 drivers/staging/rtl8192e/rtllib_crypt_tkip.c              | 2 +-
 drivers/staging/rtl8192e/rtllib_crypt_wep.c               | 2 +-
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 2 +-
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c  | 2 +-
 include/linux/slab.h                                      | 2 --
 net/tipc/crypto.c                                         | 4 ++--
 6 files changed, 6 insertions(+), 8 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_tkip.c +1 -1
index 8c2ff37b2d3a..238387d6221b 100644
@@ -100,7 +100,7 @@ static void rtllib_tkip_deinit(void *priv)
 		crypto_free_shash(_priv->tx_tfm_michael);
 		crypto_free_shash(_priv->rx_tfm_michael);
 	}
-	kzfree(priv);
+	kfree_sensitive(priv);
 }
drivers/staging/rtl8192e/rtllib_crypt_wep.c +1 -1
index 7cdd17f907fa..7790271a6a40 100644
@@ -49,7 +49,7 @@ static void *prism2_wep_init(int keyidx)
 
 static void prism2_wep_deinit(void *priv)
 {
-	kzfree(priv);
+	kfree_sensitive(priv);
 }
 
 /* Perform WEP encryption on given skb that has at least 4 bytes of headroom
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +1 -1
index 4b415cc76715..e8fa1d385f24 100644
@@ -107,7 +107,7 @@ static void ieee80211_tkip_deinit(void *priv)
 		crypto_free_shash(_priv->tx_tfm_michael);
 		crypto_free_shash(_priv->rx_tfm_michael);
 	}
-	kzfree(priv);
+	kfree_sensitive(priv);
 }
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c +1 -1
index 1c56e2d03aae..a41b6510481b 100644
@@ -54,7 +54,7 @@ static void *prism2_wep_init(int keyidx)
 
 static void prism2_wep_deinit(void *priv)
 {
-	kzfree(priv);
+	kfree_sensitive(priv);
 }
 
 /* Perform WEP encryption on given skb that has at least 4 bytes of headroom
include/linux/slab.h +0 -2
index 9e155cc83b8a..dd6897f62010 100644
@@ -187,8 +187,6 @@ void kfree_sensitive(const void *);
 size_t __ksize(const void *);
 size_t ksize(const void *);
 
-#define kzfree(x)	kfree_sensitive(x)	/* For backward compatibility */
-
 #ifdef CONFIG_HAVE_HARDENED_USERCOPY_ALLOCATOR
 void __check_heap_object(const void *ptr, unsigned long n, struct page *page,
 			bool to_user);
net/tipc/crypto.c +2 -2
index 40c44101fe8e..740ab9ae41a6 100644
@@ -418,7 +418,7 @@ static void tipc_aead_free(struct rcu_head *rp)
 		kfree(head);
 	}
 	free_percpu(aead->tfm_entry);
-	kzfree(aead->key);
+	kfree_sensitive(aead->key);
 	kfree(aead);
 }
 

@@ -2452,7 +2452,7 @@ static void tipc_crypto_work_tx(struct work_struct *work)
 		     tipc_crypto_key_init(tx, skey, PER_NODE_KEY, false);
 		if (likely(rc > 0))
 			rc = tipc_crypto_key_distr(tx, rc, NULL);
-		kzfree(skey);
+		kfree_sensitive(skey);
 	}
 
 	if (unlikely(rc))
Signature · 1 line
2.29.0.rc1.297.gfa9743e501-goog